Re: Review Request 61434: Updated health-checks.md to include description of generalized checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61434/ --- (Updated Aug. 15, 2017, 6:17 p.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 61434: Updated health-checks.md to include description of generalized checks.

> On Aug. 9, 2017, 5:30 p.m., Avinash sridharan wrote: > > docs/health-checks.md > > Lines 204 (patched) > > > > > > I think we also need to mention that the expectation here is that task > > is listening on the

Re: Review Request 61434: Updated health-checks.md to include description of generalized checks.

> On Aug. 9, 2017, 12:47 a.m., Gastón Kleiman wrote: > > docs/health-checks.md > > Lines 266 (patched) > > > > > > Don't the executors send an empty check status in this case? See > >

Re: Review Request 61434: Updated health-checks.md to include description of generalized checks.

> On Aug. 9, 2017, 12:47 a.m., Gastón Kleiman wrote: > > docs/health-checks.md > > Lines 266 (patched) > > > > > > Don't the executors send an empty check status in this case? See > >

Re: Review Request 61434: Updated health-checks.md to include description of generalized checks.

> On Aug. 11, 2017, 6:05 p.m., Greg Mann wrote: > > docs/health-checks.md > > Lines 272-278 (patched) > > > > > > Should we also call out here that setting interval_seconds to zero is a > > really bad idea? Yes,

Re: Review Request 61434: Updated health-checks.md to include description of generalized checks.

> On Aug. 11, 2017, 6:05 p.m., Greg Mann wrote: > > docs/health-checks.md > > Lines 102 (patched) > > > > > > s/it/them/ :blush: - Alexander --- This is

Re: Review Request 61434: Updated health-checks.md to include description of generalized checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61434/#review182718 --- docs/health-checks.md Line 29 (original), 29 (patched)

Re: Review Request 61434: Updated health-checks.md to include description of generalized checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61434/#review182719 --- Patch looks great! Reviews applied: [61434] Logs available

Re: Review Request 61434: Updated health-checks.md to include description of generalized checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61434/ --- (Updated Aug. 11, 2017, 12:12 a.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 61434: Updated health-checks.md to include description of generalized checks.

> On Aug. 9, 2017, 5:30 p.m., Avinash sridharan wrote: > > docs/health-checks.md > > Line 29 (original), 29 (patched) > > > > > > s/defines/which defines? It was intended as a simple enumeration. > On Aug. 9,

Re: Review Request 61434: Updated health-checks.md to include description of generalized checks.

> On Aug. 9, 2017, 12:47 a.m., Gastón Kleiman wrote: > > docs/health-checks.md > > Lines 136 (patched) > > > > > > Actually... only one status update is sent after a success, but > > failures are NOT deduplicated,

Re: Review Request 61434: Updated health-checks.md to include description of generalized checks.

> On Aug. 4, 2017, 7:18 p.m., Vinod Kone wrote: > > docs/health-checks.md > > Lines 209 (patched) > > > > > > Is it 127.0.0.1 even in the CNI network case? cc @avinash Yes, however, there is no resolution in this

Re: Review Request 61434: Updated health-checks.md to include description of generalized checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61434/#review182495 --- docs/health-checks.md Line 29 (original), 29 (patched)

Re: Review Request 61434: Updated health-checks.md to include description of generalized checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61434/#review182485 --- Patch looks great! Reviews applied: [61434] Passed command:

Re: Review Request 61434: Updated health-checks.md to include description of generalized checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61434/#review182456 --- docs/health-checks.md Lines 54-55 (original), 59-60 (patched)

Re: Review Request 61434: Updated health-checks.md to include description of generalized checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61434/#review182340 --- Patch looks great! Reviews applied: [61434] Passed command:

Re: Review Request 61434: Updated health-checks.md to include description of generalized checks.

> On Aug. 4, 2017, 7:18 p.m., Vinod Kone wrote: > > docs/health-checks.md > > Lines 110 (patched) > > > > > > s/1./2./ ? or is this markdown style? Yeah, actual numbers have no effect on the rendered HTML:

Re: Review Request 61434: Updated health-checks.md to include description of generalized checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61434/#review182234 --- Fix it, then Ship it! This is great! docs/health-checks.md

Re: Review Request 61434: Updated health-checks.md to include description of generalized checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61434/ --- (Updated Aug. 4, 2017, 6:09 p.m.) Review request for mesos, Gastón Kleiman and

Review Request 61434: Updated health-checks.md to include description of generalized checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61434/ --- Review request for mesos, Gastón Kleiman and Vinod Kone. Repository: mesos