Re: Review Request 64226: Added a `ns::supported` convenience API.

2018-02-23 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64226/#review198249 --- Patch looks great! Reviews applied: [64226] Passed command:

Re: Review Request 64226: Added a `ns::supported` convenience API.

2018-02-23 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64226/#review198248 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 64226: Added a `ns::supported` convenience API.

2018-02-23 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64226/#review198241 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 64226: Added a `ns::supported` convenience API.

2018-02-23 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64226/#review198232 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 64226: Added a `ns::supported` convenience API.

2018-02-23 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64226/#review198231 --- Fix it, then Ship it! LGTM src/linux/ns.cpp Lines 158

Re: Review Request 64226: Added a `ns::supported` convenience API.

2017-12-01 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64226/ --- (Updated Dec. 1, 2017, 11:46 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 64226: Added a `ns::supported` convenience API.

2017-12-01 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64226/#review192472 --- FAIL: Mesos libprocess-tests failed to build Reviews applied:

Re: Review Request 64226: Added a `ns::supported` convenience API.

2017-11-30 Thread James Peach
> On Dec. 1, 2017, 12:07 a.m., Jie Yu wrote: > > src/linux/ns.hpp > > Lines 99 (patched) > > > > > > Can you add some reason why there is a kernel version check there? The reason is in the implementation. I'll move

Re: Review Request 64226: Added a `ns::supported` convenience API.

2017-11-30 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64226/#review192402 --- src/linux/ns.hpp Lines 99 (patched)

Review Request 64226: Added a `ns::supported` convenience API.

2017-11-30 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64226/ --- Review request for mesos and Jie Yu. Bugs: MESOS-8284