Re: Review Request 65072: Fixed handling of terminal operations in `updateSlave` handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65072/#review195328 --- PASS: Mesos patch 65072 was successfully built and tested.

Re: Review Request 65072: Fixed handling of terminal operations in `updateSlave` handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65072/#review195302 --- FAIL: mesos-java failed to build. Reviews applied: `['65093',

Re: Review Request 65072: Fixed handling of terminal operations in `updateSlave` handler.

> On Jan. 11, 2018, 3:07 a.m., Gaston Kleiman wrote: > > src/master/master.cpp > > Line 10419 (original), 10447 (patched) > > > > > > Shouldn't we skip this if the operation was already in a terminal state? Why

Re: Review Request 65072: Fixed handling of terminal operations in `updateSlave` handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65072/ --- (Updated Jan. 12, 2018, 11:57 a.m.) Review request for mesos, Gaston Kleiman

Re: Review Request 65072: Fixed handling of terminal operations in updateSlave handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65072/#review195237 --- Fix it, then Ship it! src/master/master.cpp Lines 7635

Re: Review Request 65072: Fixed handling of terminal operations in updateSlave handler.

> On Jan. 10, 2018, 8:18 p.m., Greg Mann wrote: > > src/master/master.cpp > > Lines 7722 (patched) > > > > > > s/update/updates/ > > > > s/alter/later/ I'd prefer to stay with a singular `update` here.

Re: Review Request 65072: Fixed handling of terminal operations in updateSlave handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65072/#review195226 --- PASS: Mesos patch 65072 was successfully built and tested.

Re: Review Request 65072: Fixed handling of terminal operations in updateSlave handler.

> On Jan. 11, 2018, 12:52 a.m., Greg Mann wrote: > > src/master/master.cpp > > Lines 7722-7723 (patched) > > > > > > Suggestion: > > > > s/do not trigger another apply of the operation/do not cause us to

Re: Review Request 65072: Fixed handling of terminal operations in updateSlave handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65072/ --- (Updated Jan. 11, 2018, 2:53 p.m.) Review request for mesos, Gaston Kleiman

Re: Review Request 65072: Fixed handling of terminal operations in updateSlave handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65072/#review195202 --- src/master/master.cpp Line 10419 (original), 10447 (patched)

Re: Review Request 65072: Fixed handling of terminal operations in updateSlave handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65072/#review195192 --- src/master/master.cpp Lines 7718 (patched)

Re: Review Request 65072: Fixed handling of terminal operations in updateSlave handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65072/#review195169 --- src/master/master.cpp Lines 7722 (patched)

Re: Review Request 65072: Fixed handling of terminal operations in updateSlave handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65072/#review195157 --- PASS: Mesos patch 65072 was successfully built and tested.

Review Request 65072: Fixed handling of terminal operations in updateSlave handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65072/ --- Review request for mesos, Gaston Kleiman and Greg Mann. Repository: mesos