Re: Review Request 65448: Added a test to ensure master removes executors that never launched.

2018-02-14 Thread Greg Mann
> On Feb. 14, 2018, 4:08 a.m., Chun-Hung Hsiao wrote: > > I'll fix these while committing. - Greg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65448/#review197475 -

Re: Review Request 65448: Added a test to ensure master removes executors that never launched.

2018-02-13 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65448/#review197475 --- Fix it, then Ship it! src/tests/slave_tests.cpp Lines 4673 (pa

Re: Review Request 65448: Added a test to ensure master removes executors that never launched.

2018-02-09 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65448/#review197205 --- PASS: Mesos patch 65448 was successfully built and tested. Review

Re: Review Request 65448: Added a test to ensure master removes executors that never launched.

2018-02-09 Thread Meng Zhu
> On Feb. 8, 2018, 5:28 p.m., Vinod Kone wrote: > > src/tests/slave_tests.cpp > > Lines 4725 (patched) > > > > > > Can you also add a test with default executor? And maybe instead of > > kill task path, try to exer

Re: Review Request 65448: Added a test to ensure master removes executors that never launched.

2018-02-09 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65448/#review197172 --- Patch looks great! Reviews applied: [65445, 65504, 65446, 65449,

Re: Review Request 65448: Added a test to ensure master removes executors that never launched.

2018-02-08 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65448/#review197146 --- PASS: Mesos patch 65448 was successfully built and tested. Review

Re: Review Request 65448: Added a test to ensure master removes executors that never launched.

2018-02-08 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65448/#review197139 --- Fix it, then Ship it! src/tests/slave_tests.cpp Lines 4643 (pa

Re: Review Request 65448: Added a test to ensure master removes executors that never launched.

2018-02-06 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65448/#review196962 --- PASS: Mesos patch 65448 was successfully built and tested. Review

Re: Review Request 65448: Added a test to ensure master removes executors that never launched.

2018-01-31 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65448/#review196614 --- PASS: Mesos patch 65448 was successfully built and tested. Review

Review Request 65448: Added a test to ensure master removes executors that never launched.

2018-01-31 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65448/ --- Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, and Vinod Kone. Bug