Re: Review Request 66464: Implemented operation status reconciliation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66464/#review201762 --- Ship it! Ship It! - Greg Mann On April 20, 2018, 10:53

Re: Review Request 66464: Implemented operation status reconciliation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66464/ --- (Updated April 20, 2018, 3:53 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 66464: Implemented operation status reconciliation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66464/#review201657 --- src/master/master.cpp Lines 8929-8933 (patched)

Re: Review Request 66464: Implemented operation status reconciliation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66464/ --- (Updated April 18, 2018, 2:36 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 66464: Implemented operation status reconciliation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66464/ --- (Updated April 13, 2018, 5:51 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 66464: Implemented operation status reconciliation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66464/#review200921 --- src/master/http.cpp Line 1115 (original), -1113 (patched)

Re: Review Request 66464: Implemented operation status reconciliation.

> On April 9, 2018, 12:04 p.m., Greg Mann wrote: > > src/master/http.cpp > > Lines 5097 (patched) > > > > > > s/reconcileOperations/std::move(reconcileOperations)/ > > Gaston Kleiman wrote: > Do you think that

Re: Review Request 66464: Implemented operation status reconciliation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66464/ --- (Updated April 9, 2018, 2:30 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 66464: Implemented operation status reconciliation.

> On April 9, 2018, 12:04 p.m., Greg Mann wrote: > > src/master/http.cpp > > Lines 5097 (patched) > > > > > > s/reconcileOperations/std::move(reconcileOperations)/ Do you think that we need to use std::move to

Re: Review Request 66464: Implemented operation status reconciliation.

> On April 9, 2018, 12:04 p.m., Greg Mann wrote: > > src/master/http.cpp > > Lines 959-973 (original), 959-969 (patched) > > > > > > Hmm I think we only want to execute this block for calls which will get > > a

Re: Review Request 66464: Implemented operation status reconciliation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66464/#review200746 --- src/master/http.cpp Lines 5097 (patched)

Re: Review Request 66464: Implemented operation status reconciliation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66464/#review200680 --- src/master/http.cpp Lines 959-973 (original), 959-969 (patched)

Review Request 66464: Implemented operation status reconciliation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66464/ --- Review request for mesos and Greg Mann. Repository: mesos Description