Re: Review Request 67931: Support Image Manifest Version 2 Schema 2.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67931/#review206696 --- Ship it! I'll clean up for Mesos whitespace/formatting/commenti

Re: Review Request 67931: Support Image Manifest Version 2 Schema 2.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67931/ --- (Updated July 31, 2018, 9:41 p.m.) Review request for mesos, Akash Gupta, Andre

Re: Review Request 67931: Support Image Manifest Version 2 Schema 2.

> On July 30, 2018, 4:39 p.m., Andrew Schwartzmeyer wrote: > > include/mesos/uri/fetcher.hpp > > Lines 101 (patched) > > > > > > I am not convinced we need to be passing this as a shared_ptr, wouldn't > > const-ref

Re: Review Request 67931: Support Image Manifest Version 2 Schema 2.

> On July 30, 2018, 11:39 p.m., Andrew Schwartzmeyer wrote: > > src/uri/fetchers/docker.cpp > > Lines 1016-1017 (patched) > > > > > > Are we just skipping a failed blob here and trying to process the rest? > > Does

Re: Review Request 67931: Support Image Manifest Version 2 Schema 2.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67931/#review206622 --- 3rdparty/CMakeLists.txt Lines 721-736 (original), 721-736 (patche

Re: Review Request 67931: Support Image Manifest Version 2 Schema 2.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67931/ --- (Updated July 30, 2018, 3:40 p.m.) Review request for mesos, Akash Gupta, Andre

Re: Review Request 67931: Support Image Manifest Version 2 Schema 2.

> On July 17, 2018, 11:16 a.m., Andrew Schwartzmeyer wrote: > > include/mesos/docker/spec.hpp > > Lines 124-126 (patched) > > > > > > I think this and the commit before need to be re-ordered, as this > > commit is i

Re: Review Request 67931: Support Image Manifest Version 2 Schema 2.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67931/#review206201 --- Didn't look at the patch, but some time ago I posted a patchset th

Re: Review Request 67931: Support Image Manifest Version 2 Schema 2.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67931/ --- (Updated July 18, 2018, 9:27 a.m.) Review request for mesos, Akash Gupta, Andre

Re: Review Request 67931: Support Image Manifest Version 2 Schema 2.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67931/ --- (Updated July 17, 2018, 11:14 p.m.) Review request for mesos, Akash Gupta, Andr

Re: Review Request 67931: Support Image Manifest Version 2 Schema 2.

> On July 17, 2018, 6:16 p.m., Andrew Schwartzmeyer wrote: > > include/mesos/docker/spec.hpp > > Lines 141 (patched) > > > > > > Dumb question, but is there an S1/S2 for V1 as well? I don't think so. > On July 17,

Re: Review Request 67931: Support Image Manifest Version 2 Schema 2.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67931/#review206157 --- There is still more to review... I'll get to it. include/mesos/d

Re: Review Request 67931: Support Image Manifest Version 2 Schema 2.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67931/#review206134 --- Ah, sorry, I will get the rest of this reviewed tomorrow. 3rdpar

Review Request 67931: Support Image Manifest Version 2 Schema 2.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67931/ --- Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, and Joseph Wu. Rep