Re: Review Request 68354: Added a test to verify agent authentication retry backoff logic.

> On Sept. 12, 2018, 1:53 p.m., Gastón Kleiman wrote: > > src/tests/authentication_tests.cpp > > Lines 422 (patched) > > > > > > Nit: I am not a big fan of hard-coded magic numbers, so I'd declare > > `expected` as:

Re: Review Request 68354: Added a test to verify agent authentication retry backoff logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68354/#review208576 --- Fix it, then Ship it! src/tests/authentication_tests.cpp Lines

Re: Review Request 68354: Added a test to verify agent authentication retry backoff logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68354/#review207475 --- Patch looks great! Reviews applied: [68346, 68347, 68304, 68324,

Re: Review Request 68354: Added a test to verify agent authentication retry backoff logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68354/#review207460 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 68354: Added a test to verify agent authentication retry backoff logic.

> On Aug. 16, 2018, 3:51 p.m., Benjamin Mahler wrote: > > src/tests/authentication_tests.cpp > > Lines 415 (patched) > > > > > > Why the underscores? Removed. > On Aug. 16, 2018, 3:51 p.m., Benjamin Mahler wrote:

Re: Review Request 68354: Added a test to verify agent authentication retry backoff logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68354/ --- (Updated Aug. 16, 2018, 4:54 p.m.) Review request for mesos, Benjamin Mahler an

Re: Review Request 68354: Added a test to verify agent authentication retry backoff logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68354/#review207444 --- src/tests/authentication_tests.cpp Lines 413 (patched)

Re: Review Request 68354: Added a test to verify agent authentication retry backoff logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68354/ --- (Updated Aug. 16, 2018, 1:55 p.m.) Review request for mesos, Benjamin Mahler an

Re: Review Request 68354: Added a test to verify agent authentication retry backoff logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68354/#review207401 --- Bad patch! Reviews applied: [68354, 68324, 68304] Failed command

Re: Review Request 68354: Added a test to verify agent authentication retry backoff logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68354/#review207385 --- FAIL: Failed to apply the current review. Failed command: `python

Re: Review Request 68354: Added a test to verify agent authentication retry backoff logic.

> On Aug. 15, 2018, 3:45 p.m., Benjamin Mahler wrote: > > Probably also want to run this test in repetition to help make sure it's > > not flaky? Yep, ran almost overnight without failure. - Meng --- This is an automatically generated

Re: Review Request 68354: Added a test to verify agent authentication retry backoff logic.

> On Aug. 15, 2018, 3:45 p.m., Benjamin Mahler wrote: > > src/tests/authentication_tests.cpp > > Lines 411-425 (patched) > > > > > > Can we push down the start into the loop (only for the 1st iteration) > > and avoi

Re: Review Request 68354: Added a test to verify agent authentication retry backoff logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68354/ --- (Updated Aug. 15, 2018, 5:06 p.m.) Review request for mesos, Benjamin Mahler an

Re: Review Request 68354: Added a test to verify agent authentication retry backoff logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68354/#review207380 --- Patch looks great! Reviews applied: [68304, 68324, 68354] Passed

Re: Review Request 68354: Added a test to verify agent authentication retry backoff logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68354/#review207374 --- PASS: Mesos patch 68354 was successfully built and tested. Review

Re: Review Request 68354: Added a test to verify agent authentication retry backoff logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68354/#review207367 --- Probably also want to run this test in repetition to help make sur

Re: Review Request 68354: Added a test to verify agent authentication retry backoff logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68354/ --- (Updated Aug. 15, 2018, 11:50 a.m.) Review request for mesos, Benjamin Mahler a

Re: Review Request 68354: Added a test to verify agent authentication retry backoff logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68354/#review207308 --- FAIL: Some of the unit tests failed. Please check the relevant log

Review Request 68354: Added a test to verify agent authentication retry backoff logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68354/ --- Review request for mesos, Benjamin Mahler and Gastón Kleiman. Repository: mesos