Re: Review Request 69337: Garbage collected disappeared resource providers from master state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69337/ --- (Updated Jan. 10, 2019, 11:29 a.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 69337: Garbage collected disappeared resource providers from master state.

> On Dec. 14, 2018, 7:07 p.m., Chun-Hung Hsiao wrote: > > src/master/master.cpp > > Lines 8208 (patched) > > > > > > Does it make sense to move this line before L8016 > > Benjamin Bannier wrote: > I am not

Re: Review Request 69337: Garbage collected disappeared resource providers from master state.

> On Dec. 14, 2018, 8:07 p.m., Chun-Hung Hsiao wrote: > > src/master/master.cpp > > Lines 8208 (patched) > > > > > > Does it make sense to move this line before L8016 I am not sure what you have in mind. It seems

Re: Review Request 69337: Garbage collected disappeared resource providers from master state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69337/#review211339 --- Fix it, then Ship it! src/master/master.cpp Lines 8208

Re: Review Request 69337: Garbage collected disappeared resource providers from master state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69337/ --- (Updated Dec. 14, 2018, 4:56 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 69337: Garbage collected disappeared resource providers from master state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69337/#review211313 --- src/master/master.cpp Lines 8205 (patched)

Re: Review Request 69337: Garbage collected disappeared resource providers from master state.

> On Dec. 7, 2018, 3:18 a.m., Chun-Hung Hsiao wrote: > > src/master/master.cpp > > Lines 8228 (patched) > > > > > > It seems to me that we should remove the disappeared resources even if > > there is no resource

Re: Review Request 69337: Garbage collected disappeared resource providers from master state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69337/ --- (Updated Dec. 13, 2018, 2:51 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 69337: Garbage collected disappeared resource providers from master state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69337/#review211104 --- src/master/master.cpp Lines 8227 (patched)

Review Request 69337: Garbage collected disappeared resource providers from master state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69337/ --- Review request for mesos, Chun-Hung Hsiao and Jan Schlicht. Bugs: MESOS-9384