Re: Review Request 70116: Added metrics for offer operation feedback.

> On March 15, 2019, 12:03 a.m., Greg Mann wrote: > > src/master/metrics.hpp > > Lines 82-84 (patched) > > > > > > Hmm am I missing something, or are there no per-framework metrics > > added? I'm fine with not adding

Re: Review Request 70116: Added metrics for offer operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70116/ --- (Updated March 27, 2019, 4:39 p.m.) Review request for mesos, Gastón Kleiman, G

Re: Review Request 70116: Added metrics for offer operation feedback.

> On March 15, 2019, 12:03 a.m., Greg Mann wrote: > > src/master/metrics.hpp > > Lines 82-84 (patched) > > > > > > Hmm am I missing something, or are there no per-framework metrics > > added? I'm fine with not adding

Re: Review Request 70116: Added metrics for offer operation feedback.

> On March 15, 2019, 12:03 a.m., Greg Mann wrote: > > src/master/metrics.hpp > > Lines 82-84 (patched) > > > > > > Hmm am I missing something, or are there no per-framework metrics > > added? I'm fine with not adding

Re: Review Request 70116: Added metrics for offer operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70116/#review214068 --- Fix it, then Ship it! LGTM. Two small-ish comments to tweak be

Re: Review Request 70116: Added metrics for offer operation feedback.

> On March 12, 2019, 10:56 p.m., Joseph Wu wrote: > > src/master/master.cpp > > Lines 11361-11385 (original), 11378-11402 (patched) > > > > > > I'm curious what would be the proper way to handle operation > > clea

Re: Review Request 70116: Added metrics for offer operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70116/ --- (Updated March 26, 2019, 5:56 p.m.) Review request for mesos, Gastón Kleiman, G

Re: Review Request 70116: Added metrics for offer operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70116/#review213734 --- src/master/metrics.hpp Lines 82-84 (patched)

Re: Review Request 70116: Added metrics for offer operation feedback.

> On March 12, 2019, 10:56 p.m., Joseph Wu wrote: > > src/master/master.cpp > > Lines 11361-11385 (original), 11378-11402 (patched) > > > > > > I'm curious what would be the proper way to handle operation > > clea

Re: Review Request 70116: Added metrics for offer operation feedback.

> On March 12, 2019, 3:56 p.m., Joseph Wu wrote: > > src/master/master.cpp > > Lines 11361-11385 (original), 11378-11402 (patched) > > > > > > I'm curious what would be the proper way to handle operation > > clean

Re: Review Request 70116: Added metrics for offer operation feedback.

> On March 12, 2019, 10:56 p.m., Joseph Wu wrote: > > src/master/master.cpp > > Lines 11361-11385 (original), 11378-11402 (patched) > > > > > > I'm curious what would be the proper way to handle operation > > clea

Re: Review Request 70116: Added metrics for offer operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70116/#review213632 --- One discussion point, but otherwise LGTM. src/master/master.cpp

Re: Review Request 70116: Added metrics for offer operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70116/ --- (Updated March 11, 2019, 7:14 p.m.) Review request for mesos, Gastón Kleiman, G

Re: Review Request 70116: Added metrics for offer operation feedback.

> On March 4, 2019, 10:20 p.m., Greg Mann wrote: > > src/master/master.cpp > > Lines 2261 (patched) > > > > > > Why not use `updateOperationMetrics(OPERATION_ERROR, 1);` here? Why not, indeed. > On March 4, 2019,

Re: Review Request 70116: Added metrics for offer operation feedback.

> On March 8, 2019, 12:30 a.m., Gastón Kleiman wrote: > > src/master/master.hpp > > Lines 941-944 (patched) > > > > > > Is this used anywhere? It is not. Removed! > On March 8, 2019, 12:30 a.m., Gastón Kleiman wro

Re: Review Request 70116: Added metrics for offer operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70116/ --- (Updated March 8, 2019, 11:48 p.m.) Review request for mesos, Gastón Kleiman, G

Re: Review Request 70116: Added metrics for offer operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70116/#review213541 --- src/master/master.hpp Lines 941-944 (patched)

Re: Review Request 70116: Added metrics for offer operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70116/ --- (Updated March 7, 2019, 5:01 p.m.) Review request for mesos, Gastón Kleiman, Gr

Re: Review Request 70116: Added metrics for offer operation feedback.

> On March 4, 2019, 10:20 p.m., Greg Mann wrote: > > src/master/metrics.hpp > > Lines 63-67 (patched) > > > > > > Is this comment accurate? Looks like there is indeed an > > `operations_unreachable` metric below. > >

Re: Review Request 70116: Added metrics for offer operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70116/#review213404 --- src/master/master.cpp Lines 2261 (patched)

Review Request 70116: Added metrics for offer operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70116/ --- Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu. Bugs: MESOS