---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33276/#review82873
---
Ship it!
Maybe we could use benchmark to ensure the overall change
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33733/#review82876
---
Ship it!
Ship It!
- Joerg Schad
On April 30, 2015, 10:45 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32163/
---
(Updated May 7, 2015, 9:10 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33274/#review82875
---
Ship it!
Agree with Adam's benchmark comment, would be great.
-
On May 7, 2015, 8:07 p.m., Joerg Schad wrote:
configure.ac, line 566
https://reviews.apache.org/r/32198/diff/7/?file=952552#file952552line566
How is this related to your change?
Looking at the review history could it be that this was added by mistake?
- Joerg
On May 7, 2015, 5:40 p.m., Jie Yu wrote:
src/master/master.cpp, lines 732-735
https://reviews.apache.org/r/33935/diff/1/?file=952157#file952157line732
Why do you need to capture `this`? Http::log is a static function, I
don't think you need to capture `this`.
Capture
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32198/
---
(Updated May 7, 2015, 10:37 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33718/#review82908
---
Ship it!
Have you rendered this in a markdown viewer? As far as I
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33918/#review82905
---
src/slave/resources_estimator.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33919/#review82912
---
src/slave/slave.cpp
On May 5, 2015, 10:36 p.m., Ben Mahler wrote:
Is there a ticket for this? Would love to get a higher level view of the
motivation for the new endpoint and its format. A bit tough to tell what a
sample response looks like without reading through this diff carefully. :)
There should have
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31504/#review82918
---
src/linux/routing/filter/basic.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33358/#review82897
---
Ship it!
Ship It!
- Joerg Schad
On April 22, 2015, 9:09 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33718/
---
(Updated May 7, 2015, 8:40 p.m.)
Review request for mesos, Adam B, Kapil Arya,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33249/
---
(Updated May 7, 2015, 9:17 a.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33249/#review82833
---
Patch looks great!
Reviews applied: [33249]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33918/#review82829
---
Ship it!
Looks good! I agree with Vinod about the naming, but
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33933/#review82836
---
Ship it!
Ship It!
- Jie Yu
On May 7, 2015, 5:47 a.m., Ben
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33934/#review82840
---
Ship it!
Ship It!
- Jie Yu
On May 7, 2015, 5:47 a.m., Ben
19 matches
Mail list logo