Re: Review Request 37272: [1/3]Remove thread_tests.cpp in stout.

2015-08-09 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37272/ --- (Updated Aug. 9, 2015, 6:21 p.m.) Review request for mesos and Alex Clemmer.

Re: Review Request 37273: [2/3]Add CMake macro VsBuildCommand in libprocess.

2015-08-09 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37273/ --- (Updated Aug. 9, 2015, 6:21 p.m.) Review request for mesos and Alex Clemmer.

Review Request 37275: Generate make batch file to build project in windows.

2015-08-09 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37275/ --- Review request for mesos and Alex Clemmer. Repository: mesos Description

Review Request 37273: Add CMake macro VsBuildCommand in libprocess.

2015-08-09 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37273/ --- Review request for mesos and Alex Clemmer. Repository: mesos Description

Re: Review Request 37017: [2/3] Removed whitespace padding in overloaded operators (libprocess).

2015-08-09 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37017/#review94682 --- Ship it! Ship It! - Michael Park On Aug. 8, 2015, 9:58 p.m.,

Re: Review Request 37018: [3/3] Removed whitespace padding in overloaded operators (stout).

2015-08-09 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37018/#review94681 --- Ship it! I'll get this committed for you since it's been agreed

Re: Review Request 37268: Style checker checking for { on newline

2015-08-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37268/#review94684 --- Bad patch! Reviews applied: [37266] Failed command:

Re: Review Request 37018: [3/3] Removed whitespace padding in overloaded operators (stout).

2015-08-09 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37018/ --- (Updated Aug. 9, 2015, 3:16 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37013: [1/3] Removed whitespace padding in overloaded operators (mesos).

2015-08-09 Thread Michael Park
On Aug. 8, 2015, 8:14 p.m., Michael Park wrote: docs/mesos-c++-style-guide.md, line 40 https://reviews.apache.org/r/37013/diff/2/?file=1033909#file1033909line40 I think we can simply delete this, rather than saying don't do. What do you think? Artem Harutyunyan wrote: I'm

Review Request 37277: (WIP) Added Heartbeater to master to send periodic heartbeats to HTTP schedulers.

2015-08-09 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37277/ --- Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Ben Mahler.

Re: Review Request 37018: [3/3] Removed whitespace padding in overloaded operators (stout).

2015-08-09 Thread Artem Harutyunyan
On Aug. 8, 2015, 3:07 p.m., Mesos ReviewBot wrote: Bad patch! Reviews applied: [37013, 37017, 37018] Failed command: ./support/apply-review.sh -n -r 37018 Error: 2015-08-08 22:07:03 URL:https://reviews.apache.org/r/37018/diff/raw/ [49035/49035] - 37018.patch [1] error:

Re: Review Request 37018: [3/3] Removed whitespace padding in overloaded operators (stout).

2015-08-09 Thread Michael Park
On Aug. 9, 2015, 11:10 p.m., Michael Park wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp, line 98 https://reviews.apache.org/r/37018/diff/3/?file=1035715#file1035715line98 Removed unnecessary specialization: ``. Turns out I was wrong about this. Committed a fix.

Re: Review Request 37013: [1/3] Removed whitespace padding in overloaded operators (mesos).

2015-08-09 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37013/#review94683 --- Ship it! As I mentioned in

Re: Review Request 37260: mesos: Fixed break before braces style for 'enum'.

2015-08-09 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37260/ --- (Updated Aug. 9, 2015, 11:57 p.m.) Review request for mesos and Artem

Re: Review Request 37266: Style checker checking for { on newline

2015-08-09 Thread José Guilherme Vanz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37266/ --- (Updated Aug. 10, 2015, 1:46 a.m.) Review request for mesos. Bugs:

Re: Review Request 37267: Style checker checking for { on newline

2015-08-09 Thread José Guilherme Vanz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37267/ --- (Updated Aug. 10, 2015, 1:47 a.m.) Review request for mesos. Bugs:

Re: Review Request 37268: Style checker checking for { on newline

2015-08-09 Thread José Guilherme Vanz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37268/ --- (Updated Aug. 10, 2015, 1:46 a.m.) Review request for mesos. Bugs:

Re: Review Request 37275: [3/3]Generate make batch file to build project in windows.

2015-08-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37275/#review94693 --- Patch looks great! Reviews applied: [37272, 37273, 37275] All

Re: Review Request 37277: (WIP) Added Heartbeater to master to send periodic heartbeats to HTTP schedulers.

2015-08-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37277/#review94695 --- Bad patch! Reviews applied: [37277] Failed command:

Re: Review Request 37260: mesos: Fixed break before braces style for 'enum'.

2015-08-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37260/#review94696 --- Patch looks great! Reviews applied: [37258, 37259, 37260] All

Re: Review Request 37259: libprocess: Fixed break before braces style for 'enum'.

2015-08-09 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37259/ --- (Updated Aug. 10, 2015, 12:59 a.m.) Review request for mesos, Artem

Re: Review Request 36049: Added support for modularized Authorizer

2015-08-09 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36049/#review94664 --- src/local/local.cpp (lines 217 - 219)

Re: Review Request 36049: Added support for modularized Authorizer

2015-08-09 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36049/#review94667 --- src/master/flags.cpp (line 415)