Re: Review Request 39098: Changed secret field in Credential from 'bytes' to 'string'

2015-10-09 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39098/#review102043 --- Ship it! Ship It! - Till Toenshoff On Oct. 8, 2015, 1 a.m.,

Re: Review Request 38746: Added TaskStatus::Reason to containerizer Termination message.

2015-10-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38746/#review102036 --- Patch looks great! Reviews applied: [38746] All tests passed. -

Re: Review Request 38919: Validation of Docker Image Manifests

2015-10-09 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38919/ --- (Updated Oct. 9, 2015, 4:39 p.m.) Review request for mesos, Jojy Varghese and

Re: Review Request 39193: Fixed leakage of fts_open.

2015-10-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39193/#review102141 --- Patch looks great! Reviews applied: [39192, 39193] All tests

Re: Review Request 38919: Validation of Docker Image Manifests

2015-10-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38919/#review102148 --- Patch looks great! Reviews applied: [38901, 38919] All tests

Re: Review Request 39018: Added JSON parsing for Resources.

2015-10-09 Thread Greg Mann
> On Oct. 9, 2015, 11:14 p.m., Adam B wrote: > > include/mesos/resources.hpp, lines 83-98 > > > > > > Do these all need to be public? Indeed they do not. In addition to making these private, I rearranged the member

Re: Review Request 39018: Added JSON parsing for Resources.

2015-10-09 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39018/ --- (Updated Oct. 10, 2015, 12:43 a.m.) Review request for mesos, Adam B,

Re: Review Request 39194: Added documentation and scripts for building mesos.apache.org website locally in a Docker container.

2015-10-09 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39194/#review102133 --- support/website/README.md (line 36)

Re: Review Request 39152: Pass LIBPROCESS_IP even when executor environment is specified.

2015-10-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39152/#review102135 --- Patch looks great! Reviews applied: [39152] All tests passed. -

Review Request 39197: Provider tests: minor style fixes.

2015-10-09 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39197/ --- Review request for mesos and Timothy Chen. Repository: mesos Description

Review Request 39196: Puller tests: removed extraneous sandbox directory

2015-10-09 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39196/ --- Review request for mesos and Timothy Chen. Repository: mesos Description

Re: Review Request 39180: Windows: Added support for `stout/os/open.hpp`.

2015-10-09 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39180/#review102138 --- Ship it! Looks good (identical to the original open.hpp, except

Re: Review Request 39181: Windows: Added support for `stout/net.hpp`.

2015-10-09 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39181/#review102140 --- Ship it!

Re: Review Request 39182: Windows: Enable ip_tests.

2015-10-09 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39182/#review102142 --- Ship it! Ship It! - Joseph Wu On Oct. 9, 2015, 12:49 p.m.,

Re: Review Request 39194: Added documentation and scripts for building mesos.apache.org website locally in a Docker container.

2015-10-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39194/#review102146 --- Patch looks great! Reviews applied: [39194] All tests passed. -

Re: Review Request 39093: CMake:[3/3] Add `make check` target.

2015-10-09 Thread Alex Clemmer
> On Oct. 7, 2015, 5:05 p.m., Joseph Wu wrote: > > CMakeLists.txt, line 97 > > > > > > This only runs the libprocess tests. Did you mean to do this? Oh, man, somehow they must have gotten obliterated when I was

Re: Review Request 38919: Validation of Docker Image Manifests

2015-10-09 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38919/#review102136 --- Ship it! Ship It! - Anand Mazumdar On Oct. 9, 2015, 11:39

Re: Review Request 39018: Added JSON parsing for Resources.

2015-10-09 Thread Joseph Wu
> On Oct. 9, 2015, 4:14 p.m., Adam B wrote: > > src/common/resources.cpp, lines 368-384 > > > > > > This smells like a hack to workaround a bug in picojson. Can you link > > to something that indicates this as best

Review Request 39192: Fixed leakage of fts_open.

2015-10-09 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39192/ --- Review request for mesos and Ben Mahler. Bugs: mesos-3519

Re: Review Request 38919: Validation of Docker Image Manifests

2015-10-09 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38919/ --- (Updated Oct. 9, 2015, 3:24 p.m.) Review request for mesos, Jojy Varghese and

Re: Review Request 39194: Added documentation and scripts for building mesos.apache.org website locally in a Docker container.

2015-10-09 Thread Jonathon Rossi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39194/#review102126 --- support/website/files/run_site.sh (line 10)

Re: Review Request 39152: Pass LIBPROCESS_IP even when executor environment is specified.

2015-10-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39152/#review102021 --- Patch looks great! Reviews applied: [39152] All tests passed. -

Re: Review Request 39154: Log IP addresses together with failure messages.

2015-10-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39154/#review102026 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 39187: added FileDescriptor tests in libprocess Makefile.

2015-10-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39187/#review102120 --- Patch looks great! Reviews applied: [39186, 39187] All tests

Re: Review Request 38919: Validation of Docker Image Manifests

2015-10-09 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38919/#review102118 --- Mainly style nits otherwise looks pretty good.

Re: Review Request 38746: Added TaskStatus::Reason to containerizer Termination message.

2015-10-09 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38746/#review102111 --- Overall looks good, some of the comments I made can be addressed

Re: Review Request 39152: Pass LIBPROCESS_IP even when executor environment is specified.

2015-10-09 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39152/#review102108 --- Ship it! LGTM

Review Request 39194: Added documentation and scripts for building mesos.apache.org website locally in a Docker container.

2015-10-09 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39194/ --- Review request for mesos and Adam B. Bugs: MESOS-3694

Re: Review Request 39192: Fixed leakage of fts_open.

2015-10-09 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39192/#review102127 --- 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp

Re: Review Request 39193: Fixed leakage of fts_open.

2015-10-09 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39193/#review102128 --- src/linux/cgroups.cpp (line 925)

Re: Review Request 38919: Validation of Docker Image Manifests

2015-10-09 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38919/ --- (Updated Oct. 9, 2015, 4:08 p.m.) Review request for mesos, Jojy Varghese and

Review Request 39193: Fixed leakage of fts_open.

2015-10-09 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39193/ --- Review request for mesos and Ben Mahler. Bugs: mesos-3519

Re: Review Request 39182: Windows: Enable ip_tests.

2015-10-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39182/#review102122 --- Bad patch! Reviews applied: [39019, 39076, 39091, 39092, 39093,

Re: Review Request 39152: Pass LIBPROCESS_IP even when executor environment is specified.

2015-10-09 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39152/ --- (Updated Oct. 9, 2015, 8:33 p.m.) Review request for mesos and Kapil Arya.

Re: Review Request 38901: Serialize Docker Image Spec as Protobuf

2015-10-09 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38901/ --- (Updated Oct. 9, 2015, 2:39 p.m.) Review request for mesos, Jojy Varghese and

Re: Review Request 39152: Pass LIBPROCESS_IP even when executor environment is specified.

2015-10-09 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39152/#review102116 --- Ship it! Thanks! I'll fix the indent and commit this. Also, you

Re: Review Request 39018: Added JSON parsing for Resources.

2015-10-09 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39018/#review102110 --- Looking good, but I haven't made it to the tests yet (coming

Re: Review Request 39194: Added documentation and scripts for building mesos.apache.org website locally in a Docker container.

2015-10-09 Thread Artem Harutyunyan
> On Oct. 9, 2015, 3:52 p.m., Jonathon Rossi wrote: > > support/website/files/run_site.sh, line 10 > > > > > > With the changes we made you shouldn't pull from subversion anymore, > > the site files are in /site.

Re: Review Request 39197: Provider tests: minor style fixes.

2015-10-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39197/#review102149 --- Patch looks great! Reviews applied: [39196, 39197] All tests

Re: Review Request 39076: CMake: Added ability of Windows builds to include protobuf headers.

2015-10-09 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39076/ --- (Updated Oct. 10, 2015, 4:25 a.m.) Review request for mesos, Artem

Re: Review Request 39181: Windows: Added support for `stout/net.hpp`.

2015-10-09 Thread Alex Clemmer
> On Oct. 9, 2015, 7:02 p.m., Alex Clemmer wrote: > > 3rdparty/libprocess/include/process/future.hpp, line 39 > > > > > > FYI: `future.hpp` actually requires `check.hpp`, but this requirement > > was actually hidden

Review Request 39201: Included `stout/check.hpp` in `future.hpp`.

2015-10-09 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39201/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph

Re: Review Request 39201: Included `stout/check.hpp` in `future.hpp`.

2015-10-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39201/#review102154 --- Patch looks great! Reviews applied: [39019, 39076, 39091, 39092,

Re: Review Request 39182: Windows: Enable ip_tests.

2015-10-09 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39182/ --- (Updated Oct. 10, 2015, 5:58 a.m.) Review request for mesos, Artem

Re: Review Request 39018: Added JSON parsing for Resources.

2015-10-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39018/#review102151 --- Patch looks great! Reviews applied: [39018] All tests passed. -

Re: Review Request 39097: CMake:[2/2] remove `__WINDOWS__` flag definition from Stout config.

2015-10-09 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39097/ --- (Updated Oct. 10, 2015, 4:28 a.m.) Review request for mesos, Artem

Re: Review Request 39180: Windows: Added support for `stout/os/open.hpp`.

2015-10-09 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39180/ --- (Updated Oct. 10, 2015, 4:28 a.m.) Review request for mesos, Artem

Re: Review Request 39181: Windows: Added support for `stout/net.hpp`.

2015-10-09 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39181/ --- (Updated Oct. 10, 2015, 4:29 a.m.) Review request for mesos, Artem

Re: Review Request 39093: CMake:[3/3] Add `make check` target.

2015-10-09 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39093/ --- (Updated Oct. 10, 2015, 4:27 a.m.) Review request for mesos, Artem

Re: Review Request 39096: CMake:[1/2] Moved `__WINDOWS__` flag definition to CompilationConfigure.

2015-10-09 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39096/ --- (Updated Oct. 10, 2015, 4:27 a.m.) Review request for mesos, Artem

Review Request 39202: CMake: Moved libevent, gmock, http-parser to CMake on Windows.

2015-10-09 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39202/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph

Re: Review Request 37999: Implemented http::AuthenticatorManager

2015-10-09 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37999/ --- (Updated Oct. 9, 2015, 12:53 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 39008: Used thread-safe replacement for strerror.

2015-10-09 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39008/ --- (Updated Oct. 9, 2015, 2:25 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

2015-10-09 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39005/ --- (Updated Oct. 9, 2015, 2:24 p.m.) Review request for mesos, Bernd Mathiske,

Review Request 39172: Add Blue Yonder to the powered by Mesos list.

2015-10-09 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39172/ --- Review request for mesos and Dave Lester. Repository: mesos Description

Re: Review Request 39182: Windows: Enable ip_tests.

2015-10-09 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39182/ --- (Updated Oct. 9, 2015, 6:30 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 38579: Refactored registry client

2015-10-09 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38579/ --- (Updated Oct. 9, 2015, 6:36 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 39184: RegistryClient refactor: reordered ctor parameters

2015-10-09 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39184/ --- (Updated Oct. 9, 2015, 6:35 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 38443: Added layerid information to ManifestResponse

2015-10-09 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38443/ --- (Updated Oct. 9, 2015, 6:34 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 39152: Pass LIBPROCESS_IP even when executor environment is specified.

2015-10-09 Thread Cody Maloney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39152/#review102094 --- LGTM! - Cody Maloney On Oct. 9, 2015, 12:57 a.m., Greg Mann

Re: Review Request 39181: Windows: Added support for `stout/net.hpp`.

2015-10-09 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39181/#review102099 --- 3rdparty/libprocess/include/process/future.hpp (line 39)

Review Request 39186: added a FileDescriptor to manage the life cycle of fds.

2015-10-09 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39186/ --- Review request for mesos and Ben Mahler. Bugs: mesos-3520

Re: Review Request 39152: Pass LIBPROCESS_IP even when executor environment is specified.

2015-10-09 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39152/#review102098 --- Ship it! Ship It! - Kapil Arya On Oct. 8, 2015, 8:57 p.m.,

Review Request 39187: added FileDescriptor tests in libprocess Makefile.

2015-10-09 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39187/ --- Review request for mesos and Ben Mahler. Bugs: mesos-3520

Re: Review Request 39181: Windows: Added support for `stout/net.hpp`.

2015-10-09 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39181/ --- (Updated Oct. 9, 2015, 7 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 38746: Added TaskStatus::Reason to containerizer Termination message.

2015-10-09 Thread Jie Yu
> On Oct. 9, 2015, 2:06 a.m., Kapil Arya wrote: > > src/slave/containerizer/mesos/containerizer.cpp, lines 1109-1115 > > > > > > I am slightly confused here. If one or more `Isolator::prepare` calls > > returned a

Re: Review Request 38901: Serialize Docker Image Spec as Protobuf

2015-10-09 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38901/#review102103 --- Ship it! Ship It!

Re: Review Request 39182: Windows: Enable ip_tests.

2015-10-09 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39182/ --- (Updated Oct. 9, 2015, 7:49 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 38901: Serialize Docker Image Spec as Protobuf

2015-10-09 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38901/#review102105 --- LGTM, Just some minor comments/concerns about including `headers`