Re: Review Request 41713: Added HDFS URI fetcher plugin.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41713/
---

(Updated Dec. 31, 2015, 5:35 a.m.)


Review request for mesos, Adam B, Ben Mahler, Ian Downes, Timothy Chen, and 
Vinod Kone.


Changes
---

Addressed review comments.


Bugs: MESOS-3925
https://issues.apache.org/jira/browse/MESOS-3925


Repository: mesos


Description
---

Added HDFS URI fetcher plugin. This patch also adjusted the plugin 
initialization logic so that flags can be used to initialize each plugin.


Diffs (updated)
-

  include/mesos/uri/fetcher.hpp 6cf7b37818ceff64ffe56138ebd4bc7e2abe5a7c 
  include/mesos/uri/uri.hpp aa3ab5d24bb8c501dd19e93d7563cb0afd889f23 
  src/Makefile.am bf71fe6ee65233bbc47a41f610d68ff9760e19f6 
  src/tests/uri_fetcher_tests.cpp d54a7e7b08a741b1d5d371c11747681ae4ddef98 
  src/uri/fetcher.hpp PRE-CREATION 
  src/uri/fetcher.cpp 8bd7cf3d638a737c40183294cb4548a4851e0886 
  src/uri/fetchers/curl.hpp 401829d1990ec817ea069ce45f902c521cd1a937 
  src/uri/fetchers/curl.cpp 6c607a6a800374b6e14b37bfdc6b04e7a4e87892 
  src/uri/fetchers/hadoop.hpp PRE-CREATION 
  src/uri/fetchers/hadoop.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/41713/diff/


Testing
---

make check


Thanks,

Jie Yu

Re: Review Request 41714: Added tests for HDFS URI fetcher plugin.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41714/
---

(Updated Dec. 31, 2015, 5:36 a.m.)


Review request for mesos, Adam B, Ben Mahler, Ian Downes, Timothy Chen, and 
Vinod Kone.


Changes
---

Addressed review comments.


Bugs: MESOS-3925
https://issues.apache.org/jira/browse/MESOS-3925


Repository: mesos


Description
---

Added tests for HDFS URI fetcher plugin.


Diffs (updated)
-

  src/Makefile.am bf71fe6ee65233bbc47a41f610d68ff9760e19f6 
  src/tests/uri_fetcher_tests.cpp d54a7e7b08a741b1d5d371c11747681ae4ddef98 
  src/uri/schemes/hdfs.hpp PRE-CREATION 

Diff: https://reviews.apache.org/r/41714/diff/


Testing
---

make check


Thanks,

Jie Yu

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41681/#review112368
---



src/master/master.cpp (line 1445)


one line?



src/master/master.cpp (line 1467)


If there is a weight from --weight, and it is also in registry, the 
updateWeightinfos will have two weighinfo for the same role.



src/master/weights_handler.cpp (line 92)


<= 0



src/master/weights_handler.cpp (line 101)


s/existed/exist


- Jian Qiu


On 十二月 30, 2015, 11:54 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41681/
> ---
> 
> (Updated 十二月 30, 2015, 11:54 a.m.)
> 
> 
> Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
> 
> 
> Bugs: MESOS-4214
> https://issues.apache.org/jira/browse/MESOS-4214
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduce HTTP endpoint /weights for updating weight.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/authorizer.hpp 
> 19f6e1a2d025bf6ff07f515b10d41e8a48d7d0b4 
>   include/mesos/authorizer/authorizer.proto 
> 7b729e19484d92be48bbde4dff2c833a4109936e 
>   src/CMakeLists.txt 8169fe4f1a0eda5c2e2b30e22a7346478420a9a0 
>   src/Makefile.am bf71fe6ee65233bbc47a41f610d68ff9760e19f6 
>   src/authorizer/local/authorizer.hpp 
> 1563c11709c2612350354690b50ceb33d2720f98 
>   src/authorizer/local/authorizer.cpp 
> 1d135fb6906c7050a788cbac9ca2d8164ff064ef 
>   src/master/http.cpp deb0c8f9852dc0eec1e8c0ff35c684f982e8b110 
>   src/master/master.hpp 1cc5531de70bdc0bdce9835c4930dc774406fac9 
>   src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011 
>   src/master/registry.proto 9958f9c2bdb785390fca2f292b65d5a9310434d5 
>   src/master/weights_handler.cpp PRE-CREATION 
>   src/tests/mesos.hpp a4811b0d8dee33ff2ca4968f532ce64b7ea95249 
>   src/tests/mesos.cpp f4b0f82449c4b6a2b4b7b7f14518714485d5a13a 
> 
> Diff: https://reviews.apache.org/r/41681/diff/
> 
> 
> Testing
> ---
> 
> Make & Make check successfully!
> 
> $ (./mesos-master.sh --ip=127.0.0.1 --work_dir=/Users/yqwyq/tmp/mesos-master  
> >> /tmp/mesos-master.log 2>&1 &)
> $ curl -d 
> weights="[{\"weight\":1.0,\"role\":\"role1\"},{\"weight\":8.0,\"role\":\"role2\"}]"
>  -X PUT http://localhost:5050/weights
> $ curl http://localhost:5050/roles
> {
> "roles": [
> {
> "frameworks": [ ], 
> "name": "*", 
> "resources": {
> "cpus": 0, 
> "disk": 0, 
> "mem": 0
> }, 
> "weight": 1
> }, 
> {
> "frameworks": [ ], 
> "name": "role1", 
> "resources": {
> "cpus": 0, 
> "disk": 0, 
> "mem": 0
> }, 
> "weight": 1
> }, 
> {
> "frameworks": [ ], 
> "name": "role2", 
> "resources": {
> "cpus": 0, 
> "disk": 0, 
> "mem": 0
> }, 
> "weight": 8
> }
> ]
> }
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 41727: Fixed registry client to use libprocess parse url.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41727/#review112329
---

Ship it!


Great cleanup! THanks!


src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp (lines 439 
- 440)


Let's try to be consistent on indentation in this file. Either always 
starts from a new line for multiline parameters, or always starts from the same 
line.


- Jie Yu


On Dec. 26, 2015, 8:27 p.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41727/
> ---
> 
> (Updated Dec. 26, 2015, 8:27 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed registry client to use libprocess parse url.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
> 93e7b3b466283a7732290419060ebedad3445133 
> 
> Diff: https://reviews.apache.org/r/41727/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 41715: Support parsing url in libprocess.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41715/#review112328
---

Ship it!



3rdparty/libprocess/src/http.cpp (line 169)


static please since this is local to the file.



3rdparty/libprocess/src/http.cpp (line 212)


s/addressParts/tokens/


- Jie Yu


On Dec. 28, 2015, 8:23 p.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41715/
> ---
> 
> (Updated Dec. 28, 2015, 8:23 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Support parsing url in libprocess.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/http.hpp 
> f0666f0fa48c4f3a98332d12066561a02a715236 
>   3rdparty/libprocess/src/http.cpp e937df6875c8024ea9c178833b9faceede990969 
>   3rdparty/libprocess/src/tests/http_tests.cpp 
> 19261502be220aaa40add7ce30a9b2b65d1d9fdc 
> 
> Diff: https://reviews.apache.org/r/41715/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 41728: Removed docker provisioner port slave flags.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41728/#review112331
---

Ship it!


Again, great cleanup! Thanks Tim!

- Jie Yu


On Dec. 26, 2015, 8:28 p.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41728/
> ---
> 
> (Updated Dec. 26, 2015, 8:28 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed docker provisioner port slave flags.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp 
> 798431c737691405a15989b1eb9ed5319ea0dacd 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 7cdb15b9529eab82867b3470a016bb8ad09ff250 
>   src/slave/flags.hpp 1250786d1bdc8b312a1912a37ac8aac373dd5ec9 
>   src/slave/flags.cpp c4343ab7ff7b7b4d2c335119d41319b0779d2806 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> bb142f5ea99e8ea9b20a896f95ae37aa1d8d3f98 
> 
> Diff: https://reviews.apache.org/r/41728/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 41697: Fixed a documentation bug in containerizer internals doc.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41697/#review112333
---

Ship it!


Ship It!

- Jie Yu


On Dec. 23, 2015, 10:22 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41697/
> ---
> 
> (Updated Dec. 23, 2015, 10:22 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jojy Varghese.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The current document delves upon the behavior of using the default executor 
> i.e. `mesos-docker-executor` on whether the task has `TaskInfo` set or not. 
> This is slightly confusing as any task in Mesos is specified via the 
> `TaskInfo` protobuf message.
> 
> This change corrects this and outlines the difference in behavior on whether 
> the `Task` specifies an executor (custom executor) or specifies a command 
> (command executor).
> 
> 
> Diffs
> -
> 
>   docs/containerizer-internals.md 4386bbda21686b616ccf85db408899fece3680df 
> 
> Diff: https://reviews.apache.org/r/41697/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 41705: Added support for enforcing quota on (persistent) volumes (MESOS-4198).

[Artem Harutyunyan]

> On Dec. 25, 2015, 9:37 p.m., Qian Zhang wrote:
> > src/slave/containerizer/mesos/isolators/posix/disk.cpp, line 171
> > 
> >
> > Should we simply use `!Resources::isPersistentVolume()` here?

A disk volume resource does not necessarily have to be a persistent volume. So 
there might be cases when a task just requires a non-persistent disk volume.


- Artem


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41705/#review111902
---


On Dec. 28, 2015, 11:36 a.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41705/
> ---
> 
> (Updated Dec. 28, 2015, 11:36 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4198
> https://issues.apache.org/jira/browse/MESOS-4198
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added support for enforcing quota on (persistent) volumes (MESOS-4198).
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/posix/disk.cpp 
> d971db09083faad08f3cf18c25a79245321d1d9a 
>   src/tests/disk_quota_tests.cpp ce736c32a9e78a8a6d0793a06fe87911b9b0558d 
> 
> Diff: https://reviews.apache.org/r/41705/diff/
> 
> 
> Testing
> ---
> 
> GTEST_FILTER='DiskQuotaTest*' make check -j8
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 41704: Added support for checking whether a given path is absolute.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41704/#review112342
---

Ship it!


Ship It!

- Jie Yu


On Dec. 28, 2015, 7:35 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41704/
> ---
> 
> (Updated Dec. 28, 2015, 7:35 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4198
> https://issues.apache.org/jira/browse/MESOS-4198
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added support for checking whether a given path is absolute.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp 
> 0b986f0898da95c4cffd8bde1adfd9994d567096 
>   3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp 
> 821dbb185f09e2f279d95fd354ce2168cddf1bac 
> 
> Diff: https://reviews.apache.org/r/41704/diff/
> 
> 
> Testing
> ---
> 
> Ran stout tests.
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 41586: Partially enforced commit message guidelines with a hook.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41586/#review112346
---


Patch looks great!

Reviews applied: [41584, 41586]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 30, 2015, 7:28 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41586/
> ---
> 
> (Updated Dec. 30, 2015, 7:28 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Partially enforced commit message guidelines with a hook.
> 
> 
> Diffs
> -
> 
>   bootstrap 89d986fd95dc16bbb79623ef92e3b14a2e7009f9 
>   support/hooks/commit-msg PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41586/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 40998: Added CHECK's for various executor states in Command Executor to verify if messages are delivered in order.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40998/
---

(Updated Dec. 30, 2015, 8:47 p.m.)


Review request for mesos, Ben Mahler and Jie Yu.


Changes
---

Jie correctly spotted that we can land into `escalationTimeout` via `killTask` 
and `shutdown`. Not a good place to be. Removed the two states for now. Would 
put them back in a subsequent review.


Bugs: MESOS-3851
https://issues.apache.org/jira/browse/MESOS-3851


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/launcher/executor.cpp 09e7de6f2136ed9ca13e4822aeabcba2f7c5837d 

Diff: https://reviews.apache.org/r/40998/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 41754: Added reference to docker registry bearer token spec.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41754/#review112347
---

Ship it!



src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp (lines 259 
- 261)


No need for this comment here. What does that mean? I'll remove it for you.



src/slave/containerizer/mesos/provisioner/docker/token_manager.hpp (line 108)


I would put that above class Token. I'll fix that for you.


- Jie Yu


On Dec. 28, 2015, 10 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41754/
> ---
> 
> (Updated Dec. 28, 2015, 10 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added reference to docker registry bearer token spec.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
> 93e7b3b466283a7732290419060ebedad3445133 
>   src/slave/containerizer/mesos/provisioner/docker/token_manager.hpp 
> 3a01aca659ca2b31d0b31ec17382c953cbfc1c2b 
> 
> Diff: https://reviews.apache.org/r/41754/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 41586: Partially enforced commit message guidelines with a hook.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41586/
---

(Updated Dec. 30, 2015, 11:28 a.m.)


Review request for mesos, Adam B, Benjamin Hindman, and Neil Conway.


Repository: mesos


Description
---

Partially enforced commit message guidelines with a hook.


Diffs (updated)
-

  bootstrap 89d986fd95dc16bbb79623ef92e3b14a2e7009f9 
  support/hooks/commit-msg PRE-CREATION 

Diff: https://reviews.apache.org/r/41586/diff/


Testing
---


Thanks,

Artem Harutyunyan

Re: Review Request 41731: Removed docker puller flag.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41731/#review112336
---



src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp (line 72)


Do you still need flags here?

We typically try to be more explict and only pass in necessary parameters. 
All the flags validation should be done at the '::create()' method.



src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp (line 73)


s/imagesDir/archivesDir/



src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp (lines 79 - 
82)


Can you introduce a LocalPuller::create and put this logic there?



src/slave/containerizer/mesos/provisioner/docker/puller.cpp (line 53)


No need for this temp variable?



src/slave/flags.hpp (line 55)


Hum, this flag is confusing to me. Sounds like the  docker images (e.g., 
busybox,ubuntu...) used by Mesos.

Can we keep the name 'docker_registry'?



src/slave/flags.cpp (lines 134 - 135)


Can you briefly explain what will be there if a file location is specified:
```
or a local path (i.e., file://xxx) in which Docker image archives (result 
of 'docker save') are stored.
```



src/tests/containerizer/provisioner_docker_tests.cpp (line 1462)


s/imageDir/archivesDir/

Can you fix all the occurances?


- Jie Yu


On Dec. 27, 2015, 12:22 a.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41731/
> ---
> 
> (Updated Dec. 27, 2015, 12:22 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed docker puller flag.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp 
> f71b572a32443a6715acb4d3541aec60e0437b30 
>   src/slave/containerizer/mesos/provisioner/docker/puller.cpp 
> dd17acf6a6e5c306029198dbb2a7e2d059f87f75 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 7cdb15b9529eab82867b3470a016bb8ad09ff250 
>   src/slave/flags.hpp 1250786d1bdc8b312a1912a37ac8aac373dd5ec9 
>   src/slave/flags.cpp c4343ab7ff7b7b4d2c335119d41319b0779d2806 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> bb142f5ea99e8ea9b20a896f95ae37aa1d8d3f98 
> 
> Diff: https://reviews.apache.org/r/41731/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 41705: Added support for enforcing quota on (persistent) volumes (MESOS-4198).

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41705/#review112343
---

Ship it!



src/slave/containerizer/mesos/isolators/posix/disk.cpp (line 186)


Can you do the following instead?
```
path = path::join(info->directory, path, "");
```



src/slave/containerizer/mesos/isolators/posix/disk.cpp (line 301)


We may want to report volume usage through ResourceStatistics. This can be 
a separate ticket.



src/tests/disk_quota_tests.cpp (line 221)


Do we still need this with implicit roles?


- Jie Yu


On Dec. 28, 2015, 7:36 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41705/
> ---
> 
> (Updated Dec. 28, 2015, 7:36 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4198
> https://issues.apache.org/jira/browse/MESOS-4198
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added support for enforcing quota on (persistent) volumes (MESOS-4198).
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/posix/disk.cpp 
> d971db09083faad08f3cf18c25a79245321d1d9a 
>   src/tests/disk_quota_tests.cpp ce736c32a9e78a8a6d0793a06fe87911b9b0558d 
> 
> Diff: https://reviews.apache.org/r/41705/diff/
> 
> 
> Testing
> ---
> 
> GTEST_FILTER='DiskQuotaTest*' make check -j8
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 40998: Added CHECK's for various executor states in Command Executor to verify if messages are delivered in order.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40998/#review112337
---

Ship it!



src/launcher/executor.cpp (line 106)


use CHECK_EQ? Here and everywhere else.



src/launcher/executor.cpp (line 618)


s/RUNNING/REGISTERED/?


- Jie Yu


On Dec. 30, 2015, 6:39 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40998/
> ---
> 
> (Updated Dec. 30, 2015, 6:39 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Jie Yu.
> 
> 
> Bugs: MESOS-3851
> https://issues.apache.org/jira/browse/MESOS-3851
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/launcher/executor.cpp f90ea01131e6fa28e42f0c00a317d66a49f81ffa 
> 
> Diff: https://reviews.apache.org/r/40998/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 41584: Added commit message guidelines to docs.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41584/#review112338
---

Ship it!


Ship It!

- Neil Conway


On Dec. 19, 2015, 8:18 a.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41584/
> ---
> 
> (Updated Dec. 19, 2015, 8:18 a.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added commit message guidelines to docs.
> 
> 
> Diffs
> -
> 
>   docs/submitting-a-patch.md f0048f51395422645a520b61815c1ae3c7004aa3 
> 
> Diff: https://reviews.apache.org/r/41584/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 41586: Partially enforced commit message guidelines with a hook.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41586/#review112339
---

Ship it!


Ship It!


support/hooks/commit-msg (line 22)


Not sure why we say "(the first line)" here but not in the other error 
messages.


- Neil Conway


On Dec. 26, 2015, 2:05 a.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41586/
> ---
> 
> (Updated Dec. 26, 2015, 2:05 a.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Partially enforced commit message guidelines with a hook.
> 
> 
> Diffs
> -
> 
>   bootstrap 89d986fd95dc16bbb79623ef92e3b14a2e7009f9 
>   support/hooks/commit-msg PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41586/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41283/#review112340
---



src/executor/executor.cpp (line 229)


We should probably limit the max value here.



src/executor/executor.cpp (line 244)


Whats the maximum value allowed here? Might be a good idea to have it 
bounded.

Also what is the unit of time here?



src/executor/executor.cpp (line 291)


Have we considered using ```override``` keyword here?



src/executor/executor.cpp (line 370)


Have we considered using ```%``` operator to achieve the same semantics? 
Couple of reasons:

- Expresses the semantics in simple manner.
- Efficient in terms if number of instructions (1 DIV operation vs a DIV + 
MUL)


- Jojy Varghese


On Dec. 30, 2015, 1:30 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41283/
> ---
> 
> (Updated Dec. 30, 2015, 1:30 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-3550
> https://issues.apache.org/jira/browse/MESOS-3550
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change introduces the implementation for the executor library. 
> 
> This uses the new HTTP Connection interface to ensure calls are properly 
> pipelined.
> 
> `connected` -> Callback invoked when a TCP connection is established with the 
> agent.
> `disconnected` -> When the TCP connection is interrupted possibly due to an 
> agent restart.
> `received` -> When the executor receives events from the agent upon 
> subscribing.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 9762f8567e32d70b8df2d694a1fef5c692fc730e 
>   src/executor/executor.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41283/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

[Anand Mazumdar]

> On Dec. 30, 2015, 7:25 p.m., Jojy Varghese wrote:
> > src/executor/executor.cpp, line 229
> > 
> >
> > We should probably limit the max value here.

Does not make much sense to me. We do not have any semantics in our code 
historically to define a maximum value for most values of `Flags` passed to 
Executor/Agent. Why bother setting a maximum here. What am I missing ?

Also, these flags are passed on by the agent to the executor and are not 
invalid user inputs.


> On Dec. 30, 2015, 7:25 p.m., Jojy Varghese wrote:
> > src/executor/executor.cpp, line 244
> > 
> >
> > Whats the maximum value allowed here? Might be a good idea to have it 
> > bounded.
> > 
> > Also what is the unit of time here?

Again, did not make any sense to me. How does it matter ? 

It's pretty self-explantory to see that `maxBackoff` is a `Duration` object and 
hence can take any unit of time allowed by the `Duration` object.


> On Dec. 30, 2015, 7:25 p.m., Jojy Varghese wrote:
> > src/executor/executor.cpp, line 370
> > 
> >
> > Have we considered using ```%``` operator to achieve the same 
> > semantics? Couple of reasons:
> > 
> > - Expresses the semantics in simple manner.
> > - Efficient in terms if number of instructions (1 DIV operation vs a 
> > DIV + MUL)

I am assuming you were speaking about a previous issue that I had dropped:

`backoff = ::random() % maxBackoff + 1`

^ This is also 2 instructions (`%` and `+`). Also, considering `modulo` is a 
more expensive operation then division or multiplication. This does not make 
any sense to me. What would we gain ?

Also, We have been using this approach at 99 other places and I would any day 
trade consistency in our code then gaining an iota in performance ( a gain that 
I still do not see )
https://github.com/apache/mesos/blob/master/src/slave/slave.cpp#L740
https://github.com/apache/mesos/blob/master/src/slave/slave.cpp#L1252
https://github.com/apache/mesos/blob/master/src/sched/sched.cpp#L745
... and a zillion others.


> On Dec. 30, 2015, 7:25 p.m., Jojy Varghese wrote:
> > src/executor/executor.cpp, line 291
> > 
> >
> > Have we considered using ```override``` keyword here?

Good idea. We might consider using it widely in our code in the future as we 
become more C++11.


- Anand


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41283/#review112340
---


On Dec. 30, 2015, 1:30 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41283/
> ---
> 
> (Updated Dec. 30, 2015, 1:30 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-3550
> https://issues.apache.org/jira/browse/MESOS-3550
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change introduces the implementation for the executor library. 
> 
> This uses the new HTTP Connection interface to ensure calls are properly 
> pipelined.
> 
> `connected` -> Callback invoked when a TCP connection is established with the 
> agent.
> `disconnected` -> When the TCP connection is interrupted possibly due to an 
> agent restart.
> `received` -> When the executor receives events from the agent upon 
> subscribing.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 9762f8567e32d70b8df2d694a1fef5c692fc730e 
>   src/executor/executor.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41283/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 40998: Added CHECK's for various executor states in Command Executor to verify if messages are delivered in order.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40998/
---

(Updated Dec. 30, 2015, 8:06 p.m.)


Review request for mesos, Ben Mahler and Jie Yu.


Changes
---

Review comments from Jie.


Bugs: MESOS-3851
https://issues.apache.org/jira/browse/MESOS-3851


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/launcher/executor.cpp 09e7de6f2136ed9ca13e4822aeabcba2f7c5837d 

Diff: https://reviews.apache.org/r/40998/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 41705: Added support for enforcing quota on (persistent) volumes (MESOS-4198).

[Artem Harutyunyan]

> On Dec. 30, 2015, 11:55 a.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/posix/disk.cpp, line 301
> > 
> >
> > We may want to report volume usage through ResourceStatistics. This can 
> > be a separate ticket.

https://issues.apache.org/jira/browse/MESOS-4263


- Artem


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41705/#review112343
---


On Dec. 30, 2015, 4:01 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41705/
> ---
> 
> (Updated Dec. 30, 2015, 4:01 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4198
> https://issues.apache.org/jira/browse/MESOS-4198
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added support for enforcing quota on (persistent) volumes (MESOS-4198).
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/posix/disk.cpp 
> d971db09083faad08f3cf18c25a79245321d1d9a 
>   src/tests/disk_quota_tests.cpp ce736c32a9e78a8a6d0793a06fe87911b9b0558d 
> 
> Diff: https://reviews.apache.org/r/41705/diff/
> 
> 
> Testing
> ---
> 
> GTEST_FILTER='DiskQuotaTest*' make check -j8
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 41705: Added support for enforcing quota on (persistent) volumes (MESOS-4198).

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41705/
---

(Updated Dec. 30, 2015, 4:01 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-4198
https://issues.apache.org/jira/browse/MESOS-4198


Repository: mesos


Description
---

Added support for enforcing quota on (persistent) volumes (MESOS-4198).


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/posix/disk.cpp 
d971db09083faad08f3cf18c25a79245321d1d9a 
  src/tests/disk_quota_tests.cpp ce736c32a9e78a8a6d0793a06fe87911b9b0558d 

Diff: https://reviews.apache.org/r/41705/diff/


Testing
---

GTEST_FILTER='DiskQuotaTest*' make check -j8


Thanks,

Artem Harutyunyan

Re: Review Request 41806: Cleaned up assertions in test cases around JSON HTTP responses.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41806/#review112350
---


Patch looks great!

Reviews applied: [41806]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 30, 2015, 9:53 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41806/
> ---
> 
> (Updated Dec. 30, 2015, 9:53 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Used `AWAIT_EXPECT_RESPONSE_HEADER_EQ()` to check the "Content-Type" of
> the response, rather than accessing the "headers" field directly, and
> used the symbol `APPLICATION_JSON` rather than a string literal. Also
> added "Content-Type" checks to a few places that had neglected to make
> them, and cleaned up some whitespace style.
> 
> 
> Diffs
> -
> 
>   src/tests/executor_http_api_tests.cpp 
> 8d86df5fd54bcfe998eb7dc4302509e7a00e9d84 
>   src/tests/fault_tolerance_tests.cpp 
> ba657d0e1d8515cffd1b37925bf91a84b2feaef1 
>   src/tests/master_tests.cpp 865fa4a71f4bae2a218cd2c4e10873222d1ea3c4 
>   src/tests/metrics_tests.cpp f081fb9b68f25c6d6005f195c34253fba8abc146 
>   src/tests/monitor_tests.cpp a848d14ebb6cab79c06bcf55bd39f044b41a006e 
>   src/tests/repair_tests.cpp 63ec889c4954c2c60d3466952551aa25b3284ddf 
>   src/tests/scheduler_driver_tests.cpp 
> 1365d21ccad87923b862fb4942f1fd51630a62b7 
>   src/tests/scheduler_http_api_tests.cpp 
> 4d23a5a8368e0ed126469fa4a90a889b339ad004 
>   src/tests/slave_tests.cpp 328c853a338145256dadfc9364b9c2a0e6c356cb 
>   src/tests/status_update_manager_tests.cpp 
> bd34b97a3559a5fea9a7a253a89e0ac3029f4a33 
>   src/tests/utils.cpp 877139e97249761658dce3b1058cdc2e2a52367b 
> 
> Diff: https://reviews.apache.org/r/41806/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 41731: Removed docker puller flag.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41731/
---

(Updated Dec. 30, 2015, 11:08 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese.


Repository: mesos


Description
---

Removed docker puller flag.


Diffs (updated)
-

  docs/configuration.md a33e802a3ff1246d25f52b15da7905c5b22e339d 
  docs/mesos-provisioner.md fdb298c2a954e903317ef56abbcfe2470a2dfd23 
  src/slave/containerizer/mesos/provisioner/docker/local_puller.hpp 
025d96c80529024f6a1c1e2c15e1eda513c680fd 
  src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp 
f71b572a32443a6715acb4d3541aec60e0437b30 
  src/slave/containerizer/mesos/provisioner/docker/puller.cpp 
dd17acf6a6e5c306029198dbb2a7e2d059f87f75 
  src/slave/flags.hpp 2b2679c1ae68d120756eaf81e5728d20791d6746 
  src/slave/flags.cpp a60d3c8022aba93fbd17a46dfff601fb1b25bbee 
  src/tests/containerizer/provisioner_docker_tests.cpp 
d51f342dabf386fb618ef72ce3e36a8bd8c82b5f 

Diff: https://reviews.apache.org/r/41731/diff/


Testing
---

make check


Thanks,

Timothy Chen

Review Request 41810: Added credential to Docker image protobuf.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41810/
---

Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese.


Repository: mesos


Description
---

Added credential to Docker image protobuf.


Diffs
-

  include/mesos/mesos.proto 2431fdd6b84625c6140a2b3913736bffada4e7f6 

Diff: https://reviews.apache.org/r/41810/diff/


Testing
---

make


Thanks,

Timothy Chen

Re: Review Request 41704: Added support for checking whether a given path is absolute.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41704/
---

(Updated Dec. 30, 2015, 3:46 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-4198
https://issues.apache.org/jira/browse/MESOS-4198


Repository: mesos


Description
---

Added support for checking whether a given path is absolute.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp 
386188b26dd157a72aefdbff57da7d479f6637b4 
  3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp 
4374e64b499db3e47f62f562cb51b0640144ec6a 

Diff: https://reviews.apache.org/r/41704/diff/


Testing
---

Ran stout tests.


Thanks,

Artem Harutyunyan

Re: Review Request 40998: Added CHECK's for various executor states in Command Executor to verify if messages are delivered in order.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40998/#review112348
---


Patch looks great!

Reviews applied: [40998]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 30, 2015, 8:47 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40998/
> ---
> 
> (Updated Dec. 30, 2015, 8:47 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Jie Yu.
> 
> 
> Bugs: MESOS-3851
> https://issues.apache.org/jira/browse/MESOS-3851
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/launcher/executor.cpp 09e7de6f2136ed9ca13e4822aeabcba2f7c5837d 
> 
> Diff: https://reviews.apache.org/r/40998/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Review Request 41806: Cleaned up assertions in test cases around JSON HTTP responses.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41806/
---

Review request for mesos and Adam B.


Repository: mesos


Description
---

Used `AWAIT_EXPECT_RESPONSE_HEADER_EQ()` to check the "Content-Type" of
the response, rather than accessing the "headers" field directly, and
used the symbol `APPLICATION_JSON` rather than a string literal. Also
added "Content-Type" checks to a few places that had neglected to make
them, and cleaned up some whitespace style.


Diffs
-

  src/tests/executor_http_api_tests.cpp 
8d86df5fd54bcfe998eb7dc4302509e7a00e9d84 
  src/tests/fault_tolerance_tests.cpp ba657d0e1d8515cffd1b37925bf91a84b2feaef1 
  src/tests/master_tests.cpp 865fa4a71f4bae2a218cd2c4e10873222d1ea3c4 
  src/tests/metrics_tests.cpp f081fb9b68f25c6d6005f195c34253fba8abc146 
  src/tests/monitor_tests.cpp a848d14ebb6cab79c06bcf55bd39f044b41a006e 
  src/tests/repair_tests.cpp 63ec889c4954c2c60d3466952551aa25b3284ddf 
  src/tests/scheduler_driver_tests.cpp 1365d21ccad87923b862fb4942f1fd51630a62b7 
  src/tests/scheduler_http_api_tests.cpp 
4d23a5a8368e0ed126469fa4a90a889b339ad004 
  src/tests/slave_tests.cpp 328c853a338145256dadfc9364b9c2a0e6c356cb 
  src/tests/status_update_manager_tests.cpp 
bd34b97a3559a5fea9a7a253a89e0ac3029f4a33 
  src/tests/utils.cpp 877139e97249761658dce3b1058cdc2e2a52367b 

Diff: https://reviews.apache.org/r/41806/diff/


Testing
---

make check


Thanks,

Neil Conway

Re: Review Request 41757: Unified Container: Added passing Env in docker runtime config.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41757/#review112370
---



src/slave/containerizer/mesos/provisioner/store.hpp (line 43)


Similarly, no need for Option.


- Jie Yu


On Dec. 28, 2015, 11:50 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41757/
> ---
> 
> (Updated Dec. 28, 2015, 11:50 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4226
> https://issues.apache.org/jira/browse/MESOS-4226
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Unified Container: Added passing Env in docker runtime config.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 
> e951c96a7f9c5ff72f6993981e2e3744e3b837f6 
>   src/slave/containerizer/mesos/provisioner/store.hpp 
> aec725f789f7aeb92abfcc6718c2e6e2f1f37981 
> 
> Diff: https://reviews.apache.org/r/41757/diff/
> 
> 
> Testing
> ---
> 
> make check (ubuntu14.04 + clang-3.6)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 41758: Unified Container: Added passing Cmd in docker runtime config.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41758/#review112371
---



src/slave/containerizer/mesos/provisioner/store.hpp (line 47)


Ditto.


- Jie Yu


On Dec. 28, 2015, 11:50 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41758/
> ---
> 
> (Updated Dec. 28, 2015, 11:50 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4227
> https://issues.apache.org/jira/browse/MESOS-4227
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Unified Container: Added passing Cmd in docker runtime config.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 
> e951c96a7f9c5ff72f6993981e2e3744e3b837f6 
>   src/slave/containerizer/mesos/provisioner/store.hpp 
> aec725f789f7aeb92abfcc6718c2e6e2f1f37981 
> 
> Diff: https://reviews.apache.org/r/41758/diff/
> 
> 
> Testing
> ---
> 
> make check (ubuntu14.04 + clang-3.6)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 41704: Added support for checking whether a given path is absolute.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41704/
---

(Updated Dec. 30, 2015, 9:46 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-4198
https://issues.apache.org/jira/browse/MESOS-4198


Repository: mesos


Description
---

Added support for checking whether a given path is absolute.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp 
386188b26dd157a72aefdbff57da7d479f6637b4 
  3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp 
4374e64b499db3e47f62f562cb51b0640144ec6a 

Diff: https://reviews.apache.org/r/41704/diff/


Testing
---

Ran stout tests.


Thanks,

Artem Harutyunyan

Re: Review Request 41597: Extending allocator interface to support dynamic weights

[Yongqiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41597/
---

(Updated Dec. 30, 2015, 8:07 a.m.)


Review request for mesos, Adam B, Neil Conway, and Qian Zhang.


Changes
---

Rebase.


Bugs: MESOS-3943
https://issues.apache.org/jira/browse/MESOS-3943


Repository: mesos


Description
---

Add the interface in allocator to support updating weight
at runtime, and the allocator is invoked to allocate the
resources based on the updated weights later.


Diffs (updated)
-

  include/mesos/master/allocator.hpp f7ada68d7111486d264284990996413bb3d6 
  include/mesos/mesos.proto 2431fdd6b84625c6140a2b3913736bffada4e7f6 
  include/mesos/v1/mesos.proto 4aed0980b28dc1000aa2821f35303b736bc5bff8 
  src/master/allocator/mesos/allocator.hpp 
50ef3b20f34bc6d87cbeccabcebec9a5031a6554 
  src/master/allocator/mesos/hierarchical.hpp 
86ea5a402ed67f8f22f11d5730147cd907d66a08 
  src/master/allocator/mesos/hierarchical.cpp 
7f900c4e024485704d79e57ae22407557598fe6c 
  src/master/allocator/sorter/drf/sorter.hpp 
050896e8b12cd4097ccd137d5284d6b39b0f06ab 
  src/master/allocator/sorter/drf/sorter.cpp 
3a442f121f3a1505513877a5c78458a4b8d0a824 
  src/master/allocator/sorter/sorter.hpp 
7be6b44a762fd62c2cd7f28b4dc4865a4587ed26 
  src/tests/allocator.hpp 9bdfaecf1a148f113ad52956b50ed7cabe0902ef 

Diff: https://reviews.apache.org/r/41597/diff/


Testing
---

Make & Make check successfully!

Test case: https://reviews.apache.org/r/41672/


Thanks,

Yongqiao Wang

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

[Yongqiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41681/
---

(Updated Dec. 30, 2015, 8:07 a.m.)


Review request for mesos, Adam B, Neil Conway, and Qian Zhang.


Changes
---

Rebase.


Bugs: MESOS-4214
https://issues.apache.org/jira/browse/MESOS-4214


Repository: mesos


Description
---

Introduce HTTP endpoint /weights for updating weight.


Diffs (updated)
-

  include/mesos/authorizer/authorizer.hpp 
19f6e1a2d025bf6ff07f515b10d41e8a48d7d0b4 
  include/mesos/authorizer/authorizer.proto 
7b729e19484d92be48bbde4dff2c833a4109936e 
  src/CMakeLists.txt 8169fe4f1a0eda5c2e2b30e22a7346478420a9a0 
  src/Makefile.am bf71fe6ee65233bbc47a41f610d68ff9760e19f6 
  src/authorizer/local/authorizer.hpp 1563c11709c2612350354690b50ceb33d2720f98 
  src/authorizer/local/authorizer.cpp 1d135fb6906c7050a788cbac9ca2d8164ff064ef 
  src/master/http.cpp deb0c8f9852dc0eec1e8c0ff35c684f982e8b110 
  src/master/master.hpp 1cc5531de70bdc0bdce9835c4930dc774406fac9 
  src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011 
  src/master/registry.proto 9958f9c2bdb785390fca2f292b65d5a9310434d5 
  src/master/weights_handler.cpp PRE-CREATION 
  src/tests/mesos.hpp a4811b0d8dee33ff2ca4968f532ce64b7ea95249 
  src/tests/mesos.cpp f4b0f82449c4b6a2b4b7b7f14518714485d5a13a 

Diff: https://reviews.apache.org/r/41681/diff/


Testing
---

Make & Make check successfully!

$ (./mesos-master.sh --ip=127.0.0.1 --work_dir=/Users/yqwyq/tmp/mesos-master  
>> /tmp/mesos-master.log 2>&1 &)
$ curl -d 
weights="[{\"weight\":1.0,\"role\":\"role1\"},{\"weight\":8.0,\"role\":\"role2\"}]"
 -X PUT http://localhost:5050/weights
$ curl http://localhost:5050/roles
{
"roles": [
{
"frameworks": [ ], 
"name": "*", 
"resources": {
"cpus": 0, 
"disk": 0, 
"mem": 0
}, 
"weight": 1
}, 
{
"frameworks": [ ], 
"name": "role1", 
"resources": {
"cpus": 0, 
"disk": 0, 
"mem": 0
}, 
"weight": 1
}, 
{
"frameworks": [ ], 
"name": "role2", 
"resources": {
"cpus": 0, 
"disk": 0, 
"mem": 0
}, 
"weight": 8
}
]
}


Thanks,

Yongqiao Wang

Review Request 41789: Add put method for http PUT request.

[Yongqiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41789/
---

Review request for mesos, Adam B, Neil Conway, and Qian Zhang.


Bugs: MESOS-4200
https://issues.apache.org/jira/browse/MESOS-4200


Repository: mesos


Description
---

Add put method for http PUT request.


Diffs
-

  3rdparty/libprocess/include/process/http.hpp 
f0666f0fa48c4f3a98332d12066561a02a715236 
  3rdparty/libprocess/src/http.cpp e937df6875c8024ea9c178833b9faceede990969 

Diff: https://reviews.apache.org/r/41789/diff/


Testing
---

Make & Make check successfully.


Thanks,

Yongqiao Wang

Re: Review Request 41789: Add put method for http PUT request.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41789/#review112293
---


May need to refer to https://issues.apache.org/jira/browse/MESOS-3763

- Jian Qiu


On 十二月 30, 2015, 8:08 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41789/
> ---
> 
> (Updated 十二月 30, 2015, 8:08 a.m.)
> 
> 
> Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
> 
> 
> Bugs: MESOS-4200
> https://issues.apache.org/jira/browse/MESOS-4200
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add put method for http PUT request.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/http.hpp 
> f0666f0fa48c4f3a98332d12066561a02a715236 
>   3rdparty/libprocess/src/http.cpp e937df6875c8024ea9c178833b9faceede990969 
> 
> Diff: https://reviews.apache.org/r/41789/diff/
> 
> 
> Testing
> ---
> 
> Make & Make check successfully.
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Review Request 41790: Add tests for /weights endpoint.

[Yongqiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/
---

Review request for mesos, Adam B, Neil Conway, and Qian Zhang.


Bugs: MESOS-4200
https://issues.apache.org/jira/browse/MESOS-4200


Repository: mesos


Description
---

Add tests for /weights endpoint.


Diffs
-

  src/Makefile.am bf71fe6ee65233bbc47a41f610d68ff9760e19f6 
  src/tests/dynamic_weights_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/41790/diff/


Testing
---

Make and Make check successfully!


Thanks,

Yongqiao Wang

Re: Review Request 41790: Add tests for /weights endpoint.

[Yongqiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/
---

(Updated Dec. 30, 2015, 11:56 a.m.)


Review request for mesos, Adam B, Neil Conway, and Qian Zhang.


Bugs: MESOS-4200
https://issues.apache.org/jira/browse/MESOS-4200


Repository: mesos


Description
---

Add tests for /weights endpoint.


Diffs (updated)
-

  src/Makefile.am bf71fe6ee65233bbc47a41f610d68ff9760e19f6 
  src/tests/dynamic_weights_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/41790/diff/


Testing (updated)
---

Make and Make check successfully!

./src/mesos-tests --gtest_filter=DynamicWeightsTest.*
[==] Running 5 tests from 1 test case.
[--] Global test environment set-up.
[--] 5 tests from DynamicWeightsTest
[ RUN  ] DynamicWeightsTest.PutInvalidRequest
[   OK ] DynamicWeightsTest.PutInvalidRequest (77 ms)
[ RUN  ] DynamicWeightsTest.NegativeWeight
[   OK ] DynamicWeightsTest.NegativeWeight (35 ms)
[ RUN  ] DynamicWeightsTest.NonExistentRole
[   OK ] DynamicWeightsTest.NonExistentRole (40 ms)
[ RUN  ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
[   OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (46 ms)
[ RUN  ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles
[   OK ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles (37 ms)
[--] 5 tests from DynamicWeightsTest (235 ms total)

[--] Global test environment tear-down
[==] 5 tests from 1 test case ran. (244 ms total)
[  PASSED  ] 5 tests.


Thanks,

Yongqiao Wang

Re: Review Request 41790: Add tests for /weights endpoint.

[Yongqiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/
---

(Updated Dec. 30, 2015, 10:59 a.m.)


Review request for mesos, Adam B, Neil Conway, and Qian Zhang.


Changes
---

Change the depend bug.


Bugs: MESOS-4200
https://issues.apache.org/jira/browse/MESOS-4200


Repository: mesos


Description
---

Add tests for /weights endpoint.


Diffs
-

  src/Makefile.am bf71fe6ee65233bbc47a41f610d68ff9760e19f6 
  src/tests/dynamic_weights_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/41790/diff/


Testing
---

Make and Make check successfully!


Thanks,

Yongqiao Wang

Re: Review Request 41790: Add tests for /weights endpoint.

[Yongqiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/
---

(Updated Dec. 30, 2015, 11:24 a.m.)


Review request for mesos, Adam B, Neil Conway, and Qian Zhang.


Bugs: MESOS-4200
https://issues.apache.org/jira/browse/MESOS-4200


Repository: mesos


Description
---

Add tests for /weights endpoint.


Diffs
-

  src/Makefile.am bf71fe6ee65233bbc47a41f610d68ff9760e19f6 
  src/tests/dynamic_weights_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/41790/diff/


Testing
---

Make and Make check successfully!


Thanks,

Yongqiao Wang

Re: Review Request 41791: WIP: Updated allocation slack when dynamic reservation was updated.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41791/#review112306
---


Patch looks great!

Reviews applied: [40375, 41334, 40529, 41772, 40339, 40632, 41791]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 30, 2015, 8:38 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41791/
> ---
> 
> (Updated Dec. 30, 2015, 8:38 a.m.)
> 
> 
> Review request for mesos, Klaus Ma and Jian Qiu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> WIP: Updated allocation slack when dynamic reservation was updated.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> 7f900c4e024485704d79e57ae22407557598fe6c 
> 
> Diff: https://reviews.apache.org/r/41791/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

[Yongqiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41681/
---

(Updated Dec. 30, 2015, 11:54 a.m.)


Review request for mesos, Adam B, Neil Conway, and Qian Zhang.


Changes
---

Rebase.


Bugs: MESOS-4214
https://issues.apache.org/jira/browse/MESOS-4214


Repository: mesos


Description
---

Introduce HTTP endpoint /weights for updating weight.


Diffs (updated)
-

  include/mesos/authorizer/authorizer.hpp 
19f6e1a2d025bf6ff07f515b10d41e8a48d7d0b4 
  include/mesos/authorizer/authorizer.proto 
7b729e19484d92be48bbde4dff2c833a4109936e 
  src/CMakeLists.txt 8169fe4f1a0eda5c2e2b30e22a7346478420a9a0 
  src/Makefile.am bf71fe6ee65233bbc47a41f610d68ff9760e19f6 
  src/authorizer/local/authorizer.hpp 1563c11709c2612350354690b50ceb33d2720f98 
  src/authorizer/local/authorizer.cpp 1d135fb6906c7050a788cbac9ca2d8164ff064ef 
  src/master/http.cpp deb0c8f9852dc0eec1e8c0ff35c684f982e8b110 
  src/master/master.hpp 1cc5531de70bdc0bdce9835c4930dc774406fac9 
  src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011 
  src/master/registry.proto 9958f9c2bdb785390fca2f292b65d5a9310434d5 
  src/master/weights_handler.cpp PRE-CREATION 
  src/tests/mesos.hpp a4811b0d8dee33ff2ca4968f532ce64b7ea95249 
  src/tests/mesos.cpp f4b0f82449c4b6a2b4b7b7f14518714485d5a13a 

Diff: https://reviews.apache.org/r/41681/diff/


Testing
---

Make & Make check successfully!

$ (./mesos-master.sh --ip=127.0.0.1 --work_dir=/Users/yqwyq/tmp/mesos-master  
>> /tmp/mesos-master.log 2>&1 &)
$ curl -d 
weights="[{\"weight\":1.0,\"role\":\"role1\"},{\"weight\":8.0,\"role\":\"role2\"}]"
 -X PUT http://localhost:5050/weights
$ curl http://localhost:5050/roles
{
"roles": [
{
"frameworks": [ ], 
"name": "*", 
"resources": {
"cpus": 0, 
"disk": 0, 
"mem": 0
}, 
"weight": 1
}, 
{
"frameworks": [ ], 
"name": "role1", 
"resources": {
"cpus": 0, 
"disk": 0, 
"mem": 0
}, 
"weight": 1
}, 
{
"frameworks": [ ], 
"name": "role2", 
"resources": {
"cpus": 0, 
"disk": 0, 
"mem": 0
}, 
"weight": 8
}
]
}


Thanks,

Yongqiao Wang

Re: Review Request 41789: Add put method for http PUT request.

[Yongqiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41789/
---

(Updated Dec. 30, 2015, 11:55 a.m.)


Review request for mesos, Adam B, Neil Conway, and Qian Zhang.


Changes
---

Rebase.


Bugs: MESOS-4200
https://issues.apache.org/jira/browse/MESOS-4200


Repository: mesos


Description
---

Add put method for http PUT request.


Diffs (updated)
-

  3rdparty/libprocess/include/process/http.hpp 
f0666f0fa48c4f3a98332d12066561a02a715236 
  3rdparty/libprocess/src/http.cpp e937df6875c8024ea9c178833b9faceede990969 

Diff: https://reviews.apache.org/r/41789/diff/


Testing
---

Make & Make check successfully.


Thanks,

Yongqiao Wang

Re: Review Request 41597: Extending allocator interface to support dynamic weights

[Yongqiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41597/
---

(Updated Dec. 30, 2015, 11:54 a.m.)


Review request for mesos, Adam B, Neil Conway, and Qian Zhang.


Changes
---

Rebase.


Bugs: MESOS-3943
https://issues.apache.org/jira/browse/MESOS-3943


Repository: mesos


Description
---

Add the interface in allocator to support updating weight
at runtime, and the allocator is invoked to allocate the
resources based on the updated weights later.


Diffs (updated)
-

  include/mesos/master/allocator.hpp f7ada68d7111486d264284990996413bb3d6 
  include/mesos/mesos.proto 2431fdd6b84625c6140a2b3913736bffada4e7f6 
  include/mesos/v1/mesos.proto 4aed0980b28dc1000aa2821f35303b736bc5bff8 
  src/master/allocator/mesos/allocator.hpp 
50ef3b20f34bc6d87cbeccabcebec9a5031a6554 
  src/master/allocator/mesos/hierarchical.hpp 
86ea5a402ed67f8f22f11d5730147cd907d66a08 
  src/master/allocator/mesos/hierarchical.cpp 
7f900c4e024485704d79e57ae22407557598fe6c 
  src/master/allocator/sorter/drf/sorter.hpp 
050896e8b12cd4097ccd137d5284d6b39b0f06ab 
  src/master/allocator/sorter/drf/sorter.cpp 
3a442f121f3a1505513877a5c78458a4b8d0a824 
  src/master/allocator/sorter/sorter.hpp 
7be6b44a762fd62c2cd7f28b4dc4865a4587ed26 
  src/tests/allocator.hpp 9bdfaecf1a148f113ad52956b50ed7cabe0902ef 

Diff: https://reviews.apache.org/r/41597/diff/


Testing
---

Make & Make check successfully!

Test case: https://reviews.apache.org/r/41672/


Thanks,

Yongqiao Wang

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

[Yongqiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41681/
---

(Updated Dec. 30, 2015, 8:32 a.m.)


Review request for mesos, Adam B, Neil Conway, and Qian Zhang.


Changes
---

Rebase.


Bugs: MESOS-4214
https://issues.apache.org/jira/browse/MESOS-4214


Repository: mesos


Description
---

Introduce HTTP endpoint /weights for updating weight.


Diffs (updated)
-

  include/mesos/authorizer/authorizer.hpp 
19f6e1a2d025bf6ff07f515b10d41e8a48d7d0b4 
  include/mesos/authorizer/authorizer.proto 
7b729e19484d92be48bbde4dff2c833a4109936e 
  src/CMakeLists.txt 8169fe4f1a0eda5c2e2b30e22a7346478420a9a0 
  src/Makefile.am bf71fe6ee65233bbc47a41f610d68ff9760e19f6 
  src/authorizer/local/authorizer.hpp 1563c11709c2612350354690b50ceb33d2720f98 
  src/authorizer/local/authorizer.cpp 1d135fb6906c7050a788cbac9ca2d8164ff064ef 
  src/master/http.cpp deb0c8f9852dc0eec1e8c0ff35c684f982e8b110 
  src/master/master.hpp 1cc5531de70bdc0bdce9835c4930dc774406fac9 
  src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011 
  src/master/registry.proto 9958f9c2bdb785390fca2f292b65d5a9310434d5 
  src/master/weights_handler.cpp PRE-CREATION 
  src/tests/mesos.hpp a4811b0d8dee33ff2ca4968f532ce64b7ea95249 
  src/tests/mesos.cpp f4b0f82449c4b6a2b4b7b7f14518714485d5a13a 

Diff: https://reviews.apache.org/r/41681/diff/


Testing
---

Make & Make check successfully!

$ (./mesos-master.sh --ip=127.0.0.1 --work_dir=/Users/yqwyq/tmp/mesos-master  
>> /tmp/mesos-master.log 2>&1 &)
$ curl -d 
weights="[{\"weight\":1.0,\"role\":\"role1\"},{\"weight\":8.0,\"role\":\"role2\"}]"
 -X PUT http://localhost:5050/weights
$ curl http://localhost:5050/roles
{
"roles": [
{
"frameworks": [ ], 
"name": "*", 
"resources": {
"cpus": 0, 
"disk": 0, 
"mem": 0
}, 
"weight": 1
}, 
{
"frameworks": [ ], 
"name": "role1", 
"resources": {
"cpus": 0, 
"disk": 0, 
"mem": 0
}, 
"weight": 1
}, 
{
"frameworks": [ ], 
"name": "role2", 
"resources": {
"cpus": 0, 
"disk": 0, 
"mem": 0
}, 
"weight": 8
}
]
}


Thanks,

Yongqiao Wang

Re: Review Request 41597: Extending allocator interface to support dynamic weights

[Yongqiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41597/
---

(Updated Dec. 30, 2015, 8:32 a.m.)


Review request for mesos, Adam B, Neil Conway, and Qian Zhang.


Changes
---

Rebase.


Bugs: MESOS-3943
https://issues.apache.org/jira/browse/MESOS-3943


Repository: mesos


Description
---

Add the interface in allocator to support updating weight
at runtime, and the allocator is invoked to allocate the
resources based on the updated weights later.


Diffs (updated)
-

  include/mesos/master/allocator.hpp f7ada68d7111486d264284990996413bb3d6 
  include/mesos/mesos.proto 2431fdd6b84625c6140a2b3913736bffada4e7f6 
  include/mesos/v1/mesos.proto 4aed0980b28dc1000aa2821f35303b736bc5bff8 
  src/master/allocator/mesos/allocator.hpp 
50ef3b20f34bc6d87cbeccabcebec9a5031a6554 
  src/master/allocator/mesos/hierarchical.hpp 
86ea5a402ed67f8f22f11d5730147cd907d66a08 
  src/master/allocator/mesos/hierarchical.cpp 
7f900c4e024485704d79e57ae22407557598fe6c 
  src/master/allocator/sorter/drf/sorter.hpp 
050896e8b12cd4097ccd137d5284d6b39b0f06ab 
  src/master/allocator/sorter/drf/sorter.cpp 
3a442f121f3a1505513877a5c78458a4b8d0a824 
  src/master/allocator/sorter/sorter.hpp 
7be6b44a762fd62c2cd7f28b4dc4865a4587ed26 
  src/tests/allocator.hpp 9bdfaecf1a148f113ad52956b50ed7cabe0902ef 

Diff: https://reviews.apache.org/r/41597/diff/


Testing
---

Make & Make check successfully!

Test case: https://reviews.apache.org/r/41672/


Thanks,

Yongqiao Wang

Review Request 41791: WIP: Updated allocation slack when dynamic reservation was updated.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41791/
---

Review request for mesos, Klaus Ma and Jian Qiu.


Repository: mesos


Description
---

WIP: Updated allocation slack when dynamic reservation was updated.


Diffs
-

  src/master/allocator/mesos/hierarchical.cpp 
7f900c4e024485704d79e57ae22407557598fe6c 

Diff: https://reviews.apache.org/r/41791/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 41789: Add put method for http PUT request.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41789/#review112294
---


Patch looks great!

Reviews applied: [41597, 41681, 41789]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 30, 2015, 8:34 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41789/
> ---
> 
> (Updated Dec. 30, 2015, 8:34 a.m.)
> 
> 
> Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
> 
> 
> Bugs: MESOS-4200
> https://issues.apache.org/jira/browse/MESOS-4200
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add put method for http PUT request.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/http.hpp 
> f0666f0fa48c4f3a98332d12066561a02a715236 
>   3rdparty/libprocess/src/http.cpp e937df6875c8024ea9c178833b9faceede990969 
> 
> Diff: https://reviews.apache.org/r/41789/diff/
> 
> 
> Testing
> ---
> 
> Make & Make check successfully.
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 41789: Add put method for http PUT request.

[Yongqiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41789/
---

(Updated Dec. 30, 2015, 8:34 a.m.)


Review request for mesos, Adam B, Neil Conway, and Qian Zhang.


Changes
---

Rebase.


Bugs: MESOS-4200
https://issues.apache.org/jira/browse/MESOS-4200


Repository: mesos


Description
---

Add put method for http PUT request.


Diffs (updated)
-

  3rdparty/libprocess/include/process/http.hpp 
f0666f0fa48c4f3a98332d12066561a02a715236 
  3rdparty/libprocess/src/http.cpp e937df6875c8024ea9c178833b9faceede990969 

Diff: https://reviews.apache.org/r/41789/diff/


Testing
---

Make & Make check successfully.


Thanks,

Yongqiao Wang

Re: Review Request 41790: Add tests for /weights endpoint.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/#review112297
---


Patch looks great!

Reviews applied: [41597, 41681, 41789, 41790]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 30, 2015, 8:35 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41790/
> ---
> 
> (Updated Dec. 30, 2015, 8:35 a.m.)
> 
> 
> Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
> 
> 
> Bugs: MESOS-4200
> https://issues.apache.org/jira/browse/MESOS-4200
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add tests for /weights endpoint.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am bf71fe6ee65233bbc47a41f610d68ff9760e19f6 
>   src/tests/dynamic_weights_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41790/diff/
> 
> 
> Testing
> ---
> 
> Make and Make check successfully!
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 41789: Add put method for http PUT request.

[Yongqiao Wang]

> On Dec. 30, 2015, 8:17 a.m., Jian Qiu wrote:
> > May need to refer to https://issues.apache.org/jira/browse/MESOS-3763

Yes, I have noticed that ticket, but I found that patch does not work now, so I 
post a new patch to contiue my test coding. I have email to the owner of that 
ticket, and after he addressed and committed that ticket, I will depend on that 
issue rather than this RR.


- Yongqiao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41789/#review112293
---


On Dec. 30, 2015, 11:55 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41789/
> ---
> 
> (Updated Dec. 30, 2015, 11:55 a.m.)
> 
> 
> Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
> 
> 
> Bugs: MESOS-4200
> https://issues.apache.org/jira/browse/MESOS-4200
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add put method for http PUT request.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/http.hpp 
> f0666f0fa48c4f3a98332d12066561a02a715236 
>   3rdparty/libprocess/src/http.cpp e937df6875c8024ea9c178833b9faceede990969 
> 
> Diff: https://reviews.apache.org/r/41789/diff/
> 
> 
> Testing
> ---
> 
> Make & Make check successfully.
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 41790: Add tests for /weights endpoint.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/#review112308
---


Patch looks great!

Reviews applied: [41597, 41681, 41789, 41790]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 30, 2015, 11:56 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41790/
> ---
> 
> (Updated Dec. 30, 2015, 11:56 a.m.)
> 
> 
> Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
> 
> 
> Bugs: MESOS-4200
> https://issues.apache.org/jira/browse/MESOS-4200
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add tests for /weights endpoint.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am bf71fe6ee65233bbc47a41f610d68ff9760e19f6 
>   src/tests/dynamic_weights_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41790/diff/
> 
> 
> Testing
> ---
> 
> Make and Make check successfully!
> 
> ./src/mesos-tests --gtest_filter=DynamicWeightsTest.*
> [==] Running 5 tests from 1 test case.
> [--] Global test environment set-up.
> [--] 5 tests from DynamicWeightsTest
> [ RUN  ] DynamicWeightsTest.PutInvalidRequest
> [   OK ] DynamicWeightsTest.PutInvalidRequest (77 ms)
> [ RUN  ] DynamicWeightsTest.NegativeWeight
> [   OK ] DynamicWeightsTest.NegativeWeight (35 ms)
> [ RUN  ] DynamicWeightsTest.NonExistentRole
> [   OK ] DynamicWeightsTest.NonExistentRole (40 ms)
> [ RUN  ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
> [   OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (46 ms)
> [ RUN  ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles
> [   OK ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles (37 ms)
> [--] 5 tests from DynamicWeightsTest (235 ms total)
> 
> [--] Global test environment tear-down
> [==] 5 tests from 1 test case ran. (244 ms total)
> [  PASSED  ] 5 tests.
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 41772: WIP: Added helper function to flatten resources.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41772/#review112310
---



src/common/resources.cpp (line 854)


I'd suggest to only return `stateless.reserved` resources; allocator need 
role info to exclude current framework's reserved resources.

Not sure which name is better, maybe `allocationSlackable` 
(ALLOCATION_SLACK-able) which means the resources that can be ALLOCATION_SLACK 
to other framework.


- Klaus Ma


On Dec. 30, 2015, 3:02 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41772/
> ---
> 
> (Updated Dec. 30, 2015, 3:02 p.m.)
> 
> 
> Review request for mesos and Klaus Ma.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added two new helper functions to flatten resources.
> 1) Flatten reserved resources.
> 2) Flatten allocation slack revocable resources.
> 
> 
> Diffs
> -
> 
>   include/mesos/resources.hpp 9c8bfb0e7e1e40ca99b4cc75079e5b950630243d 
>   include/mesos/v1/resources.hpp db87c992e2ec466cb1d4d17775bf6423a2fb15aa 
>   src/common/resources.cpp b9d31aef8babee212374e352c57fadbff02167f3 
>   src/tests/resources_tests.cpp e4a3435adc14f3b6b278b32348a6991543d5a320 
>   src/v1/resources.cpp 0c0eee6b3b7ae3254d7dc7b06187855c9b873764 
> 
> Diff: https://reviews.apache.org/r/41772/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 40632: WIP: Enabled oversubscribed resources for reservations in allocator.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40632/#review112309
---



src/master/allocator/mesos/hierarchical.cpp (line 1302)


If framework has reserved.statless resources, allocator should not dispatch 
it as ALLOCATION_SLACK.



src/master/allocator/mesos/hierarchical.cpp (line 1321)


As framework can not use ALLOCATION_SLACK mixed with other resources, 
allocator need to check seperatly.



src/master/allocator/mesos/hierarchical.cpp (line 1334)


In this check, it seems allocator send offer when both !allocation & 
allocation are enough.


- Klaus Ma


On Dec. 30, 2015, 3:04 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40632/
> ---
> 
> (Updated Dec. 30, 2015, 3:04 p.m.)
> 
> 
> Review request for mesos, Klaus Ma and Jian Qiu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled oversubscribed resources for reservations in allocator.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> 7f900c4e024485704d79e57ae22407557598fe6c 
> 
> Diff: https://reviews.apache.org/r/40632/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>