Re: Review Request 41850: Add map to trace evictable executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41850/#review115295 --- src/slave/slave.cpp (line 1599)

Review Request 42575: Removed superfluous word from quota.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42575/ --- Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, and Neil Co

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review115526 --- Patch looks great! Reviews applied: [42516] Passed command: expor

Re: Review Request 42575: Removed superfluous word from quota.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42575/#review115528 --- Ship it! Ship It! - Alexander Rukletsov On Jan. 20, 2016, 11:17

Re: Review Request 42517: Added discussion about allowing multiple frameworks in a role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42517/#review115529 --- Ship it! Ship It! - Alexander Rukletsov On Jan. 20, 2016, 9:57

Re: Review Request 42239: Added tests for the Docker URI fetcher plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42239/ --- (Updated Jan. 21, 2016, 12:41 a.m.) Review request for mesos, Ben Mahler, Gilbe

Re: Review Request 42239: Added tests for the Docker URI fetcher plugin.

> On Jan. 18, 2016, 11:02 p.m., Timothy Chen wrote: > > src/tests/uri_fetcher_tests.cpp, line 216 > > > > > > Should we create a constant for docker registry server url? We're > > referring to it in multiple places

Re: Review Request 42389: Fixed unmount order in linux filesystem isolator cleanup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42389/#review115530 --- Ship it! Ship It! - Jie Yu On Jan. 19, 2016, 12:10 a.m., Timoth

Review Request 42580: Updated changelog :renaming of 'authenticate' to 'authenticate_frameworks' flag

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42580/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4386 https://issues.ap

Re: Review Request 42546: Updated `Master::Http::stateSummary` to use `jsonify`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42546/#review115533 --- Patch looks great! Reviews applied: [42543, 42546] Passed command

Re: Review Request 41855: Trace pending executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41855/#review115534 --- src/slave/slave.cpp (lines 1384 - 1388)

Re: Review Request 42559: Allocated resources as revocable beyond quota.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42559/#review115537 --- src/master/allocator/mesos/hierarchical.cpp (line 1310)

Re: Review Request 42517: Added discussion about allowing multiple frameworks in a role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42517/#review115538 --- Ship it! Ship It! - Guangya Liu On 一月 20, 2016, 9:57 p.m., Neil

Re: Review Request 42559: Allocated resources as revocable beyond quota.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42559/#review115539 --- There maybe risk if we want to catch up with 0.27.0 for this. src

Re: Review Request 42575: Removed superfluous word from quota.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42575/#review115540 --- Patch looks great! Reviews applied: [42575] Passed command: expor

Re: Review Request 42559: Allocated resources as revocable beyond quota.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42559/#review115541 --- Another problem is with Qos Controller, the slave may found that th

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review115542 --- src/docker/docker.cpp (line 517)

Re: Review Request 42559: Allocated resources as revocable beyond quota.

> On 一月 21, 2016, 1:48 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1310 > > > > > > The `resource` will include some `reserved` resources, here even if you > > call `resource.muta

Re: Review Request 42559: Allocated resources as revocable beyond quota.

> On Jan. 21, 2016, 1:20 a.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1313 > > > > > > Who will kill this `revocable` resources? So we'll have a patch for > > evicting? > > Alexander

Re: Review Request 42559: Allocated resources as revocable beyond quota.

> On Jan. 21, 2016, 1:20 a.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1313 > > > > > > Who will kill this `revocable` resources? So we'll have a patch for > > evicting? > > Alexander

Re: Review Request 41790: Add tests for /weights endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/ --- (Updated Jan. 21, 2016, 3:08 a.m.) Review request for mesos, Adam B, Neil Conwa

Re: Review Request 42239: Added tests for the Docker URI fetcher plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42239/#review115547 --- Patch looks great! Reviews applied: [42235, 41961, 42236, 42237, 4

Re: Review Request 42288: Add timestamp to DockerContainerizer's ResourceStatistics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42288/ --- (Updated 一月 21, 2016, 3:46 a.m.) Review request for mesos, Jie Yu and Timothy C

Re: Review Request 42288: Add timestamp to DockerContainerizer's ResourceStatistics

> On 一月 14, 2016, 9:19 a.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [42288] > > > > Failed command: ./support/apply-review.sh -n -r 42288 > > > > Error: > > 2016-01-14 09:19:38 URL:https://reviews.apache.org/r/42288/diff/raw/ > > [612/612] -> "42288.patch" [1] > > Tot

Re: Review Request 42355: Removed the timeout from the filter.

> On Jan. 20, 2016, 9:49 a.m., Qian Zhang wrote: > > One question: Say allocation interval is 10s, at the time 5s, framework > > sets a filter with 3s, so with this patch, we will expire the filter 10s > > (max(10, 3)) later, i.e., at the time 15s. Then at the time of 10s (the > > next allocat

Re: Review Request 42580: Updated changelog :renaming of 'authenticate' to 'authenticate_frameworks' flag

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42580/#review115551 --- Bad patch! Reviews applied: [42580] Failed command: ./support/app

Re: Review Request 42288: Add timestamp to DockerContainerizer's ResourceStatistics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42288/ --- (Updated 一月 21, 2016, 4:12 a.m.) Review request for mesos, Jie Yu and Timothy C

Re: Review Request 42517: Added discussion about allowing multiple frameworks in a role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42517/#review115565 --- Patch looks great! Reviews applied: [42517] Passed command: expor

Re: Review Request 41772: Added helper function to flatten resources.

> On 一月 19, 2016, 10:18 p.m., Joseph Wu wrote: > > src/common/resources.cpp, line 880 > > > > > > It should be fine to just name this `flatten`. > > > > You should also consider changing the parameter type f

Re: Review Request 41790: Add tests for /weights endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/#review115567 --- Bad patch! Reviews applied: [41597, 41681, 41789] Failed command:

Re: Review Request 42288: Add timestamp to DockerContainerizer's ResourceStatistics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42288/#review115570 --- Bad patch! Reviews applied: [42288] Failed command: ./support/app

Re: Review Request 42288: Add timestamp to DockerContainerizer's ResourceStatistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42288/ --- (Updated 一月 21, 2016, 6:18 a.m.) Review request for mesos, Jie Yu and Timothy C

Re: Review Request 42288: Add timestamp to DockerContainerizer's ResourceStatistics.

> On 一月 21, 2016, 6:12 a.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [42288] > > > > Failed command: ./support/apply-review.sh -n -r 42288 > > > > Error: > > 2016-01-21 06:12:19 URL:https://reviews.apache.org/r/42288/diff/raw/ > > [612/612] -> "42288.patch" [1] > > Tot

Review Request 42589: Added test case for allocator recover with Quota.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42589/ --- Review request for mesos, Alexander Rukletsov, Ben Mahler, and Joris Van Remoort

Re: Review Request 42535: Made allocator's pause/resume idempotent.

> On Jan. 20, 2016, 3:11 p.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1048 > > > > > > Suggest to add some tests for this case. > > Alexander Rukletsov wrote: > I totally agree we

Re: Review Request 42589: Added test case for allocator recover with Quota.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42589/ --- (Updated Jan. 21, 2016, 2:27 p.m.) Review request for mesos, Alexander Rukletso

Review Request 42590: Removed reserved() API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42590/ --- Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, J

Re: Review Request 41772: Added helper function to flatten resources.

> On 一月 19, 2016, 10:18 p.m., Joseph Wu wrote: > > src/common/resources.cpp, lines 874-877 > > > > > > This is pretty much a copy of `Resources::reserved` now. You can > > remove it. > > Guangya Liu wrote: > T

Review Request 42591: Added Framework protobufs to registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42591/ --- Review request for mesos, Ben Mahler and Vinod Kone. Bugs: MESOS-1719 https

Re: Review Request 42591: Added Framework protobufs to registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42591/ --- (Updated Jan. 21, 2016, 6:44 a.m.) Review request for mesos, Ben Mahler and Vin

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

> On 一月 16, 2016, 2:11 a.m., Joseph Wu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1291-1319 > > > > > > None of this should be necessary: > > > > 1) You should have all the allocation sl

Re: Review Request 42239: Added tests for the Docker URI fetcher plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42239/#review115586 --- Ship it! Ship It! - Timothy Chen On Jan. 21, 2016, 12:41 a.m.,

Re: Review Request 42355: Removed the timeout from the filter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42355/#review115583 --- Thanks Alex, code change looks great. Feel free to split the fix an

Re: Review Request 41847: Updated allocation slack when slave was updated.

> On 一月 16, 2016, 2:21 a.m., Joseph Wu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 529-535 > > > > > > What if you did this? > > ``` > > slaves[slaveId]total = slaves[slaveId].total.nonUsage

Re: Review Request 42589: Added test case for allocator recover with Quota.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42589/#review115588 --- Patch looks great! Reviews applied: [42535, 42589] Passed command

Re: Review Request 42470: Multiple Disk: Added 'Source' to 'Resource.DiskInfo'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42470/ --- (Updated Jan. 21, 2016, 7:35 a.m.) Review request for mesos, Jie Yu and Michael

Re: Review Request 42471: Multiple Disk: Adjusted resource arithmetic for 'DiskInfo.Source'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42471/ --- (Updated Jan. 21, 2016, 7:36 a.m.) Review request for mesos, Jie Yu and Michael

Re: Review Request 42472: Multiple Disk: Checkpoint persistent volume based on 'DiskInfo.Source'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42472/ --- (Updated Jan. 21, 2016, 7:37 a.m.) Review request for mesos, Jie Yu and Michael

Re: Review Request 42473: Multiple Disk: Updated filesystem isolators to use 'DiskInfo.Source'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42473/ --- (Updated Jan. 21, 2016, 7:37 a.m.) Review request for mesos, Jie Yu and Michael

Re: Review Request 42474: Multiple Disk: Updated Slave initialize to create DiskInfo paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42474/ --- (Updated Jan. 21, 2016, 7:38 a.m.) Review request for mesos, Jie Yu and Michael

Re: Review Request 42503: Multiple Disk: Added Resource arithmetic tests for type 'PATH'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42503/ --- (Updated Jan. 21, 2016, 7:39 a.m.) Review request for mesos, Jie Yu and Michael

Review Request 42593: Multiple Disk: Fixed invalid 'DiskResourcesTest's.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42593/ --- Review request for mesos. Repository: mesos Description --- These were i

Re: Review Request 42504: Multiple Disk: Modified 'DiskInfo' stripping logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42504/ --- (Updated Jan. 21, 2016, 7:39 a.m.) Review request for mesos, Jie Yu and Michael

Re: Review Request 42505: Multiple Disk: Adjusted DiskInfo validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42505/ --- (Updated Jan. 21, 2016, 7:40 a.m.) Review request for mesos, Jie Yu and Michael

Re: Review Request 42506: Multiple Disk: Parameterized persistent volume tests on disk source.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42506/ --- (Updated Jan. 21, 2016, 7:41 a.m.) Review request for mesos, Jie Yu and Michael

Re: Review Request 42535: Made allocator's pause/resume idempotent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42535/#review115589 --- Ship it! I see the test is in the works in a separate review. - J

Re: Review Request 41791: Updated allocation slack when dynamic reserve new resources (1/3).

> On 一月 20, 2016, 10:54 p.m., Joseph Wu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 662 > > > > > > Have you considered modifying `Resources::apply` to "create" allocation > > slack upon a reservati

<    1   2