Re: Review Request 41333: Added helper functions to filter usage slack resources.

2016-03-15 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41333/#review123823 --- include/mesos/resources.hpp (line 174)

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

2016-03-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/#review123828 --- Patch looks great! Reviews applied: [43613, 43614, 43629, 43630,

Re: Review Request 42036: Windows: Added `slave/flags.cpp` to Windows build.

2016-03-15 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42036/#review123834 --- Ship it! Ship It! - Michael Park On March 11, 2016, 9:51

Re: Review Request 44836: Update TaskId in long_lived_framework to use fixed length taskid.

2016-03-15 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44836/ --- (Updated March 16, 2016, 2:27 a.m.) Review request for mesos and haosdent

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

2016-03-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44758/#review123836 --- Patch looks great! Reviews applied: [44758] Passed command:

Re: Review Request 44846: Deprecated the plain text credential format.

2016-03-15 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44846/#review123720 --- FYI, this review: https://reviews.apache.org/r/44515/ adds

Re: Review Request 44755: Added getAppcImage for Appc provisioning tests.

2016-03-15 Thread Anand Mazumdar
> On March 15, 2016, 4:56 p.m., Jie Yu wrote: > > src/tests/containerizer/provisioner_appc_tests.cpp, lines 587-610 > > > > > > Can you move this function to the top of this file and make it 'static'? > > Anand

Re: Review Request 44755: Added getAppcImage for Appc provisioning tests.

2016-03-15 Thread Jojy Varghese
> On March 15, 2016, 4:56 p.m., Jie Yu wrote: > > src/tests/containerizer/provisioner_appc_tests.cpp, lines 587-610 > > > > > > Can you move this function to the top of this file and make it 'static'? > > Anand

Re: Review Request 44654: Fixed hard-coded executor shutdown grace period in executor library.

2016-03-15 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44654/#review123713 --- Looks great! Main thing is documenting why we don't assume the

Re: Review Request 44755: Added getAppcImage for Appc provisioning tests.

2016-03-15 Thread Jojy Varghese
> On March 15, 2016, 4:56 p.m., Jie Yu wrote: > > src/tests/containerizer/provisioner_appc_tests.cpp, lines 587-610 > > > > > > Can you move this function to the top of this file and make it 'static'? > > Anand

Re: Review Request 44755: Added getAppcImage for Appc provisioning tests.

2016-03-15 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44755/ --- (Updated March 15, 2016, 6:26 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

2016-03-15 Thread Jie Yu
> On March 11, 2016, 8:02 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni.hpp, line 85 > > > > > > I would suggest we have a `Info` for each container. > > > > ``` > > struct

Re: Review Request 44545: Separated standalone and zookeeper classes.

2016-03-15 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44545/ --- (Updated March 15, 2016, 6:17 a.m.) Review request for mesos and Benjamin

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

2016-03-15 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/ --- (Updated March 15, 2016, 6:16 a.m.) Review request for mesos and Benjamin

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

2016-03-15 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44288/ --- (Updated March 15, 2016, 6:17 a.m.) Review request for mesos and Benjamin

Re: Review Request 44544: Moved contender and detector definitions into separate directories.

2016-03-15 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44544/ --- (Updated March 15, 2016, 6:17 a.m.) Review request for mesos and Benjamin

Re: Review Request 44543: Removed unnecessary MasterContender and MasterDetector definitions.

2016-03-15 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44543/ --- (Updated March 15, 2016, 6:17 a.m.) Review request for mesos and Benjamin

Re: Review Request 44546: Moved functions in promises to a common header file.

2016-03-15 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44546/ --- (Updated March 15, 2016, 6:18 a.m.) Review request for mesos and Benjamin

Re: Review Request 44670: Added master_detector and master_contender flags.

2016-03-15 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44670/ --- (Updated March 15, 2016, 6:18 a.m.) Review request for mesos and Benjamin

Re: Review Request 44669: Added createFromModule methods to MasterContender and MasterDetector.

2016-03-15 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44669/ --- (Updated March 15, 2016, 6:18 a.m.) Review request for mesos and Benjamin

Re: Review Request 44547: Added functions in promises to the collect header.

2016-03-15 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44547/ --- (Updated March 15, 2016, 6:18 a.m.) Review request for mesos and Benjamin

Re: Review Request 44289: Added support for contender and detector modules.

2016-03-15 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44289/ --- (Updated March 15, 2016, 6:18 a.m.) Review request for mesos and Benjamin

<    1   2   3