Re: Review Request 44257: Upgrade protobuf to 2.6.1 to support PowerPC LE platform [stout].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44257/#review126348 --- Ship it! Ship It! - Vinod Kone On March 29, 2016, 7:14

Re: Review Request 45528: [WIP] Upgrade http-parser to v2.6.2 [mesos].

> On March 31, 2016, 10:02 a.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [45528, 45527] > > > > Failed command: ./support/apply-review.sh -n -r 45527 > > > > Error: > > 2016-03-31 10:02:51 URL:https://reviews.apache.org/r/45527/diff/raw/ > > [125760/125760] ->

Re: Review Request 45536: Cleaned up temporary directories in `PersistentVolumeTest`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45536/#review126346 --- Ship it! Ship It! - Jie Yu On March 31, 2016, 12:16 p.m.,

Re: Review Request 45527: Upgrade http-parser to v2.6.2 [libprocess].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45527/#review126343 --- Ship it! Ship It! - Vinod Kone On March 31, 2016, 9:48

Re: Review Request 45534: Added per-role and quota share metrics to the DRFSorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45534/#review126342 --- Bad patch! Reviews applied: [45534, 45533, 45529] Failed

Re: Review Request 45439: Completed MVP implementation of the Nvidia GPU isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45439/ --- (Updated March 31, 2016, 4:48 p.m.) Review request for mesos, Ben Mahler, Rob

Re: Review Request 45535: Fixed PersistentVolumeTest `TearDown`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45535/#review126340 --- Ship it! Ship It! - Jie Yu On March 31, 2016, 12:15 p.m.,

Re: Review Request 44080: Windows:[1/2] Implemented `os::gmtime_r`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44080/ --- (Updated March 31, 2016, 4:40 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 45450: Add JSON::Object::at() helper API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45450/ --- (Updated March 31, 2016, 4:25 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 45451: Fix the local Docker puller for private registries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45451/ --- (Updated March 31, 2016, 4:25 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44571: Added timeout for destroying Docker containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44571/#review126330 --- Bad patch! Reviews applied: [44571] Failed command:

Re: Review Request 45537: Updated testing `Environment` to remove temp dirs after each test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45537/#review126322 --- Patch looks great! Reviews applied: [45535, 45536, 45537]

Re: Review Request 45537: Updated testing `Environment` to remove temp dirs after each test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45537/#review126318 --- src/tests/environment.cpp (lines 767 - 771)

Re: Review Request 45536: Cleaned up temporary directories in `PersistentVolumeTest`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45536/#review126315 --- LGTM. I'll let Jie give the final ship it.

Re: Review Request 45535: Fixed PersistentVolumeTest `TearDown`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45535/#review126314 --- Ship it! Ship It! - Vinod Kone On March 31, 2016, 12:15

Review Request 45546: Implemented status() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45546/ --- Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu. Bugs:

Re: Review Request 45529: Do not leak roleSorter and quotaRoleSorter in Mesos allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45529/ --- (Updated March 31, 2016, 4:34 p.m.) Review request for mesos and Joris Van

Review Request 45533: Explicitly typed quota role sorter in Mesos allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45533/ --- Review request for mesos, Alexander Rukletsov and Ben Mahler. Bugs: MESOS-4760

Review Request 45534: Added per-role and quota share metrics to the DRFSorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45534/ --- Review request for mesos, Alexander Rukletsov and Ben Mahler. Bugs: MESOS-4760

Re: Review Request 45539: Added Hamburg Mesos User Group to community page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45539/ --- (Updated March 31, 2016, 1:30 p.m.) Review request for mesos and Alexander

Re: Review Request 45539: Added Hamburg Mesos User Group to community page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45539/ --- (Updated March 31, 2016, 1:30 p.m.) Review request for mesos and Alexander

Re: Review Request 44571: Added timeout for destroying Docker containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44571/ --- (Updated March 31, 2016, 3:26 p.m.) Review request for mesos and Joris Van

Re: Review Request 45495: Removed custom clone functions from Mesos [5/5].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45495/#review126302 --- Patch looks great! Reviews applied: [45491, 45492, 45493, 45494,

Review Request 45537: Updated testing `Environment` to remove temp dirs after each test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45537/ --- Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone. Bugs:

Review Request 45536: Cleaned up temporary directories in `PersistentVolumeTest`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45536/ --- Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone. Bugs:

Review Request 45535: Fixed PersistentVolumeTest `TearDown`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45535/ --- Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone. Bugs:

Re: Review Request 45383: Implemented recover() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45383/ --- (Updated March 31, 2016, 7:33 p.m.) Review request for mesos, Avinash

Re: Review Request 45383: Implemented recover() method of "network/cni" isolator.

> On March 31, 2016, 2:12 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 339 > > > > > > I think this is not needed because if recover fails, slave will restart. Agree,

Review Request 45532: Renamed 'getNetworkInfoDir' to 'getContainerDir'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45532/ --- Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu. Bugs:

Review Request 45531: Made 'ROOT_DIR' a shared mount.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45531/ --- Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu. Bugs:

Re: Review Request 45082: Implemented cleanup() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45082/ --- (Updated March 31, 2016, 7:28 p.m.) Review request for mesos, Avinash

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/ --- (Updated March 31, 2016, 11:17 a.m.) Review request for mesos, Jie Yu and

Re: Review Request 45500: Fix Mesos-1104, linux/fs.hpp remove mesos::internal:: should be enough.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45500/ --- (Updated 三月 31, 2016, 10:50 a.m.) Review request for mesos, haosdent huang and

Re: Review Request 45495: Removed custom clone functions from Mesos [5/5].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45495/ --- (Updated March 31, 2016, 10:24 a.m.) Review request for mesos and Joris Van

Re: Review Request 45494: Removed clone option from subprocess [4/5].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45494/ --- (Updated March 31, 2016, 10:23 a.m.) Review request for mesos and Joris Van

Re: Review Request 45493: Added namespace option to subprocess [3/5].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45493/ --- (Updated March 31, 2016, 10:22 a.m.) Review request for mesos and Joris Van

Re: Review Request 45492: Used ChildHooks in Mesos [2/5].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45492/ --- (Updated March 31, 2016, 10:21 a.m.) Review request for mesos and Joris Van

Re: Review Request 45491: Refactored subprocess options [1/5].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45491/ --- (Updated March 31, 2016, 10:21 a.m.) Review request for mesos and Joris Van

Re: Review Request 45528: [WIP] Upgrade http-parser to v2.6.2 [mesos].

> On March 31, 2016, 6:02 p.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [45528, 45527] > > > > Failed command: ./support/apply-review.sh -n -r 45527 > > > > Error: > > 2016-03-31 10:02:51 URL:https://reviews.apache.org/r/45527/diff/raw/ > > [125760/125760] ->

Re: Review Request 45528: [WIP] Upgrade http-parser to v2.6.2 [mesos].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45528/#review126288 --- Bad patch! Reviews applied: [45528, 45527] Failed command:

Review Request 45529: Do not leak roleSorter and quotaRoleSorter in Mesos allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45529/ --- Review request for mesos and Joris Van Remoortere. Repository: mesos

Re: Review Request 45528: [WIP] Upgrade http-parser to v2.6.2 [mesos].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45528/ --- (Updated March 31, 2016, 5:48 p.m.) Review request for mesos, Greg Mann and

Re: Review Request 45527: Upgrade http-parser to v2.6.2 [libprocess].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45527/ --- (Updated March 31, 2016, 5:48 p.m.) Review request for mesos, Greg Mann and

Re: Review Request 45528: [WIP] Upgrade http-parser to v2.6.2 [mesos].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45528/ --- (Updated March 31, 2016, 5:47 p.m.) Review request for mesos, Greg Mann and

Re: Review Request 45527: Upgrade http-parser to v2.6.2 [libprocess].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45527/ --- (Updated March 31, 2016, 5:43 p.m.) Review request for mesos, Greg Mann and

Review Request 45527: Upgrade http-parser to v2.6.2 [libprocess].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45527/ --- Review request for mesos, Greg Mann and Vinod Kone. Repository: mesos

Review Request 45528: Upgrade http-parser to v2.6.2 [mesos].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45528/ --- Review request for mesos, Greg Mann and Vinod Kone. Repository: mesos

Re: Review Request 45482: Replace NULL with nullptr.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45482/#review126285 --- Patch looks great! Reviews applied: [45482] Passed command:

Re: Review Request 45202: Add test for rescinding offer trriggered by updating weights.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45202/#review126281 --- Patch looks great! Reviews applied: [45202] Passed command:

Re: Review Request 45482: Replace NULL with nullptr.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45482/ --- (Updated March 31, 2016, 7:42 a.m.) Review request for mesos and Michael Park.

Re: Review Request 45202: Add test for rescinding offer trriggered by updating weights.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45202/ --- (Updated March 31, 2016, 7:15 a.m.) Review request for mesos and Adam B.

Re: Review Request 45202: Add test for rescinding offer trriggered by updating weights.

> On March 30, 2016, 11:58 a.m., Adam B wrote: > > src/tests/master_allocator_tests.cpp, line 1519 > > > > > > Don't you at least know that one of these parameters is the master's > > pid? Do you mean the

<    1   2