Re: Review Request 46525: Moved 3rdparty packages from libprocess/3rdparty/ to 3rdparty/.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46525/ --- (Updated April 21, 2016, 6:01 p.m.) Review request for mesos, Cody Maloney,

Re: Review Request 46535: Updated stout path for doxygen main page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46535/ --- (Updated April 21, 2016, 6:02 p.m.) Review request for mesos, Cody Maloney,

Re: Review Request 46536: Updated stout path in newbie-guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46536/ --- (Updated April 21, 2016, 6:02 p.m.) Review request for mesos, Cody Maloney,

Re: Review Request 46514: Libprocess: Sorted configure.ac AC_ARG_{ENABLE, WITH} entries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46514/ --- (Updated April 21, 2016, 6:01 p.m.) Review request for mesos, Cody Maloney,

Re: Review Request 46529: Moved stout from libprocess/3rdparty/ to 3rdparty/.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46529/ --- (Updated April 21, 2016, 6:01 p.m.) Review request for mesos, Cody Maloney,

Re: Review Request 46524: Sanitized src/Makefile.am.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46524/ --- (Updated April 21, 2016, 6:01 p.m.) Review request for mesos, Cody Maloney,

Re: Review Request 46519: Copied libprocess-specific configure options to top-level configure.ac.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46519/ --- (Updated April 21, 2016, 6:01 p.m.) Review request for mesos, Cody Maloney,

Re: Review Request 46522: Sanitized libprocess/3rdparty/Makefile.am.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46522/ --- (Updated April 21, 2016, 6:01 p.m.) Review request for mesos, Cody Maloney,

Re: Review Request 46530: Libprocess: Replaced $(top_srcdir) with $(srcdir) in Makefile.am.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46530/ --- (Updated April 21, 2016, 6:02 p.m.) Review request for mesos, Cody Maloney,

Re: Review Request 46517: Sorted top-level configure.ac AC_ARG_{ENABLE, WITH} entries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46517/ --- (Updated April 21, 2016, 6:01 p.m.) Review request for mesos, Cody Maloney,

Re: Review Request 46518: Sorted option checks for top-level configure.ac.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46518/ --- (Updated April 21, 2016, 6:01 p.m.) Review request for mesos, Cody Maloney,

Re: Review Request 46526: Updated 3rdparty paths in Python build scripts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46526/ --- (Updated April 21, 2016, 6:01 p.m.) Review request for mesos, Cody Maloney,

Re: Review Request 46523: Sanitized libprocess/Makefile.am.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46523/ --- (Updated April 21, 2016, 6:01 p.m.) Review request for mesos, Cody Maloney,

Re: Review Request 46527: Updated stout/configure.ac to include several '--with-XXX' options.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46527/ --- (Updated April 21, 2016, 6:01 p.m.) Review request for mesos, Cody Maloney,

Re: Review Request 46533: Stopped using libprocess/stout configure scripts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46533/ --- (Updated April 21, 2016, 6:02 p.m.) Review request for mesos, Cody Maloney,

Re: Review Request 46515: Libprocess: Renamed --without-zlib to --disable-zlib.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46515/ --- (Updated April 21, 2016, 6:01 p.m.) Review request for mesos, Cody Maloney,

Re: Review Request 46532: Updated LDADD flags for libprocess tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46532/ --- (Updated April 21, 2016, 6:02 p.m.) Review request for mesos, Cody Maloney,

Re: Review Request 46534: Updated stout path for mesos_split.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46534/ --- (Updated April 21, 2016, 6:02 p.m.) Review request for mesos, Cody Maloney,

Re: Review Request 46539: Removed libprocess/3rdparty references from misc files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46539/ --- (Updated April 21, 2016, 6:02 p.m.) Review request for mesos, Cody Maloney,

Re: Review Request 45370: Implemented prepare() for volume isolator.

> On 四月 13, 2016, 9:05 p.m., James DeFelice wrote: > > src/slave/containerizer/mesos/isolators/docker/dvd/dvd.cpp, line 106 > > > > > > we should probably validate (or else sanitize) the contents of driver, > >

Re: Review Request 45275: Enabled "--explicitcreate" when call "dvdcli mount".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45275/ --- (Updated 四月 22, 2016, 2:29 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 46550: Fixed slave to initialize libprocess before modules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46550/#review130025 --- Patch looks great! Reviews applied: [46550] Passed command:

Re: Review Request 45375: Implemented cleanup() for docker volume isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45375/#review129968 ---

Re: Review Request 46456: Clarified and improved documentation for maintenance primitives.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46456/#review130010 --- Ship it! Ship It! - Joris Van Remoortere On April 21, 2016,

Re: Review Request 45674: Implemented recover() for dvd isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45674/#review130011 ---

Re: Review Request 46469: Added support for credentials to mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46469/#review130012 --- src/cli/execute.cpp (line 754)

Re: Review Request 46340: Stout:[1/2] Implement `os::waitpid`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46340/#review130013 --- 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp

Re: Review Request 46372: Fixed broken mesos.native package installation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46372/ --- (Updated April 22, 2016, 1:22 a.m.) Review request for mesos, Steve Niemitz,

Re: Review Request 46372: Fixed broken mesos.native package installation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46372/#review130017 --- Ship it! Ship It! - Steve Niemitz On April 22, 2016, 1:22

Review Request 46550: Fixed slave to initialize libprocess before modules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46550/ --- Review request for mesos, Adam B, Kapil Arya, Joseph Wu, Niklas Nielsen, and

Re: Review Request 45500: Keep fs::mount information should be consolidated.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45500/#review130021 --- why not group it into `namespace linux`, along with others in the

Re: Review Request 45014: Add /containers endpoint.

> On April 15, 2016, 12:33 a.m., Jie Yu wrote: > > ping? > > Jay Guo wrote: > bump sorry, was sick these days. WIll commit it today. - Jie --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 46538: Install module dependencies in build/3rdparty as well.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46538/#review129989 --- Bad review! Reviews applied: [46538, 46537, 46539, 46536, 46535,

Re: Review Request 46436: Added the test "CniIsolatorTest.ROOT_FailedPlugin".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46436/#review129991 --- Fix it, then Ship it! Ship It!

Re: Review Request 46249: Hook and module process operation before main process initialize.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46249/#review129996 --- Committed this. But can you send another review for

Re: Review Request 46314: Added upstream patch fixing signed/unsigned comparison for protobuf.

> On April 18, 2016, 6:11 p.m., Vinod Kone wrote: > > Looks good to me. Is there already a bug reported for this in the protobuf > > project? If not, can you create one and link it here? > > > > Also, this review is incomplete. There has to be corresponding changes in > > the Makefiles and

Re: Review Request 46391: Clarified several agent log messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46391/#review12 --- src/slave/slave.cpp (line 1826)

Re: Review Request 46471: Updated descriptions for master endpoints which may return redirect.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46471/#review130004 --- src/master/http.cpp (line 335)

Re: Review Request 45370: Implemented prepare() for volume isolator.

> On 四月 21, 2016, 9:36 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp, line 77 > > > > > > Should we use a hashset for `dockerVolumeInfos`? > > > > I am

Re: Review Request 46435: Added the test "CniIsolatorTest.ROOT_VerifyCheckpointedInfo".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46435/#review129963 --- src/tests/containerizer/cni_isolator_tests.cpp (line 160)

Re: Review Request 45500: Keep fs::mount information should be consolidated.

> On April 21, 2016, 5:45 p.m., haosdent huang wrote: > > src/tests/containerizer/fs_tests.cpp, line 37 > > > > > > I think need remove this blank line. > > Deshi Xiao wrote: > are u sure? > > 36 using

Re: Review Request 46249: Hook and module process operation before main process initialize.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46249/#review129994 --- Ship it! Ship It! - Vinod Kone On April 19, 2016, 2:52

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

> On April 14, 2016, 4:49 p.m., Vinod Kone wrote: > > src/launcher/http_command_executor.cpp, line 749 > > > > > > Looking at slave::statusUpdate() code there are several scenarios where > > the slave ignores a

Re: Review Request 34646: Redirected to the leading master when current master is not the leader.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34646/#review130003 --- Ship it! Ship It! - Vinod Kone On April 21, 2016, 7:04

Re: Review Request 46472: Reran `generate-endpoint-help.py` script for endpoints redirection.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46472/#review130006 --- Re-run this after addressing the comments in the previous review.

Re: Review Request 45014: Add /containers endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45014/#review130005 --- Ship it! src/slave/http.cpp (line 680)

Re: Review Request 46473: Updated `high-availability` and `operational-guide` docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46473/#review130008 --- docs/high-availability.md (line 29)

Re: Review Request 46472: Reran `generate-endpoint-help.py` script for endpoints redirection.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46472/ --- (Updated April 22, 2016, 4:10 a.m.) Review request for mesos, Adam B, Anand

Re: Review Request 46471: Updated descriptions for master endpoints which may return redirect.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46471/ --- (Updated April 22, 2016, 4:10 a.m.) Review request for mesos, Adam B, Anand

Re: Review Request 45922: Added agent authorization flags.

> On April 20, 2016, 9:26 a.m., Adam B wrote: > > src/tests/cluster.hpp, line 151 > > > > > > Why do you even need the overload for the authorizer here? Seems like > > most tests will either provide --acls and use

Re: Review Request 46135: Fix the bug in MasterAllocatorTest/1.RebalancedForUpdatedWeights test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46135/#review129884 --- Ship it! Ship It! - Alexander Rukletsov On April 20, 2016,

Re: Review Request 45922: Added agent authorization flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45922/ --- (Updated April 21, 2016, 3:45 p.m.) Review request for mesos, Adam B and

Re: Review Request 45922: Added agent authorization flags.

> On April 20, 2016, 9:26 a.m., Adam B wrote: > > src/tests/cluster.cpp, lines 406-412 > > > > > > Why is it an error to start an agent with no authorizer and no ACLs? > > What if I don't want to do any

Re: Review Request 46322: Added KillPolicy to scheduler and executor Kill protobuf messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46322/ --- (Updated April 21, 2016, 2:03 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 45370: Implemented prepare() for volume isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45370/ --- (Updated 四月 21, 2016, 2:21 p.m.) Review request for mesos, David vonThenen,

Re: Review Request 46325: Updated HTTP command executor to support kill policy in Kill event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46325/ --- (Updated April 21, 2016, 2:28 p.m.) Review request for mesos, Ben Mahler and

Review Request 46491: Ensured escalated() is not called after reaped() in command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46491/ --- Review request for mesos, Benjamin Bannier and Ben Mahler. Bugs: MESOS-5240

Re: Review Request 46321: Renamed a variable in command executors for clarity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46321/ --- (Updated April 21, 2016, 2:01 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 46325: Updated HTTP command executor to support kill policy in Kill event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46325/ --- (Updated April 21, 2016, 2:06 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 46323: Propagated KillPolicy in kill task from scheduler to executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46323/ --- (Updated April 21, 2016, 2:06 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 46325: Updated HTTP command executor to support kill policy in Kill event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46325/ --- (Updated April 21, 2016, 2:11 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 46324: Corrected indentation in HttpCommandExecutor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46324/ --- (Updated April 21, 2016, 2:11 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 46491: Ensured escalated() is not called after reaped() in command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46491/ --- (Updated April 21, 2016, 2:28 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 46321: Renamed a variable in command executors for clarity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46321/ --- (Updated April 21, 2016, 2:27 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 46323: Propagated KillPolicy in kill task from scheduler to executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46323/ --- (Updated April 21, 2016, 2:28 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 46322: Added KillPolicy to scheduler and executor Kill protobuf messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46322/ --- (Updated April 21, 2016, 2:28 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 46203: Added authorization of the '/flags' endpoint.

> On April 20, 2016, 10:35 a.m., Adam B wrote: > > src/tests/slave_authorization_tests.cpp, line 49 > > > > > > Any reason why these shouldn't just go in authorization_tests.cpp? I'm following the pattern

Re: Review Request 46491: Ensured escalated() is not called after reaped() in command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46491/#review129903 --- Patch looks great! Reviews applied: [46321, 46322, 46323, 46325,

Review Request 46461: Updated gperftools to version 2.5 (libprocess).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46461/ --- Review request for mesos and Kapil Arya. Bugs: MESOS-3319

Re: Review Request 46462: Updated gperftools to version 2.5 (Mesos).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46462/#review129908 --- Bad patch! Reviews applied: [46462, 46461] Failed command:

Re: Review Request 46473: Updated `high-availability` and `operational-guide` docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46473/#review129861 --- Patch looks great! Reviews applied: [34646, 46471, 46472, 46473]

Re: Review Request 34646: Redirected to the leading master when current master is not the leader.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34646/ --- (Updated April 21, 2016, 7:04 a.m.) Review request for mesos, Adam B, Anand

Re: Review Request 34646: Redirected to the leading master when current master is not the leader.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34646/ --- (Updated April 21, 2016, 7:04 a.m.) Review request for mesos, Adam B, Anand

Re: Review Request 34646: Redirected to the leading master when current master is not the leader.

> On April 19, 2016, 3:37 p.m., Neil Conway wrote: > > Can we update the docs to describe this behavior? e.g., add a note to > > https://mesos.apache.org/documentation/latest/endpoints/ describing the > > redirect behavior -- I suppose it is worth adding a note to every master > > endpoint's

Re: Review Request 45674: Implemented recover() for dvd isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45674/ --- (Updated 四月 21, 2016, 9:13 a.m.) Review request for mesos, Gilbert Song and

<    1   2