> On 四月 13, 2016, 9:05 p.m., James DeFelice wrote: > > src/slave/containerizer/mesos/isolators/docker/dvd/dvd.cpp, line 106 > > <https://reviews.apache.org/r/45370/diff/4/?file=1324030#file1324030line106> > > > > we should probably validate (or else sanitize) the contents of driver, > > name, and options > > Guangya Liu wrote: > I did not check because they are `required` values.
But as `options` is optional, so I only validate `options` - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45370/#review128744 ----------------------------------------------------------- On 四月 21, 2016, 2:21 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45370/ > ----------------------------------------------------------- > > (Updated 四月 21, 2016, 2:21 p.m.) > > > Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and > Jie Yu. > > > Bugs: MESOS-5013 > https://issues.apache.org/jira/browse/MESOS-5013 > > > Repository: mesos > > > Description > ------- > > Implemented prepare() for volume isolator. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp > bedc687cc280d0b721fb84801039fd3614364cca > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp > 915e5ae755a55a02b7dfcda88165f27346cad955 > src/slave/slave.cpp d82dec2b10d496065013eb4ad6a35dc054b72553 > > Diff: https://reviews.apache.org/r/45370/diff/ > > > Testing > ------- > > make > make check > > Will update `Sequence` later. > > > Thanks, > > Guangya Liu > >