Re: Review Request 50741: Replaced CHECK in SSL socket's `send()` with a log message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50741/#review144890 --- Patch looks great! Reviews applied: [50739, 50741] Passed

Re: Review Request 50494: Remove `base` from ZooKeeperPIDGroup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50494/ --- (Updated Aug. 5, 2016, 8:18 a.m.) Review request for mesos and Joseph Wu.

Re: Review Request 50493: Added `base` to PIDGroup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50493/ --- (Updated Aug. 5, 2016, 8:18 a.m.) Review request for mesos and Joseph Wu.

Re: Review Request 50490: Separated ZooKeeper PIDGroup implementation into its own cpp/hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50490/ --- (Updated Aug. 5, 2016, 8:18 a.m.) Review request for mesos and Joseph Wu.

Re: Review Request 50495: Added PIDGroup module struct.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50495/ --- (Updated Aug. 5, 2016, 8:19 a.m.) Review request for mesos and Joseph Wu.

Re: Review Request 50491: Added PIDGroup to libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50491/ --- (Updated Aug. 5, 2016, 8:16 a.m.) Review request for mesos and Joseph Wu.

Re: Review Request 50492: Switched replicated log to use PIDGroup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50492/ --- (Updated Aug. 5, 2016, 8:16 a.m.) Review request for mesos and Joseph Wu.

Re: Review Request 50496: Added static `createPIDGroup` method to LogProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50496/ --- (Updated Aug. 5, 2016, 8:25 a.m.) Review request for mesos and Joseph Wu.

Re: Review Request 50496: Added static `createPIDGroup` method to LogProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50496/ --- (Updated Aug. 5, 2016, 8:20 a.m.) Review request for mesos and Joseph Wu.

Re: Review Request 50499: Added logic in master/main.cpp to use pid_group module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50499/ --- (Updated Aug. 5, 2016, 8:28 a.m.) Review request for mesos and Joseph Wu.

Review Request 50838: Updated modules documentation to reflect PIDGroup module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50838/ --- Review request for mesos. Repository: mesos Description --- Updated

Re: Review Request 50498: Added --pid_group flag in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50498/ --- (Updated Aug. 5, 2016, 8:28 a.m.) Review request for mesos and Joseph Wu.

Re: Review Request 50127: Added NvidiaGpuDockerContainerizerTest.ROOT_DOCKER_LaunchWithGpu.

> On 八月 4, 2016, 3:04 p.m., Guangya Liu wrote: > > src/tests/containerizer/nvidia_gpu_isolator_tests.cpp, lines 81-141 > > > > > > Seems those are from docker_containerizer_test.cpp, I think that we do > > not need

Re: Review Request 50497: Added new constructors in Log and LogProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50497/ --- (Updated Aug. 5, 2016, 8:27 a.m.) Review request for mesos and Joseph Wu.

Re: Review Request 50838: Updated modules documentation to reflect PIDGroup module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50838/ --- (Updated Aug. 5, 2016, 8:44 a.m.) Review request for mesos and Joseph Wu.

Re: Review Request 50568: Updated -=/+= to subtract/add for resource object.

> On 八月 1, 2016, 10:39 p.m., Jiang Yan Xu wrote: > > Can we keep add/subtract private? The fact they were added to save some > > redudant work suggests their `private` nature. Otherwise what if people use > > `add` directly instead of `+=`? > > > > Looks like they were changed to public just

Review Request 50836: Made add/subtract resource object as private method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50836/ --- Review request for mesos, Benjamin Mahler and Jiang Yan Xu. Repository: mesos

Review Request 50837: Fixed minor code style.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50837/ --- Review request for mesos and Joseph Wu. Repository: mesos Description

Re: Review Request 50812: Updated `HealthCheck` protobuf for HTTP and TCP health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50812/ --- (Updated Aug. 5, 2016, 4:19 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 39939: Made docker_socket option support different protocols.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39939/ --- (Updated Aug. 5, 2016, 4:01 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 39939: Made docker_socket option support different protocols.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39939/ --- (Updated Aug. 5, 2016, 4:31 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50763: Updated Linux 'MountInfoTable' entries to be sorted as expected.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50763/ --- (Updated Aug. 5, 2016, 4:36 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/ --- (Updated 八月 5, 2016, 9:47 a.m.) Review request for mesos, Benjamin Mahler,

Review Request 50844: Fixed outdated comment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50844/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 50812: Updated `HealthCheck` protobuf for HTTP and TCP health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50812/#review144907 --- I've talked to BenM offline and we agreed to simplify messages a

Re: Review Request 50599: Passed allocated GPUs to 'device' entry of 'docker::Flags'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50599/ --- (Updated 八月 5, 2016, 9:51 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50125: Added mesos-docker-executor support for device control.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/ --- (Updated 八月 5, 2016, 9:52 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50677: Renamed `OfferedResources` to `Allocation`.

> On 八月 2, 2016, 12:12 a.m., Benjamin Mahler wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 3461-3466 > > > > > > Can we re-use the Allocation struct from above? > > > > > >

Review Request 50841: Added GPU scheduling logic to docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/ --- Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat

Re: Review Request 50127: Added DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50127/ --- (Updated 八月 5, 2016, 9:53 a.m.) Review request for mesos, Benjamin Mahler,

Review Request 50846: Added more assertions to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50846/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5949

Review Request 50845: Added `unreachable_time` to TaskStatus.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50845/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5949

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/ --- (Updated 八月 5, 2016, 9:58 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50836: Made add/subtract resource object as private method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50836/#review144914 --- Patch looks great! Reviews applied: [50836] Passed command:

Re: Review Request 50705: Changed master to allow partitioned slaves to reregister.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50705/ --- (Updated Aug. 5, 2016, 10:11 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 50812: Updated `HealthCheck` protobuf for HTTP and TCP health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50812/#review144916 --- include/mesos/mesos.proto (line 363)

Re: Review Request 50851: Decode Protobuf long int form strings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50851/#review144960 --- Patch looks great! Reviews applied: [50851] Passed command:

Re: Review Request 50854: Resolved C++11-related TODO in zookeeper/group.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50854/#review144965 --- Ship it! Just a nit, I'll fix it when committing.

Re: Review Request 50838: Updated modules documentation to reflect PIDGroup module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50838/#review144923 --- Patch looks great! Reviews applied: [50837, 50491, 50492, 50490,

Review Request 50862: [MESOS-5929] Update app.js to handle petabyte scale

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50862/ --- Review request for mesos and haosdent huang. Bugs: MESOS-5929

Re: Review Request 50763: Updated Linux 'MountInfoTable' entries to be sorted as expected.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50763/ --- (Updated Aug. 5, 2016, 6:45 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 50853: Resolved C++11-related TODO in master/master.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50853/#review144974 --- Patch looks great! Reviews applied: [50853] Passed command:

Re: Review Request 50862: [MESOS-5929] Update app.js to handle petabyte scale

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50862/#review144976 --- Ship it! Ship It! - Benjamin Mahler On Aug. 5, 2016, 7:28

Re: Review Request 50812: Updated `HealthCheck` protobuf for HTTP and TCP health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50812/ --- (Updated Aug. 5, 2016, 1:59 p.m.) Review request for mesos, Adam B, Alexander

Review Request 50851: Decode Protobuf long int form strings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50851/ --- Review request for mesos, Anand Mazumdar and Joseph Wu. Bugs: MESOS-5995

Re: Review Request 39939: Made docker_socket option support different protocols.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39939/#review145005 --- Patch looks great! Reviews applied: [39939] Passed command:

Re: Review Request 50422: Future-proofed some slave removal tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50422/#review145008 --- Ship it! Ship It! - Vinod Kone On July 28, 2016, 10:14

Re: Review Request 50002: Allow all flags load methods to specify a prefix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50002/ --- (Updated Aug. 5, 2016, 11:58 p.m.) Review request for mesos, Greg Mann and

Re: Review Request 50410: Added helpers evolve/devolve functions for executor calls/events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50410/#review145012 --- Fix it, then Ship it! src/internal/evolve.hpp (line 116)

Re: Review Request 50700: Added a list of "unreachable" agents to the registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50700/#review145018 --- Ship it! Ship It! - Vinod Kone On Aug. 2, 2016, 1:01 p.m.,

Re: Review Request 50699: Added new TaskState values and PARTITION_AWARE capability.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50699/#review145016 --- Fix it, then Ship it! include/mesos/mesos.proto (line 309)

Re: Review Request 50410: Added helpers evolve/devolve functions for executor calls/events.

> On Aug. 6, 2016, 12:30 a.m., Vinod Kone wrote: > > src/internal/evolve.hpp, line 116 > > > > > > s/mesos::// to be consistent with above? Removed the redundant `mesos::` prefixes in this file in another cleanup

Re: Review Request 50410: Added helpers evolve/devolve functions for executor calls/events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50410/ --- (Updated Aug. 6, 2016, 1:35 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 50741: Replaced CHECK in SSL socket's `send()` with a log message.

> On Aug. 5, 2016, 2:51 a.m., Benjamin Mahler wrote: > > 3rdparty/libprocess/src/libevent_ssl_socket.cpp, lines 704-713 > > > > > > Don't we need the same fix in `sendfile`? > > > > It seems a bit odd that

Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50003/#review145011 --- Fix it, then Ship it! src/local/local.cpp (lines 179 - 180)

Review Request 50868: Using `OfferedResources` for benchmark test of `SuppressOffers`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50868/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 40266: Libprocess Reinit: Cleanup SocketManager alongside ProcessManager.

> On Aug. 5, 2016, 2:43 p.m., Greg Mann wrote: > > 3rdparty/libprocess/src/process.cpp, lines 2407-2413 > > > > > > I discovered while running my SSL scheduler test that it's possible for > > new processes to be

Re: Review Request 49571: Added a benchmark test for allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49571/#review144996 --- src/tests/hierarchical_allocator_tests.cpp (line 3490)

Review Request 50871: Supported auto backend in Unified Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50871/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen. Bugs:

Re: Review Request 50763: Updated Linux 'MountInfoTable' entries to be sorted as expected.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50763/#review145019 --- Patch looks great! Reviews applied: [50762, 50763] Passed

Re: Review Request 50741: Replaced CHECK in SSL socket's `send()` with a log message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50741/ --- (Updated Aug. 5, 2016, 10:19 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 50002: Allow all flags load methods to specify a prefix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50002/#review145009 --- Fix it, then Ship it!

Re: Review Request 50868: Using `OfferedResources` for benchmark test of `SuppressOffers`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50868/#review145025 --- Patch looks great! Reviews applied: [50693, 50695, 50866, 50868]

Re: Review Request 40266: Libprocess Reinit: Cleanup SocketManager alongside ProcessManager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40266/#review144989 --- 3rdparty/libprocess/src/process.cpp (lines 2407 - 2413)

Re: Review Request 50677: Renamed `OfferedResources` to `Allocation`.

> On 八月 2, 2016, 12:12 a.m., Benjamin Mahler wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 3461-3466 > > > > > > Can we re-use the Allocation struct from above? > > > > > >

Re: Review Request 50412: Removed a no longer valid comment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50412/#review145014 --- Ship it! Ship It! - Vinod Kone On July 25, 2016, 9:35 p.m.,

Re: Review Request 50413: Minor cleanups to the command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50413/#review145015 --- Ship it! Ship It! - Vinod Kone On July 25, 2016, 9:35 p.m.,

Re: Review Request 50411: Made the command executor use the unversioned protobufs internally.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50411/#review145013 --- Ship it! Ship It! - Vinod Kone On July 25, 2016, 9:36 p.m.,

Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

> On Aug. 6, 2016, 12:29 a.m., Vinod Kone wrote: > > src/local/local.cpp, lines 179-180 > > > > > > not sure if 'propagated_flags' is the right name. > > > > also, wondering if it would be intuitive to just

Review Request 50866: Updated `offerCallback` for allocator benchmark test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50866/ --- Review request for mesos, Benjamin Mahler and Jiang Yan Xu. Repository: mesos

Re: Review Request 50812: Updated `HealthCheck` protobuf for HTTP and TCP health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50812/#review144984 --- Patch looks great! Reviews applied: [50812] Passed command:

Re: Review Request 50871: Supported auto backend in Unified Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50871/#review145026 --- Patch looks great! Reviews applied: [50871] Passed command:

Re: Review Request 50846: Added more assertions to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50846/#review144934 --- Patch looks great! Reviews applied: [50235, 50416, 50417, 50418,

Review Request 50853: Resolved C++11-related TODO in master/master.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50853/ --- Review request for mesos, Alexander Rukletsov and Benjamin Mahler. Repository:

Review Request 50854: Resolved C++11-related TODO in zookeeper/group.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50854/ --- Review request for mesos, Alexander Rukletsov and Jiang Yan Xu. Repository: