Re: Review Request 56740: Update Allegro url on Powered By page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56740/#review165815 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 56593: Explicitly marked protobuf files as using v2 syntax.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56593/ --- (Updated Feb. 16, 2017, 2:58 p.m.) Review request for mesos, Andrew

Re: Review Request 56594: Explicitly marked protobuf files as using v2 syntax.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56594/ --- (Updated Feb. 16, 2017, 2:58 p.m.) Review request for mesos, Andrew

Re: Review Request 56052: Added the 'Secret' protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56052/#review165898 --- Ship it! Ship It! - Vinod Kone On Feb. 16, 2017, 5:52 p.m.,

Re: Review Request 56592: Libprocess: Removed MSVC compiler warnings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56592/#review165879 --- Fix it, then Ship it!

Re: Review Request 56392: Tightened test expecations in reservation-related tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56392/#review165897 --- Ship it! Ship It! - Benjamin Mahler On Feb. 16, 2017, 10:24

Re: Review Request 56593: Explicitly marked protobuf files as using v2 syntax.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56593/#review165895 --- Ship it! Effectively the same as:

Re: Review Request 56594: Explicitly marked protobuf files as using v2 syntax.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56594/#review165893 --- Ship it! Effectively the same as:

Re: Review Request 56623: Implemented 'AuthenticationContext' in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56623/ --- (Updated Feb. 17, 2017, 5:20 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 56778: Fixed a bug around executor not able to use reserved resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56778/ --- (Updated Feb. 17, 2017, 5:24 a.m.) Review request for mesos and Benjamin

Review Request 56778: Fixed a bug around executor not able to use reserved resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56778/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-7119

Re: Review Request 56619: Updated Mesos handlers to use 'AuthenticationContext'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56619/ --- (Updated Feb. 17, 2017, 6:03 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 56619: Updated Mesos handlers to use 'AuthenticationContext'.

> On Feb. 16, 2017, 3:56 p.m., Alexander Rojas wrote: > > I personally find this patch way too big, so at the end I found myself just > > going through the changeset, perhaps breaking it into the _master_, _agent_ > > and _files_ components will help reviewers. What do you think? Good idea,

Re: Review Request 56692: Silenced a GMock warning in a test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56692/#review165840 --- Fix it, then Ship it! src/tests/master_validation_tests.cpp

Review Request 56754: Implemented a JWT secret generator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56754/ --- Review request for mesos and Greg Mann. Bugs: MESOS-7000

Re: Review Request 56213: Added check tests for command executor.

> On Feb. 10, 2017, 2:42 a.m., Vinod Kone wrote: > > src/tests/check_tests.cpp, line 177 > > > > > > s/agent/slave/ > > > > here and everywhere else. > > > > we are not doing this change yet. > >

Re: Review Request 56601: Used single quotes instead of backticks in error message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56601/#review165842 --- Patch looks great! Reviews applied: [55461, 56391, 55462, 56392,

Review Request 56753: Implemented the JWT authenticator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56753/ --- Review request for mesos and Greg Mann. Bugs: MESOS-7001

Review Request 56742: Updated CHANGELOG for Mesos 1.2.0 release.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56742/ --- Review request for mesos. Repository: mesos Description --- Updated

Re: Review Request 56618: Updated common Mesos code to use 'AuthenticationContext'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56618/#review165825 --- src/common/http.hpp (line 133)

Re: Review Request 56052: Added the 'Secret' protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56052/#review165843 --- src/common/validation.cpp (line 113)

Re: Review Request 56601: Used single quotes instead of backticks in error message.

> On Feb. 14, 2017, 1:48 p.m., Gastón Kleiman wrote: > > I think that we should also update `checks/checker.cpp` and > > `checks/health_checker.cpp`: > > > > ``` > > $ ag --cpp --nomultiline '^\s*[^/"]+".*`' > > checks/checker.cpp > > 60:"Check's `CommandInfo` is invalid: " +

Re: Review Request 56530: Prevent offers for old agents being sent to MULTI_ROLE frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56530/#review165846 --- src/master/master.cpp (lines 6943 - 6944)

Re: Review Request 56667: Added support for JSON Web Tokens.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56667/ --- (Updated Feb. 16, 2017, 10:35 a.m.) Review request for mesos and Greg Mann.

Re: Review Request 56667: Added support for JSON Web Tokens.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56667/#review165823 --- Patch looks great! Reviews applied: [56665, 5, 56667]

Re: Review Request 56665: Added a URL-safe base64 implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56665/ --- (Updated Feb. 16, 2017, 10:33 a.m.) Review request for mesos and Greg Mann.

Re: Review Request 56666: Added a HMAC SHA256 generator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/ --- (Updated Feb. 16, 2017, 10:34 a.m.) Review request for mesos and Greg Mann.

Re: Review Request 56618: Updated common Mesos code to use 'AuthenticationContext'.

> On Feb. 14, 2017, 4:12 p.m., Jan Schlicht wrote: > > src/common/http.hpp, line 133 > > > > > > How about using an `Option` here and returning > > `Subject()` in the case of `context.isNone()`? > > All calls

Re: Review Request 56742: Updated CHANGELOG for Mesos 1.2.0 release.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56742/#review165830 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 56601: Used single quotes instead of backticks in error message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56601/ --- (Updated Feb. 16, 2017, 11:24 a.m.) Review request for mesos and Benjamin

Re: Review Request 56617: Updated libprocess handlers to use 'AuthenticationContext'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56617/#review165824 --- Ship it! Ship It! - Alexander Rojas On Feb. 14, 2017, 4:41

Re: Review Request 56623: Implemented 'AuthenticationContext' in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56623/#review165822 --- 3rdparty/libprocess/include/process/http.hpp (line 22)

Re: Review Request 56711: Fixed fetcher to not pick up environment variables it should not see.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56711/#review165818 --- src/slave/containerizer/fetcher.cpp (lines 827 - 828)

Re: Review Request 56392: Tightened test expecations in reservation-related tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56392/ --- (Updated Feb. 16, 2017, 11:24 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 56618: Updated common Mesos code to use 'AuthenticationContext'.

> On Feb. 14, 2017, 4:12 p.m., Jan Schlicht wrote: > > src/common/http.hpp, line 133 > > > > > > How about using an `Option` here and returning > > `Subject()` in the case of `context.isNone()`? > > All calls

Review Request 56757: Added the SecretGenerator module interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56757/ --- Review request for mesos and Greg Mann. Bugs: MESOS-6997

Review Request 56413: WIP Support pausing/resuming health checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56413/ --- Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent huang,

Re: Review Request 55901: Added support for command health checks to the default executor.

> On Feb. 15, 2017, 9:40 p.m., Vinod Kone wrote: > > src/checks/health_checker.cpp, line 664 > > > > > > won't we be losing the info about why wait failed? Yes, but the health check timed out anyway, we call

Re: Review Request 56754: Implemented a JWT secret generator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56754/ --- (Updated Feb. 16, 2017, 3:55 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 56288: Improved the wording of what's logged on command health check timeouts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56288/ --- (Updated Feb. 16, 2017, 2:58 p.m.) Review request for mesos, Alexander

Re: Review Request 55901: Added support for command health checks to the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55901/ --- (Updated Feb. 16, 2017, 2:59 p.m.) Review request for mesos, Alexander

Re: Review Request 56711: Fixed fetcher to not pick up environment variables it should not see.

> On Feb. 16, 2017, 9:39 a.m., Adam B wrote: > > src/slave/containerizer/fetcher.cpp, lines 827-828 > > > > > > How confident are you that the fetcher doesn't actually need any of > > these env vars? How can we

Re: Review Request 56623: Implemented 'AuthenticationContext' in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56623/#review165857 --- 3rdparty/libprocess/include/process/http.hpp (lines 75 - 78)

Re: Review Request 56619: Updated Mesos handlers to use 'AuthenticationContext'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56619/#review165838 --- I personally find this patch way too big, so at the end I found

Re: Review Request 56052: Added the 'Secret' protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56052/ --- (Updated Feb. 16, 2017, 5:52 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 56413: WIP Support pausing/resuming health checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56413/#review165873 --- Patch looks great! Reviews applied: [55900, 56288, 55901, 56413]

Re: Review Request 56053: Added a 'SECRET' type to the 'Environment' protobuf message.

> On Feb. 16, 2017, 12:10 a.m., Vinod Kone wrote: > > src/tests/slave_validation_tests.cpp, line 145 > > > > > > Why is this test here instead of master validationt ests? Doesn't this > > validation happen in

Re: Review Request 56053: Added a 'SECRET' type to the 'Environment' protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56053/ --- (Updated Feb. 16, 2017, 5:57 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 56740: Update Allegro url on Powered By page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56740/#review165876 --- Ship it! Ship It! - Benjamin Mahler On Feb. 16, 2017, 8:27

Re: Review Request 56505: Added Windows support for Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56505/#review165767 --- Ship it! LGTM. I will discard

Re: Review Request 56702: Windows: Handle environment variable inheritance uniformly in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56702/#review165800 --- Ship it! LGTM. I will discard

Re: Review Request 56591: Stout: Removed MSVC compiler warnings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56591/#review165791 --- Ship it! - Joseph Wu On Feb. 15, 2017, 1:36 p.m., Alex

Re: Review Request 56623: Implemented 'AuthenticationContext' in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56623/ --- (Updated Feb. 17, 2017, 5:31 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 56778: Fixed a bug around executor not able to use reserved resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56778/#review165910 --- Patch looks great! Reviews applied: [56778] Passed command: