Re: Review Request 55888: Test to ensure non-authorized users cannot launch tasks on agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55888/#review167592 --- Patch looks great! Reviews applied: [55887, 55888] Passed

Re: Review Request 55790: Support the full CNI DNS specification.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55790/#review167620 --- Patch looks great! Reviews applied: [55790] Passed command:

Re: Review Request 57166: Updated role validation for hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57166/#review167623 --- src/common/roles.cpp Line 71 (original), 71 (patched)

Re: Review Request 57195: Updated WebUI to display role information of tasks in homepage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57195/#review167637 --- Ship it! Ship It! - Benjamin Mahler On March 1, 2017, 10:24

Re: Review Request 57106: Added `FrameworkInfo` to `UpdateFrameworkMessage`.

> On Feb. 27, 2017, 6:42 p.m., Benjamin Mahler wrote: > > src/messages/messages.proto > > Lines 574-575 (patched) > > > > > > Just one thing, looking at the subsequent patch, it appears that the > > agent updates

Re: Review Request 53666: Refactor cgroups cleanup to allow cleanup to continue on an error.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53666/#review167233 --- Patch looks great! Reviews applied: [53666] Passed command:

Review Request 57186: Added unit test for persistent volume using default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57186/ --- Review request for mesos, Anand Mazumdar, Avinash sridharan, Jie Yu, Joris Van

Review Request 57184: Fixed bugs in tests/mesos.hpp helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57184/ --- Review request for mesos, Anand Mazumdar, Avinash sridharan, Jie Yu, Joris Van

Review Request 57185: Support 'v1::createCallAccept()' helper with multi operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57185/ --- Review request for mesos, Anand Mazumdar, Avinash sridharan, Jie Yu, Joris Van

Review Request 57191: Fixed flaky test MasterTest.MultiRoleFrameworkReceivesOffers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57191/ --- Review request for mesos, Benjamin Mahler and Neil Conway. Bugs: MESOS-7182

Re: Review Request 57012: Added unit tests for SHARE and UNSHARE offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57012/#review167244 --- Patch looks great! Reviews applied: [57010, 57011, 57012]

Re: Review Request 57165: Minor cleanup for quota validation code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57165/#review167247 --- Fix it, then Ship it! src/master/quota.cpp Line 147

Re: Review Request 57132: Fixed WebUI data-key.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57132/ --- (Updated March 1, 2017, 6:23 p.m.) Review request for mesos and Benjamin

Review Request 57192: Updated WebUI to display role information under tab 'Frameworks'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57192/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-6657

Review Request 57195: Updated WebUI to display role information of tasks in homepage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57195/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-6657

Review Request 57193: Updated WebUI to display role information under tab 'Agents'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57193/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-6657

Review Request 57194: Updated WebUI to display role information under tab 'Offers'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57194/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-6657

Re: Review Request 57166: Updated role validation for hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57166/#review167254 --- I wonder if it would make sense to introduce some more knowledge

Re: Review Request 56213: Added check tests for command executor.

> On Feb. 15, 2017, 5:07 p.m., Gastón Kleiman wrote: > > src/tests/check_tests.cpp > > Lines 269 (patched) > > > > > > We should add: > > > > ``` > >

Re: Review Request 56213: Added check tests for command executor.

> On Feb. 15, 2017, 1:41 p.m., Gastón Kleiman wrote: > > src/tests/check_tests.cpp > > Lines 632 (patched) > > > > > > I'd add: > > > > ``` > > EXPECT_FALSE(updateTaskRunning->status().has_healthy()); >

Re: Review Request 56213: Added check tests for command executor.

> On Feb. 10, 2017, 2:42 a.m., Vinod Kone wrote: > > src/tests/check_tests.cpp > > Lines 138 (patched) > > > > > > no need for this. For implicit reconciliation, `tasks` are empty, hence we need to ensure the

Re: Review Request 56213: Added check tests for command executor.

> On Feb. 10, 2017, 2:42 a.m., Vinod Kone wrote: > > src/tests/check_tests.cpp > > Lines 73 (patched) > > > > > > Any particular reason for using v1 scheduler API? The general > > recommendation has been to use v0

Re: Review Request 57177: Clarified naming rules in C++ style guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57177/#review167266 --- Patch looks great! Reviews applied: [57177] Passed command:

Re: Review Request 56208: Updated checks library with general check support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56208/ --- (Updated March 1, 2017, 12:50 p.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 57176: Pulled 'ContainerIO' out of the 'ContainerLogger'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57176/#review167275 --- Patch looks great! Reviews applied: [57121, 57122, 56195, 57176]

Review Request 57190: Updated agent for hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57190/ --- Review request for mesos, Michael Park and Neil Conway. Bugs: MESOS-7047

Re: Review Request 57184: Fixed bugs in tests/mesos.hpp helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57184/#review167281 --- Ship it! Ship It! - Joris Van Remoortere On March 1, 2017,

Re: Review Request 57052: CMake: Add `build_config.hpp.in` for `BUILD_TIME` variables.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57052/#review167283 --- Patch looks great! Reviews applied: [57052] Passed command:

Re: Review Request 57185: Support 'v1::createCallAccept()' helper with multi operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57185/#review167282 --- Ship it! Ship It! - Joris Van Remoortere On March 1, 2017,

Re: Review Request 55887: Check task user before allowing a task to be launched on the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55887/ --- (Updated March 1, 2017, 4:15 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 55888: Test to ensure non-authorized users cannot launch tasks on agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55888/ --- (Updated March 1, 2017, 4:15 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 53369: Agent cgroup assignment should precede agent initialization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53369/#review167640 --- Patch looks great! Reviews applied: [53369] Passed command:

Re: Review Request 57106: Added `FrameworkInfo` to `UpdateFrameworkMessage`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57106/#review167655 --- Ship it! Ship It! - Jay Guo On Feb. 28, 2017, 6:11 a.m.,

Re: Review Request 57193: Updated WebUI to display role information under tab 'Agents'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57193/ --- (Updated March 2, 2017, 11:34 a.m.) Review request for mesos and Benjamin

Re: Review Request 57192: Updated WebUI to display role information under tab 'Frameworks'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57192/ --- (Updated March 2, 2017, 11:34 a.m.) Review request for mesos and Benjamin

Re: Review Request 57186: Added unit test for persistent volume using default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57186/#review167292 --- Patch looks great! Reviews applied: [57184, 57185, 57186]

Re: Review Request 57191: Fixed flakiness in three MULTI_ROLE related tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57191/ --- (Updated March 2, 2017, 1:22 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 55790: Support the full CNI DNS specification.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55790/ --- (Updated March 1, 2017, 4:51 p.m.) Review request for mesos, Avinash

Re: Review Request 53369: Agent cgroup assignment should precede agent initialization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53369/ --- (Updated March 1, 2017, 5:57 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 47238: Shifted from a cpu-core model of selection to processing unit model.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47238/#review167314 --- Closing this review due to inactivity. Please see our

Re: Review Request 43473: Sped up ContenderDetectorShutdownNetwork by advance Clock.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43473/#review167335 --- Closing this review due to inactivity. Please see our

Re: Review Request 50249: Modified 'agent' to accecpt request with charset in Content-Type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50249/#review167340 --- Closing this review due to inactivity. Please see our

Re: Review Request 57165: Minor cleanup for quota validation code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57165/ --- (Updated March 1, 2017, 6:07 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47095/#review167341 --- Closing this review due to inactivity. Please see our

Re: Review Request 47055: Make the proper contrast ratio in web page for accessibility.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47055/#review167319 --- Closing this review due to inactivity. Please see our

Re: Review Request 49262: Added '--enable-netlink' into configure.ac.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49262/#review167329 --- Closing this review due to inactivity. Please see our

Re: Review Request 47608: Add Labels from TaskInfo into TaskStatus message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47608/#review167321 --- Closing this review due to inactivity. Please see our

Re: Review Request 48581: Removed duplicated code in 'strings::tokenize()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48581/#review167328 --- Closing this review due to inactivity. Please see our

Re: Review Request 46954: Ensuring that id attributes are unique on a Web page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46954/#review167318 --- Closing this review due to inactivity. Please see our

Re: Review Request 32079: added a few more presentations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32079/#review167332 --- Closing this review due to inactivity. Please see our

Re: Review Request 51110: Introduced the PluginTestBase class into the CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51110/#review167363 --- Closing this review due to inactivity. Please see our

Re: Review Request 51157: Added testing for the container plugin of the CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51157/#review167367 --- Closing this review due to inactivity. Please see our

Re: Review Request 51145: Added testing for the cluster plugin of the CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51145/#review167364 --- Closing this review due to inactivity. Please see our

Re: Review Request 51111: Added the container plugin to the Mesos CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/#review167366 --- Closing this review due to inactivity. Please see our

Re: Review Request 50540: Add systemd watchdog support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50540/#review167368 --- Closing this review due to inactivity. Please see our

Re: Review Request 51351: Update HttpDockerExecutor with v1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51351/#review167370 --- Closing this review due to inactivity. Please see our

Re: Review Request 49689: Added Appc runtime isolator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49689/#review167369 --- Closing this review due to inactivity. Please see our

Re: Review Request 51109: Added a Table abstraction and some functions to the CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51109/#review167360 --- Closing this review due to inactivity. Please see our

Re: Review Request 50851: Decode Protobuf long int form strings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50851/#review167358 --- Closing this review due to inactivity. Please see our

Re: Review Request 51113: Added the agent plugin the the Mesos CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51113/#review167361 --- Closing this review due to inactivity. Please see our

Re: Review Request 51127: Added the cluster plugin the the Mesos CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51127/#review167362 --- Closing this review due to inactivity. Please see our

Re: Review Request 51146: Added testing for the agent plugin of the CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51146/#review167365 --- Closing this review due to inactivity. Please see our

Re: Review Request 52855: Re-enabled the change user test in slave tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52855/#review167395 --- Closing this review due to inactivity. Please see our

Re: Review Request 50960: Added appc uri fetcher tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50960/#review167398 --- Closing this review due to inactivity. Please see our

Re: Review Request 52944: Updated CLI pylint configuration to disable 'fixme' warnings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52944/#review167409 --- Closing this review due to inactivity. Please see our

Re: Review Request 51352: Make docker executor unversioned.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51352/#review167375 --- Closing this review due to inactivity. Please see our

Re: Review Request 50380: Added new benchmark test for port resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50380/#review167405 --- Closing this review due to inactivity. Please see our

Re: Review Request 52809: User Namespaces Initial Implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52809/#review167400 --- Closing this review due to inactivity. Please see our

Re: Review Request 52810: Added tests to test usernamespaces.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52810/#review167401 --- Closing this review due to inactivity. Please see our

Re: Review Request 47771: Validate ACLs on creating an instance of local authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47771/#review167376 --- Closing this review due to inactivity. Please see our

Re: Review Request 51505: Replace http::get with http::request in mesos project.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51505/#review167404 --- Closing this review due to inactivity. Please see our

Re: Review Request 52943: Updated CLI pylint configuration to disable no-self-use warnings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52943/#review167408 --- Closing this review due to inactivity. Please see our

Re: Review Request 57165: Minor cleanup for quota validation code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57165/ --- (Updated March 1, 2017, 6:23 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 53074: Updated pylint to rebuild 'virtualenv' if pip-requirements.txt modified.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53074/#review167426 --- Closing this review due to inactivity. Please see our

Re: Review Request 53082: Refactored `ROOT_CGROUPS_CreateRemove` test case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53082/#review167436 --- Closing this review due to inactivity. Please see our

Re: Review Request 52941: Updated CLI pylint configuration to allow 0 public methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52941/#review167428 --- Closing this review due to inactivity. Please see our

Re: Review Request 52952: Added a 'container' plugin to the CLI with a 'list()' command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52952/#review167418 --- Closing this review due to inactivity. Please see our

Re: Review Request 51185: Removed the expired TODO about non-recursive version `cgroups::get`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51185/#review167435 --- Closing this review due to inactivity. Please see our

Re: Review Request 53267: Added log and counter for tracking subscribers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53267/#review167438 --- Closing this review due to inactivity. Please see our

Re: Review Request 52947: Updated parsing for CLI config to be more dynamic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52947/#review167430 --- Closing this review due to inactivity. Please see our

Re: Review Request 53035: Tweaked an agent log message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53035/#review167424 --- Closing this review due to inactivity. Please see our

Re: Review Request 52934: Explain read-only mode of persistent volumes in shared-resources.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52934/#review167434 --- Closing this review due to inactivity. Please see our

Re: Review Request 52939: Updated CLI pylint configuration to add 'ip' to the list of good-names.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52939/#review167427 --- Closing this review due to inactivity. Please see our

Re: Review Request 53173: Removed flakiness from SlaveTest.KillTaskGroupBetweenRunTaskParts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53173/#review167431 --- Closing this review due to inactivity. Please see our

Re: Review Request 53067: Added log message when terminating agent ID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53067/#review167425 --- Closing this review due to inactivity. Please see our

Re: Review Request 52946: Fixed some bugs in the CLI help formatting.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52946/#review167429 --- Closing this review due to inactivity. Please see our

Re: Review Request 52879: Cleaned up the way in which the executors load configuration options.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52879/#review167443 --- Closing this review due to inactivity. Please see our

Re: Review Request 53293: Show framework's role and principal in WebUI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53293/#review167440 --- Closing this review due to inactivity. Please see our

Re: Review Request 53083: Made `cgroups::create` create cgroup recursively as default behaviour.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53083/#review167437 --- Closing this review due to inactivity. Please see our

Re: Review Request 53501: Added a test to catch regressions to MESOS-4975.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53501/#review167449 --- Closing this review due to inactivity. Please see our

Re: Review Request 52668: Refactored nested container tests launcher orphans.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52668/#review167445 --- Closing this review due to inactivity. Please see our

Re: Review Request 53253: Fixed the bug when search base hierarchy in `cgroups_tests.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53253/#review167447 --- Closing this review due to inactivity. Please see our

Re: Review Request 53253: Fixed the bug when search base hierarchy in `cgroups_tests.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53253/#review167446 --- - Joris Van Remoortere On Oct. 28, 2016, 5:13 a.m., haosdent

Re: Review Request 51700: Add `FrameworkAdded` event to master event stream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51700/#review167450 --- Closing this review due to inactivity. Please see our

Re: Review Request 50490: Separated ZooKeeper PIDGroup implementation into its own cpp/hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50490/#review167455 --- Closing this review due to inactivity. Please see our

Re: Review Request 50494: Remove `base` from ZooKeeperPIDGroup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50494/#review167456 --- Closing this review due to inactivity. Please see our

Re: Review Request 50492: Switched replicated log to use PIDGroup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50492/#review167454 --- Closing this review due to inactivity. Please see our

Re: Review Request 50495: Added PIDGroup module struct.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50495/#review167457 --- Closing this review due to inactivity. Please see our

Re: Review Request 57177: Clarified naming rules in C++ style guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57177/ --- (Updated March 1, 2017, 6:34 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 51008: Added infrastructure for unit tests in the new python-based CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51008/#review167432 --- Closing this review due to inactivity. Please see our

  1   2   3   >