> On Feb. 15, 2017, 5:07 p.m., Gastón Kleiman wrote: > > src/tests/check_tests.cpp > > Lines 269 (patched) > > <https://reviews.apache.org/r/56213/diff/3/?file=1627707#file1627707line269> > > > > We should add: > > > > ``` > > ASSERT_EQ(TaskStatus::REASON_TASK_CHECK_STATUS_UPDATED, > > checkResult.reason()); > > ``` > > > > We should do something like this in all tests each time we get an > > update.
Great suggestion, thanks! - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56213/#review165724 ----------------------------------------------------------- On Feb. 28, 2017, 3:55 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56213/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2017, 3:55 p.m.) > > > Review request for mesos, Gastón Kleiman and Vinod Kone. > > > Bugs: MESOS-6906 > https://issues.apache.org/jira/browse/MESOS-6906 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/check_tests.cpp b5a5d8e80c80b480992a3c8160ee7d0e4443111c > src/tests/mesos.hpp b450a04dfbf3bbeeb6b605fb78097dca390cbdbe > > > Diff: https://reviews.apache.org/r/56213/diff/3/ > > > Testing > ------- > > See https://reviews.apache.org/r/56218/ > > > Thanks, > > Alexander Rukletsov > >
