Re: Review Request 60651: Updated bundled ruby dependencies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60651/#review179621 --- Ship it! Ship It! - haosdent huang On July 5, 2017, 11:08

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60500/ --- (Updated July 5, 2017, 3:03 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 60647: Fixed the mention of default ports in 'configuration.md'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60647/#review179613 --- Ship it! Ship It! - Benjamin Bannier On July 5, 2017, 11:15

Review Request 60647: Fixed the mention of default ports in 'configuration.md'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60647/ --- Review request for mesos, Andrei Budnik and Benjamin Bannier. Repository:

Re: Review Request 60653: Tightened namespace to fix a lookup error on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60653/#review179622 --- Ship it! Could you update the commit message to maybe include

Re: Review Request 60651: Updated bundled ruby dependencies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60651/ --- (Updated July 5, 2017, 1:34 p.m.) Review request for mesos, haosdent huang and

Review Request 60651: Updated bundled ruby dependencies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60651/ --- Review request for mesos, haosdent huang and Vinod Kone. Repository: mesos

Review Request 60652: Bundled rake as part of managed ruby dependencies of website.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60652/ --- Review request for mesos, haosdent huang and Vinod Kone. Repository: mesos

Review Request 60653: Tightened namespace to fix a lookup error on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60653/ --- Review request for mesos, Alexander Rukletsov and Benjamin Bannier.

Re: Review Request 60558: Set container DNS with `--default_container_dns` in Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60558/ --- (Updated July 5, 2017, 3:06 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 60558: Set container DNS with `--default_container_dns` in Docker executor.

> On July 4, 2017, 2:35 a.m., Avinash sridharan wrote: > > src/docker/docker.hpp > > Lines 167 (patched) > > > > > > For consistency can we use `defautlContainerDNS`? > > Qian Zhang wrote: > Originally I used

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

> On July 3, 2017, 5:22 p.m., Avinash sridharan wrote: > > docs/configuration.md > > Lines 1329 (patched) > > > > > > This is interesting. I think this example highlights a subtle > > difference between the

Review Request 60646: Modifed handling of parallel test configure flag for documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60646/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description

Re: Review Request 60558: Set container DNS with `--default_container_dns` in Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60558/ --- (Updated July 5, 2017, 3:18 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 60558: Set container DNS with `--default_container_dns` in Docker executor.

> On July 4, 2017, 2:35 a.m., Avinash sridharan wrote: > > src/docker/docker.hpp > > Lines 167 (patched) > > > > > > For consistency can we use `defautlContainerDNS`? Originally I used `defautlContainerDNS`, but

Re: Review Request 60558: Set container DNS with `--default_container_dns` in Docker executor.

> On July 3, 2017, 6:35 p.m., Avinash sridharan wrote: > > src/docker/docker.hpp > > Lines 167 (patched) > > > > > > For consistency can we use `defautlContainerDNS`? > > Qian Zhang wrote: > Originally I used

Re: Review Request 60675: Fixed compilation failure in port-mapping network isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60675/#review179755 --- Patch looks great! Reviews applied: [60674, 60675] Passed

Re: Review Request 58394: Setup new directory for python http client lib in src/python.

> On July 5, 2017, 6:02 p.m., Eric Chung wrote: > > bump FYI the Mesos Reviewbot Windows reports a bad patch due to an error in `apply-reviews.py`, I doubt there is an issue with your review request. A fix has been merged a few hours ago:

Re: Review Request 60653: Tightened namespace to fix a lookup error on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60653/ --- (Updated July 5, 2017, 3:58 p.m.) Review request for mesos, Alexander

Re: Review Request 59989: Added a test `ProtobufTest.JsonifyMap`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59989/#review179630 --- Patch looks great! Reviews applied: [60109, 59987, 59988, 59989]

Re: Review Request 60653: Tightened namespace to fix a lookup error on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60653/#review179632 --- Ship it! Ship It! - Alexander Rukletsov On July 5, 2017,

Re: Review Request 60653: Tightened namespace to fix a lookup error on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60653/ --- (Updated July 5, 2017, 2:28 p.m.) Review request for mesos, Alexander

Re: Review Request 60280: Provide full path to the custom executor.

> On June 30, 2017, 11:48 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/launch.cpp > > Lines 799 (patched) > > > > > > What if `launchInfo.working_directory()` is not set? Maybe use > > os::realpath here to

Re: Review Request 60546: Harden Mesos when building with cmake.

> On July 4, 2017, 3:06 p.m., Benjamin Bannier wrote: > > cmake/CompilationConfigure.cmake > > Lines 213-214 (patched) > > > > > > Not sure this is needed, see below. Relating to my comment below, I saw that `-pie`

Re: Review Request 60280: Provide full path to the custom executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60280/#review179650 --- src/slave/containerizer/mesos/launch.cpp Lines 799 (patched)

Re: Review Request 60280: Provide full path to the custom executor.

> On July 5, 2017, 4:48 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/launch.cpp > > Lines 799 (patched) > > > > > > This is still based on the assumption that `launchInfo` has > > `working_directory()`

Re: Review Request 60546: Harden Mesos when building with cmake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60546/ --- (Updated July 5, 2017, 4:06 p.m.) Review request for mesos, Andrew

Re: Review Request 60581: Added filtering to the '/slaves' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60581/ --- (Updated July 5, 2017, 4:28 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 60647: Fixed the mention of default ports in 'configuration.md'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60647/#review179647 --- Ship it! Ship It! - Gilbert Song On July 5, 2017, 2:15

Re: Review Request 60580: Added filtering to the '/frameworks' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60580/ --- (Updated July 5, 2017, 4:30 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 60647: Fixed the mention of default ports in 'configuration.md'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60647/#review179649 --- Ship it! Ship It! - Gastón Kleiman On July 5, 2017, 9:15

Re: Review Request 60397: Check perf version compatibility in tests with disabled coredumps.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60397/#review179642 --- Ship it! I assume this makes the workaround from

Re: Review Request 60598: Replaced abort() with _exit() in ChildHook::SUPERVISOR from subprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60598/#review179643 --- 3rdparty/libprocess/src/subprocess.cpp Lines 172-173 (original),

Re: Review Request 60620: Modify os::write to write binary files on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60620/ --- (Updated July 5, 2017, 5:43 p.m.) Review request for mesos, Andrew

Re: Review Request 58394: Setup new directory for python http client lib in src/python.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58394/#review179666 --- bump - Eric Chung On June 29, 2017, 6:22 p.m., Eric Chung

Re: Review Request 59739: Replaced use of `net::IPNetwork` by `net::IP::Network`.

> On July 5, 2017, 6:35 p.m., Benjamin Hindman wrote: > > Ship It! I'll split this into a Stout and Mesos commit for you! - Benjamin --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 60638: Adjusted allocator interfaces to allow passing new agent total.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60638/#review179659 --- include/mesos/allocator/allocator.hpp Line 219 (original),

Re: Review Request 59688: Moved `net::IPNetwork` to `net::IP:Network`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59688/#review179672 --- Ship it! Ship It! - Benjamin Hindman On June 29, 2017,

Re: Review Request 60280: Provide full path to the custom executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60280/#review179745 --- This will break the windows build. os::which is only in posix

Re: Review Request 60583: Add upgrade notes for Linux capabilities changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60583/#review179746 --- Ship it! Ship It! - Jie Yu On July 3, 2017, 1:20 a.m.,

Re: Review Request 60584: Fix bullet-point formatting.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60584/#review179747 --- Ship it! Ship It! - Jie Yu On July 3, 2017, 1:20 a.m.,

Re: Review Request 60585: Add Linux capabilities changes to the CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60585/#review179748 --- Ship it! Ship It! - Jie Yu On July 3, 2017, 1:21 a.m.,

Re: Review Request 60598: Replaced abort() with _exit() in ChildHook::SUPERVISOR from subprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60598/#review179730 --- Bad patch! Reviews applied: [60598] Failed command: python

Re: Review Request 60580: Added filtering to the '/frameworks' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60580/#review179731 --- Bad patch! Reviews applied: [60580] Failed command: python

Re: Review Request 60647: Fixed the mention of default ports in 'configuration.md'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60647/#review179732 --- Bad patch! Reviews applied: [60647] Failed command: python

Re: Review Request 58394: Setup new directory for python http client lib in src/python.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58394/#review179733 --- Bad patch! Reviews applied: [58394] Failed command: python

Re: Review Request 59921: Added agent domain to Offer message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59921/#review179737 --- Bad patch! Reviews applied: [59921, 59766, 59764, 59763, 59762,

Re: Review Request 60551: Added a test for docker container running on a v4/6 host network.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60551/#review179729 --- Fix it, then Ship it!

Re: Review Request 60551: Added a test for docker container running on a v4/6 host network.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60551/#review179739 --- Bad patch! Reviews applied: [60551, 59233, 59130, 60149, 59131,

Re: Review Request 60485: Fixed flaky PersistentVolumeEndpointsTest.ReserveAndSlaveRemoval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60485/#review179709 --- Ship it! Ship It! - Vinod Kone On June 27, 2017, 11:17

Re: Review Request 60652: Bundled rake as part of managed ruby dependencies of website.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60652/#review179711 --- Ship it! Ship It! - Vinod Kone On July 5, 2017, 11:08 a.m.,

Re: Review Request 60280: Provide full path to the custom executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60280/#review179735 --- Bad patch! Reviews applied: [60280] Failed command: python

Re: Review Request 60546: Harden Mesos when building with cmake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60546/#review179738 --- Bad patch! Reviews applied: [60546] Failed command: python

Review Request 60675: Fixed compilation failure in port-mapping network isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60675/ --- Review request for mesos and Joseph Wu. Bugs: MESOS-7762

Review Request 60674: Fixed windows failure due to new `net::IP::Network` class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60674/ --- Review request for mesos and Joseph Wu. Bugs: MESOS-7762

Re: Review Request 60674: Fixed windows failure due to new `net::IP::Network` class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60674/ --- (Updated July 6, 2017, 4:12 a.m.) Review request for mesos and Joseph Wu.

Re: Review Request 60581: Added filtering to the '/slaves' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60581/#review179726 --- Bad patch! Reviews applied: [60581, 60107] Failed command:

Re: Review Request 59131: Added an IPv6 address storage to UPID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59131/#review179727 --- 3rdparty/libprocess/include/process/pid.hpp Lines 97 (patched)

Re: Review Request 60346: Improved the documentation of 'TASK_LOST'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60346/#review179725 --- Ship it! include/mesos/mesos.proto Lines 1940 (patched)

Re: Review Request 60675: Fixed compilation failure in port-mapping network isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60675/#review179753 --- Patch looks great! Reviews applied: [60674, 60675] Passed

Re: Review Request 60675: Fixed compilation failure in port-mapping network isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60675/ --- (Updated July 6, 2017, 5:03 a.m.) Review request for mesos and Joseph Wu.

Re: Review Request 60280: Provide full path to the custom executor.

> On July 5, 2017, 4:48 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/launch.cpp > > Lines 799 (patched) > > > > > > This is still based on the assumption that `launchInfo` has > > `working_directory()`

Re: Review Request 60280: Provide full path to the custom executor.

> On June 30, 2017, 11:48 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/launch.cpp > > Lines 799 (patched) > > > > > > What if `launchInfo.working_directory()` is not set? Maybe use > > os::realpath here to

Re: Review Request 59739: Replaced use of `net::IPNetwork` by `net::IP::Network`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59739/#review179674 --- Ship it! Ship It! - Benjamin Hindman On June 29, 2017,

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

> On July 3, 2017, 9:51 a.m., Alexander Rojas wrote: > > src/common/http.hpp > > Lines 175-229 (patched) > > > > > > What is the point of having multiple different > > `AuthorizationAcceptors`? Each have a method

Re: Review Request 60136: Refactored inet::Address to base of inet4::Address and inet6::Address.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60136/#review179686 --- Ship it! Ship It! - Benjamin Hindman On June 29, 2017,

Re: Review Request 60148: Mesos updates for new inet4::Address.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60148/#review179687 --- Ship it! Ship It! - Benjamin Hindman On June 29, 2017,

Re: Review Request 59233: Updated v6 address for containers running on host network.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59233/#review179691 --- Fix it, then Ship it! src/slave/slave.cpp Lines 4543

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

> On July 5, 2017, 8:02 p.m., Alexander Rojas wrote: > > src/common/http.cpp > > Lines 1199-1200 (patched) > > > > > > make use of the new constructors. Yep, the new constructor patch will be merged after these

Re: Review Request 60280: Provide full path to the custom executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60280/ --- (Updated July 5, 2017, 9:03 p.m.) Review request for mesos, Jie Yu, James

Re: Review Request 59721: Refactored net::IP and added net::IPv4 and net::IPv6.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59721/#review179684 --- Ship it! Ship It! - Benjamin Hindman On June 29, 2017,

Re: Review Request 59130: Added storage for IPv6 in a `libprocess` process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59130/#review179690 --- Fix it, then Ship it! 3rdparty/libprocess/src/process.cpp

Re: Review Request 59127: Added IPv6 flags for Mesos agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59127/#review179692 --- src/slave/flags.hpp Line 173 (original), 173 (patched)

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60107/#review179693 --- src/common/http.cpp Lines 1199-1200 (patched)

Re: Review Request 60149: Added support for `net::IPv4` and `net::IPv6` in `FlagsBase`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60149/#review179688 --- Ship it! Ship It! - Benjamin Hindman On June 29, 2017,

Re: Review Request 60652: Bundled rake as part of managed ruby dependencies of website.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60652/ --- (Updated July 5, 2017, 10:09 p.m.) Review request for mesos, haosdent huang

Re: Review Request 60651: Updated bundled ruby dependencies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60651/#review179712 --- Ship it! Ship It! - Vinod Kone On July 5, 2017, 11:34 a.m.,

Re: Review Request 59766: Changed allocator to offer remote resources to region-aware frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59766/ --- (Updated July 5, 2017, 10:32 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 59760: Added REGION_AWARE framework capability.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59760/ --- (Updated July 5, 2017, 10:31 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 59763: Caused master to abort when joining a mixed-region cluster.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59763/ --- (Updated July 5, 2017, 10:32 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 59759: Added protobuf definitions for fault domains.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59759/ --- (Updated July 5, 2017, 10:31 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 59761: Added master and agent flags to specify domain.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59761/ --- (Updated July 5, 2017, 10:31 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 59762: Added domain to MasterInfo and SlaveInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59762/ --- (Updated July 5, 2017, 10:32 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 59921: Added agent domain to Offer message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59921/ --- (Updated July 5, 2017, 10:32 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 59764: Ignore registration attempts by agents with misconfigured domain.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59764/ --- (Updated July 5, 2017, 10:32 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 59759: Added protobuf definitions for fault domains.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59759/#review179715 --- Ship it! Ship It! - Vinod Kone On July 5, 2017, 10:31 p.m.,

Re: Review Request 59760: Added REGION_AWARE framework capability.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59760/#review179716 --- Ship it! Ship It! - Vinod Kone On July 5, 2017, 10:31 p.m.,

Re: Review Request 59761: Added master and agent flags to specify domain.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59761/#review179718 --- Ship it! Ship It! - Vinod Kone On July 5, 2017, 10:31 p.m.,

Re: Review Request 60511: Added MockMetadataManager and test concurrent prune and pull.

> On June 28, 2017, 10:37 p.m., Mesos Reviewbot Windows wrote: > > Bad patch! > > > > Reviews applied: [60511, 56722, 60471, 56721, 59705, 55727, 59687, 55335, > > 55334] > > > > Failed command: python support/apply-reviews.py -n -r 55334 > > > > Error: > > Traceback (most recent call last):

Re: Review Request 60546: Harden Mesos when building with cmake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60546/#review179721 --- Ship it! Ship It! - Andrew Schwartzmeyer On July 5, 2017,

Re: Review Request 60646: Modifed handling of parallel test configure flag for documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60646/#review179722 --- Bad patch! Reviews applied: [60646, 6] Failed command:

Re: Review Request 59762: Added domain to MasterInfo and SlaveInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59762/#review179719 --- Fix it, then Ship it! include/mesos/mesos.proto Lines 869

Re: Review Request 59989: Added a test `ProtobufTest.JsonifyMap`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59989/#review179724 --- Bad patch! Reviews applied: [59989, 59988, 59987, 60109] Failed