Re: Review Request 61495: Add documentation for possible task reasons.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61495/ --- (Updated Aug. 10, 2017, 2:01 p.m.) Review request for mesos, Alexander

Review Request 61558: Move duplicate comment closer to implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61558/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Re: Review Request 61530: Enabled retries for `killTasks` in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61530/ --- (Updated Aug. 10, 2017, 4:14 p.m.) Review request for mesos and Alexander

Re: Review Request 61435: Added logging in docker executor on `docker stop` failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61435/ --- (Updated Aug. 10, 2017, 4:12 p.m.) Review request for mesos and Alexander

Re: Review Request 61511: Improved the readability of some assertions/expectations.

> On Aug. 9, 2017, 5:21 p.m., Benjamin Bannier wrote: > > src/tests/api_tests.cpp > > Line 1 (original), 1 (patched) > > > > > > Searching with > > > > $ git grep -E

Review Request 61546: Created staging dir only when needed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61546/ --- Review request for mesos and Gilbert Song. Bugs: MESOS-6950

Re: Review Request 61495: Removed table from markdown and added cross-links.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61495/ --- (Updated Aug. 10, 2017, 8:55 a.m.) Review request for mesos, Alexander

Re: Review Request 61137: Cleaned up style in example frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61137/#review182582 --- Fix it, then Ship it! Thanks for the cleanup! I'll fix the

Re: Review Request 61110: Added name flag to balloon and disk full frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61110/#review182592 --- Ship it! - Alexander Rukletsov On Aug. 1, 2017, 10:20 a.m.,

Review Request 61565: Stout: Improved the readability of some assertions/expectations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61565/ --- Review request for mesos. Repository: mesos Description --- Prefer

Re: Review Request 60235: Linted support/test-upgrade.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60235/#review182608 --- Ship it! Only some slight changes in error messages if/when

Review Request 61564: Libprocess: Improved the readability of some assertions/expectations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61564/ --- Review request for mesos, Benjamin Bannier, Jie Yu, and Vinod Kone.

Review Request 61579: Ensured JAVA HTTP adapter propagates a subscription error.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61579/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-7872

Re: Review Request 61580: Extracted JNI code into a protected function for clarity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61580/ --- (Updated Aug. 10, 2017, 8:41 p.m.) Review request for mesos, Anand Mazumdar

Review Request 61580: Extracted JNI code into a protected function for clarity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61580/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-7872

Re: Review Request 61530: Enabled retries for `killTasks` in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61530/#review182624 --- Ship it! Great job, great testing. Thanks a lot! - Alexander

Review Request 61578: Updated the CPP linter to ignore patch files for gRPC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61578/ --- Review request for mesos and Jie Yu. Bugs: mesos-7749

Review Request 61576: Added a patch for building/installing the bundled gRPC library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61576/ --- Review request for mesos and Jie Yu. Bugs: MESOS-7749

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/#review182605 --- Some of the comments below were made before I started to feel

Re: Review Request 61262: Added 'heartbeat' event for the operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61262/#review182627 --- src/master/master.hpp Lines 1826 (patched)

Re: Review Request 61511: Improved the readability of some assertions/expectations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61511/ --- (Updated Aug. 10, 2017, 9:10 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 61511: Improved the readability of some assertions/expectations.

> On Aug. 9, 2017, 3:21 p.m., Benjamin Bannier wrote: > > src/tests/api_tests.cpp > > Line 1 (original), 1 (patched) > > > > > > Searching with > > > > $ git grep -E

Re: Review Request 61408: Added test cases for V1 teardown Call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61408/#review182630 --- src/tests/api_tests.cpp Lines 2739-2758 (patched)

Review Request 61584: Fixed a typo in a test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61584/ --- Review request for mesos, Alexander Rukletsov and Vinod Kone. Repository:

Re: Review Request 61578: Updated the CPP linter to ignore patch files for gRPC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61578/ --- (Updated Aug. 10, 2017, 9:54 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 61531: Fixed the device number proto 'major' and 'minor' to avoid MACROs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61531/#review182632 --- Ship it! Ship It! - James Peach On Aug. 9, 2017, 10:24

Re: Review Request 61433: Refactored OpenSSL library checks in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61433/ --- (Updated Aug. 10, 2017, 9:58 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 61260: Added agent garbage collection metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61260/ --- (Updated Aug. 10, 2017, 10 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 61578: Updated the CPP linter to ignore patch files for gRPC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61578/#review182636 --- Ship it! Ship It! - Jie Yu On Aug. 10, 2017, 9:54 p.m.,

Re: Review Request 61576: Added a patch for building/installing the bundled gRPC library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61576/#review182637 --- Ship it! Ship It! - Jie Yu On Aug. 10, 2017, 8:52 p.m.,

Re: Review Request 61408: Added test cases for V1 teardown Call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61408/ --- (Updated Aug. 10, 2017, 10:47 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 61433: Refactored OpenSSL library checks in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61433/#review182638 --- Ship it! Ship It! - Jie Yu On Aug. 10, 2017, 9:58 p.m.,

Re: Review Request 61517: Refactored OpenSSL library checks in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61517/#review182639 --- Ship it! Ship It! - Jie Yu On Aug. 9, 2017, 11:48 p.m.,

Re: Review Request 61222: Added V1 teardown Call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61222/#review182640 --- src/master/http.cpp Lines 3766-3777 (original), 3776-3785

Re: Review Request 60088: CLI: Added 'masters' key as an acceptable key in config.toml.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60088/ --- (Updated Aug. 10, 2017, 11:19 p.m.) Review request for mesos and Kevin Klues.

Review Request 61588: Added a `--skip-style-check` option when applying reviews.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61588/ --- Review request for mesos, Benjamin Bannier, Jie Yu, and Kevin Klues. Bugs:

Re: Review Request 59146: Added a 'UNKNOWN' field to the Update.State enumeration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59146/#review182645 --- Ship it! Ship It! - Alexander Rukletsov On May 10, 2017,

Re: Review Request 61434: Updated health-checks.md to include description of generalized checks.

> On Aug. 4, 2017, 7:18 p.m., Vinod Kone wrote: > > docs/health-checks.md > > Lines 209 (patched) > > > > > > Is it 127.0.0.1 even in the CNI network case? cc @avinash Yes, however, there is no resolution in this

Re: Review Request 61434: Updated health-checks.md to include description of generalized checks.

> On Aug. 9, 2017, 12:47 a.m., Gastón Kleiman wrote: > > docs/health-checks.md > > Lines 136 (patched) > > > > > > Actually... only one status update is sent after a success, but > > failures are NOT deduplicated,

Re: Review Request 61434: Updated health-checks.md to include description of generalized checks.

> On Aug. 9, 2017, 5:30 p.m., Avinash sridharan wrote: > > docs/health-checks.md > > Line 29 (original), 29 (patched) > > > > > > s/defines/which defines? It was intended as a simple enumeration. > On Aug. 9,

Re: Review Request 61434: Updated health-checks.md to include description of generalized checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61434/ --- (Updated Aug. 11, 2017, 12:12 a.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 61111: Extracted strings into constants in example frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6/#review182578 --- Fix it, then Ship it! I will fix outstanding issues and commit

Review Request 61204: CLI: Added 'mesos task list' command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61204/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-7840

Re: Review Request 61189: Added authorization for V1 events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61189/#review181716 --- src/master/master.hpp Lines 1835 (patched)

Re: Review Request 61511: Improved the readability of some assertions/expectations.

> On Aug. 9, 2017, 5:21 p.m., Benjamin Bannier wrote: > > Thanks for the cleanup Gaston! > > > > Until looking at your patch I didn't realize how widespread the mistake of > > possibly using junk elements from possibly empty containers was, e.g., > > > > EXPECT_NE(0u, offers.size()); //

Re: Review Request 61495: Add documentation for possible task reasons.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61495/ --- (Updated Aug. 10, 2017, 10:43 a.m.) Review request for mesos, Alexander

Re: Review Request 61530: Enabled retries for `killTasks` in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61530/#review182573 --- src/docker/executor.cpp Lines 31 (patched)

Re: Review Request 61530: Enabled retries for `killTasks` in docker executor.

> On Aug. 10, 2017, 12:07 p.m., Alexander Rukletsov wrote: > > src/docker/executor.cpp > > Lines 410-415 (original), 416-421 (patched) > > > > > > Let's add a comment explaining why are we doing retry / unblock on

Re: Review Request 61435: Added logging in docker executor on `docker stop` failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61435/#review182575 --- Fix it, then Ship it! src/docker/executor.cpp Lines 415

Re: Review Request 60088: CLI: Added 'master' key as an acceptable key in config.toml.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60088/#review182611 --- src/python/cli_new/README.md Lines 81 (patched)

Review Request 61570: Added the `kill()` function to the containerizer interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61570/ --- Review request for mesos, Jie Yu and Vinod Kone. Bugs: MESOS-7879

Re: Review Request 61584: Fixed a typo in a test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61584/#review182653 --- Ship it! Ship It! - Alexander Rukletsov On Aug. 10, 2017,

Review Request 61575: Added a test for verifying signal escalation on the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61575/ --- Review request for mesos, Jie Yu and Vinod Kone. Bugs: MESOS-7879

Review Request 61574: Added `kill()` support to the test containerizer interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61574/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-7879

Review Request 61573: Made the default executor support signal escalation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61573/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-7879

Review Request 61571: Added `kill()` call to the composing containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61571/ --- Review request for mesos, Jie Yu and Vinod Kone. Bugs: MESOS-7879

Review Request 61569: Added the field `signal` to the `KillNestedContainer` call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61569/ --- Review request for mesos, Jie Yu and Vinod Kone. Bugs: MESOS-7879

Review Request 61572: Made `killNestedContainer()` use `kill()` on the containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61572/ --- Review request for mesos, Jie Yu and Vinod Kone. Bugs: MESOS-7879

Review Request 61583: Bundled gRPC v1.4.2 into 3rdparty libraries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61583/ --- Review request for mesos and Jie Yu. Bugs: MESOS-7808

Re: Review Request 61495: Add documentation for possible task reasons.

> On Aug. 10, 2017, 1:56 a.m., Till Toenshoff wrote: > > docs/task-reasons.md > > Lines 49 (patched) > > > > > > Can we avoid HTML code here? We typically used HTML for getting tables > > properly formatted as the