Re: Review Request 64354: Added tests for UriVolumeProfile module.

2017-12-08 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64354/#review193229 --- FAIL: Some Mesos libprocess-tests failed. Reviews applied:

Review Request 64448: Added a missing include.

2017-12-08 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64448/ --- Review request for mesos and Jan Schlicht. Bugs: MESOS-8270

Re: Review Request 64379: Improved logs displayed after a slave failed recovery.

2017-12-08 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64379/ --- (Updated Dec. 8, 2017, 1:23 p.m.) Review request for mesos, Alexander

Re: Review Request 64381: Mesos: Used a namespace for UUID.

2017-12-08 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64381/ --- (Updated Dec. 8, 2017, 2:43 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63253: Fixed DefaultExecutorTest for proper URI handling on Windows.

2017-12-08 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63253/#review193244 --- FAIL: Some Mesos libprocess-tests failed. Reviews applied:

Re: Review Request 64432: Windows: Enabled remaining `FlagsTests`.

2017-12-08 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64432/#review193251 --- FAIL: Some Mesos libprocess-tests failed. Reviews applied:

Re: Review Request 64430: Only passed agent's resource version in top-level 'UpdateSlaveMessage'.

2017-12-08 Thread Benjamin Bannier
> On Dec. 8, 2017, 6:15 a.m., Jie Yu wrote: > > src/master/master.cpp > > Line 7193 (original), 7193 (patched) > > > > > > Do we still need this? I removed this as part of https://reviews.apache.org/r/64424. >

Re: Review Request 64422: Added explicit resource provider information to 'UpdateSlaveMessage'.

2017-12-08 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64422/ --- (Updated Dec. 8, 2017, 12:32 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 64430: Only passed agent's resource version in top-level 'UpdateSlaveMessage'.

2017-12-08 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64430/ --- (Updated Dec. 8, 2017, 12:32 p.m.) Review request for mesos, Jie Yu and Jan

Review Request 64445: Renamed resource categories in 'UpdateSlaveMessage'.

2017-12-08 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64445/ --- Review request for mesos, Jie Yu and Jan Schlicht. Bugs: MESOS-8312

Re: Review Request 64424: Removed 'total' from 'UpdateSlaveMessage'.

2017-12-08 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64424/ --- (Updated Dec. 8, 2017, 12:32 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 64423: Explicitly passed resource-provider information in 'UpdateSlaveMessage'.

2017-12-08 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64423/ --- (Updated Dec. 8, 2017, 12:32 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 64430: Only passed agent's resource version in top-level 'UpdateSlaveMessage'.

2017-12-08 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64430/#review193245 --- FAIL: Some Mesos libprocess-tests failed. Reviews applied:

Re: Review Request 64448: Added a missing include.

2017-12-08 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64448/#review193246 --- Ship it! Ship It! - Jan Schlicht On Dec. 8, 2017, 1:52

Re: Review Request 64168: Introduced a 'UUID' type.

2017-12-08 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64168/ --- (Updated Dec. 8, 2017, 2:45 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 64299: Passed versions when launching tasks.

2017-12-08 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64299/ --- (Updated Dec. 8, 2017, 11:22 a.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 64298: Added ResourceVersion to RunTask and RunTaskGroup messages.

2017-12-08 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64298/ --- (Updated Dec. 8, 2017, 11:21 a.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 64434: Windows: Fixed `os::stat::size()`.

2017-12-08 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64434/#review193233 --- FAIL: Some Mesos libprocess-tests failed. Reviews applied:

Re: Review Request 64151: Added a V1 API call to list resource providers.

2017-12-08 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64151/#review193238 --- Ship it! Ship It! - Benjamin Bannier On Dec. 8, 2017, 11:24

Re: Review Request 64430: Only passed agent's resource version in top-level 'UpdateSlaveMessage'.

2017-12-08 Thread Benjamin Bannier
> On Dec. 8, 2017, 6:15 a.m., Jie Yu wrote: > > Let's also follow up with the change to remove `ResourcesCategory` I posted https://reviews.apache.org/r/64445/ to address this in isolation and on top of the changes here. - Benjamin

Re: Review Request 64151: Added a V1 API call to list resource providers.

2017-12-08 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64151/ --- (Updated Dec. 8, 2017, 11:24 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 64439: Added `LocalResourceProviderDaemon` methods to modify configs.

2017-12-08 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64439/#review193239 --- FAIL: Some Mesos libprocess-tests failed. Reviews applied:

Re: Review Request 64380: Stout: Used a namespace for UUID.

2017-12-08 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64380/ --- (Updated Dec. 8, 2017, 4:12 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63951: Added noexcept specifier to Option.

2017-12-08 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63951/#review193255 --- Fix it, then Ship it! 3rdparty/stout/include/stout/option.hpp

Re: Review Request 64381: Mesos: Used a namespace for UUID.

2017-12-08 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64381/ --- (Updated Dec. 8, 2017, 4:14 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 64168: Introduced a 'UUID' type.

2017-12-08 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64168/ --- (Updated Dec. 8, 2017, 4:15 p.m.) Review request for mesos, Benjamin Bannier

Review Request 64450: Update docs to mention new '--reconfiguration_policy' flag.

2017-12-08 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64450/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 64436: Toggled the authenticate_http_readwrite flag in MesosTest.

2017-12-08 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64436/#review193253 --- FAIL: Some Mesos libprocess-tests failed. Reviews applied:

Re: Review Request 64454: Fixed a typo in a gpu test.

2017-12-08 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64454/#review193257 --- src/tests/containerizer/nvidia_gpu_isolator_tests.cpp Line 268

Re: Review Request 64455: Fixed a typo in a nested containerizer test.

2017-12-08 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64455/#review193258 --- Ship it! Ship It! - Benno Evers On Dec. 8, 2017, 4:49 p.m.,

Re: Review Request 64454: Fixed a typo in a gpu test.

2017-12-08 Thread Benno Evers
> On Dec. 8, 2017, 4:56 p.m., Benno Evers wrote: > > src/tests/containerizer/nvidia_gpu_isolator_tests.cpp > > Line 268 (original), 268 (patched) > > > > > > Since we're fixing this, actually only one of these

Re: Review Request 64456: Increased wait time for specific task updates.

2017-12-08 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64456/#review193263 --- Ship it! Looks good, but please amend the commit message to

Re: Review Request 64454: Fixed a typo in a gpu test.

2017-12-08 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64454/#review193262 --- Ship it! Ship It! - Benno Evers On Dec. 8, 2017, 4:48 p.m.,

Re: Review Request 63951: Added noexcept specifier to Option.

2017-12-08 Thread Dmitry Zhuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63951/ --- (Updated Dec. 8, 2017, 4:51 p.m.) Review request for mesos, Benjamin Mahler

Review Request 64456: Increased wait time for specific task updates.

2017-12-08 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64456/ --- Review request for mesos and Benno Evers. Bugs: MESOS-8316

Re: Review Request 64456: Increased wait time for specific task updates.

2017-12-08 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64456/ --- (Updated Dec. 8, 2017, 5:40 p.m.) Review request for mesos and Benno Evers.

Re: Review Request 64379: Improved logs displayed after a slave failed recovery.

2017-12-08 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64379/#review193266 --- Please check how the output actually looks in console and paste

Re: Review Request 64445: Renamed resource categories in 'UpdateSlaveMessage'.

2017-12-08 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64445/#review193259 --- FAIL: Some Mesos libprocess-tests failed. Reviews applied:

Re: Review Request 63953: Added logging based on container class.

2017-12-08 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63953/#review193267 --- src/slave/containerizer/mesos/containerizer.hpp Line 356

Review Request 64454: Fixed a typo in a gpu test.

2017-12-08 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64454/ --- Review request for mesos and Benno Evers. Repository: mesos Description

Review Request 64455: Fixed a typo in a nested containerizer test.

2017-12-08 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64455/ --- Review request for mesos and Benno Evers. Repository: mesos Description

Review Request 64458: Fixed a comment in the master.

2017-12-08 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64458/ --- Review request for mesos and Benjamin Bannier. Repository: mesos Description

Re: Review Request 64098: Send status updates when agent re-registers.

2017-12-08 Thread Megha Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64098/ --- (Updated Dec. 8, 2017, 6:42 p.m.) Review request for mesos, Ilya Pronin, James

Re: Review Request 64458: Fixed a comment in the master.

2017-12-08 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64458/#review193271 --- Ship it! Ship It! - Benjamin Bannier On Dec. 8, 2017, 7:34

Re: Review Request 64457: Instructed frameworks to avoid setting the offer operation 'id' field.

2017-12-08 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64457/#review193273 --- Ship it! Ship It! - Jie Yu On Dec. 8, 2017, 6:53 p.m., Greg

Re: Review Request 64457: Instructed frameworks to avoid setting the offer operation 'id' field.

2017-12-08 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64457/#review193272 --- include/mesos/mesos.proto Line 1976 (original), 1980 (patched)

Re: Review Request 64457: Instructed frameworks to avoid setting the offer operation 'id' field.

2017-12-08 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64457/ --- (Updated Dec. 8, 2017, 6:53 p.m.) Review request for mesos, Jie Yu and Vinod

Review Request 64461: Windows: Added legacy support for admin-only symlinks.

2017-12-08 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64461/ --- Review request for mesos, Akash Gupta, Alexander Rukletsov, Greg Mann, and

Review Request 64462: Edited some comments in the master for style and grammar.

2017-12-08 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64462/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Repository: mesos

Re: Review Request 64304: Enforced quota limit in the presence of unallocated reservations.

2017-12-08 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64304/ --- (Updated Dec. 8, 2017, 1:51 p.m.) Review request for mesos, Alexander

Review Request 64463: Added the OFFER_OPERATION_DROPPED state.

2017-12-08 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64463/ --- Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Jie Yu. Bugs:

Re: Review Request 60622: Added new stout functions for path and URI conversions.

2017-12-08 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60622/#review193292 --- Ship it! Ship It! - Andrew Schwartzmeyer On Dec. 7, 2017,

Re: Review Request 60623: Converted "file://" URI handling to use new uri function.

2017-12-08 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60623/#review193293 --- Ship it! Ship It! - Andrew Schwartzmeyer On Dec. 7, 2017,

Re: Review Request 60626: Eliminated os::shell calls from HDFS for Windows compatibility.

2017-12-08 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60626/#review193295 --- Ship it! Ship It! - Andrew Schwartzmeyer On Dec. 7, 2017,

Re: Review Request 60624: Enabled HDFS compilation and associated tests.

2017-12-08 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60624/#review193294 --- Ship it! Ship It! - Andrew Schwartzmeyer On Dec. 7, 2017,

Re: Review Request 64431: Updated Windows documentation.

2017-12-08 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64431/#review193301 --- Fix it, then Ship it! docs/windows.md Lines 73 (patched)

Re: Review Request 64470: Clarified comments in the allocator.

2017-12-08 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64470/#review193285 --- Ship it! src/master/allocator/mesos/hierarchical.hpp Line 513

Re: Review Request 64303: Tracked resource reservations in the allocator.

2017-12-08 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64303/#review192962 --- Looks good! Just some minor suggestions below

Re: Review Request 64456: Increased wait time for specific task updates.

2017-12-08 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64456/#review193299 --- FAIL: Some Mesos libprocess-tests failed. Failed command:

Re: Review Request 64432: Windows: Enabled remaining `FlagsTests`.

2017-12-08 Thread Akash Gupta
> On Dec. 8, 2017, 2:16 p.m., Mesos Reviewbot Windows wrote: > > FAIL: Some Mesos libprocess-tests failed. > > > > Reviews applied: `['64432']` > > > > Failed command: > > `C:\DCOS\mesos\3rdparty\libprocess\src\tests\Debug\libprocess-tests.exe` > > > > All the build artifacts available at:

Re: Review Request 64432: Windows: Enabled remaining `FlagsTests`.

2017-12-08 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64432/#review193303 --- Ship it! Ship It! - Akash Gupta On Dec. 8, 2017, 12:23

Re: Review Request 64461: Windows: Added legacy support for admin-only symlinks.

2017-12-08 Thread Andrew Schwartzmeyer
> On Dec. 8, 2017, 5:47 p.m., Akash Gupta wrote: > > 3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp > > Lines 354 (patched) > > > > > > Does this flag exist on older versions of Windows? You might

Re: Review Request 64432: Windows: Enabled remaining `FlagsTests`.

2017-12-08 Thread Andrew Schwartzmeyer
> On Dec. 8, 2017, 6:16 a.m., Mesos Reviewbot Windows wrote: > > FAIL: Some Mesos libprocess-tests failed. > > > > Reviews applied: `['64432']` > > > > Failed command: > > `C:\DCOS\mesos\3rdparty\libprocess\src\tests\Debug\libprocess-tests.exe` > > > > All the build artifacts available at:

Re: Review Request 64439: Added `LocalResourceProviderDaemon` methods to modify configs.

2017-12-08 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64439/#review193318 --- src/resource_provider/daemon.cpp Lines 192 (patched)

Re: Review Request 64466: Added a test to check shared resources accounting in quota enforcement.

2017-12-08 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64466/#review193286 --- Can you add Yan Xu and Anindya Sinha as reviewers? - Benjamin

Re: Review Request 60628: Enabled fetcher_tests.cpp unit test module on Windows platform.

2017-12-08 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60628/#review193296 --- Ship it! Ship It! - Andrew Schwartzmeyer On Dec. 7, 2017,

Re: Review Request 64464: Made master reconcile known offer operations with agent.

2017-12-08 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64464/#review193306 --- Ship it! Ship It! - Gaston Kleiman On Dec. 8, 2017, 3:46

Re: Review Request 64440: Added `MODIFY_RESOURCE_PROVIDER_CONFIG` authorization.

2017-12-08 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64440/#review193311 --- Ship it! Ship It! - Jie Yu On Dec. 8, 2017, 3:59 a.m.,

Re: Review Request 64437: Added missing filesystem isolation for SLRP tests.

2017-12-08 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64437/#review193308 --- Ship it! Ship It! - Jie Yu On Dec. 8, 2017, 5:54 a.m.,

Re: Review Request 64441: Removed a CHECK that should not be there in SLRP.

2017-12-08 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64441/#review193307 --- Ship it! Ship It! - Jie Yu On Dec. 8, 2017, 4:56 a.m.,

Re: Review Request 64353: Added example VolumeProfile module.

2017-12-08 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64353/ --- (Updated Dec. 8, 2017, 6:17 p.m.) Review request for mesos, Chun-Hung Hsiao

Review Request 64464: Made master reconcile known offer operations with agent.

2017-12-08 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64464/ --- Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Jie Yu. Bugs:

Review Request 64474: Changed `framework_id` to optional for offer oporations in RP API.

2017-12-08 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64474/ --- Review request for mesos, Benjamin Bannier, Greg Mann, Jie Yu, and Jan Schlicht.

Review Request 64475: Initialized offer operation status update manager in SLRP.

2017-12-08 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64475/ --- Review request for mesos, Greg Mann and Jie Yu. Repository: mesos

Re: Review Request 64467: Rewrote the quota headroom enforcement logic in the allocator.

2017-12-08 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64467/ --- (Updated Dec. 8, 2017, 4:26 p.m.) Review request for mesos, Benjamin Mahler

Review Request 64473: Fixed naming of a variable in `status_update_manager_process.hpp`.

2017-12-08 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64473/ --- Review request for mesos and Greg Mann. Repository: mesos Description

Re: Review Request 60620: Modifed os::write to write binary files on Windows.

2017-12-08 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60620/#review193289 --- Ship it! Ship It! - Andrew Schwartzmeyer On Dec. 7, 2017,

Re: Review Request 60620: Modifed os::write to write binary files on Windows.

2017-12-08 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60620/#review193290 --- Ship it! Ship It! - Andrew Schwartzmeyer On Dec. 7, 2017,

Re: Review Request 60621: Added new stout capability: os::copyfile(source, dest).

2017-12-08 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60621/#review193291 --- Ship it! Ship It! - Andrew Schwartzmeyer On Dec. 7, 2017,

Review Request 64472: Improved the logging in `StatusUpdateManagerProcess`.

2017-12-08 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64472/ --- Review request for mesos and Greg Mann. Repository: mesos Description

Re: Review Request 64461: Windows: Added legacy support for admin-only symlinks.

2017-12-08 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64461/#review193302 --- Also, we need to update the tests or fix the library functions

Re: Review Request 64463: Added the OFFER_OPERATION_DROPPED state.

2017-12-08 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64463/#review193305 --- Ship it! Ship It! - Gaston Kleiman On Dec. 8, 2017, 3:40

Re: Review Request 64468: SLRP reconciliation only preserves missing resources that are converted.

2017-12-08 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64468/#review193310 --- Ship it! Ship It! - Jie Yu On Dec. 8, 2017, 9:59 p.m.,

Re: Review Request 64304: Enforced quota limit in the presence of unallocated reservations.

2017-12-08 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64304/#review193288 --- Great to see this getting fixed! First pass over just the

Re: Review Request 64438: Implemented API for modifying resource provider configs.

2017-12-08 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64438/#review193314 --- Ship it! Ship It! - Jie Yu On Dec. 8, 2017, 2:58 a.m.,

Review Request 64470: Clarified comments in the allocator.

2017-12-08 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64470/ --- Review request for mesos, Benjamin Mahler and Michael Park. Repository: mesos

Review Request 64477: Refactored agent to keep track of local resource providers.

2017-12-08 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64477/ --- Review request for mesos, Benjamin Bannier, Greg Mann, and Jan Schlicht.

Review Request 64465: Added a test for non-quota role reservation allocation.

2017-12-08 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64465/ --- Review request for mesos, Benjamin Mahler and Michael Park. Repository: mesos

Re: Review Request 64465: Added a test for non-quota role reservation allocation.

2017-12-08 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64465/ --- (Updated Dec. 8, 2017, 1:54 p.m.) Review request for mesos, Benjamin Mahler

Review Request 64468: SLRP reconciliation only preserves missing resources that are converted.

2017-12-08 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64468/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 63901: Added operator API to update and remove resource provider configs.

2017-12-08 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63901/ --- (Updated Dec. 8, 2017, 10 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 64439: Added `LocalResourceProviderDaemon` methods to modify configs.

2017-12-08 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64439/ --- (Updated Dec. 8, 2017, 10 p.m.) Review request for mesos, James DeFelice, Jie

Review Request 64466: Added a test to check shared resources accounting in quota enforcement.

2017-12-08 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64466/ --- Review request for mesos. Repository: mesos Description --- This test

Review Request 64469: Added unit tests for resource provider config modification API.

2017-12-08 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64469/ --- Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu. Repository:

Re: Review Request 64168: Introduced a 'UUID' type.

2017-12-08 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64168/#review193282 --- FAIL: Some Mesos libprocess-tests failed. Reviews applied:

Review Request 64467: Rewrote the quota headroom enforcement logic in the allocator.

2017-12-08 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64467/ --- Review request for mesos, Benjamin Mahler and Michael Park. Bugs: MESOS-8293

Re: Review Request 64466: Added a test to check shared resources accounting in quota enforcement.

2017-12-08 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64466/ --- (Updated Dec. 8, 2017, 2:15 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 64465: Added a test for non-quota role reservation allocation.

2017-12-08 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64465/ --- (Updated Dec. 8, 2017, 2:16 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 64379: Improved logs displayed after a slave failed recovery.

2017-12-08 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64379/#review193278 --- FAIL: Some Mesos libprocess-tests failed. Reviews applied: