Re: Review Request 56722: Added a new operator API for `PRUNE_IMAGES`.

2017-12-26 Thread Gilbert Song
> On Dec. 22, 2017, 7:34 p.m., Gilbert Song wrote: > > src/slave/http.cpp > > Lines 2452 (patched) > > > > > > As we discussed offline, we should follow the semantic that if there > > are excluded images from the

Re: Review Request 56722: Added a new operator API for `PRUNE_IMAGES`.

2017-12-26 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56722/#review194516 --- src/slave/http.cpp Lines 2452 (patched)

Re: Review Request 64812: Added `excluded_images` parameter to `PRUNE_IMAGES` agent API.

2017-12-26 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64812/#review194515 --- src/slave/http.cpp Line 2450 (original), 2450-2459 (patched)

Re: Review Request 64812: Added `excluded_images` parameter to `PRUNE_IMAGES` agent API.

2017-12-26 Thread Zhitao Li
> On Dec. 26, 2017, 4:06 p.m., Gilbert Song wrote: > > src/slave/http.cpp > > Line 2450 (original), 2450-2459 (patched) > > > > > > see my comment at https://reviews.apache.org/r/56722/ > > > > excluded

Re: Review Request 59987: Added protobuf map support.

2017-12-26 Thread Qian Zhang
> On Oct. 17, 2017, 7:15 p.m., Benjamin Bannier wrote: > > 3rdparty/stout/include/stout/protobuf.hpp > > Line 1 (original), 1 (patched) > > > > > > We should call out that we have a hard requirement on proto3 now in