Re: Review Request 66780: Removed redundant master flags in resource provider tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66780/#review201983 --- Patch looks great! Reviews applied: [66779, 66308, 66309, 66526,

Re: Review Request 66568: Dropped combined operations with GROW and SHRINK volumes.

> On April 23, 2018, 3:43 p.m., Greg Mann wrote: > > src/master/master.cpp > > Line 4512 (original), 4515-4527 (patched) > > > > > > I was just wondering - perhaps this code belongs in the validation > > function

Re: Review Request 66568: Dropped combined operations with GROW and SHRINK volumes.

> On April 23, 2018, 10:43 p.m., Greg Mann wrote: > > src/master/master.cpp > > Line 4512 (original), 4515-4527 (patched) > > > > > > I was just wondering - perhaps this code belongs in the validation > > function

Re: Review Request 66532: Added test for authorization actions for `RESIZE_VOLUME`.

> On April 17, 2018, 4:24 p.m., Greg Mann wrote: > > src/tests/authorization_tests.cpp > > Line 1979 (original), 1979 (patched) > > > > > > Could you also add an end-to-end test of authorization for these > >

Re: Review Request 66532: Added test for authorization actions for `RESIZE_VOLUME`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66532/ --- (Updated April 24, 2018, 11:16 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 66779: Inserted explicit moves in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66779/#review201903 --- Ship it! Ship It! - Alexander Rukletsov On April 24, 2018,

Re: Review Request 66546: Prevent resubscription of resource providers with unknown IDs.

> On April 25, 2018, 1:51 a.m., Chun-Hung Hsiao wrote: > > src/tests/resource_provider_manager_tests.cpp > > Lines 1155 (patched) > > > > > > Let's also add a test for resource provider manager recovery in another

Re: Review Request 66545: Added admitted resource providers to the manager's registry.

> On April 25, 2018, 1:50 a.m., Chun-Hung Hsiao wrote: > > src/tests/resource_provider_manager_tests.cpp > > Line 851 (original), 851 (patched) > > > > > > Should we add a new test for `GenericRegistrar` recovery?

Re: Review Request 66526: Renamed resource provider `AgentRegistrar` to `GenericRegistrar`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66526/ --- (Updated April 25, 2018, 12:56 p.m.) Review request for mesos, Chun-Hung

Re: Review Request 66780: Removed redundant master flags in resource provider tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66780/#review201921 --- FAIL: Failed to apply the dependent review: 66545. Failed

Re: Review Request 66769: Fixed flaky ReconciliationTest.ReconcileStatusUpdateTaskState.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66769/#review201924 --- Ship it! Ship It! - Andrei Budnik On April 23, 2018, 10:23

Re: Review Request 63372: Added documentation for memory profiling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63372/ --- (Updated April 25, 2018, 2:07 p.m.) Review request for mesos and Alexander

Re: Review Request 63372: Added documentation for memory profiling.

> On April 24, 2018, 5:59 p.m., Alexander Rukletsov wrote: > > Have you rendered using our website renderer? Yes. > On April 24, 2018, 5:59 p.m., Alexander Rukletsov wrote: > > docs/memory-profiling.md > > Lines 54 (patched) > >

Re: Review Request 66173: Add test for new `disk/xfs` kill functionality.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66173/#review201940 --- Ship it! Looks good. There's a coupld of small nits that I'll

Re: Review Request 66220: Added tests for `GROW_VOLUME` and `SHRINK_VOLUME` operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66220/#review201843 --- src/tests/persistent_volume_tests.cpp Lines 451 (patched)

Re: Review Request 66644: Remove unknown unreachable tasks when agent reregisters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66644/#review201941 --- PASS: Mesos patch 66644 was successfully built and tested.

Re: Review Request 66769: Fixed flaky ReconciliationTest.ReconcileStatusUpdateTaskState.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66769/#review201944 --- Ship it! Ship It! - Megha Sharma On April 23, 2018, 10:23

Re: Review Request 66776: Changed failure check for a call to os::system().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66776/#review201949 --- Patch looks great! Reviews applied: [66776] Passed command:

Re: Review Request 66568: Dropped combined operations with GROW and SHRINK volumes.

> On April 23, 2018, 3:43 p.m., Greg Mann wrote: > > src/master/master.cpp > > Line 4512 (original), 4515-4527 (patched) > > > > > > I was just wondering - perhaps this code belongs in the validation > > function

Review Request 66799: Fixed flakyness in 'MasterAPITest.MasterFailover'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66799/ --- Review request for mesos and Greg Mann. Bugs: MESOS-8687

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/#review201935 --- Ship it! I'll fix up the last couple of nits as I commit. -

Re: Review Request 66568: Dropped combined operations with GROW and SHRINK volumes.

> On April 23, 2018, 10:43 p.m., Greg Mann wrote: > > src/master/master.cpp > > Line 4512 (original), 4515-4527 (patched) > > > > > > I was just wondering - perhaps this code belongs in the validation > > function

Re: Review Request 66568: Dropped combined operations with GROW and SHRINK volumes.

> On April 23, 2018, 3:43 p.m., Greg Mann wrote: > > src/master/master.cpp > > Line 4512 (original), 4515-4527 (patched) > > > > > > I was just wondering - perhaps this code belongs in the validation > > function

Re: Review Request 66776: Changed failure check for a call to os::system().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66776/#review201929 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66568: Dropped combined operations with GROW and SHRINK volumes.

> On April 23, 2018, 10:43 p.m., Greg Mann wrote: > > src/master/master.cpp > > Line 4512 (original), 4515-4527 (patched) > > > > > > I was just wondering - perhaps this code belongs in the validation > > function

Re: Review Request 66568: Dropped combined operations with GROW and SHRINK volumes.

> On April 23, 2018, 10:43 p.m., Greg Mann wrote: > > src/master/master.cpp > > Line 4512 (original), 4515-4527 (patched) > > > > > > I was just wondering - perhaps this code belongs in the validation > > function

Re: Review Request 66799: Fixed flakyness in 'MasterAPITest.MasterFailover'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66799/#review201958 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66173: Add test for new `disk/xfs` kill functionality.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66173/#review201956 --- Patch looks great! Reviews applied: [66001, 66173] Passed

Re: Review Request 66220: Added tests for `GROW_VOLUME` and `SHRINK_VOLUME` operations.

> On April 13, 2018, 4:43 p.m., Greg Mann wrote: > > src/tests/persistent_volume_tests.cpp > > Lines 455-459 (patched) > > > > > > Is this enforced somewhere in validation code? Can we check for > > expected

Re: Review Request 66220: Added tests for `GROW_VOLUME` and `SHRINK_VOLUME` operations.

> On April 17, 2018, 10:52 p.m., Gaston Kleiman wrote: > > src/tests/persistent_volume_tests.cpp > > Lines 502 (patched) > > > > > > Nit: `Offer offer = offersBeforeCreate->at(0);` > > > > If this test is

Re: Review Request 66220: Added tests for `GROW_VOLUME` and `SHRINK_VOLUME` operations.

> On April 25, 2018, 4:09 p.m., Greg Mann wrote: > > src/tests/persistent_volume_tests.cpp > > Lines 585-586 (patched) > > > > > > IIUC, the `Clock::settle()` here is ensuring that this test actually > > verifies

Re: Review Request 66220: Added tests for `GROW_VOLUME` and `SHRINK_VOLUME` operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66220/#review201969 --- src/tests/persistent_volume_tests.cpp Lines 501-505 (patched)