> On April 17, 2018, 10:52 p.m., Gaston Kleiman wrote: > > src/tests/persistent_volume_tests.cpp > > Lines 502 (patched) > > <https://reviews.apache.org/r/66220/diff/4/?file=1996762#file1996762line502> > > > > Nit: `Offer offer = offersBeforeCreate->at(0);` > > > > If this test is split into smaller ones, then you can also probable > > make `offer` a const ref. > > Zhitao Li wrote: > We need to obtain offer at least twice.
s/`.get()[0]`/`->at(0)`/ here and below. Reopen this since this is missed. - Chun-Hung ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66220/#review201355 ----------------------------------------------------------- On April 19, 2018, 4:39 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66220/ > ----------------------------------------------------------- > > (Updated April 19, 2018, 4:39 p.m.) > > > Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann. > > > Bugs: MESOS-4965 > https://issues.apache.org/jira/browse/MESOS-4965 > > > Repository: mesos > > > Description > ------- > > Added tests for `GROW_VOLUME` and `SHRINK_VOLUME` operations. > > > Diffs > ----- > > src/tests/persistent_volume_tests.cpp > 4edf781711d9efdb994114aeb6289b6af750b87a > > > Diff: https://reviews.apache.org/r/66220/diff/7/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > >
