Re: Review Request 67547: Added check for API endpoints that do not support streaming responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67547/#review204661 --- Patch looks great! Reviews applied: [67546, 67547] Passed

Re: Review Request 67565: Added a test `ROOT_CGROUPS_CommandTaskSpecificCgroupsMount`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67565/#review204660 --- PASS: Mesos patch 67565 was successfully built and tested.

Review Request 67565: Added a test `ROOT_CGROUPS_CommandTaskSpecificCgroupsMount`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67565/ --- Review request for mesos, Gilbert Song and Jason Lai. Bugs: MESOS-8327

Review Request 67564: Added a test `ROOT_CGROUPS_NestedContainerSpecificCgroupsMount`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67564/ --- Review request for mesos, Gilbert Song and Jason Lai. Bugs: MESOS-8327

Re: Review Request 67526: Added container-specific cgroup FS mounts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67526/ --- (Updated June 13, 2018, 10:42 a.m.) Review request for mesos, Gilbert Song and

Review Request 67563: Added a new agent flag `--cgroups_enable_container_specific_mounts`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67563/ --- Review request for mesos, Gilbert Song and Jason Lai. Bugs: MESOS-8327

Re: Review Request 67559: Added Yihua He to the contributor list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67559/#review204656 --- PASS: Mesos patch 67559 was successfully built and tested.

Re: Review Request 67553: Added Xiang Chaosheng to the contributors list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67553/#review204655 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67562: The container should not be access when the container is destroyed in the mean time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67562/#review204654 --- PASS: Mesos patch 67562 was successfully built and tested.

Re: Review Request 67557: Add contributor info at the file contributors.yaml.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67557/#review204653 --- PASS: Mesos patch 67557 was successfully built and tested.

Re: Review Request 67561: Refactored `struct Slave` in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67561/#review204652 --- PASS: Mesos patch 67561 was successfully built and tested.

Re: Review Request 67558: Cai change.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67558/#review204651 --- PASS: Mesos patch 67558 was successfully built and tested.

Re: Review Request 67356: Made `TestContainerizerProcess::launch()` thread safe.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67356/#review204650 --- Patch looks great! Reviews applied: [67354, 67355, 67356]

Re: Review Request 67394: White list fds that child processes can inherit in mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67394/#review204648 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 67554: Removed headers from `libprocess/src/CMakeList.txt`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67554/#review204646 --- PASS: Mesos patch 67554 was successfully built and tested.

Re: Review Request 67286: White list fds that child processes can inherit in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67286/ --- (Updated June 12, 2018, 10:56 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 67287: White list fds that child processes can inherit in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67287/ --- (Updated June 12, 2018, 10:56 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 67394: White list fds that child processes can inherit in mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67394/ --- (Updated June 12, 2018, 10:56 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 67542: submmit my user information

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67542/ --- (Updated 六月 12, 2018, 10:49 p.m.) Review request for mesos and Gilbert Song.

Re: Review Request 67549: modify my user information

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67549/ --- (Updated 六月 12, 2018, 10:48 p.m.) Review request for mesos and Gilbert Song.

Review Request 67561: Refactored `struct Slave` in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67561/ --- Review request for mesos, Gastón Kleiman, Greg Mann, Kapil Arya, and Till

Review Request 67562: The container should not be access when the container is destroyed in the mean time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67562/ --- Review request for mesos and Gilbert Song. Bugs: 6092

Re: Review Request 67394: White list fds that child processes can inherit in mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67394/#review204644 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 67557: Add contributor info at the file contributors.yaml.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67557/#review204642 --- Ship it! Ship It! - cui dt On 六月 12, 2018, 8:24 p.m., cui

Re: Review Request 67552: Added LongFei Niu to contributors list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67552/#review204641 --- PASS: Mesos patch 67552 was successfully built and tested.

Review Request 67554: Removed headers from `libprocess/src/CMakeList.txt`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67554/ --- Review request for mesos, Akash Gupta, Benjamin Bannier, and Joseph Wu.

Re: Review Request 67287: White list fds that child processes can inherit in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67287/ --- (Updated June 12, 2018, 9:07 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 67286: White list fds that child processes can inherit in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67286/ --- (Updated June 12, 2018, 9:08 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 67394: White list fds that child processes can inherit in mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67394/ --- (Updated June 12, 2018, 9:07 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 67398: Changed default executor tests to not use pipes for synchronization.

> On Juni 12, 2018, 9:47 nachm., Jie Yu wrote: > > src/tests/containerizer/nested_mesos_containerizer_tests.cpp > > Lines 1017-1028 (original), 1012-1028 (patched) > > > > > > Any reason we cannot use a named pipe

Re: Review Request 67557: Add contributor info at the file contributors.yaml.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67557/ --- (Updated 六月 12, 2018, 8:24 p.m.) Review request for mesos and Gilbert Song.

Re: Review Request 67423: Skipped metric for non existing paths in gc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67423/ --- (Updated June 12, 2018, 1:23 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 67421: Rewrote the `ROOT_BusyMountPoint` test to reflect updated behavior.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67421/ --- (Updated June 12, 2018, 1:23 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 67264: Unmounted any mount points in gc paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67264/ --- (Updated June 12, 2018, 1:22 p.m.) Review request for mesos, Chun-Hung Hsiao,

Review Request 67558: Cai change.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67558/ --- Review request for mesos and Gilbert Song. Repository: mesos Description

Review Request 67559: Added Yihua He to the contributor list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67559/ --- Review request for mesos and Gilbert Song. Repository: mesos Description

Re: Review Request 67551: Fixed `push-commits.py` for Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67551/#review204634 --- PASS: Mesos patch 67551 was successfully built and tested.

Re: Review Request 67549: modify my user information

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67549/#review204632 --- PASS: Mesos patch 67549 was successfully built and tested.

Re: Review Request 67398: Changed default executor tests to not use pipes for synchronization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67398/#review204629 --- src/tests/containerizer/nested_mesos_containerizer_tests.cpp

Review Request 67557: Add contributor info at the file contributors.yaml.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67557/ --- Review request for mesos and Gilbert Song. Repository: mesos Description

Re: Review Request 67421: Rewrote the `ROOT_BusyMountPoint` test to reflect updated behavior.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67421/#review204627 --- Fix it, then Ship it! src/tests/gc_tests.cpp Lines 912

Re: Review Request 67423: Skipped metric for non existing paths in gc.

> On June 12, 2018, 6:17 p.m., Jie Yu wrote: > > src/slave/gc.cpp > > Lines 262 (patched) > > > > > > This is a bit hacky. A better way should be modify `os::rmdir` to > > return `Try`. The second template

Re: Review Request 67423: Skipped metric for non existing paths in gc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67423/#review204623 --- Fix it, then Ship it! src/slave/gc.cpp Lines 262 (patched)

Re: Review Request 67264: Unmounted any mount points in gc paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67264/#review204608 --- Fix it, then Ship it! LGTM overall! src/slave/gc.cpp Lines

Re: Review Request 67457: Windows: Ported docker_containerizer_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67457/#review204619 --- src/tests/containerizer/docker_containerizer_tests.cpp Lines

Re: Review Request 67457: Windows: Ported docker_containerizer_tests.cpp.

> On June 8, 2018, 4:12 p.m., Andrew Schwartzmeyer wrote: > > src/tests/containerizer/docker_containerizer_tests.cpp > > Line 300 (original), 339 (patched) > > > > > > What changed here to need another argument? >

Review Request 67553: Added Xiang Chaosheng to the contributors list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67553/ --- Review request for mesos and Gilbert Song. Repository: mesos Description

Re: Review Request 67385: Windows: Added IOCP `HANDLE` to `WindowsFD`.

> On June 5, 2018, 2:02 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/stout/include/stout/os/windows/fd.hpp > > Lines 183-184 (patched) > > > > > > Is there ever a case where `iocp_handle_` hasn't been allocated?

Re: Review Request 67547: Added check for API endpoints that do not support streaming responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67547/#review204616 --- PASS: Mesos patch 67547 was successfully built and tested.

Re: Review Request 67488: Updated CLI to Python 3.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67488/#review204613 --- PASS: Mesos patch 67488 was successfully built and tested.

Re: Review Request 67547: Added check for API endpoints that do not support streaming responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67547/#review204612 --- src/slave/http.cpp Lines 559 (patched)

Review Request 67551: Fixed `push-commits.py` for Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67551/ --- Review request for mesos and Armand Grillet. Repository: mesos Description

Re: Review Request 67546: Moved RecordIO documentation into separate file.

> On June 12, 2018, 5:38 p.m., Alexander Rukletsov wrote: > > docs/recordio.md > > Lines 26 (patched) > > > > > > ## ## > On June 12, 2018, 5:38 p.m., Alexander Rukletsov wrote: > > docs/recordio.md > > Lines 69

Re: Review Request 67546: Moved RecordIO documentation into separate file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67546/#review204610 --- Fix it, then Ship it! docs/recordio.md Lines 26 (patched)

Review Request 67552: Added LongFei Niu to contributors list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67552/ --- Review request for mesos and Gilbert Song. Repository: mesos Description

Re: Review Request 67542: submmit my user information

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67542/ --- (Updated 六月 12, 2018, 5:19 p.m.) Review request for mesos and Gilbert Song.

Review Request 67549: modify my user information

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67549/ --- Review request for mesos. Repository: mesos Description --- modify my

Re: Review Request 67487: Used `$PYTHON` in configure.ac and Makefile.am.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67487/#review204606 --- PASS: Mesos patch 67487 was successfully built and tested.

Review Request 67488: Updated CLI to Python 3.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67488/ --- Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung,

Review Request 67547: Added check for API endpoints not supporting streaming responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67547/ --- Review request for mesos, Alexander Rukletsov and Jan Schlicht. Bugs:

Review Request 67546: Moved RecordIO documentation into separate file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67546/ --- Review request for mesos, Alexander Rukletsov and Jan Schlicht. Repository:

Re: Review Request 67356: Made `TestContainerizerProcess::launch()` thread safe.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67356/#review204599 --- PASS: Mesos patch 67356 was successfully built and tested.

Re: Review Request 67487: Used `$PYTHON` in configure.ac and Makefile.am.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67487/ --- (Updated June 12, 2018, 2:51 p.m.) Review request for mesos, Eric Chung and

Re: Review Request 67413: Added `PYTHON_3` and `PYTHON_3_VERSION` variables in `configure.ac`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67413/ --- (Updated June 12, 2018, 1:46 p.m.) Review request for mesos, Andrew

Re: Review Request 67534: CMake: Added libapr as interface dependency of libsvn.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67534/#review204595 --- Patch looks great! Reviews applied: [67534] Passed command:

Re: Review Request 67534: CMake: Added libapr as interface dependency of libsvn.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67534/#review204594 --- 3rdparty/CMakeLists.txt Lines 652 (patched)

Re: Review Request 67535: CMake: Removed explicit linkage of libapr.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67535/#review204593 --- 3rdparty/stout/CMakeLists.txt Line 24 (original)

Re: Review Request 67538: Added Bin Zheng to the contributors list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67538/#review204591 --- PASS: Mesos patch 67538 was successfully built and tested.

Re: Review Request 67535: CMake: Removed explicit linkage of libapr.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67535/#review204589 --- Patch looks great! Reviews applied: [67535] Passed command:

Re: Review Request 67538: Added Bin Zheng to the contributors list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67538/ --- (Updated 六月 12, 2018, 6:36 a.m.) Review request for mesos and Gilbert Song.

Re: Review Request 67538: Add zhengbin.

> On 六月 12, 2018, 5:49 a.m., Gilbert Song wrote: > > Could you re-phase the commit message as: > > `Added Bin Zheng to the contributors list.` Done,has been modified - bin --- This is an automatically generated e-mail. To reply, visit: