[GitHub] bbannier edited a comment on issue #310: Added Python 3.6 and pip to Docker ARM image.

bbannier edited a comment on issue #310: Added Python 3.6 and pip to Docker ARM image. URL: https://github.com/apache/mesos/pull/310#issuecomment-421397897 Yes, pretty sure, see

[GitHub] janisz commented on issue #310: Added Python 3.6 and pip to Docker ARM image.

janisz commented on issue #310: Added Python 3.6 and pip to Docker ARM image. URL: https://github.com/apache/mesos/pull/310#issuecomment-421397983 Merged: https://github.com/apache/mesos/commit/0fa42f82770a4afca1908449f0cfd41e5383988e

[GitHub] bbannier commented on issue #310: Added Python 3.6 and pip to Docker ARM image.

bbannier commented on issue #310: Added Python 3.6 and pip to Docker ARM image. URL: https://github.com/apache/mesos/pull/310#issuecomment-421397897 Yes, pretty sure, see

[GitHub] janisz closed pull request #310: Added Python 3.6 and pip to Docker ARM image.

janisz closed pull request #310: Added Python 3.6 and pip to Docker ARM image. URL: https://github.com/apache/mesos/pull/310 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

Re: Review Request 68711: Added `task ls` command to Mesos CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68711/ --- (Updated Sept. 14, 2018, 6:26 p.m.) Review request for mesos, Eric Chung and

[GitHub] janisz commented on issue #310: Added Python 3.6 and pip to Docker ARM image.

janisz commented on issue #310: Added Python 3.6 and pip to Docker ARM image. URL: https://github.com/apache/mesos/pull/310#issuecomment-421397193 @bbannier Are you sure? This is an automated message from the Apache Git

Re: Review Request 68711: Added `task ls` command to Mesos CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68711/#review208638 --- PASS: Mesos patch 68711 was successfully built and tested.

Re: Review Request 68548: Introduced a base class for writing allocator benchmarks.

> On Sept. 14, 2018, 3:07 p.m., Meng Zhu wrote: > > src/tests/hierarchical_allocator_benchmarks.cpp > > Lines 306 (patched) > > > > > > const ? The value is computed during initialize() call. - Kapil

Re: Review Request 68591: Added allocator benchmark for non-homogeneous framework profiles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68591/ --- (Updated Sept. 14, 2018, 3:17 p.m.) Review request for mesos, Meng Zhu and

Re: Review Request 68696: Eliminating an unnecessary copy when devolving a scheduler call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68696/#review208645 --- Ship it! Ship It! - Meng Zhu On Sept. 11, 2018, 7:03 p.m.,

Re: Review Request 68679: Fixed stout `FsTest.Used` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68679/ --- (Updated Sept. 14, 2018, 5:46 p.m.) Review request for mesos and Till

Re: Review Request 68591: Added allocator benchmark for non-homogeneous framework profiles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68591/ --- (Updated Sept. 14, 2018, 2:01 p.m.) Review request for mesos, Meng Zhu and

Re: Review Request 68548: Introduced a base class for writing allocator benchmarks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68548/ --- (Updated Sept. 14, 2018, 2 p.m.) Review request for mesos, Meng Zhu and Till

Re: Review Request 68591: Added allocator benchmark for non-homogeneous framework profiles.

> On Sept. 14, 2018, 3:07 p.m., Meng Zhu wrote: > > src/tests/hierarchical_allocator_benchmarks.cpp > > Lines 422 (patched) > > > > > > Is this redundant? since we already checked > >

Re: Review Request 68549: Added pause and resume helpers to the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68549/#review208634 --- Ship it! No need to mention my patch in the commit message. -

Re: Review Request 68591: Added allocator benchmark for non-homogeneous framework profiles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68591/#review208632 --- Fix it, then Ship it! Just a few minor issues, mostly

Re: Review Request 68548: Introduced a base class for writing allocator benchmarks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68548/#review208633 --- Fix it, then Ship it! This is great!

Re: Review Request 68591: Added allocator benchmark for non-homogeneous framework profiles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68591/ --- (Updated Sept. 14, 2018, 3:22 p.m.) Review request for mesos, Meng Zhu and

Re: Review Request 68695: Reduced protobuf copying in evolve helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68695/#review208644 --- Ship it! Ship It! - Meng Zhu On Sept. 11, 2018, 7:03 p.m.,

Re: Review Request 68548: Introduced a base class for writing allocator benchmarks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68548/ --- (Updated Sept. 14, 2018, 3:16 p.m.) Review request for mesos, Meng Zhu and

Re: Review Request 68591: Added allocator benchmark for non-homogeneous framework profiles.

> On Sept. 14, 2018, 3:07 p.m., Meng Zhu wrote: > > src/tests/hierarchical_allocator_benchmarks.cpp > > Lines 422 (patched) > > > > > > Is this redundant? since we already checked > >

Review Request 68723: Fixed `verify-reviews.py` script to make `-o` optional.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68723/ --- Review request for mesos and Benjamin Bannier. Bugs: MESOS-9232

Re: Review Request 68723: Fixed `verify-reviews.py` script to make `-o` optional.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68723/#review208646 --- support/verify-reviews.py Line 253 (original), 246 (patched)

Re: Review Request 68718: Added patch for PicoJSON.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68718/#review208630 --- PASS: Mesos patch 68718 was successfully built and tested.

Re: Review Request 68720: Added new member function to stout PicoJSON context.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68720/#review208636 --- PASS: Mesos patch 68720 was successfully built and tested.

Re: Review Request 68679: Fixed stout `FsTest.Used` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68679/#review208637 --- PASS: Mesos patch 68679 was successfully built and tested.

Re: Review Request 68490: Optimized `class Resources` with copy-on-write.

> On Sept. 11, 2018, 7:25 p.m., Benjamin Mahler wrote: > > src/common/resources.cpp > > Line 1641 (original), 1655 (patched) > > > > > > Actually, I was thinking about this, isn't the casting to `Resource` > >

Re: Review Request 67175: Added support for marking slave mounts and creating non-existing paths.

> On May 23, 2018, 12:18 a.m., James Peach wrote: > > src/linux/fs.hpp > > Lines 294 (patched) > > > > > > This only ever gets used by the `hashset` version, so don't make it a > > static function, just call

Re: Review Request 67175: Added support for marking slave mounts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67175/ --- (Updated Sept. 15, 2018, 12:36 a.m.) Review request for mesos, Eric Chung,

Re: Review Request 68414: Made authentication tests independent of wall clock time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68414/#review208657 --- PASS: Mesos patch 68414 was successfully built and tested.

Re: Review Request 68639: Renamed `Resources::resources` vector and typedef its item type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68639/ --- (Updated Sept. 14, 2018, 3:11 p.m.) Review request for mesos, Benjamin

Re: Review Request 68490: Optimized `class Resources` with copy-on-write.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68490/ --- (Updated Sept. 14, 2018, 3:11 p.m.) Review request for mesos, Benjamin

Re: Review Request 68414: Made authentication tests independent of wall clock time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68414/ --- (Updated Sept. 14, 2018, 3:19 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 68639: Renamed `Resources::resources` vector and typedef its item type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68639/#review208655 --- PASS: Mesos patch 68639 was successfully built and tested.

Re: Review Request 68591: Added allocator benchmark for non-homogeneous framework profiles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68591/#review208647 --- PASS: Mesos patch 68591 was successfully built and tested.

Review Request 68724: Added the ability to launch tasks with a TTY attached to mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68724/ --- Review request for mesos, Gilbert Song and Jie Yu. Repository: mesos

Re: Review Request 68723: Fixed `verify-reviews.py` script to make `-o` optional.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68723/#review208650 --- PASS: Mesos patch 68723 was successfully built and tested.

Re: Review Request 68354: Added a test to verify agent authentication retry backoff logic.

> On Sept. 12, 2018, 1:53 p.m., Gastón Kleiman wrote: > > src/tests/authentication_tests.cpp > > Lines 422 (patched) > > > > > > Nit: I am not a big fan of hard-coded magic numbers, so I'd declare > > `expected`

Re: Review Request 68724: Added the ability to launch tasks with a TTY attached to mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68724/#review208656 --- PASS: Mesos patch 68724 was successfully built and tested.

Re: Review Request 68714: Fixed jenkins/reviewbot.sh to work with updated verify-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68714/#review208618 --- Ship it! Makes sense, let's role it out and see if it gets

Review Request 68714: Fixed jenkins/reviewbot.sh to work with updated verify-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68714/ --- Review request for mesos and Benjamin Bannier. Repository: mesos Description

Re: Review Request 68714: Fixed jenkins/reviewbot.sh to work with updated verify-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68714/#review208619 --- support/jenkins/reviewbot.sh Line 37 (original), 37 (patched)

Re: Review Request 68714: Fixed jenkins/reviewbot.sh to work with updated verify-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68714/#review208620 --- Ship it! Ship It! - Benjamin Bannier On Sept. 14, 2018,

Re: Review Request 68714: Fixed jenkins/reviewbot.sh to work with updated verify-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68714/ --- (Updated Sept. 14, 2018, 9:42 a.m.) Review request for mesos, Andrew

Re: Review Request 68714: Fixed jenkins/reviewbot.sh to work with updated verify-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68714/#review208624 --- PASS: Mesos patch 68714 was successfully built and tested.

[GitHub] janisz edited a comment on issue #310: Added Python 3.6 and pip to Docker ARM image.

janisz edited a comment on issue #310: Added Python 3.6 and pip to Docker ARM image. URL: https://github.com/apache/mesos/pull/310#issuecomment-421340082 @bbannier @bmahler Can you take a look? Tested: ```java $ docker run -it janisz/mesos-build:ubuntu-16.04-arm python3.6

[GitHub] janisz opened a new pull request #310: Added Python 3.6 and pip to Docker ARM image.

janisz opened a new pull request #310: Added Python 3.6 and pip to Docker ARM image. URL: https://github.com/apache/mesos/pull/310 Following the update of the CLI to Python 3, we embed Python 3.6 (the minimum required Python version) into the Docker images used during continuous

[GitHub] janisz commented on issue #310: Added Python 3.6 and pip to Docker ARM image.

janisz commented on issue #310: Added Python 3.6 and pip to Docker ARM image. URL: https://github.com/apache/mesos/pull/310#issuecomment-421340082 @bbannier @bmahler Can you take a look? This is an automated message from the

[GitHub] bbannier commented on issue #310: Added Python 3.6 and pip to Docker ARM image.

bbannier commented on issue #310: Added Python 3.6 and pip to Docker ARM image. URL: https://github.com/apache/mesos/pull/310#issuecomment-421357018 Thanks a lot @janisz, merged. This is an automated message from the Apache