Re: Review Request 71299: Added separate script to install developer setup.

> On Aug. 26, 2019, 8:50 p.m., Till Toenshoff wrote: > > support/setup-dev.sh > > Lines 29-48 (patched) > > > > > > These still are rather unfortunate, I feel. This will go away with r/71205. - Benjamin

Re: Review Request 71300: Removed mesos-style transition script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71300/#review217452 --- Patch looks great! Reviews applied: [70096, 71203, 71204, 71299,

Re: Review Request 71209: Enabled a number of additional pre-commit checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71209/ --- (Updated Aug. 27, 2019, 9:57 a.m.) Review request for mesos and Till

Re: Review Request 71376: Avoid potential for race in Master::apply.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71376/#review217473 --- Patch looks great! Reviews applied: [71376] Passed command:

Review Request 71376: Avoid potential for race in Master::apply.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71376/ --- Review request for mesos, Greg Mann and Meng Zhu. Repository: mesos

Re: Review Request 65112: Added documentation about standalone containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65112/#review217469 --- Patch looks great! Reviews applied: [65112] Passed command:

Re: Review Request 71378: Added node draining to 1.9.0 CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71378/#review217472 --- Ship it! Ship It! - Gilbert Song On Aug. 27, 2019, 6:19

Review Request 71378: Added node draining to 1.9.0 CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71378/ --- Review request for mesos, Gilbert Song, Greg Mann, and Qian Zhang. Repository:

Review Request 71381: Added a DRF sorter test for sorting frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71381/ --- Review request for mesos, Andrei Sekretenko and Benjamin Mahler. Bugs:

Re: Review Request 71303: Enabled role sorters to track frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71303/ --- (Updated Aug. 27, 2019, 10 p.m.) Review request for mesos, Andrei Sekretenko

Review Request 71379: Tracked framework allocation in the allocator framework struct.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71379/ --- Review request for mesos, Andrei Sekretenko and Benjamin Mahler. Repository:

Review Request 71380: Added a random sorter test for sorting frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71380/ --- Review request for mesos, Andrei Sekretenko and Benjamin Mahler. Bugs:

Re: Review Request 71204: Added gitlint config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71204/#review217459 --- bootstrap.bat Lines 64 (patched)

Re: Review Request 71299: Added separate script to install developer setup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71299/#review217460 --- Ship it! Ship It! - Joseph Wu On Aug. 20, 2019, 4:48 a.m.,

Re: Review Request 71205: Switched commit hooks to pre-commit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71205/#review217461 --- Fix it, then Ship it! support/setup-dev.bat Lines 59

Re: Review Request 71203: Added check script to check for license headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71203/#review217462 --- Ship it! Ship It! - Joseph Wu On Aug. 19, 2019, 12:20 a.m.,

Re: Review Request 71206: Removed old mesos-style and references.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71206/#review217463 --- Ship it! Ship It! - Joseph Wu On Aug. 20, 2019, 4:49 a.m.,

Re: Review Request 71208: Revert "Updated cpplint to be compatible with Python 3."

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71208/#review217465 --- Ship it! Ship It! - Joseph Wu On July 30, 2019, 2:01 p.m.,

Re: Review Request 71207: Revert "Updated cpplint.py to be less verbose when there is no linting issue."

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71207/#review217464 --- Ship it! Ship It! - Joseph Wu On Aug. 20, 2019, 4:49 a.m.,

Re: Review Request 71209: Enabled a number of additional pre-commit checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71209/#review217466 --- Ship it! Ship It! - Joseph Wu On Aug. 27, 2019, 12:57 a.m.,

Re: Review Request 71375: Added quota limits to the 1.9.0 CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71375/#review217467 --- Patch looks great! Reviews applied: [71375] Passed command:

Re: Review Request 65112: Added documentation about standalone containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65112/ --- (Updated Aug. 27, 2019, 11:47 a.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 71375: Added quota limits to the 1.9.0 CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71375/#review217454 --- Ship it! Ship It! - Vinod Kone On Aug. 27, 2019, 4:56 p.m.,

Re: Review Request 71375: Added quota limits to the 1.9.0 CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71375/#review217456 --- Ship it! Ship It! - Gilbert Song On Aug. 27, 2019, 9:56

Re: Review Request 70096: Moved cpplint configuration into dedicated file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70096/#review217457 --- Fix it, then Ship it! bootstrap.bat Lines 60 (patched)

Review Request 71375: Added quota limits to the 1.9.0 CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71375/ --- Review request for mesos, Andrei Sekretenko, Meng Zhu, Qian Zhang, and Vinod

Re: Review Request 71205: Switched commit hooks to pre-commit.

> On Aug. 26, 2019, 8:51 p.m., Till Toenshoff wrote: > > When running the script, I noticed this > > ``` > > [INFO] Installing environment for local. > > [INFO] Once installed this environment will be reused. > > [INFO] This may take a few minutes... > > [INFO] Installing environment for local.

Re: Review Request 71205: Switched commit hooks to pre-commit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71205/ --- (Updated Aug. 27, 2019, 10:08 a.m.) Review request for mesos and Till