Re: Review Request 71961: Added deprecated absolute() function for backwards compatibility.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71961/#review219142 --- Ship it! Ship It! - Benjamin Bannier On Jan. 7, 2020, 1:24

Re: Review Request 71960: Added support for deprecated attribute to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71960/#review219141 --- Ship it! Ship It! - Benjamin Bannier On Jan. 7, 2020, 1:24

Review Request 71961: Added deprecated absolute() function for backwards compatibility.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71961/ --- Review request for mesos, Benjamin Bannier and Benjamin Mahler. Repository:

Review Request 71960: Added support for deprecated attribute to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71960/ --- Review request for mesos, Benjamin Bannier and Benjamin Mahler. Repository:

Re: Review Request 71953: Updated the test `ROOT_CGROUPS_CFS_EnableCfs` to check CFS quota.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71953/ --- (Updated Jan. 7, 2020, 11:05 p.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 71956: Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71956/ --- (Updated Jan. 7, 2020, 11:06 p.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 71862: Moved creating authorization Object out of `Master::authorize*Disk`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71862/#review219147 --- Ship it! Ship It! - Benjamin Mahler On Jan. 2, 2020, 8:01

Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71965/ --- Review request for mesos, Greg Mann and Qian Zhang. Bugs: MESOS-10076

Review Request 71966: Cgroups isolator: added support for nested cgroups during recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71966/ --- Review request for mesos, Greg Mann and Qian Zhang. Bugs: MESOS-10079

Re: Review Request 71861: Moved creating authz Object out of `Master::authorizeResizeVolume`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71861/#review219146 --- Ship it! src/master/http.cpp Lines 158 (patched)

Re: Review Request 71863: Moved creating authorization Object out of `Master::authorize*Volume`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71863/#review219148 --- Ship it! Ship It! - Benjamin Mahler On Jan. 2, 2020, 8:37

Re: Review Request 71956: Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71956/#review219153 --- Patch looks great! Reviews applied: [71855, 71931, 71856, 71858,

Re: Review Request 71864: Moved creating authorization Object out of `Master::authorize*reserve`.

> On Dec. 4, 2019, 8:27 p.m., Benjamin Mahler wrote: > > src/master/authorization.cpp > > Lines 239-240 (patched) > > > > > > Ditto the broader question about validation errors from the previous > > review. > >

Re: Review Request 71864: Moved creating authorization Object out of `Master::authorize*reserve`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71864/#review219150 --- Ship it! src/master/authorization.hpp Lines 109-125 (patched)

Re: Review Request 71865: Moved creating authorization Object out of `Master::authorizeSlave`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71865/#review219152 --- Ship it! src/master/authorization.cpp Lines 101 (patched)

Re: Review Request 71966: Cgroups isolator: added support for nested cgroups during recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71966/#review219155 --- Bad review! Reviews applied: [71966, 71965] Error: 2020-01-07

Re: Review Request 71858: WIP: Set resource limits when launching executor container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71858/#review219154 --- src/slave/slave.cpp Lines 3115 (patched)

Re: Review Request 71886: WIP: Set container's `cpu.cfs_quota_us` to its CPU resource limit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71886/#review219156 --- Ship it! Is this still WIP? If not, could you update the

Re: Review Request 71943: WIP: Set container's `memory.limit_in_bytes` to its memory limit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71943/#review219157 --- Ship it! Is this still WIP? If not, could you update the

Re: Review Request 71858: WIP: Set resource limits when launching executor container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71858/ --- (Updated Jan. 8, 2020, 10:08 a.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 71952: WIP: Set resource limits when updating executor container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71952/ --- (Updated Jan. 8, 2020, 10:08 a.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 71858: WIP: Set resource limits when launching executor container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71858/#review219164 --- src/slave/slave.cpp Lines 126 (patched)

Re: Review Request 71858: WIP: Set resource limits when launching executor container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71858/ --- (Updated Jan. 8, 2020, 10:40 a.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 71952: WIP: Set resource limits when updating executor container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71952/ --- (Updated Jan. 8, 2020, 10:40 a.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 71858: WIP: Set resource limits when launching executor container.

> On Jan. 8, 2020, 5:43 a.m., Greg Mann wrote: > > src/slave/slave.cpp > > Lines 3116 (patched) > > > > > > Are we using `-1` for this? I thought the plan was to use `INFINITY`? Yeah, that's why I marked this

Re: Review Request 71886: WIP: Set container's `cpu.cfs_quota_us` to its CPU resource limit.

> On Jan. 8, 2020, 6:11 a.m., Greg Mann wrote: > > Is this still WIP? If not, could you update the commit message accordingly? Yes, it is still WIP since I have not handled infinite CPU limit yet. Once https://issues.apache.org/jira/browse/MESOS-10064 is resolved, I will update this patch

Re: Review Request 71943: WIP: Set container's `memory.limit_in_bytes` to its memory limit.

> On Jan. 8, 2020, 6:34 a.m., Greg Mann wrote: > > Is this still WIP? If not, could you update the commit message accordingly? Yes, it is still WIP since I have not handled infinite memory limit yet. Once https://issues.apache.org/jira/browse/MESOS-10064 is resolved, I will update this patch

Re: Review Request 71944: Set container process's OOM score adjust.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71944/#review219158 ---

Re: Review Request 71950: Updated containierzer's `update()` method to handle resource limits.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71950/#review219161 --- Also, s/containierzer/containerizer/ in the commit message. -

Re: Review Request 71950: Updated containierzer's `update()` method to handle resource limits.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71950/#review219160 --- src/slave/containerizer/composing.cpp Lines 78-79 (patched)

Re: Review Request 71951: Added resource limits into the `Task` protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71951/#review219162 --- Ship it! Ship It! - Greg Mann On Jan. 5, 2020, 2:07 p.m.,

Re: Review Request 71956: Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71956/#review219169 --- Patch looks great! Reviews applied: [71855, 71931, 71856, 71858,