Re: Review Request 32198: Added a not equal operator for json objects.

2015-05-04 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32198/#review82407 --- Ship it! Ship It! - Niklas Nielsen On May 1, 2015, 11:55 a.m.,

Re: Review Request 33531: Made master/slave usage flags newline behaviour consistent.

2015-05-04 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33531/#review82416 --- Ship it! Ship It! - Alexander Rojas On April 27, 2015, 6:50

Re: Review Request 33249: Send statusUpdate to scheduler on containerizer launch failure

2015-05-04 Thread Jay Buffington
On April 21, 2015, 4:25 p.m., Jie Yu wrote: src/slave/slave.cpp, lines 3065-3078 https://reviews.apache.org/r/33249/diff/3/?file=938221#file938221line3065 Instead of doing that in your way, can we just try to make sure `containerizer-wait` here will return a failure (or a

Re: Review Request 33828: Fix for MESOS-2690. Issue with enable-optimize build.

2015-05-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33828/#review82462 --- Patch looks great! Reviews applied: [33828] All tests passed. -

Re: Review Request 33828: Fix for MESOS-2690. Issue with enable-optimize build.

2015-05-04 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33828/#review82464 --- Ship it! Minor style/consistency nit, but otherwise shippable.

Re: Review Request 32163: Added a function which checks if a json object is contained within another.

2015-05-04 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32163/#review82410 --- 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp

Re: Review Request 33792: Add InsensitiveHashMap.

2015-05-04 Thread Ben Mahler
On May 4, 2015, 6:46 p.m., Alexander Rojas wrote: I am not really sure this is the way to go in order to create a case insensite hashmap. The class `hashmap` simply adds functionality to the `boost::unordered_map`. If one checks the API for the latter, the way needed to create an

Re: Review Request 33558: Add C++11 lambdas to the C++ style guide.

2015-05-04 Thread Ben Mahler
On April 28, 2015, 2:08 a.m., Ben Mahler wrote: docs/mesos-c++-style-guide.md, lines 206-208 https://reviews.apache.org/r/33558/diff/3/?file=942044#file942044line206 What does it mean to pass a lambda to `socket.send`? Doesn't look like this is functionality provided on the

Review Request 33825: Added executor implementation for the new HTTP API

2015-05-04 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33825/ --- Review request for mesos, Isabel Jimenez, Marco Massenzio, and Vinod Kone.

Re: Review Request 30774: Fetcher Cache

2015-05-04 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30774/ --- (Updated May 4, 2015, 4:29 p.m.) Review request for mesos, Adam B, Benjamin

Review Request 33828: Fix for MESOS-2690. Issue with enable-optimize build.

2015-05-04 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33828/ --- Review request for mesos, Ben Mahler and Cody Maloney. Bugs: MESOS-2690