Review Request 36819: Use setup.py in python cli package.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/ --- Review request for mesos. Repository: mesos Description --- Use setup.py in python cli package. Diffs - Makefile.am f8e958d376efa55ace7c5727a31b8e747403641e bin/mesos.sh.in 5cbeac4330a9f45fc6d54b8c2d383f48e4098f95 configure.ac 546c9bbf775a4ef481fafb3a58c85c6d80e19500 src/Makefile.am a7104bb642339c2fe8a466983300d4c62dc2b344 src/cli/python/mesos/__init__.py 028b0d27fb193bac96f2a6a3201ee4cc8fd369ef src/cli/python/mesos/cli.py src/cli/python/mesos/futures.py src/cli/python/mesos/http.py src/python/cli/src/mesos/__init__.py PRE-CREATION Diff: https://reviews.apache.org/r/36819/diff/ Testing --- Thanks, haosdent huang
Re: Review Request 36819: Use setup.py in python cli package.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/ --- (Updated July 26, 2015, 5:10 p.m.) Review request for mesos and Benjamin Hindman. Repository: mesos Description --- Use setup.py in python cli package. Diffs - Makefile.am f8e958d376efa55ace7c5727a31b8e747403641e bin/mesos.sh.in 5cbeac4330a9f45fc6d54b8c2d383f48e4098f95 configure.ac 546c9bbf775a4ef481fafb3a58c85c6d80e19500 src/Makefile.am a7104bb642339c2fe8a466983300d4c62dc2b344 src/cli/python/mesos/__init__.py 028b0d27fb193bac96f2a6a3201ee4cc8fd369ef src/cli/python/mesos/cli.py src/cli/python/mesos/futures.py src/cli/python/mesos/http.py src/python/cli/src/mesos/__init__.py PRE-CREATION Diff: https://reviews.apache.org/r/36819/diff/ Testing (updated) --- make check Thanks, haosdent huang
Re: Review Request 36656: Removed 'SSL_ENABLE_SSL_V2' configuration flag for SSLv2.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36656/ --- (Updated July 26, 2015, 5:28 p.m.) Review request for mesos, Benjamin Hindman and Michael Park. Changes --- Addressed comments. Bugs: MESOS-3121 https://issues.apache.org/jira/browse/MESOS-3121 Repository: mesos Description --- See summary. Diffs (updated) - 3rdparty/libprocess/src/openssl.hpp 3f8d351589f8bb26c886da12c53b5e02a242376a 3rdparty/libprocess/src/openssl.cpp 6aa2a4db8d64011d0fde6ff0cf4b144c41949d39 3rdparty/libprocess/src/tests/ssl_tests.cpp 2fe50601615b0bee57bd3e05dc9c932f93ca7477 Diff: https://reviews.apache.org/r/36656/diff/ Testing --- make check. Thanks, Joris Van Remoortere
Re: Review Request 36799: Renamed Executor{Limitation, RunState} to Container{Limitation, State}.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36799/#review93057 --- Patch looks great! Reviews applied: [36718, 36754, 36755, 36799] All tests passed. - Mesos ReviewBot On July 26, 2015, 6:49 p.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36799/ --- (Updated July 26, 2015, 6:49 p.m.) Review request for mesos, Benjamin Hindman and Jie Yu. Repository: mesos Description --- The new names better reflect the contents since the Limitation and State are for the container. Diffs - include/mesos/slave/isolator.hpp 879e03e5bf49fab507b8d9904f944d950de18987 include/mesos/slave/isolator.proto 07c1c1a09d1578dd4c3abd8bb1773782b4aa9549 src/common/protobuf_utils.hpp 5c992540e29143ed51fdd06b52dbde05e4136f58 src/common/protobuf_utils.cpp bf178d2942e8f5bed3d7eff44ed5929a552ecf35 src/slave/containerizer/isolator.hpp 1482b4c9fa375bdb2607bf83334b44b97024cba8 src/slave/containerizer/isolator.cpp 9d2af8b42f37550a75eae52ef1f5c1a647131072 src/slave/containerizer/isolators/cgroups/cpushare.hpp 409a3a997a7b2c7104421f48ee1078e8fd369a2a src/slave/containerizer/isolators/cgroups/cpushare.cpp ccaf1e372c0693522aed2e0aa8d680e404faf8ef src/slave/containerizer/isolators/cgroups/mem.hpp d43ba6d3debfc6279a023bd28f584635eeb79dc3 src/slave/containerizer/isolators/cgroups/mem.cpp 70c9868dbb670278b3bb4e4322598285488851fe src/slave/containerizer/isolators/cgroups/perf_event.hpp 3796b30a56799a00f1ddbec9bd20b9203d689856 src/slave/containerizer/isolators/cgroups/perf_event.cpp a62a4e6ca573230af17781495eae63115ef28f00 src/slave/containerizer/isolators/filesystem/posix.hpp 2afc572d20acb3d31d3981d99ffe6ea45ae93dff src/slave/containerizer/isolators/filesystem/posix.cpp 5e5a896d9888375259a38dcc68d03dce6406a28e src/slave/containerizer/isolators/filesystem/shared.hpp f6ba43a6d6d3a2afb9380f05de9edaa3fe3c5936 src/slave/containerizer/isolators/filesystem/shared.cpp 4694025eb9b3adad70cc1ec7541c3d3f95fec2bc src/slave/containerizer/isolators/namespaces/pid.hpp 61db386b1d6f602edcba8a1fa251cfd12a534aca src/slave/containerizer/isolators/namespaces/pid.cpp 29be94b96ed9a3db90c88a4b60517d78e95b7144 src/slave/containerizer/isolators/network/port_mapping.hpp fb9ce9c3a33d652a6e1dda3485dde0f2d914ccac src/slave/containerizer/isolators/network/port_mapping.cpp 3f35782c9e0e458169777bab778178c524a58b2b src/slave/containerizer/isolators/posix.hpp 58d9911fef6f57dd078c533221094f9c69489fe4 src/slave/containerizer/isolators/posix/disk.hpp 86aea37d0bbf5d2e5bfc32624fe084b2e73dac1a src/slave/containerizer/isolators/posix/disk.cpp 845496c865a92946910a4e9dd50d05482503b7ef src/slave/containerizer/launcher.hpp a19b8592f943d3a2ae0337c142f54c0ada204536 src/slave/containerizer/launcher.cpp ecb33309ff0941985eebf7a94d831330076978de src/slave/containerizer/linux_launcher.hpp 28a7d35d99881486a9d63eb0aaedad15cb99 src/slave/containerizer/linux_launcher.cpp ed2e881f555d651ad1e5f1b62f32848ade09b424 src/slave/containerizer/mesos/containerizer.hpp 5155362bef9163af3fa5334be3a39b91549e1ec1 src/slave/containerizer/mesos/containerizer.cpp 11eedf30674b326ea3e1f6f71d27f9eb54126368 src/slave/containerizer/provisioner.hpp f7fb068ca5b0a8da1fb756411d59536ed7a1aec8 src/tests/containerizer/containerizer_tests.cpp a44b6e887c37e55213db068a95ab3e73a033e1ea src/tests/containerizer/isolator.hpp 8aaf88c3ea8362950e363d15cbe2b598a12f12d6 src/tests/containerizer/launcher.hpp 78216e0805eadb8eb425d9d58aae1b102a7817b5 Diff: https://reviews.apache.org/r/36799/diff/ Testing --- make check Thanks, Kapil Arya
Re: Review Request 36819: Use setup.py in python cli package.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/ --- (Updated July 26, 2015, 5:24 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-3149 https://issues.apache.org/jira/browse/MESOS-3149 Repository: mesos Description --- Use setup.py in python cli package. Diffs - Makefile.am f8e958d376efa55ace7c5727a31b8e747403641e bin/mesos.sh.in 5cbeac4330a9f45fc6d54b8c2d383f48e4098f95 configure.ac 546c9bbf775a4ef481fafb3a58c85c6d80e19500 src/Makefile.am a7104bb642339c2fe8a466983300d4c62dc2b344 src/cli/python/mesos/__init__.py 028b0d27fb193bac96f2a6a3201ee4cc8fd369ef src/cli/python/mesos/cli.py src/cli/python/mesos/futures.py src/cli/python/mesos/http.py src/python/cli/src/mesos/__init__.py PRE-CREATION Diff: https://reviews.apache.org/r/36819/diff/ Testing --- make check Thanks, haosdent huang
Re: Review Request 36656: Removed 'SSL_ENABLE_SSL_V2' configuration flag for SSLv2.
On July 22, 2015, 7:51 p.m., Michael Park wrote: 3rdparty/libprocess/src/openssl.cpp, line 332 https://reviews.apache.org/r/36656/diff/1/?file=1018170#file1018170line332 Saw this while grepping for `SSLv2`. We still need to use this rather than `TLS_method` currently because of support for older OpenSSL, correct? Just wondering since we no longer support `SSLv2`. OpenSSL documentation [1] mentions that `SSLv23_method` has been replaced with `TLS_method` which supports `SSLv3`, `TLSv1`, `TLSv1.1` and `TLSv1.2`. It also mentioned that `TLS_method` was introduced in OpenSSL 1.1.0. [1] https://www.openssl.org/docs/ssl/TLSv1_1_server_method.html Indeed. I think we should maintain support for older versions of OpenSSL for now. I will add a comment referencing this for future deprecation though. Thanks! On July 22, 2015, 7:51 p.m., Michael Park wrote: 3rdparty/libprocess/src/openssl.cpp, lines 483-489 https://reviews.apache.org/r/36656/diff/1/?file=1018170#file1018170line483 Saw this while grepping for `SSLv2`. I feel like `SSL_CTX_clear_options(ctx, SSL_CTX_get_options(ctx));` would be a concise way to do this? It would also continue to completely clear the options, even if new protocols were to be introduced into OpenSSL. I agree that it would be more concise; however, it would also clear the options that are set by default during construction. I don't think it is a safe strategy to blindly clear them. I'm going to leave the manual clear for now. - Joris --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36656/#review92638 --- On July 21, 2015, 10:51 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36656/ --- (Updated July 21, 2015, 10:51 p.m.) Review request for mesos, Benjamin Hindman and Michael Park. Bugs: MESOS-3121 https://issues.apache.org/jira/browse/MESOS-3121 Repository: mesos Description --- See summary. Diffs - 3rdparty/libprocess/src/openssl.hpp 3f8d351589f8bb26c886da12c53b5e02a242376a 3rdparty/libprocess/src/openssl.cpp 6aa2a4db8d64011d0fde6ff0cf4b144c41949d39 3rdparty/libprocess/src/tests/ssl_tests.cpp 2fe50601615b0bee57bd3e05dc9c932f93ca7477 Diff: https://reviews.apache.org/r/36656/diff/ Testing --- make check. Thanks, Joris Van Remoortere
Review Request 36828: Used std::thread instead of pthread for stout proc tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36828/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael Park. Bugs: MESOS-3118 https://issues.apache.org/jira/browse/MESOS-3118 Repository: mesos Description --- See summary. Diffs - 3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp 5d24f21f63433b8525370736dd630880d324ebeb Diff: https://reviews.apache.org/r/36828/diff/ Testing --- make check Thanks, Joris Van Remoortere
Re: Review Request 36720: Add subscribe- subscribed workflow for http frameworks
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/#review93060 --- src/master/http.cpp (line 339) https://reviews.apache.org/r/36720/#comment147323 complexity of a function is measured by the nested if condition in it. Maybe we accomplish the same using simple small functions ? - Jojy Varghese On July 25, 2015, 2:32 p.m., Anand Mazumdar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/ --- (Updated July 25, 2015, 2:32 p.m.) Review request for mesos and Ben Mahler. Bugs: MESOS-2294 https://issues.apache.org/jira/browse/MESOS-2294 Repository: mesos Description --- Split review out of r36318. This change adds the functionality of making a http call for subscribe and the master responding with a subscribed event on the persistent stream. Diffs - src/master/http.cpp 3a1598fad4db03e5f62fd4a6bd26b2bedeee4070 src/master/master.hpp 827d0d599912b2936beb9615610f627f6c9a2d43 src/master/master.cpp 613a011e205611702921179b6c436d62447e2dca src/tests/http_api_tests.cpp 64bbeb6699171e85a5be293919ad9f32ded0ebac Diff: https://reviews.apache.org/r/36720/diff/ Testing --- make check + test. Thanks, Anand Mazumdar
Review Request 36825: Removed common/thread as it is not used.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36825/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael Park. Bugs: MESOS-3120 https://issues.apache.org/jira/browse/MESOS-3120 Repository: mesos Description --- See summary. Diffs - src/Makefile.am a7104bb642339c2fe8a466983300d4c62dc2b344 src/common/thread.hpp 9685898136b7a270f5ff53bdd3720ad717c4943d src/common/thread.cpp 751e9e83e0ed3b9e4a5e0a8396424f2ef4e8fe4b Diff: https://reviews.apache.org/r/36825/diff/ Testing --- make check. grepped for common/thread Thanks, Joris Van Remoortere
Re: Review Request 36821: Fix disable endpoints rule fails to recognize HTTP path delegates.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36821/#review93056 --- Patch looks great! Reviews applied: [36821] All tests passed. - Mesos ReviewBot On July 26, 2015, 6:14 p.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36821/ --- (Updated July 26, 2015, 6:14 p.m.) Review request for mesos. Bugs: MESOS-3143 https://issues.apache.org/jira/browse/MESOS-3143 Repository: mesos Description --- Fix disable endpoints rule fails to recognize HTTP path delegates. Diffs - 3rdparty/libprocess/include/process/firewall.hpp f92a6c5bbd4af0cab43e487b0c347c30059cf162 3rdparty/libprocess/include/process/process.hpp 8620547148f8a69d5b661eaf08063ca72347b6a4 3rdparty/libprocess/src/process.cpp 6d3609d06d017d8e50d7935b335fda7ebecbd04c Diff: https://reviews.apache.org/r/36821/diff/ Testing --- Thanks, haosdent huang
Review Request 36827: Removed and guarded pthread specifics for libevent-openssl.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36827/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael Park. Bugs: MESOS-3119 https://issues.apache.org/jira/browse/MESOS-3119 Repository: mesos Description --- See summary. Diffs - 3rdparty/libprocess/src/libevent.cpp 1f175a4ae83391152d064779c6ab69d31cbaf867 3rdparty/libprocess/src/openssl.cpp 6aa2a4db8d64011d0fde6ff0cf4b144c41949d39 Diff: https://reviews.apache.org/r/36827/diff/ Testing --- make check. Waiting on validation from someone with an OSX build Thanks, Joris Van Remoortere
Re: Review Request 36720: Add subscribe- subscribed workflow for http frameworks
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36720/#review93048
---
src/master/http.cpp (line 359)
https://reviews.apache.org/r/36720/#comment147318
Why not static initialization pattern :
OK ok = {
.type = Response::PIPE,
.reader = pipe.reader(),
};
Maybe its not allowed in the coding style but I would think it looks
elegant.
- Jojy Varghese
On July 25, 2015, 2:32 p.m., Anand Mazumdar wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36720/
---
(Updated July 25, 2015, 2:32 p.m.)
Review request for mesos and Ben Mahler.
Bugs: MESOS-2294
https://issues.apache.org/jira/browse/MESOS-2294
Repository: mesos
Description
---
Split review out of r36318. This change adds the functionality of making a
http call for subscribe and the master responding with a subscribed event on
the persistent stream.
Diffs
-
src/master/http.cpp 3a1598fad4db03e5f62fd4a6bd26b2bedeee4070
src/master/master.hpp 827d0d599912b2936beb9615610f627f6c9a2d43
src/master/master.cpp 613a011e205611702921179b6c436d62447e2dca
src/tests/http_api_tests.cpp 64bbeb6699171e85a5be293919ad9f32ded0ebac
Diff: https://reviews.apache.org/r/36720/diff/
Testing
---
make check + test.
Thanks,
Anand Mazumdar
Review Request 36820: Fixed clang warning [-Wunevaluated-expression] in process tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36820/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael Park. Repository: mesos Description --- Removes `warning: expression with side effects has no effect in an unevaluated context`. Diffs - 3rdparty/libprocess/src/tests/process_tests.cpp bc54d29235e7cf015d796f83000a136788c7df65 Diff: https://reviews.apache.org/r/36820/diff/ Testing --- Make check. Thanks, Joris Van Remoortere
Re: Review Request 36658: Updated SSL documentation. Added to home page.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36658/#review93053 --- Patch looks great! Reviews applied: [36646, 36656, 36658] All tests passed. - Mesos ReviewBot On July 26, 2015, 6:01 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36658/ --- (Updated July 26, 2015, 6:01 p.m.) Review request for mesos, Benjamin Hindman and Michael Park. Bugs: MESOS-3121 https://issues.apache.org/jira/browse/MESOS-3121 Repository: mesos Description --- See summary. Diffs - docs/home.md a02fea62360b39ed6af2025db52c06014f0a4ef2 docs/mesos-ssl.md bb218492df90c922bc4955daeca5513ba9d18633 Diff: https://reviews.apache.org/r/36658/diff/ Testing --- Thanks, Joris Van Remoortere
Re: Review Request 36754: Updated Isolator::prepare to return ContainerPrepareInfo.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36754/ --- (Updated July 26, 2015, 2:49 p.m.) Review request for mesos, Benjamin Hindman and Jie Yu. Changes --- rebased Bugs: MESOS-3133 https://issues.apache.org/jira/browse/MESOS-3133 Repository: mesos Description --- ContainerPrepareInfo contains CommandInfo as well as Environment. While the CommandInfo lists the commands to be run inside the containerized context, the Environment allows the isolator to specify environment variables for the Executor itself. Diffs (updated) - include/mesos/slave/isolator.hpp 879e03e5bf49fab507b8d9904f944d950de18987 include/mesos/slave/isolator.proto 07c1c1a09d1578dd4c3abd8bb1773782b4aa9549 src/slave/containerizer/isolator.hpp 1482b4c9fa375bdb2607bf83334b44b97024cba8 src/slave/containerizer/isolator.cpp 9d2af8b42f37550a75eae52ef1f5c1a647131072 src/slave/containerizer/isolators/cgroups/cpushare.hpp 409a3a997a7b2c7104421f48ee1078e8fd369a2a src/slave/containerizer/isolators/cgroups/cpushare.cpp ccaf1e372c0693522aed2e0aa8d680e404faf8ef src/slave/containerizer/isolators/cgroups/mem.hpp d43ba6d3debfc6279a023bd28f584635eeb79dc3 src/slave/containerizer/isolators/cgroups/mem.cpp 70c9868dbb670278b3bb4e4322598285488851fe src/slave/containerizer/isolators/cgroups/perf_event.hpp 3796b30a56799a00f1ddbec9bd20b9203d689856 src/slave/containerizer/isolators/cgroups/perf_event.cpp a62a4e6ca573230af17781495eae63115ef28f00 src/slave/containerizer/isolators/filesystem/posix.hpp 2afc572d20acb3d31d3981d99ffe6ea45ae93dff src/slave/containerizer/isolators/filesystem/posix.cpp 5e5a896d9888375259a38dcc68d03dce6406a28e src/slave/containerizer/isolators/filesystem/shared.hpp f6ba43a6d6d3a2afb9380f05de9edaa3fe3c5936 src/slave/containerizer/isolators/filesystem/shared.cpp 4694025eb9b3adad70cc1ec7541c3d3f95fec2bc src/slave/containerizer/isolators/namespaces/pid.hpp 61db386b1d6f602edcba8a1fa251cfd12a534aca src/slave/containerizer/isolators/namespaces/pid.cpp 29be94b96ed9a3db90c88a4b60517d78e95b7144 src/slave/containerizer/isolators/network/port_mapping.hpp fb9ce9c3a33d652a6e1dda3485dde0f2d914ccac src/slave/containerizer/isolators/network/port_mapping.cpp 3f35782c9e0e458169777bab778178c524a58b2b src/slave/containerizer/isolators/posix.hpp 58d9911fef6f57dd078c533221094f9c69489fe4 src/slave/containerizer/isolators/posix/disk.hpp 86aea37d0bbf5d2e5bfc32624fe084b2e73dac1a src/slave/containerizer/isolators/posix/disk.cpp 845496c865a92946910a4e9dd50d05482503b7ef src/slave/containerizer/mesos/containerizer.hpp 5155362bef9163af3fa5334be3a39b91549e1ec1 src/slave/containerizer/mesos/containerizer.cpp 11eedf30674b326ea3e1f6f71d27f9eb54126368 src/tests/containerizer/containerizer_tests.cpp a44b6e887c37e55213db068a95ab3e73a033e1ea src/tests/containerizer/isolator.hpp 8aaf88c3ea8362950e363d15cbe2b598a12f12d6 src/tests/containerizer/isolator_tests.cpp 59f08c0c175ea800ba23d85666d20b6a7b6d07d6 Diff: https://reviews.apache.org/r/36754/diff/ Testing --- make check with an added test (in the followup review). Thanks, Kapil Arya
Re: Review Request 36799: Renamed Executor{Limitation, RunState} to Container{Limitation, State}.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36799/ --- (Updated July 26, 2015, 2:49 p.m.) Review request for mesos, Benjamin Hindman and Jie Yu. Changes --- rebased Repository: mesos Description --- The new names better reflect the contents since the Limitation and State are for the container. Diffs (updated) - include/mesos/slave/isolator.hpp 879e03e5bf49fab507b8d9904f944d950de18987 include/mesos/slave/isolator.proto 07c1c1a09d1578dd4c3abd8bb1773782b4aa9549 src/common/protobuf_utils.hpp 5c992540e29143ed51fdd06b52dbde05e4136f58 src/common/protobuf_utils.cpp bf178d2942e8f5bed3d7eff44ed5929a552ecf35 src/slave/containerizer/isolator.hpp 1482b4c9fa375bdb2607bf83334b44b97024cba8 src/slave/containerizer/isolator.cpp 9d2af8b42f37550a75eae52ef1f5c1a647131072 src/slave/containerizer/isolators/cgroups/cpushare.hpp 409a3a997a7b2c7104421f48ee1078e8fd369a2a src/slave/containerizer/isolators/cgroups/cpushare.cpp ccaf1e372c0693522aed2e0aa8d680e404faf8ef src/slave/containerizer/isolators/cgroups/mem.hpp d43ba6d3debfc6279a023bd28f584635eeb79dc3 src/slave/containerizer/isolators/cgroups/mem.cpp 70c9868dbb670278b3bb4e4322598285488851fe src/slave/containerizer/isolators/cgroups/perf_event.hpp 3796b30a56799a00f1ddbec9bd20b9203d689856 src/slave/containerizer/isolators/cgroups/perf_event.cpp a62a4e6ca573230af17781495eae63115ef28f00 src/slave/containerizer/isolators/filesystem/posix.hpp 2afc572d20acb3d31d3981d99ffe6ea45ae93dff src/slave/containerizer/isolators/filesystem/posix.cpp 5e5a896d9888375259a38dcc68d03dce6406a28e src/slave/containerizer/isolators/filesystem/shared.hpp f6ba43a6d6d3a2afb9380f05de9edaa3fe3c5936 src/slave/containerizer/isolators/filesystem/shared.cpp 4694025eb9b3adad70cc1ec7541c3d3f95fec2bc src/slave/containerizer/isolators/namespaces/pid.hpp 61db386b1d6f602edcba8a1fa251cfd12a534aca src/slave/containerizer/isolators/namespaces/pid.cpp 29be94b96ed9a3db90c88a4b60517d78e95b7144 src/slave/containerizer/isolators/network/port_mapping.hpp fb9ce9c3a33d652a6e1dda3485dde0f2d914ccac src/slave/containerizer/isolators/network/port_mapping.cpp 3f35782c9e0e458169777bab778178c524a58b2b src/slave/containerizer/isolators/posix.hpp 58d9911fef6f57dd078c533221094f9c69489fe4 src/slave/containerizer/isolators/posix/disk.hpp 86aea37d0bbf5d2e5bfc32624fe084b2e73dac1a src/slave/containerizer/isolators/posix/disk.cpp 845496c865a92946910a4e9dd50d05482503b7ef src/slave/containerizer/launcher.hpp a19b8592f943d3a2ae0337c142f54c0ada204536 src/slave/containerizer/launcher.cpp ecb33309ff0941985eebf7a94d831330076978de src/slave/containerizer/linux_launcher.hpp 28a7d35d99881486a9d63eb0aaedad15cb99 src/slave/containerizer/linux_launcher.cpp ed2e881f555d651ad1e5f1b62f32848ade09b424 src/slave/containerizer/mesos/containerizer.hpp 5155362bef9163af3fa5334be3a39b91549e1ec1 src/slave/containerizer/mesos/containerizer.cpp 11eedf30674b326ea3e1f6f71d27f9eb54126368 src/slave/containerizer/provisioner.hpp f7fb068ca5b0a8da1fb756411d59536ed7a1aec8 src/tests/containerizer/containerizer_tests.cpp a44b6e887c37e55213db068a95ab3e73a033e1ea src/tests/containerizer/isolator.hpp 8aaf88c3ea8362950e363d15cbe2b598a12f12d6 src/tests/containerizer/launcher.hpp 78216e0805eadb8eb425d9d58aae1b102a7817b5 Diff: https://reviews.apache.org/r/36799/diff/ Testing --- make check Thanks, Kapil Arya
Re: Review Request 36755: Passed env vars returned by Isolator::prepare() to executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36755/ --- (Updated July 26, 2015, 2:49 p.m.) Review request for mesos, Benjamin Hindman and Jie Yu. Changes --- rebased Bugs: MESOS-3133 https://issues.apache.org/jira/browse/MESOS-3133 Repository: mesos Description --- Append the environment variables returned by Isolator::prepare() to the list of environment variables being passed to the executor. Added a test to verify that the executor is launched with the said environment variables. Diffs (updated) - src/slave/containerizer/mesos/containerizer.cpp 11eedf30674b326ea3e1f6f71d27f9eb54126368 src/tests/containerizer/containerizer_tests.cpp a44b6e887c37e55213db068a95ab3e73a033e1ea Diff: https://reviews.apache.org/r/36755/diff/ Testing --- make check with an added test. Thanks, Kapil Arya
Review Request 36826: Removed common/factory as it is not used.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36826/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael Park. Bugs: MESOS-3120 https://issues.apache.org/jira/browse/MESOS-3120 Repository: mesos Description --- See summary. Diffs - src/Makefile.am a7104bb642339c2fe8a466983300d4c62dc2b344 src/common/factory.hpp bdddcf872eae1a4ed78ca8b35864ee59bbaecb65 Diff: https://reviews.apache.org/r/36826/diff/ Testing --- make check Thanks, Joris Van Remoortere
Review Request 36830: Libprocess: Introduce configurable `UNIMPLEMENTED` macro.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36830/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joseph Wu, and Michael Park. Bugs: MESOS-3122 https://issues.apache.org/jira/browse/MESOS-3122 Repository: mesos Description --- use --enable-static-unimplemented to get compile time errors as opposed to runtime errors. Diffs - 3rdparty/libprocess/configure.ac 7d1221bd5ddfc4fa816b0bbea0be5c6b2cbb Diff: https://reviews.apache.org/r/36830/diff/ Testing --- created a function with an `UNIMPLEMENTED()` body and verified the runtime error occured when configured by default, and a compile-time error ocurred when configured with `--enable-static-unimplemented` Thanks, Joris Van Remoortere
Review Request 36829: Stout: Introduced configurable `UNIMPLEMENTED()` macro.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36829/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joseph Wu, and Michael Park. Bugs: MESOS-3122 https://issues.apache.org/jira/browse/MESOS-3122 Repository: mesos Description --- See summary. Diffs - 3rdparty/libprocess/3rdparty/stout/include/Makefile.am 5c19e3ef8ba50ab007eda26b752441f076ca7ed0 3rdparty/libprocess/3rdparty/stout/include/stout/unimplemented.hpp PRE-CREATION Diff: https://reviews.apache.org/r/36829/diff/ Testing --- requires follow-up patch. Thanks, Joris Van Remoortere
Re: Review Request 36757: Added https support.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36757/#review93049 --- Can you add (or at least make TODOs for) tests for the negative cases? http - ssl socket, https - raw socket. After the remaining open issues this should look pretty good. 3rdparty/libprocess/src/tests/ssl_tests.cpp (lines 1025 - 1029) https://reviews.apache.org/r/36757/#comment147319 You're going to get rid of this anyway, but for future reference: please use full words for variable names e.g. `responseBuffer` - Joris Van Remoortere On July 24, 2015, 5:49 p.m., Jojy Varghese wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36757/ --- (Updated July 24, 2015, 5:49 p.m.) Review request for mesos, Joris Van Remoortere and Timothy Chen. Bugs: MESOS-3093 https://issues.apache.org/jira/browse/MESOS-3093 Repository: mesos Description --- Current http implementation lacks a https interface. This change exposes SSL socket for https URL scheme. JIRA: MESOS-3093 Diffs - 3rdparty/libprocess/src/http.cpp d1685799f4c53e067d0812e037e171324ee7195f 3rdparty/libprocess/src/tests/ssl_tests.cpp 2fe50601615b0bee57bd3e05dc9c932f93ca7477 Diff: https://reviews.apache.org/r/36757/diff/ Testing --- make check Thanks, Jojy Varghese
Review Request 36821: Fix disable endpoints rule fails to recognize HTTP path delegates.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36821/ --- Review request for mesos. Bugs: MESOS-3143 https://issues.apache.org/jira/browse/MESOS-3143 Repository: mesos Description --- Fix disable endpoints rule fails to recognize HTTP path delegates. Diffs - 3rdparty/libprocess/include/process/firewall.hpp f92a6c5bbd4af0cab43e487b0c347c30059cf162 3rdparty/libprocess/include/process/process.hpp 8620547148f8a69d5b661eaf08063ca72347b6a4 3rdparty/libprocess/src/process.cpp 6d3609d06d017d8e50d7935b335fda7ebecbd04c Diff: https://reviews.apache.org/r/36821/diff/ Testing --- Thanks, haosdent huang
Review Request 36824: Used std::thread instead of pthread for ns tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36824/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael Park. Bugs: MESOS-3120 https://issues.apache.org/jira/browse/MESOS-3120 Repository: mesos Description --- See summary. Diffs - src/tests/containerizer/ns_tests.cpp c71c33fa1247d1658be91ce81c93bfffd5b282b7 Diff: https://reviews.apache.org/r/36824/diff/ Testing --- sudo ./bin/mesos-tests.sh --gtest_filter=NsTest.* Thanks, Joris Van Remoortere
Review Request 36822: Used std::thread instead of pthread for Long Lived Executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36822/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael Park. Bugs: MESOS-3120 https://issues.apache.org/jira/browse/MESOS-3120 Repository: mesos Description --- See summary. Diffs - src/examples/long_lived_executor.cpp d9b7fa1eefd1c53447244586797cb96a5c33d4f1 Diff: https://reviews.apache.org/r/36822/diff/ Testing --- make check Thanks, Joris Van Remoortere
Review Request 36823: Used std::thread instead of pthread for cgroups tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36823/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael Park. Bugs: MESOS-3120 https://issues.apache.org/jira/browse/MESOS-3120 Repository: mesos Description --- See summary. Diffs - src/tests/containerizer/cgroups_tests.cpp caecd5dfa3fef33dba35cfc1b5934a11e2cc961a Diff: https://reviews.apache.org/r/36823/diff/ Testing --- sudo ./bin/mesos-tests.sh --gtest_filter=CgroupsAnyHierarchyWithFreezerTest.* Thanks, Joris Van Remoortere
Re: Review Request 36837: Update gmock to 1.7.0 .
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/#review93066 --- Bad patch! Reviews applied: [36837] Failed command: ./support/apply-review.sh -n -r 36837 Error: 2015-07-27 03:46:17 URL:https://reviews.apache.org/r/36837/diff/raw/ [1085/1085] - 36837.patch [1] error: missing binary patch data for '3rdparty/libprocess/3rdparty/gmock-1.7.0.tar.gz' error: binary patch does not apply to '3rdparty/libprocess/3rdparty/gmock-1.7.0.tar.gz' error: 3rdparty/libprocess/3rdparty/gmock-1.7.0.tar.gz: patch does not apply Failed to apply patch - Mesos ReviewBot On July 27, 2015, 3:36 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/ --- (Updated July 27, 2015, 3:36 a.m.) Review request for mesos. Bugs: MESOS-3141 https://issues.apache.org/jira/browse/MESOS-3141 Repository: mesos Description --- Update gmock to 1.7.0 . Diffs - 3rdparty/libprocess/3rdparty/gmock-1.6.0.tar.gz d45d9894b0214f5f02a88f6da5c258327110efd8 3rdparty/libprocess/3rdparty/gmock-1.7.0.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/versions.am 97727537778511ca5a10be4f3c25cd21d919 Diff: https://reviews.apache.org/r/36837/diff/ Testing --- Thanks, haosdent huang
Re: Review Request 36837: Update gmock to 1.7.0 .
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/#review93067 --- Bad patch! Reviews applied: [36837] Failed command: ./support/apply-review.sh -n -r 36837 Error: 2015-07-27 04:06:07 URL:https://reviews.apache.org/r/36837/diff/raw/ [1085/1085] - 36837.patch [1] error: missing binary patch data for '3rdparty/libprocess/3rdparty/gmock-1.7.0.tar.gz' error: binary patch does not apply to '3rdparty/libprocess/3rdparty/gmock-1.7.0.tar.gz' error: 3rdparty/libprocess/3rdparty/gmock-1.7.0.tar.gz: patch does not apply Failed to apply patch - Mesos ReviewBot On July 27, 2015, 4:03 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/ --- (Updated July 27, 2015, 4:03 a.m.) Review request for mesos. Bugs: MESOS-3141 https://issues.apache.org/jira/browse/MESOS-3141 Repository: mesos Description --- Update gmock to 1.7.0 . Diffs - 3rdparty/libprocess/3rdparty/gmock-1.6.0.tar.gz d45d9894b0214f5f02a88f6da5c258327110efd8 3rdparty/libprocess/3rdparty/gmock-1.7.0.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/versions.am 97727537778511ca5a10be4f3c25cd21d919 Diff: https://reviews.apache.org/r/36837/diff/ Testing --- Thanks, haosdent huang
Re: Review Request 36831: Allowed Isolator::prepare to return a list of CommandInfos.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36831/#review93065 --- Patch looks great! Reviews applied: [36718, 36754, 36755, 36799, 36831] All tests passed. - Mesos ReviewBot On July 27, 2015, 12:04 a.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36831/ --- (Updated July 27, 2015, 12:04 a.m.) Review request for mesos, Benjamin Hindman and Jie Yu. Repository: mesos Description --- Previously, the Isolators had to join all the preparation commands into a single command using ``. Now they can pass each command separately. Diffs - include/mesos/slave/isolator.proto 07c1c1a09d1578dd4c3abd8bb1773782b4aa9549 src/slave/containerizer/isolators/filesystem/shared.cpp 4694025eb9b3adad70cc1ec7541c3d3f95fec2bc src/slave/containerizer/isolators/namespaces/pid.cpp 29be94b96ed9a3db90c88a4b60517d78e95b7144 src/slave/containerizer/mesos/containerizer.cpp 11eedf30674b326ea3e1f6f71d27f9eb54126368 src/tests/containerizer/containerizer_tests.cpp a44b6e887c37e55213db068a95ab3e73a033e1ea src/tests/containerizer/isolator_tests.cpp 59f08c0c175ea800ba23d85666d20b6a7b6d07d6 Diff: https://reviews.apache.org/r/36831/diff/ Testing --- make check. Thanks, Kapil Arya
Re: Review Request 36837: Update gmock to 1.7.0 .
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/ --- (Updated July 27, 2015, 3:48 a.m.) Review request for mesos. Bugs: MESOS-3141 https://issues.apache.org/jira/browse/MESOS-3141 Repository: mesos Description --- Update gmock to 1.7.0 . Diffs (updated) - 3rdparty/libprocess/3rdparty/gmock-1.6.0.tar.gz d45d9894b0214f5f02a88f6da5c258327110efd8 3rdparty/libprocess/3rdparty/gmock-1.7.0.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/versions.am 97727537778511ca5a10be4f3c25cd21d919 Diff: https://reviews.apache.org/r/36837/diff/ Testing --- Thanks, haosdent huang
Re: Review Request 36837: Update gmock to 1.7.0 .
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/ --- (Updated July 27, 2015, 4:03 a.m.) Review request for mesos. Bugs: MESOS-3141 https://issues.apache.org/jira/browse/MESOS-3141 Repository: mesos Description --- Update gmock to 1.7.0 . Diffs (updated) - 3rdparty/libprocess/3rdparty/gmock-1.6.0.tar.gz d45d9894b0214f5f02a88f6da5c258327110efd8 3rdparty/libprocess/3rdparty/gmock-1.7.0.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/versions.am 97727537778511ca5a10be4f3c25cd21d919 Diff: https://reviews.apache.org/r/36837/diff/ Testing --- Thanks, haosdent huang
Re: Review Request 36830: Libprocess: Introduce configurable `UNIMPLEMENTED` macro.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36830/#review93063 --- Patch looks great! Reviews applied: [36822, 36823, 36824, 36825, 36826, 36827, 36828, 36829, 36830] All tests passed. - Mesos ReviewBot On July 26, 2015, 9:01 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36830/ --- (Updated July 26, 2015, 9:01 p.m.) Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joseph Wu, and Michael Park. Bugs: MESOS-3122 https://issues.apache.org/jira/browse/MESOS-3122 Repository: mesos Description --- use --enable-static-unimplemented to get compile time errors as opposed to runtime errors. Diffs - 3rdparty/libprocess/configure.ac 7d1221bd5ddfc4fa816b0bbea0be5c6b2cbb Diff: https://reviews.apache.org/r/36830/diff/ Testing --- created a function with an `UNIMPLEMENTED()` body and verified the runtime error occured when configured by default, and a compile-time error ocurred when configured with `--enable-static-unimplemented` Thanks, Joris Van Remoortere
Review Request 36831: Allowed Isolator::prepare to return a list of CommandInfos.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36831/ --- Review request for mesos, Benjamin Hindman and Jie Yu. Repository: mesos Description --- Previously, the Isolators had to join all the preparation commands into a single command using ``. Now they can pass each command separately. Diffs - include/mesos/slave/isolator.proto 07c1c1a09d1578dd4c3abd8bb1773782b4aa9549 src/slave/containerizer/isolators/filesystem/shared.cpp 4694025eb9b3adad70cc1ec7541c3d3f95fec2bc src/slave/containerizer/isolators/namespaces/pid.cpp 29be94b96ed9a3db90c88a4b60517d78e95b7144 src/slave/containerizer/mesos/containerizer.cpp 11eedf30674b326ea3e1f6f71d27f9eb54126368 src/tests/containerizer/containerizer_tests.cpp a44b6e887c37e55213db068a95ab3e73a033e1ea src/tests/containerizer/isolator_tests.cpp 59f08c0c175ea800ba23d85666d20b6a7b6d07d6 Diff: https://reviews.apache.org/r/36831/diff/ Testing --- make check. Thanks, Kapil Arya
Review Request 36837: Update gmock to 1.7.0 .
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/ --- Review request for mesos. Bugs: MESOS-3141 https://issues.apache.org/jira/browse/MESOS-3141 Repository: mesos Description --- Update gmock to 1.7.0 . Diffs - 3rdparty/libprocess/3rdparty/gmock-1.6.0.tar.gz d45d9894b0214f5f02a88f6da5c258327110efd8 3rdparty/libprocess/3rdparty/gmock-1.7.0.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/versions.am 97727537778511ca5a10be4f3c25cd21d919 Diff: https://reviews.apache.org/r/36837/diff/ Testing --- Thanks, haosdent huang
Re: Review Request 36837: Update gmock to 1.7.0 .
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/ --- (Updated July 27, 2015, 4:18 a.m.) Review request for mesos. Bugs: MESOS-3141 https://issues.apache.org/jira/browse/MESOS-3141 Repository: mesos Description --- Update gmock to 1.7.0 . Diffs - 3rdparty/libprocess/3rdparty/gmock-1.6.0.tar.gz d45d9894b0214f5f02a88f6da5c258327110efd8 3rdparty/libprocess/3rdparty/gmock-1.7.0.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/versions.am 97727537778511ca5a10be4f3c25cd21d919 Diff: https://reviews.apache.org/r/36837/diff/ Testing (updated) --- make check Thanks, haosdent huang
Re: Review Request 36829: Stout: Introduced configurable `UNIMPLEMENTED()` macro.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36829/#review93077 --- Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/unimplemented.hpp (line 29) https://reviews.apache.org/r/36829/#comment147336 const? 3rdparty/libprocess/3rdparty/stout/include/stout/unimplemented.hpp (line 30) https://reviews.apache.org/r/36829/#comment147337 Perhaps I am missing something, but is it reasonable to assume that iostream will always be included before this header? 3rdparty/libprocess/3rdparty/stout/include/stout/unimplemented.hpp (line 32) https://reviews.apache.org/r/36829/#comment147338 Ditto about stdlib.h. - Artem Harutyunyan On July 26, 2015, 2 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36829/ --- (Updated July 26, 2015, 2 p.m.) Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joseph Wu, and Michael Park. Bugs: MESOS-3122 https://issues.apache.org/jira/browse/MESOS-3122 Repository: mesos Description --- See summary. Diffs - 3rdparty/libprocess/3rdparty/stout/include/Makefile.am 5c19e3ef8ba50ab007eda26b752441f076ca7ed0 3rdparty/libprocess/3rdparty/stout/include/stout/unimplemented.hpp PRE-CREATION Diff: https://reviews.apache.org/r/36829/diff/ Testing --- requires follow-up patch. Thanks, Joris Van Remoortere
Review Request 36838: Use flags.executor_shutdown_grace_period as shutdownTimeout in ShutdownProcess.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36838/ --- Review request for mesos. Repository: mesos Description --- Use flags.executor_shutdown_grace_period as shutdownTimeout in ShutdownProcess. Diffs - src/exec/exec.cpp d59a7e1df0d4786ee72b410f4fbb3b71e585b39d src/slave/containerizer/containerizer.cpp 25c87e9f948b7efe8b9a853c403bee69982d6c4c Diff: https://reviews.apache.org/r/36838/diff/ Testing --- Thanks, haosdent huang
Re: Review Request 36838: Use flags.executor_shutdown_grace_period as shutdownTimeout in ShutdownProcess.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36838/ --- (Updated July 27, 2015, 5:47 a.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-3111 https://issues.apache.org/jira/browse/MESOS-3111 Repository: mesos Description --- Use flags.executor_shutdown_grace_period as shutdownTimeout in ShutdownProcess. Diffs - src/exec/exec.cpp d59a7e1df0d4786ee72b410f4fbb3b71e585b39d src/slave/containerizer/containerizer.cpp 25c87e9f948b7efe8b9a853c403bee69982d6c4c Diff: https://reviews.apache.org/r/36838/diff/ Testing --- Thanks, haosdent huang
Re: Review Request 36819: Use setup.py in python cli package.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/#review93047 --- Patch looks great! Reviews applied: [36819] All tests passed. - Mesos ReviewBot On July 26, 2015, 2:47 p.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/ --- (Updated July 26, 2015, 2:47 p.m.) Review request for mesos. Repository: mesos Description --- Use setup.py in python cli package. Diffs - Makefile.am f8e958d376efa55ace7c5727a31b8e747403641e bin/mesos.sh.in 5cbeac4330a9f45fc6d54b8c2d383f48e4098f95 configure.ac 546c9bbf775a4ef481fafb3a58c85c6d80e19500 src/Makefile.am a7104bb642339c2fe8a466983300d4c62dc2b344 src/cli/python/mesos/__init__.py 028b0d27fb193bac96f2a6a3201ee4cc8fd369ef src/cli/python/mesos/cli.py src/cli/python/mesos/futures.py src/cli/python/mesos/http.py src/python/cli/src/mesos/__init__.py PRE-CREATION Diff: https://reviews.apache.org/r/36819/diff/ Testing --- Thanks, haosdent huang
Re: Review Request 36820: Fixed clang warning [-Wunevaluated-expression] in process tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36820/#review93051 --- Patch looks great! Reviews applied: [36820] All tests passed. - Mesos ReviewBot On July 26, 2015, 4:51 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36820/ --- (Updated July 26, 2015, 4:51 p.m.) Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael Park. Repository: mesos Description --- Removes `warning: expression with side effects has no effect in an unevaluated context`. Diffs - 3rdparty/libprocess/src/tests/process_tests.cpp bc54d29235e7cf015d796f83000a136788c7df65 Diff: https://reviews.apache.org/r/36820/diff/ Testing --- Make check. Thanks, Joris Van Remoortere
Re: Review Request 36658: Updated SSL documentation. Added to home page.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36658/ --- (Updated July 26, 2015, 6:01 p.m.) Review request for mesos, Benjamin Hindman and Michael Park. Changes --- clean up. Bugs: MESOS-3121 https://issues.apache.org/jira/browse/MESOS-3121 Repository: mesos Description --- See summary. Diffs (updated) - docs/home.md a02fea62360b39ed6af2025db52c06014f0a4ef2 docs/mesos-ssl.md bb218492df90c922bc4955daeca5513ba9d18633 Diff: https://reviews.apache.org/r/36658/diff/ Testing --- Thanks, Joris Van Remoortere
