Re: Review Request 41790: Add tests for /weights endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/#review113689 --- A good set of tests for the functionality, but I've got some

Re: Review Request 42130: WIP: Added tests for `ALLOCATION_SLACK` helper functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42130/ --- (Updated Jan. 11, 2016, 3:52 p.m.) Review request for mesos, Guangya Liu and

Review Request 42130: WIP: Added tests for `ALLOCATION_SLACK` helper functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42130/ --- Review request for mesos, Guangya Liu and Jian Qiu. Bugs: MESOS-3897

Re: Review Request 41790: Add tests for /weights endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/#review113678 --- Patch looks great! Reviews applied: [41597, 41681, 41789, 41790]

Review Request 42127: Did not rescind offer if only ALLOCATION_SLACK resources incuded.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42127/ --- Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Joris Van

Re: Review Request 42123: Enabled load qos controller use USAGE SLACK revocable resources.

> On 一月 11, 2016, 3:33 a.m., Klaus Ma wrote: > > Would you add test case for that? It seems `make check` will also pass > > without this patch :). I think that we need to update oversubscription_tests.cpp to use usageSlack() instead of revocable() to get usage slack resources which is more

Re: Review Request 41859: Launch tasks after evicting executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41859/ --- (Updated Jan. 11, 2016, 11:36 a.m.) Review request for mesos, Ben Mahler,

Review Request 42113: WIP: Handle unreserve logic for dynamic reservation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42113/ --- Review request for mesos and Klaus Ma. Repository: mesos Description ---

Re: Review Request 35711: Disallow special characters in role name.

> On Jan. 10, 2016, 3:44 p.m., Klaus Ma wrote: > > src/common/roles.cpp, line 34 > > > > > > Do we need to check whether duplicated roles here? > > Adam B wrote: > Not necessary here, since they're de-duped

Re: Review Request 42123: Enabled load qos controller use USAGE SLACK revocable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42123/ --- (Updated 一月 11, 2016, 1:56 a.m.) Review request for mesos, Ben Mahler, Artem

Review Request 42124: Updated /state to show usage slack and allocation slack resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42124/ --- Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere,

Re: Review Request 42123: Enabled load qos controller use USAGE SLACK revocable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42123/#review113670 --- Would you add test case for that? It seems `make check` will also

Re: Review Request 41820: Pulled out provisioner from linux filesystem isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41820/#review113667 --- Bad patch! Reviews applied: [41814, 41999, 41815, 41816, 41817,

Review Request 42123: Enabled load qos controller use USAGE SLACK revocable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42123/ --- Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere,

Re: Review Request 42100: Updated the jenkins build script to copy out xml testing reports.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42100/#review113669 --- Patch looks great! Reviews applied: [42100] Passed command:

Re: Review Request 42086: Updated and refactored Master::accept for Offers with InverseOffers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42086/#review113672 --- Patch looks great! Reviews applied: [42092, 42086] Passed

Re: Review Request 42123: Enabled load qos controller use USAGE SLACK revocable resources.

> On Jan. 11, 2016, 11:33 a.m., Klaus Ma wrote: > > Would you add test case for that? It seems `make check` will also pass > > without this patch :). > > Guangya Liu wrote: > I think that we need to update oversubscription_tests.cpp to use > usageSlack() instead of revocable() to get

Re: Review Request 42123: Enabled load qos controller use USAGE SLACK revocable resources.

> On 一月 11, 2016, 3:33 a.m., Klaus Ma wrote: > > Would you add test case for that? It seems `make check` will also pass > > without this patch :). > > Guangya Liu wrote: > I think that we need to update oversubscription_tests.cpp to use > usageSlack() instead of revocable() to get usage

Re: Review Request 42107: Added sample to use RETURN_ERROR_IF.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42107/#review113684 --- Patch looks great! Reviews applied: [42106, 42107] Passed

Re: Review Request 41930: Added "TeardownFramework" to ACL protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41930/#review113687 --- include/mesos/authorizer/authorizer.proto (line 62)

Re: Review Request 42127: Did not rescind offer if only ALLOCATION_SLACK resources incuded.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42127/#review113688 --- src/master/master.cpp (line 4654)

Re: Review Request 35711: Disallow special characters in role name.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/#review113644 --- Ship it! Looks good to me. We can commit this once you've

Re: Review Request 35711: Disallow special characters in role name.

> On Jan. 10, 2016, 7:44 a.m., Klaus Ma wrote: > > src/common/roles.cpp, lines 56-63 > > > > > > Just another question about the role: do we support other language, > > e.g. Chinese? If not, I'd suggest also to

Re: Review Request 41590: Modulize the containerizer interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41590/#review113662 --- src/slave/containerizer/containerizer.hpp (line 46)

Review Request 42121: Replaced `Clock::settle()` with `os::sleep` in test case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42121/ --- Review request for mesos, Ben Mahler and Joris Van Remoortere. Repository:

Re: Review Request 39802: Windows: Implemented `stout/os/windows/ls.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39802/#review113580 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/ls.hpp

Re: Review Request 37703: Add docker exec command.

> On Jan. 11, 2016, 8:16 a.m., Qian Zhang wrote: > > @haosdent, can you please let me know in which case we need to call this "docker exec" command that you added in this patch? - Qian --- This is an automatically generated e-mail. To

Re: Review Request 37703: Add docker exec command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37703/#review113664 --- src/docker/docker.cpp (line 1229)

Re: Review Request 41896: Added guide to writing highly available Mesos frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41896/ --- (Updated Jan. 11, 2016, 12:23 a.m.) Review request for mesos, Benjamin

Re: Review Request 42096: Fixed race in persistent volume tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42096/#review113666 --- Patch looks great! Reviews applied: [42096] Passed command: