Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47095/#review133296 --- Ship it! Ship It! - Guangya Liu On May 14, 2016, 4:30 p.m.,

Re: Review Request 47208: Made logic for executor path consistent across example frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47208/#review133294 --- src/examples/test_framework.cpp (line 197)

Re: Review Request 47366: Made the command executor use the adapter interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47366/#review133292 --- Ship it! Ship It! - Vinod Kone On May 13, 2016, 10:33 p.m.,

Re: Review Request 47367: Removed references to HTTP command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47367/#review133293 --- Ship it! Ship It! - Vinod Kone On May 14, 2016, 8:40 a.m.,

Re: Review Request 47365: Moved code from HTTP command executor to command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47365/#review133290 --- src/launcher/executor.cpp (line 104)

Re: Review Request 47363: Introduced a driver to v1 executor shim/adapter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47363/#review133289 --- include/mesos/v1/executor.hpp (line 38)

Re: Review Request 47364: Set env variable used to toggle executor implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47364/#review133291 --- src/slave/containerizer/containerizer.cpp (line 364)

Re: Review Request 47281: Mesos::master::allocation namespace removed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47281/#review133287 --- Patch looks great! Reviews applied: [47281] Passed command:

Re: Review Request 47209: Establish TCP connection after backing off.

> On May 14, 2016, 2:01 a.m., Qian Zhang wrote: > > src/slave/slave.cpp, line 1020 > > > > > > If we do the link here, that means we still establish TCP connection > > with master right after a new master is

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47095/#review133285 --- Patch looks great! Reviews applied: [47095] Passed command:

Re: Review Request 47281: Mesos::master::allocation namespace removed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47281/ --- (Updated May 14, 2016, 6:25 p.m.) Review request for mesos and haosdent huang.

Re: Review Request 38146: Added missing colon in modules.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38146/#review133284 --- Patch looks great! Reviews applied: [38146] Passed command:

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

> On May 14, 2016, 2:30 p.m., Guangya Liu wrote: > > src/tests/containerizer/provisioner_docker_tests.cpp, lines 606-609 > > > > > > It seems a bit confuse for me: You are setting shell as false above, > > but here

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47095/ --- (Updated May 14, 2016, 4:30 p.m.) Review request for mesos, Guangya Liu and

Re: Review Request 47324: Update leveldb to 1.18.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47324/#review133278 --- Patch looks great! Reviews applied: [47324] Passed command:

Review Request 38146: Added missing colon in modules.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38146/ --- Review request for mesos and Alexander Rukletsov. Summary (updated)

Re: Review Request 47324: Update leveldb to 1.18.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47324/ --- (Updated May 14, 2016, 3:01 p.m.) Review request for mesos, Bing Li, Benjamin

Re: Review Request 47324: Upgrade leveldb to 1.18.

> On May 14, 2016, 10:11 a.m., haosdent huang wrote: > > I suggest to change Summary and Description to `Upgrade leveldb to 1.18 to > > suport s390x.` > > Tomasz Janiszewski wrote: > Fixed. Actually I need it to fix replica log provlems on ARM Cool! And thhe description have a 72

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47095/#review133273 --- src/tests/containerizer/mesos_containerizer_tests.cpp (line

Re: Review Request 47391: Stout: Removed warning in Windows implementation of `stat.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47391/#review133274 --- Patch looks great! Reviews applied: [47052, 47053, 47221, 47054,

Re: Review Request 47360: Updated dynamic reservation and persistent volume docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47360/#review133272 --- docs/persistent-volume.md (line 96)

Re: Review Request 47324: Upgrade leveldb to 1.18.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47324/ --- (Updated May 14, 2016, 1:46 p.m.) Review request for mesos, Bing Li, Benjamin

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47095/#review133269 --- Patch looks great! Reviews applied: [47095] Passed command:

Review Request 47391: Stout: Removed warning in Windows implementation of `stat.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47391/ --- Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van

Review Request 47390: Stout: Removed implicit conversions in `permissions.hpp` on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47390/ --- Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van

Review Request 47386: Stout: Implemented `setHostname` on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47386/ --- Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van

Review Request 47389: Stout: Added support for correct path delimiters in Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47389/ --- Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van

Re: Review Request 47281: Mesos::master::allocation namespace removed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47281/#review133265 --- src/local/local.cpp (line 93)

Re: Review Request 47324: Update leveldb.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47324/#review133264 --- Patch looks great! Reviews applied: [47324] Passed command:

Re: Review Request 47324: Update leveldb.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47324/#review133263 --- I suggest to change Summary and Description to `Upgrade leveldb

Re: Review Request 47381: Fixed agent to properly handle killTask of unregistered executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47381/#review133260 --- Patch looks great! Reviews applied: [47381] Passed command:

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47095/ --- (Updated May 14, 2016, 8:55 a.m.) Review request for mesos, Guangya Liu and

Re: Review Request 47367: Removed references to HTTP command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47367/ --- (Updated May 14, 2016, 8:40 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 47363: Introduced a driver to v1 executor shim/adapter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47363/ --- (Updated May 14, 2016, 8:39 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 46498: Add runtime for Appc Spec ex: command, workingdir and environment.

> On 五月 12, 2016, 11:44 p.m., Jojy Varghese wrote: > > Srinivas, thanks for taking this on. It looks like you combined your > > previous patches (https://reviews.apache.org/r/46107) here. I would advice > > you to split this patch into 2: > > - Protobuf changes > > - Other changes > > > >

Re: Review Request 46498: Add runtime for Appc Spec ex: command, workingdir and environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46498/#review133256 --- Some early comments, can you please split this to small patches?

Re: Review Request 44839: Enabled mesos containerizer force_pull_image for appc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44839/#review133255 --- Patch looks great! Reviews applied: [44837, 44838, 44839]

Re: Review Request 47324: Update leveldb.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47324/ --- (Updated May 14, 2016, 7:33 a.m.) Review request for mesos, Bing Li, Benjamin

Re: Review Request 47360: Updated dynamic reservation and persistent volume docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47360/#review133252 --- Patch looks great! Reviews applied: [47359, 47360] Passed