-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47095/#review133273
-----------------------------------------------------------




src/tests/containerizer/mesos_containerizer_tests.cpp (line 1064)
<https://reviews.apache.org/r/47095/#comment197566>

    s/roots/rootfs



src/tests/containerizer/mesos_containerizer_tests.cpp (line 1107)
<https://reviews.apache.org/r/47095/#comment197567>

    s/roots/rootfs



src/tests/containerizer/provisioner_docker_tests.cpp (line 604)
<https://reviews.apache.org/r/47095/#comment197564>

    Can you please add some comments here to clairfy why setting the shell as 
false?
    
    // NOTE: We use a non-shell command here because 'sh' might not be
    // in the PATH. 'alpine' does not specify env PATH in the image. On
    // some linux distribution, '/bin' is not in the PATH by default.



src/tests/containerizer/provisioner_docker_tests.cpp (lines 606 - 609)
<https://reviews.apache.org/r/47095/#comment197565>

    It seems a bit confuse for me: You are setting shell as false above, but 
here for the command using shell again.
    
    I try to update code as following:
    CommandInfo command;
    command.set_shell(false);
    command.set_value("/bin/echo");
    command.add_arguments("echo");
    command.add_arguments("-n");
    command.add_arguments("$MESOS_SANDBOX > $MESOS_SANDBOX/env.txt");
    
    But test failed, seems the env.txt was not generated:
    I0514 10:16:05.751787 21127 master.cpp:6827] Removing task 
d9820712-987a-4a7b-997a-498d38a95c60 with resources cpus(*):1; mem(*):128 of 
framework a40a88ba-f3cb-45ad-95b8-a1892f583495-0000 on agent 
a40a88ba-f3cb-45ad-95b8-a1892f583495-S0 at slave(1)@9.21.51.124:52999 
(mesos-24.eng.platformlab.ibm.com)
    ../../src/tests/containerizer/provisioner_docker_tests.cpp:654: Failure
    os::read(envfile): Failed to open file 
'/tmp/ProvisionerSandboxTest_ROOT_INTERNET_CURL_MesosSandboxEnv_IxqEbu/slaves/a40a88ba-f3cb-45ad-95b8-a1892f583495-S0/frameworks/a40a88ba-f3cb-45ad-95b8-a1892f583495-0000/executors/d9820712-987a-4a7b-997a-498d38a95c60/runs/latest/env.txt':
 No such file or directory
    
    Do you know why?


- Guangya Liu


On May 14, 2016, 8:55 a.m., Shuai Lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47095/
> -----------------------------------------------------------
> 
> (Updated May 14, 2016, 8:55 a.m.)
> 
> 
> Review request for mesos, Guangya Liu and Jie Yu.
> 
> 
> Bugs: MESOS-5312
>     https://issues.apache.org/jira/browse/MESOS-5312
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added tests for MESOS_SANDBOX env for unified containerizer.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 09742ff21513dc2570684d384b257868dd57a9ce 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 69505c922617273effc2eb52b0c567a3c01bf640 
> 
> Diff: https://reviews.apache.org/r/47095/diff/
> 
> 
> Testing
> -------
> 
> "make check" on ubuntu 14.04 64bit with gcc 4.8.4
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Reply via email to