date:20160514

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

2016-05-14 Thread Guangya Liu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47095/#review133296
---


Ship it!




Ship It!

- Guangya Liu


On May 14, 2016, 4:30 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47095/
> ---
> 
> (Updated May 14, 2016, 4:30 p.m.)
> 
> 
> Review request for mesos, Guangya Liu and Jie Yu.
> 
> 
> Bugs: MESOS-5312
> https://issues.apache.org/jira/browse/MESOS-5312
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for MESOS_SANDBOX env for unified containerizer.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 09742ff21513dc2570684d384b257868dd57a9ce 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 69505c922617273effc2eb52b0c567a3c01bf640 
> 
> Diff: https://reviews.apache.org/r/47095/diff/
> 
> 
> Testing
> ---
> 
> "make check" on ubuntu 14.04 64bit with gcc 4.8.4
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 47208: Made logic for executor path consistent across example frameworks.

2016-05-14 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47208/#review133294
---




src/examples/test_framework.cpp (line 197)


This was added by jpeach for making tests run from the installation 
directory, IIRC. Does this not break that?


- Vinod Kone


On May 11, 2016, 12:44 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47208/
> ---
> 
> (Updated May 11, 2016, 12:44 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This trivial change makes the logic for retrieving the path to
> the executor consistent across all example frameworks.
> - The test framework was using the `MESOS_HELPER_DIR` while
> other examples used to rely on `MESOS_BUILD_DIR`.
> - The test HTTP framework used to append `src` to the executor
> path that is not needed strictly. The other examples don't do it.
> 
> 
> Diffs
> -
> 
>   src/examples/test_framework.cpp 79113fbe47fda0912f0b01dc10429495a96ba8b8 
>   src/examples/test_http_framework.cpp 
> db0463d894e9f2fb964781d16f8c622ce8a507a5 
> 
> Diff: https://reviews.apache.org/r/47208/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 47366: Made the command executor use the adapter interface.

2016-05-14 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47366/#review133292
---


Ship it!




Ship It!

- Vinod Kone


On May 13, 2016, 10:33 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47366/
> ---
> 
> (Updated May 13, 2016, 10:33 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5302
> https://issues.apache.org/jira/browse/MESOS-5302
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change adds support to the command executor to toggle
> between the driver based adapter/v1 API based on the
> `MESOS_HTTP_COMMAND_EXECUTOR` environment variable
> set by the agent.
> 
> 
> Diffs
> -
> 
>   src/launcher/executor.cpp 7d111e668e0a139a98bdeb959997843180b40452 
> 
> Diff: https://reviews.apache.org/r/47366/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 47367: Removed references to HTTP command executor.

2016-05-14 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47367/#review133293
---


Ship it!




Ship It!

- Vinod Kone


On May 14, 2016, 8:40 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47367/
> ---
> 
> (Updated May 14, 2016, 8:40 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5302
> https://issues.apache.org/jira/browse/MESOS-5302
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am ce5245883f3d2661812272702c0d2060513b6d88 
>   src/launcher/http_command_executor.cpp 
> f78d7988e4be0ee05b75c49c9e04bab58d0916db 
>   src/slave/slave.cpp 7c870396b4d6804bfda6169d76d136e95cd839f5 
> 
> Diff: https://reviews.apache.org/r/47367/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 47365: Moved code from HTTP command executor to command executor.

2016-05-14 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47365/#review133290
---




src/launcher/executor.cpp (line 104)


s/HttpCommandExecutor/CommandExecutor/


- Vinod Kone


On May 13, 2016, 10:33 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47365/
> ---
> 
> (Updated May 13, 2016, 10:33 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5302
> https://issues.apache.org/jira/browse/MESOS-5302
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change makes reviewing code later in the chain easier.
> Later in the chain, we would make this use the Shim/Adapter
> to toggle between using the driver or the v1 API via an
> environment variable. `http_command_executor.cpp` would
> be deleted.
> 
> 
> Diffs
> -
> 
>   src/launcher/executor.cpp 7d111e668e0a139a98bdeb959997843180b40452 
> 
> Diff: https://reviews.apache.org/r/47365/diff/
> 
> 
> Testing
> ---
> 
> make check
> (this should not be committed on its own)
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 47363: Introduced a driver to v1 executor shim/adapter.

2016-05-14 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47363/#review133289
---




include/mesos/v1/executor.hpp (line 38)


We don't name our interfaces as *Interface :) Is there an alternative name 
we could use? 

Also, I'm curious to know why you used inheritance instead of composition. 
For example, the Mesos class itself could take a parameter which tells it use 
V1 or V0 API.



include/mesos/v1/executor.hpp (line 74)


use the override keyword here?



src/executor/v0_v1executor.hpp (lines 45 - 71)


do you want to use the override keywords here as well?



src/executor/v0_v1executor.hpp (line 75)


Any reason why the driver is not a part of the V0ToV1AdapterProcess ?



src/executor/v0_v1executor.cpp (lines 66 - 67)


why did you need to make a copy?



src/executor/v0_v1executor.cpp (lines 106 - 107)


hmm. this seems like a bug. we should fix the driver!



src/executor/v0_v1executor.cpp (line 173)


why did you pull it out instead of doing it inside the case statement?



src/executor/v0_v1executor.cpp (line 234)


s/pendingEvents/pending/


- Vinod Kone


On May 14, 2016, 8:39 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47363/
> ---
> 
> (Updated May 14, 2016, 8:39 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5302
> https://issues.apache.org/jira/browse/MESOS-5302
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change adds a driver to v1 executor shim/adapter. This can
> be used by the command executor/docker executor to toggle
> between using the new/old API instead of duplicating the
> code like we did with `http_command_executor.cpp`.
> 
> 
> Diffs
> -
> 
>   include/mesos/v1/executor.hpp adca287be3bb88c8b3298705740cb6bcbb3a09f0 
>   src/Makefile.am ce5245883f3d2661812272702c0d2060513b6d88 
>   src/executor/v0_v1executor.hpp PRE-CREATION 
>   src/executor/v0_v1executor.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47363/diff/
> 
> 
> Testing
> ---
> 
> make check (Later in the chain, we make the command executor use this 
> interface)
> So the existing tests should be able to test this out.
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 47364: Set env variable used to toggle executor implementation.

2016-05-14 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47364/#review133291
---




src/slave/containerizer/containerizer.cpp (line 364)


How about

MESOS_HTTP_API

Also, should this be only set if it's a command executor?


- Vinod Kone


On May 13, 2016, 10:34 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47364/
> ---
> 
> (Updated May 13, 2016, 10:34 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5063
> https://issues.apache.org/jira/browse/MESOS-5063
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change adds the environment variable that is set by
> the agent allowing the command executor to toggle between
> implementations.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/containerizer.cpp 
> d0cae79834e451594d7675f00c5f7d2d2cd3a264 
> 
> Diff: https://reviews.apache.org/r/47364/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 47281: Mesos::master::allocation namespace removed.

2016-05-14 Thread Mesos ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47281/#review133287
---



Patch looks great!

Reviews applied: [47281]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 14, 2016, 6:25 p.m., Jose Guilherme Vanz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47281/
> ---
> 
> (Updated May 14, 2016, 6:25 p.m.)
> 
> 
> Review request for mesos and haosdent huang.
> 
> 
> Bugs: MESOS-2516
> https://issues.apache.org/jira/browse/MESOS-2516
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> To keep consistence with the rest of the codebase, the allocation
> namespace has been removed from mesos::master namespace. To not
> pollute the master namespace, sorters have been moved to the new
> mesos::master::sorter namespace
> 
> MESOS-2516
> 
> 
> Diffs
> -
> 
>   docs/allocation-module.md 651f0a232426f537f7a1f3dbd96b0f24b60d695f 
>   include/mesos/master/allocator.hpp a4743c5a31b18d96722a42d526bfb669d30e6e48 
>   include/mesos/module/allocator.hpp 5e65e69b6d62611f51e85aa9adaa283713896d4c 
>   src/examples/test_allocator_module.cpp 
> 1255a4a22a9d1a5724bef78dfc4dee498ed50fff 
>   src/local/local.hpp f4ae285edc30a0fb1c960d50dfb1a859b2eae166 
>   src/local/local.cpp 352f4239cbcb6834b57295b86a57e41ff2798497 
>   src/master/allocator/allocator.cpp 8e76a3a33efd896a21960b0092dfdee800d211f5 
>   src/master/allocator/mesos/allocator.hpp 
> 64bce0fb143b109c26f923cd97d5facb393dee9d 
>   src/master/allocator/mesos/hierarchical.hpp 
> 3f5dff72945bf81fda4e5bc9b11edfba40cced9d 
>   src/master/allocator/mesos/hierarchical.cpp 
> 51125bac62735879f66234765dad92a759f6724b 
>   src/master/allocator/mesos/metrics.hpp 
> 06fdd1633f63c005230e1cc5fafdad358a0ac254 
>   src/master/allocator/mesos/metrics.cpp 
> a36d21c297160bc1c9f43a22743fd5448d7ae5ac 
>   src/master/allocator/sorter/drf/metrics.hpp 
> 61568cb520826ab59d675824b212e0d3deb63764 
>   src/master/allocator/sorter/drf/metrics.cpp 
> c793f3216287fd40998a1d4aab016d55aa1ac151 
>   src/master/allocator/sorter/drf/sorter.hpp 
> 05d5205d29ad74e01e07c508d88b6f8371541513 
>   src/master/allocator/sorter/drf/sorter.cpp 
> 4306973277b9d32356eed31ceabac09fb2a03e6c 
>   src/master/allocator/sorter/sorter.hpp 
> 9e04adf54f2d80541a95f0a9a49b329dc9e8f5e3 
>   src/master/main.cpp 172c0992a00700c0addf4d1faddb2d449eca736f 
>   src/master/master.hpp 380be95c0e861100680c5906b589049d56463766 
>   src/master/master.cpp 9205b3c50f655c7f5d617949320abdf47e7fb6a2 
>   src/tests/allocator.hpp 4081193abed29b99f60254e98ef9ebc981bde859 
>   src/tests/cluster.hpp c93f0526382360bf0bf2dcca7aca48ded2dc5828 
>   src/tests/cluster.cpp c03e053ffdc708792905b2d494402733928d6589 
>   src/tests/fault_tolerance_tests.cpp 
> c39a0ccf8fa124b2c230864f3ba1f7e8e05b36dc 
>   src/tests/hierarchical_allocator_tests.cpp 
> d75df737d2a62c77176cc02fc47362943c29b551 
>   src/tests/http_fault_tolerance_tests.cpp 
> baa07395b9bd588daa5438369954584787d7952a 
>   src/tests/master_allocator_tests.cpp 
> ec46913e7fed4bc8cda68ff20d04d6714ecb644d 
>   src/tests/master_authorization_tests.cpp 
> 5c221f059585d49be5848bc0b655adab6b02 
>   src/tests/master_maintenance_tests.cpp 
> 971c4473acbec5206614f46f51b06b3460595d50 
>   src/tests/master_tests.cpp 25c3559f2ac0112137c56efe423ba828fd2b2157 
>   src/tests/mesos.hpp 79bf1ff16412ce2a510a9b75ab1ac91c1c182653 
>   src/tests/mesos.cpp 849e656c8b85304cccecc9d7b9d9116884132244 
>   src/tests/partition_tests.cpp 3ec51cedcea9c7ed5cf41e9e0087fc044c85d2f1 
>   src/tests/rate_limiting_tests.cpp 5d68ac170cb5a948df1429ffbf8e5b8f02f708d9 
>   src/tests/reservation_tests.cpp 2d7fb21e2fe153c2b62dfd60bbaccb350a157391 
>   src/tests/resource_offers_tests.cpp 
> 046adaedf9121655f377f503bb30437803bf0005 
>   src/tests/scheduler_driver_tests.cpp 
> 217185780e3576faf633dd9629ae93a275fac284 
>   src/tests/scheduler_tests.cpp d9cc3fde0caeadb16164e68ed66be098fd3ada7c 
>   src/tests/slave_recovery_tests.cpp 70fdd0dae4ada1ccbdbc809c7e805d9738346b02 
>   src/tests/sorter_tests.cpp eb207a36c18198588cd8a98b3860a66c2ff7a641 
> 
> Diff: https://reviews.apache.org/r/47281/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jose Guilherme Vanz
> 
>

Re: Review Request 47209: Establish TCP connection after backing off.

2016-05-14 Thread Cong Wang



> On May 14, 2016, 2:01 a.m., Qian Zhang wrote:
> > src/slave/slave.cpp, line 1020
> > 
> >
> > If we do the link here, that means we still establish TCP connection 
> > with master right after a new master is detected, right? But I think we 
> > want to do the link after the initial backoff to avoid SYN flood.

Authentication code path doesn't have a backoff, so we don't want to touch it 
in this patch.


- Cong


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47209/#review133243
---


On May 13, 2016, 3:37 a.m., David Robinson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47209/
> ---
> 
> (Updated May 13, 2016, 3:37 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Ian Downes, and Cong Wang.
> 
> 
> Bugs: MESOS-5330
> https://issues.apache.org/jira/browse/MESOS-5330
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Establish TCP connection after backing off.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp 116ea59b72950db4a7cd721b7ba5bfbb2e1c1454 
> 
> Diff: https://reviews.apache.org/r/47209/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Also started a master and agent and captured a tcpdump to verify the 
> connection is only established _after_ the registration backoff.
> 
> 
> Thanks,
> 
> David Robinson
> 
>

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

2016-05-14 Thread Mesos ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47095/#review133285
---



Patch looks great!

Reviews applied: [47095]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 14, 2016, 4:30 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47095/
> ---
> 
> (Updated May 14, 2016, 4:30 p.m.)
> 
> 
> Review request for mesos, Guangya Liu and Jie Yu.
> 
> 
> Bugs: MESOS-5312
> https://issues.apache.org/jira/browse/MESOS-5312
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for MESOS_SANDBOX env for unified containerizer.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 09742ff21513dc2570684d384b257868dd57a9ce 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 69505c922617273effc2eb52b0c567a3c01bf640 
> 
> Diff: https://reviews.apache.org/r/47095/diff/
> 
> 
> Testing
> ---
> 
> "make check" on ubuntu 14.04 64bit with gcc 4.8.4
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 47281: Mesos::master::allocation namespace removed.

2016-05-14 Thread Jose Guilherme Vanz


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47281/
---

(Updated May 14, 2016, 6:25 p.m.)


Review request for mesos and haosdent huang.


Bugs: MESOS-2516
https://issues.apache.org/jira/browse/MESOS-2516


Repository: mesos


Description
---

To keep consistence with the rest of the codebase, the allocation
namespace has been removed from mesos::master namespace. To not
pollute the master namespace, sorters have been moved to the new
mesos::master::sorter namespace

MESOS-2516


Diffs (updated)
-

  docs/allocation-module.md 651f0a232426f537f7a1f3dbd96b0f24b60d695f 
  include/mesos/master/allocator.hpp a4743c5a31b18d96722a42d526bfb669d30e6e48 
  include/mesos/module/allocator.hpp 5e65e69b6d62611f51e85aa9adaa283713896d4c 
  src/examples/test_allocator_module.cpp 
1255a4a22a9d1a5724bef78dfc4dee498ed50fff 
  src/local/local.hpp f4ae285edc30a0fb1c960d50dfb1a859b2eae166 
  src/local/local.cpp 352f4239cbcb6834b57295b86a57e41ff2798497 
  src/master/allocator/allocator.cpp 8e76a3a33efd896a21960b0092dfdee800d211f5 
  src/master/allocator/mesos/allocator.hpp 
64bce0fb143b109c26f923cd97d5facb393dee9d 
  src/master/allocator/mesos/hierarchical.hpp 
3f5dff72945bf81fda4e5bc9b11edfba40cced9d 
  src/master/allocator/mesos/hierarchical.cpp 
51125bac62735879f66234765dad92a759f6724b 
  src/master/allocator/mesos/metrics.hpp 
06fdd1633f63c005230e1cc5fafdad358a0ac254 
  src/master/allocator/mesos/metrics.cpp 
a36d21c297160bc1c9f43a22743fd5448d7ae5ac 
  src/master/allocator/sorter/drf/metrics.hpp 
61568cb520826ab59d675824b212e0d3deb63764 
  src/master/allocator/sorter/drf/metrics.cpp 
c793f3216287fd40998a1d4aab016d55aa1ac151 
  src/master/allocator/sorter/drf/sorter.hpp 
05d5205d29ad74e01e07c508d88b6f8371541513 
  src/master/allocator/sorter/drf/sorter.cpp 
4306973277b9d32356eed31ceabac09fb2a03e6c 
  src/master/allocator/sorter/sorter.hpp 
9e04adf54f2d80541a95f0a9a49b329dc9e8f5e3 
  src/master/main.cpp 172c0992a00700c0addf4d1faddb2d449eca736f 
  src/master/master.hpp 380be95c0e861100680c5906b589049d56463766 
  src/master/master.cpp 9205b3c50f655c7f5d617949320abdf47e7fb6a2 
  src/tests/allocator.hpp 4081193abed29b99f60254e98ef9ebc981bde859 
  src/tests/cluster.hpp c93f0526382360bf0bf2dcca7aca48ded2dc5828 
  src/tests/cluster.cpp c03e053ffdc708792905b2d494402733928d6589 
  src/tests/fault_tolerance_tests.cpp c39a0ccf8fa124b2c230864f3ba1f7e8e05b36dc 
  src/tests/hierarchical_allocator_tests.cpp 
d75df737d2a62c77176cc02fc47362943c29b551 
  src/tests/http_fault_tolerance_tests.cpp 
baa07395b9bd588daa5438369954584787d7952a 
  src/tests/master_allocator_tests.cpp ec46913e7fed4bc8cda68ff20d04d6714ecb644d 
  src/tests/master_authorization_tests.cpp 
5c221f059585d49be5848bc0b655adab6b02 
  src/tests/master_maintenance_tests.cpp 
971c4473acbec5206614f46f51b06b3460595d50 
  src/tests/master_tests.cpp 25c3559f2ac0112137c56efe423ba828fd2b2157 
  src/tests/mesos.hpp 79bf1ff16412ce2a510a9b75ab1ac91c1c182653 
  src/tests/mesos.cpp 849e656c8b85304cccecc9d7b9d9116884132244 
  src/tests/partition_tests.cpp 3ec51cedcea9c7ed5cf41e9e0087fc044c85d2f1 
  src/tests/rate_limiting_tests.cpp 5d68ac170cb5a948df1429ffbf8e5b8f02f708d9 
  src/tests/reservation_tests.cpp 2d7fb21e2fe153c2b62dfd60bbaccb350a157391 
  src/tests/resource_offers_tests.cpp 046adaedf9121655f377f503bb30437803bf0005 
  src/tests/scheduler_driver_tests.cpp 217185780e3576faf633dd9629ae93a275fac284 
  src/tests/scheduler_tests.cpp d9cc3fde0caeadb16164e68ed66be098fd3ada7c 
  src/tests/slave_recovery_tests.cpp 70fdd0dae4ada1ccbdbc809c7e805d9738346b02 
  src/tests/sorter_tests.cpp eb207a36c18198588cd8a98b3860a66c2ff7a641 

Diff: https://reviews.apache.org/r/47281/diff/


Testing
---


Thanks,

Jose Guilherme Vanz

Re: Review Request 38146: Added missing colon in modules.md.

2016-05-14 Thread Mesos ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38146/#review133284
---



Patch looks great!

Reviews applied: [38146]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 14, 2016, 3:16 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38146/
> ---
> 
> (Updated May 14, 2016, 3:16 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added missing colon in modules.md.
> 
> 
> Diffs
> -
> 
>   docs/modules.md 28eb233a30b844b302fd95c03e4ff6647355cdfa 
> 
> Diff: https://reviews.apache.org/r/38146/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

2016-05-14 Thread Shuai Lin



> On May 14, 2016, 2:30 p.m., Guangya Liu wrote:
> > src/tests/containerizer/provisioner_docker_tests.cpp, lines 606-609
> > 
> >
> > It seems a bit confuse for me: You are setting shell as false above, 
> > but here for the command using shell again.
> > 
> > I try to update code as following:
> > CommandInfo command;
> > command.set_shell(false);
> > command.set_value("/bin/echo");
> > command.add_arguments("echo");
> > command.add_arguments("-n");
> > command.add_arguments("$MESOS_SANDBOX > $MESOS_SANDBOX/env.txt");
> > 
> > But test failed, seems the env.txt was not generated:
> > I0514 10:16:05.751787 21127 master.cpp:6827] Removing task 
> > d9820712-987a-4a7b-997a-498d38a95c60 with resources cpus(*):1; mem(*):128 
> > of framework a40a88ba-f3cb-45ad-95b8-a1892f583495- on agent 
> > a40a88ba-f3cb-45ad-95b8-a1892f583495-S0 at slave(1)@9.21.51.124:52999 
> > (mesos-24.eng.platformlab.ibm.com)
> > ../../src/tests/containerizer/provisioner_docker_tests.cpp:654: Failure
> > os::read(envfile): Failed to open file 
> > '/tmp/ProvisionerSandboxTest_ROOT_INTERNET_CURL_MesosSandboxEnv_IxqEbu/slaves/a40a88ba-f3cb-45ad-95b8-a1892f583495-S0/frameworks/a40a88ba-f3cb-45ad-95b8-a1892f583495-/executors/d9820712-987a-4a7b-997a-498d38a95c60/runs/latest/env.txt':
> >  No such file or directory
> > 
> > Do you know why?

Because we need to redirect the output to the `env.txt` file. To do that we 
need a shell :)


- Shuai


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47095/#review133273
---


On May 14, 2016, 4:30 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47095/
> ---
> 
> (Updated May 14, 2016, 4:30 p.m.)
> 
> 
> Review request for mesos, Guangya Liu and Jie Yu.
> 
> 
> Bugs: MESOS-5312
> https://issues.apache.org/jira/browse/MESOS-5312
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for MESOS_SANDBOX env for unified containerizer.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 09742ff21513dc2570684d384b257868dd57a9ce 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 69505c922617273effc2eb52b0c567a3c01bf640 
> 
> Diff: https://reviews.apache.org/r/47095/diff/
> 
> 
> Testing
> ---
> 
> "make check" on ubuntu 14.04 64bit with gcc 4.8.4
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

2016-05-14 Thread Shuai Lin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47095/
---

(Updated May 14, 2016, 4:30 p.m.)


Review request for mesos, Guangya Liu and Jie Yu.


Changes
---

Address gyliu's comments.


Bugs: MESOS-5312
https://issues.apache.org/jira/browse/MESOS-5312


Repository: mesos


Description
---

Added tests for MESOS_SANDBOX env for unified containerizer.


Diffs (updated)
-

  src/tests/containerizer/mesos_containerizer_tests.cpp 
09742ff21513dc2570684d384b257868dd57a9ce 
  src/tests/containerizer/provisioner_docker_tests.cpp 
69505c922617273effc2eb52b0c567a3c01bf640 

Diff: https://reviews.apache.org/r/47095/diff/


Testing
---

"make check" on ubuntu 14.04 64bit with gcc 4.8.4


Thanks,

Shuai Lin

Re: Review Request 47324: Update leveldb to 1.18.

2016-05-14 Thread Mesos ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47324/#review133278
---



Patch looks great!

Reviews applied: [47324]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 14, 2016, 3:01 p.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47324/
> ---
> 
> (Updated May 14, 2016, 3:01 p.m.)
> 
> 
> Review request for mesos, Bing Li, Benjamin Mahler, Zhiwei Chen, and haosdent 
> huang.
> 
> 
> Bugs: MESOS-970
> https://issues.apache.org/jira/browse/MESOS-970
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Leveldb in modern version is required to support s390x.
> It's also required to replace default byte-wise comparator
> with varint comparator in `src/log/leveldb.cpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/cmake/Versions.cmake 86c51edb3aa2daf6451459aaf18278f09b91b000 
>   3rdparty/leveldb-1.18.patch PRE-CREATION 
>   3rdparty/leveldb-1.18.tar.gz PRE-CREATION 
>   3rdparty/leveldb-1.4.patch b899f0141d633b1ffb2321e573395256fc893b16 
>   3rdparty/leveldb-1.4.tar.gz 2ddbc0c2e02054406ff0ea43ddc10d14979de8d8 
>   3rdparty/versions.am 7dcd6bf914de3213755ec9d4e701a190750424e9 
>   LICENSE eb39f6d69a165f59c00e8bb0ba9e15be8c958a5b 
>   src/python/native_common/ext_modules.py.in 
> 2d4a45efa224b32f80ace4542a00062c5ccb06d5 
> 
> Diff: https://reviews.apache.org/r/47324/diff/
> 
> 
> Testing
> ---
> 
> Tested on Ubuntu amd_64 need to test on PPC
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Review Request 38146: Added missing colon in modules.md.

2016-05-14 Thread Guangya Liu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38146/
---

Review request for mesos and Alexander Rukletsov.


Summary (updated)
-

Added missing colon in modules.md.


Repository: mesos


Description (updated)
---

Added missing colon in modules.md.


Diffs (updated)
-

  docs/modules.md 28eb233a30b844b302fd95c03e4ff6647355cdfa 

Diff: https://reviews.apache.org/r/38146/diff/


Testing
---


Thanks,

Guangya Liu

Re: Review Request 47324: Update leveldb to 1.18.

2016-05-14 Thread Tomasz Janiszewski


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47324/
---

(Updated May 14, 2016, 3:01 p.m.)


Review request for mesos, Bing Li, Benjamin Mahler, Zhiwei Chen, and haosdent 
huang.


Summary (updated)
-

Update leveldb to 1.18.


Bugs: MESOS-970
https://issues.apache.org/jira/browse/MESOS-970


Repository: mesos


Description (updated)
---

Leveldb in modern version is required to support s390x.
It's also required to replace default byte-wise comparator
with varint comparator in `src/log/leveldb.cpp`.


Diffs (updated)
-

  3rdparty/cmake/Versions.cmake 86c51edb3aa2daf6451459aaf18278f09b91b000 
  3rdparty/leveldb-1.18.patch PRE-CREATION 
  3rdparty/leveldb-1.18.tar.gz PRE-CREATION 
  3rdparty/leveldb-1.4.patch b899f0141d633b1ffb2321e573395256fc893b16 
  3rdparty/leveldb-1.4.tar.gz 2ddbc0c2e02054406ff0ea43ddc10d14979de8d8 
  3rdparty/versions.am 7dcd6bf914de3213755ec9d4e701a190750424e9 
  LICENSE eb39f6d69a165f59c00e8bb0ba9e15be8c958a5b 
  src/python/native_common/ext_modules.py.in 
2d4a45efa224b32f80ace4542a00062c5ccb06d5 

Diff: https://reviews.apache.org/r/47324/diff/


Testing
---

Tested on Ubuntu amd_64 need to test on PPC


Thanks,

Tomasz Janiszewski

Re: Review Request 47324: Upgrade leveldb to 1.18.

2016-05-14 Thread haosdent huang



> On May 14, 2016, 10:11 a.m., haosdent huang wrote:
> > I suggest to change Summary and Description to `Upgrade leveldb to 1.18 to 
> > suport s390x.`
> 
> Tomasz Janiszewski wrote:
> Fixed. Actually I need it to fix replica log provlems on ARM

Cool! And thhe description have a 72 characters limit, otherwise could not pass 
jenkins. Please update to

```
Leveldb in modern version is required to support s390x.  It's also
required to replace default byte-wise comparator with varint comparator
in `src/log/leveldb.cpp`.
```


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47324/#review133263
---


On May 14, 2016, 1:46 p.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47324/
> ---
> 
> (Updated May 14, 2016, 1:46 p.m.)
> 
> 
> Review request for mesos, Bing Li, Benjamin Mahler, Zhiwei Chen, and haosdent 
> huang.
> 
> 
> Bugs: MESOS-970
> https://issues.apache.org/jira/browse/MESOS-970
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Leveldb in modern version is required to support s390x. 
> It's also required to replace default byte-wise comparator with varint 
> comparator in `src/log/leveldb.cpp`
> 
> 
> Diffs
> -
> 
>   3rdparty/cmake/Versions.cmake 86c51edb3aa2daf6451459aaf18278f09b91b000 
>   3rdparty/leveldb-1.18.patch PRE-CREATION 
>   3rdparty/leveldb-1.18.tar.gz PRE-CREATION 
>   3rdparty/leveldb-1.4.patch b899f0141d633b1ffb2321e573395256fc893b16 
>   3rdparty/leveldb-1.4.tar.gz 2ddbc0c2e02054406ff0ea43ddc10d14979de8d8 
>   3rdparty/versions.am 7dcd6bf914de3213755ec9d4e701a190750424e9 
>   LICENSE eb39f6d69a165f59c00e8bb0ba9e15be8c958a5b 
>   src/python/native_common/ext_modules.py.in 
> 2d4a45efa224b32f80ace4542a00062c5ccb06d5 
> 
> Diff: https://reviews.apache.org/r/47324/diff/
> 
> 
> Testing
> ---
> 
> Tested on Ubuntu amd_64 need to test on PPC
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

2016-05-14 Thread Guangya Liu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47095/#review133273
---




src/tests/containerizer/mesos_containerizer_tests.cpp (line 1064)


s/roots/rootfs



src/tests/containerizer/mesos_containerizer_tests.cpp (line 1107)


s/roots/rootfs



src/tests/containerizer/provisioner_docker_tests.cpp (line 604)


Can you please add some comments here to clairfy why setting the shell as 
false?

// NOTE: We use a non-shell command here because 'sh' might not be
// in the PATH. 'alpine' does not specify env PATH in the image. On
// some linux distribution, '/bin' is not in the PATH by default.



src/tests/containerizer/provisioner_docker_tests.cpp (lines 606 - 609)


It seems a bit confuse for me: You are setting shell as false above, but 
here for the command using shell again.

I try to update code as following:
CommandInfo command;
command.set_shell(false);
command.set_value("/bin/echo");
command.add_arguments("echo");
command.add_arguments("-n");
command.add_arguments("$MESOS_SANDBOX > $MESOS_SANDBOX/env.txt");

But test failed, seems the env.txt was not generated:
I0514 10:16:05.751787 21127 master.cpp:6827] Removing task 
d9820712-987a-4a7b-997a-498d38a95c60 with resources cpus(*):1; mem(*):128 of 
framework a40a88ba-f3cb-45ad-95b8-a1892f583495- on agent 
a40a88ba-f3cb-45ad-95b8-a1892f583495-S0 at slave(1)@9.21.51.124:52999 
(mesos-24.eng.platformlab.ibm.com)
../../src/tests/containerizer/provisioner_docker_tests.cpp:654: Failure
os::read(envfile): Failed to open file 
'/tmp/ProvisionerSandboxTest_ROOT_INTERNET_CURL_MesosSandboxEnv_IxqEbu/slaves/a40a88ba-f3cb-45ad-95b8-a1892f583495-S0/frameworks/a40a88ba-f3cb-45ad-95b8-a1892f583495-/executors/d9820712-987a-4a7b-997a-498d38a95c60/runs/latest/env.txt':
 No such file or directory

Do you know why?


- Guangya Liu


On May 14, 2016, 8:55 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47095/
> ---
> 
> (Updated May 14, 2016, 8:55 a.m.)
> 
> 
> Review request for mesos, Guangya Liu and Jie Yu.
> 
> 
> Bugs: MESOS-5312
> https://issues.apache.org/jira/browse/MESOS-5312
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for MESOS_SANDBOX env for unified containerizer.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 09742ff21513dc2570684d384b257868dd57a9ce 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 69505c922617273effc2eb52b0c567a3c01bf640 
> 
> Diff: https://reviews.apache.org/r/47095/diff/
> 
> 
> Testing
> ---
> 
> "make check" on ubuntu 14.04 64bit with gcc 4.8.4
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 47391: Stout: Removed warning in Windows implementation of `stat.hpp`.

2016-05-14 Thread Mesos ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47391/#review133274
---



Patch looks great!

Reviews applied: [47052, 47053, 47221, 47054, 41632, 47168, 47169, 47386, 
47387, 47388, 47389, 47390, 47391]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 14, 2016, noon, Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47391/
> ---
> 
> (Updated May 14, 2016, noon)
> 
> 
> Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
> Remoortere, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Stout: Removed warning in Windows implementation of `stat.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/windows/stat.hpp 
> f4414dda61386e9458a6aba6014b1df799c89500 
> 
> Diff: https://reviews.apache.org/r/47391/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 47360: Updated dynamic reservation and persistent volume docs.

2016-05-14 Thread Guangya Liu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47360/#review133272
---




docs/persistent-volume.md (line 96)


Can you please show more detail for `may take any value, or may be omitted.`

a) In which condition can take any value if the framework did not provide a 
principal.
b) In which condition the `principal` will be omitted if the framework did 
not provide a principal.

Ditto for others.


- Guangya Liu


On May 14, 2016, 12:39 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47360/
> ---
> 
> (Updated May 14, 2016, 12:39 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Neil Conway.
> 
> 
> Bugs: MESOS-5215
> https://issues.apache.org/jira/browse/MESOS-5215
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch updates the documentation of RESERVE and
> CREATE operations, both via offer operations and
> operator endpoints. Specifically, we clarify the
> Mesos master's expectations for the values of the
> `principal` fields found in `ReservationInfo` and
> `DiskInfo.Persistence`.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md e5f2836c8867d5221da9e4f89167850ef9dab8ec 
>   docs/reservation.md a400d19aec7a48d122ba1c9c23d38d792b8dbe6f 
> 
> Diff: https://reviews.apache.org/r/47360/diff/
> 
> 
> Testing
> ---
> 
> Viewed with the Mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 47324: Upgrade leveldb to 1.18.

2016-05-14 Thread Tomasz Janiszewski


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47324/
---

(Updated May 14, 2016, 1:46 p.m.)


Review request for mesos, Bing Li, Benjamin Mahler, Zhiwei Chen, and haosdent 
huang.


Changes
---

Change summary and description


Summary (updated)
-

Upgrade leveldb to 1.18.


Bugs: MESOS-970
https://issues.apache.org/jira/browse/MESOS-970


Repository: mesos


Description (updated)
---

Leveldb in modern version is required to support s390x. 
It's also required to replace default byte-wise comparator with varint 
comparator in `src/log/leveldb.cpp`


Diffs
-

  3rdparty/cmake/Versions.cmake 86c51edb3aa2daf6451459aaf18278f09b91b000 
  3rdparty/leveldb-1.18.patch PRE-CREATION 
  3rdparty/leveldb-1.18.tar.gz PRE-CREATION 
  3rdparty/leveldb-1.4.patch b899f0141d633b1ffb2321e573395256fc893b16 
  3rdparty/leveldb-1.4.tar.gz 2ddbc0c2e02054406ff0ea43ddc10d14979de8d8 
  3rdparty/versions.am 7dcd6bf914de3213755ec9d4e701a190750424e9 
  LICENSE eb39f6d69a165f59c00e8bb0ba9e15be8c958a5b 
  src/python/native_common/ext_modules.py.in 
2d4a45efa224b32f80ace4542a00062c5ccb06d5 

Diff: https://reviews.apache.org/r/47324/diff/


Testing
---

Tested on Ubuntu amd_64 need to test on PPC


Thanks,

Tomasz Janiszewski

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

2016-05-14 Thread Mesos ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47095/#review133269
---



Patch looks great!

Reviews applied: [47095]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 14, 2016, 8:55 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47095/
> ---
> 
> (Updated May 14, 2016, 8:55 a.m.)
> 
> 
> Review request for mesos, Guangya Liu and Jie Yu.
> 
> 
> Bugs: MESOS-5312
> https://issues.apache.org/jira/browse/MESOS-5312
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for MESOS_SANDBOX env for unified containerizer.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 09742ff21513dc2570684d384b257868dd57a9ce 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 69505c922617273effc2eb52b0c567a3c01bf640 
> 
> Diff: https://reviews.apache.org/r/47095/diff/
> 
> 
> Testing
> ---
> 
> "make check" on ubuntu 14.04 64bit with gcc 4.8.4
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Review Request 47391: Stout: Removed warning in Windows implementation of `stat.hpp`.

2016-05-14 Thread Alex Clemmer


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47391/
---

Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
Remoortere, and Michael Park.


Repository: mesos


Description
---

Stout: Removed warning in Windows implementation of `stat.hpp`.


Diffs
-

  3rdparty/stout/include/stout/os/windows/stat.hpp 
f4414dda61386e9458a6aba6014b1df799c89500 

Diff: https://reviews.apache.org/r/47391/diff/


Testing
---


Thanks,

Alex Clemmer

Review Request 47390: Stout: Removed implicit conversions in `permissions.hpp` on Windows.

2016-05-14 Thread Alex Clemmer


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47390/
---

Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
Remoortere, and Michael Park.


Repository: mesos


Description
---

Stout: Removed implicit conversions in `permissions.hpp` on Windows.


Diffs
-

  3rdparty/stout/include/stout/os/permissions.hpp 
16b5bca67bc32ae0a2aa32a13b7ff1368e11dcc3 

Diff: https://reviews.apache.org/r/47390/diff/


Testing
---


Thanks,

Alex Clemmer

Review Request 47386: Stout: Implemented `setHostname` on Windows.

2016-05-14 Thread Alex Clemmer


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47386/
---

Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
Remoortere, and Michael Park.


Bugs: MESOS-5383
https://issues.apache.org/jira/browse/MESOS-5383


Repository: mesos


Description
---

Stout: Implemented `setHostname` on Windows.


Diffs
-

  3rdparty/stout/include/Makefile.am 9b39ce32c0269479066cf7991afaeed65d8ab547 
  3rdparty/stout/include/stout/net.hpp 1c99d893af34b834faf8c4e1bd5aee1b377af84f 
  3rdparty/stout/include/stout/posix/net.hpp PRE-CREATION 
  3rdparty/stout/include/stout/windows/net.hpp PRE-CREATION 

Diff: https://reviews.apache.org/r/47386/diff/


Testing
---


Thanks,

Alex Clemmer

Review Request 47389: Stout: Added support for correct path delimiters in Windows.

2016-05-14 Thread Alex Clemmer


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47389/
---

Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
Remoortere, and Michael Park.


Repository: mesos


Description
---

Stout: Added support for correct path delimiters in Windows.


Diffs
-

  3rdparty/stout/include/stout/os/constants.hpp 
438840aaef189ef4fb457b856790efb3b6333a7d 
  3rdparty/stout/include/stout/path.hpp 
ef538045a8b7a1e3d8962c869317d86a85e0259f 

Diff: https://reviews.apache.org/r/47389/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 47281: Mesos::master::allocation namespace removed.

2016-05-14 Thread haosdent huang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47281/#review133265
---




src/local/local.cpp (line 93)


Kill this line because it is belong to same `using` with following using 
items.



src/master/allocator/mesos/hierarchical.hpp (line 45)


I suggest to using excactly using here instead of use `using namespace`



src/tests/hierarchical_allocator_tests.cpp (line 54)


Put it on the `using mesos::internal::master::MIN_CPUS;`



src/tests/master_allocator_tests.cpp (line 55)


Add a blank line between them



src/tests/master_authorization_tests.cpp (line 49)


Kill this line.



src/tests/master_tests.cpp (line 74)


Kill this blank line



src/tests/scheduler_driver_tests.cpp (line 49)


Put it after `using mesos::internal::master::Master;`



src/tests/scheduler_tests.cpp (line 55)


Put it after `using mesos::internal::master::Master;`


- haosdent huang


On May 12, 2016, 2:02 a.m., Jose Guilherme Vanz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47281/
> ---
> 
> (Updated May 12, 2016, 2:02 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-2516
> https://issues.apache.org/jira/browse/MESOS-2516
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> To keep consistence with the rest of the codebase, the allocation
> namespace has been removed from mesos::master namespace. To not
> pollute the master namespace, sorters have been moved to the new
> mesos::master::sorter namespace
> 
> MESOS-2516
> 
> 
> Diffs
> -
> 
>   docs/allocation-module.md 651f0a232426f537f7a1f3dbd96b0f24b60d695f 
>   include/mesos/master/allocator.hpp a4743c5a31b18d96722a42d526bfb669d30e6e48 
>   include/mesos/module/allocator.hpp 5e65e69b6d62611f51e85aa9adaa283713896d4c 
>   src/examples/test_allocator_module.cpp 
> 1255a4a22a9d1a5724bef78dfc4dee498ed50fff 
>   src/local/local.hpp f4ae285edc30a0fb1c960d50dfb1a859b2eae166 
>   src/local/local.cpp 1c679ecb486cb3d6184ec9a941f2ac5dbd2bcc1f 
>   src/master/allocator/allocator.cpp 8e76a3a33efd896a21960b0092dfdee800d211f5 
>   src/master/allocator/mesos/allocator.hpp 
> 64bce0fb143b109c26f923cd97d5facb393dee9d 
>   src/master/allocator/mesos/hierarchical.hpp 
> 3f5dff72945bf81fda4e5bc9b11edfba40cced9d 
>   src/master/allocator/mesos/hierarchical.cpp 
> 51125bac62735879f66234765dad92a759f6724b 
>   src/master/allocator/mesos/metrics.hpp 
> 06fdd1633f63c005230e1cc5fafdad358a0ac254 
>   src/master/allocator/mesos/metrics.cpp 
> a36d21c297160bc1c9f43a22743fd5448d7ae5ac 
>   src/master/allocator/sorter/drf/metrics.hpp 
> 61568cb520826ab59d675824b212e0d3deb63764 
>   src/master/allocator/sorter/drf/metrics.cpp 
> c793f3216287fd40998a1d4aab016d55aa1ac151 
>   src/master/allocator/sorter/drf/sorter.hpp 
> 05d5205d29ad74e01e07c508d88b6f8371541513 
>   src/master/allocator/sorter/drf/sorter.cpp 
> 4306973277b9d32356eed31ceabac09fb2a03e6c 
>   src/master/allocator/sorter/sorter.hpp 
> 9e04adf54f2d80541a95f0a9a49b329dc9e8f5e3 
>   src/master/main.cpp 23149d5511d1556f1a885d01ea9380a9669fa8c5 
>   src/master/master.hpp 3e55114ee7866e06513071e86e15608099dae052 
>   src/master/master.cpp 35b428b0f7dee5954514d8860cfc498271ccf267 
>   src/tests/cluster.hpp 60ab3f72b6ff84324c9991d22d6e52cfe0cb6501 
>   src/tests/fault_tolerance_tests.cpp 
> c39a0ccf8fa124b2c230864f3ba1f7e8e05b36dc 
>   src/tests/hierarchical_allocator_tests.cpp 
> e6101fdffe5e340619d79d821a2f5f891cb2dec7 
>   src/tests/master_allocator_tests.cpp 
> ec46913e7fed4bc8cda68ff20d04d6714ecb644d 
>   src/tests/master_authorization_tests.cpp 
> 804b39a269c09df9f6c0bbdf6f8b53921ac09ce8 
>   src/tests/master_tests.cpp 8e00753fcbcd0cae1d08aad387b08aa17c7f63ad 
>   src/tests/mesos.hpp 79bf1ff16412ce2a510a9b75ab1ac91c1c182653 
>   src/tests/mesos.cpp 849e656c8b85304cccecc9d7b9d9116884132244 
>   src/tests/partition_tests.cpp 3ec51cedcea9c7ed5cf41e9e0087fc044c85d2f1 
>   src/tests/rate_limiting_tests.cpp 5d68ac170cb5a948df1429ffbf8e5b8f02f708d9 
>   src/tests/reservation_tests.cpp 2d7fb21e2fe153c2b62dfd60bbaccb350a157391 
>   src/tests/resource_offers_tests.cpp 
> 046adaedf9121655f377f503bb30437803bf0005 
>   src/tests/scheduler_driver_tests.cpp 
> 217185780e3576faf633dd9629ae93a275fac284 
>   src/tests/scheduler_tests.cpp d9cc3fde0caeadb16164e68ed66be098fd3ada7c

Re: Review Request 47324: Update leveldb.

2016-05-14 Thread Mesos ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47324/#review133264
---



Patch looks great!

Reviews applied: [47324]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 14, 2016, 7:33 a.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47324/
> ---
> 
> (Updated May 14, 2016, 7:33 a.m.)
> 
> 
> Review request for mesos, Bing Li, Benjamin Mahler, Zhiwei Chen, and haosdent 
> huang.
> 
> 
> Bugs: MESOS-970
> https://issues.apache.org/jira/browse/MESOS-970
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update leveldb.
> 
> 
> Diffs
> -
> 
>   3rdparty/cmake/Versions.cmake 86c51edb3aa2daf6451459aaf18278f09b91b000 
>   3rdparty/leveldb-1.18.patch PRE-CREATION 
>   3rdparty/leveldb-1.18.tar.gz PRE-CREATION 
>   3rdparty/leveldb-1.4.patch b899f0141d633b1ffb2321e573395256fc893b16 
>   3rdparty/leveldb-1.4.tar.gz 2ddbc0c2e02054406ff0ea43ddc10d14979de8d8 
>   3rdparty/versions.am 7dcd6bf914de3213755ec9d4e701a190750424e9 
>   LICENSE eb39f6d69a165f59c00e8bb0ba9e15be8c958a5b 
>   src/python/native_common/ext_modules.py.in 
> 2d4a45efa224b32f80ace4542a00062c5ccb06d5 
> 
> Diff: https://reviews.apache.org/r/47324/diff/
> 
> 
> Testing
> ---
> 
> Tested on Ubuntu amd_64 need to test on PPC
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Re: Review Request 47324: Update leveldb.

2016-05-14 Thread haosdent huang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47324/#review133263
---



I suggest to change Summary and Description to `Upgrade leveldb to 1.18 to 
suport s390x.`

- haosdent huang


On May 14, 2016, 7:33 a.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47324/
> ---
> 
> (Updated May 14, 2016, 7:33 a.m.)
> 
> 
> Review request for mesos, Bing Li, Benjamin Mahler, Zhiwei Chen, and haosdent 
> huang.
> 
> 
> Bugs: MESOS-970
> https://issues.apache.org/jira/browse/MESOS-970
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update leveldb.
> 
> 
> Diffs
> -
> 
>   3rdparty/cmake/Versions.cmake 86c51edb3aa2daf6451459aaf18278f09b91b000 
>   3rdparty/leveldb-1.18.patch PRE-CREATION 
>   3rdparty/leveldb-1.18.tar.gz PRE-CREATION 
>   3rdparty/leveldb-1.4.patch b899f0141d633b1ffb2321e573395256fc893b16 
>   3rdparty/leveldb-1.4.tar.gz 2ddbc0c2e02054406ff0ea43ddc10d14979de8d8 
>   3rdparty/versions.am 7dcd6bf914de3213755ec9d4e701a190750424e9 
>   LICENSE eb39f6d69a165f59c00e8bb0ba9e15be8c958a5b 
>   src/python/native_common/ext_modules.py.in 
> 2d4a45efa224b32f80ace4542a00062c5ccb06d5 
> 
> Diff: https://reviews.apache.org/r/47324/diff/
> 
> 
> Testing
> ---
> 
> Tested on Ubuntu amd_64 need to test on PPC
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Re: Review Request 47381: Fixed agent to properly handle killTask of unregistered executor.

2016-05-14 Thread Mesos ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47381/#review133260
---



Patch looks great!

Reviews applied: [47381]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 14, 2016, 12:28 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47381/
> ---
> 
> (Updated May 14, 2016, 12:28 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-5380
> https://issues.apache.org/jira/browse/MESOS-5380
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The agent now shuts down the executor during registration if it does not
> have any queued tasks (e.g., framework sent a killTask before
> registration).
> 
> Note that if the executor doesn't register at all, it will be cleaned up
> anyway after the registration timeout value.
> 
> Also, note that this doesn't handle the case where the agent restarts
> after processing the killTask() but before cleaning up the executor.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp 7c870396b4d6804bfda6169d76d136e95cd839f5 
>   src/tests/slave_tests.cpp 3ec670aa75790417ec8b7b96cfdb787492b104e1 
> 
> Diff: https://reviews.apache.org/r/47381/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> The new test failed w/o the code change.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

2016-05-14 Thread Shuai Lin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47095/
---

(Updated May 14, 2016, 8:55 a.m.)


Review request for mesos, Guangya Liu and Jie Yu.


Changes
---

Fix the tests on CentOS.


Bugs: MESOS-5312
https://issues.apache.org/jira/browse/MESOS-5312


Repository: mesos


Description
---

Added tests for MESOS_SANDBOX env for unified containerizer.


Diffs (updated)
-

  src/tests/containerizer/mesos_containerizer_tests.cpp 
09742ff21513dc2570684d384b257868dd57a9ce 
  src/tests/containerizer/provisioner_docker_tests.cpp 
69505c922617273effc2eb52b0c567a3c01bf640 

Diff: https://reviews.apache.org/r/47095/diff/


Testing
---

"make check" on ubuntu 14.04 64bit with gcc 4.8.4


Thanks,

Shuai Lin

Re: Review Request 47367: Removed references to HTTP command executor.

2016-05-14 Thread Anand Mazumdar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47367/
---

(Updated May 14, 2016, 8:40 a.m.)


Review request for mesos and Vinod Kone.


Changes
---

Run review bot again.


Bugs: MESOS-5302
https://issues.apache.org/jira/browse/MESOS-5302


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/Makefile.am ce5245883f3d2661812272702c0d2060513b6d88 
  src/launcher/http_command_executor.cpp 
f78d7988e4be0ee05b75c49c9e04bab58d0916db 
  src/slave/slave.cpp 7c870396b4d6804bfda6169d76d136e95cd839f5 

Diff: https://reviews.apache.org/r/47367/diff/


Testing
---


Thanks,

Anand Mazumdar

Re: Review Request 47363: Introduced a driver to v1 executor shim/adapter.

2016-05-14 Thread Anand Mazumdar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47363/
---

(Updated May 14, 2016, 8:39 a.m.)


Review request for mesos and Vinod Kone.


Changes
---

Add missing header to Makefile.


Bugs: MESOS-5302
https://issues.apache.org/jira/browse/MESOS-5302


Repository: mesos


Description
---

This change adds a driver to v1 executor shim/adapter. This can
be used by the command executor/docker executor to toggle
between using the new/old API instead of duplicating the
code like we did with `http_command_executor.cpp`.


Diffs (updated)
-

  include/mesos/v1/executor.hpp adca287be3bb88c8b3298705740cb6bcbb3a09f0 
  src/Makefile.am ce5245883f3d2661812272702c0d2060513b6d88 
  src/executor/v0_v1executor.hpp PRE-CREATION 
  src/executor/v0_v1executor.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/47363/diff/


Testing
---

make check (Later in the chain, we make the command executor use this interface)
So the existing tests should be able to test this out.


Thanks,

Anand Mazumdar

Re: Review Request 46498: Add runtime for Appc Spec ex: command, workingdir and environment.

2016-05-14 Thread Guangya Liu



> On 五月 12, 2016, 11:44 p.m., Jojy Varghese wrote:
> > Srinivas, thanks for taking this on. It looks like you combined your 
> > previous patches (https://reviews.apache.org/r/46107) here. I would advice 
> > you to split this patch into 2:
> >  - Protobuf changes
> >  - Other changes
> >  
> > 
> > -jojy
> 
> Srinivas Brahmaroutu wrote:
> Hi Jojy, I would rebase as the other two patches get merged. This patch 
> includes other two patches https://reviews.apache.org/r/46107 and 
> https://reviews.apache.org/r/46182  I have cumlative patches. I may be wrong, 
> but once https://reviews.apache.org/r/46107 is checked in I will rebase 46182 
> and so on?

Srini, you can create a patch chain that have dependeny to resolve this, the 
steps could be as this:
1) git checkout -b part1
2) Update your code and `support/post-review.sh`
3) git checkout -b part2 (This can make sure part2 depend on part1)
4) Update your code and `support/post-review.sh`
5) repeat 3) and 4) for other patches


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46498/#review133004
---


On 五月 14, 2016, 4:20 a.m., Srinivas Brahmaroutu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46498/
> ---
> 
> (Updated 五月 14, 2016, 4:20 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add runtime for Appc Spec ex: command, workingdir and environment.
> 
> 
> Diffs
> -
> 
>   include/mesos/appc/spec.proto 4ef0473748c2f47aff1729c1d969185803fe72d4 
>   include/mesos/slave/isolator.proto 60a9bb637e12593a97ed1a7c510ebccd4e5a9615 
>   src/Makefile.am 447bc2ab511ad173d3d911be10992be0974f4584 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 75e5a32a3e70ec60a6800e21a621673184ea0956 
>   src/slave/containerizer/mesos/isolators/appc/runtime.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/appc/runtime.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/appc/store.cpp 
> 33e97fc645a9b7fbc9ae47f67c1b5dacf999fce0 
>   src/slave/containerizer/mesos/provisioner/provisioner.hpp 
> 5c96e9f6603d39889e6bc807874d35d0cb3556be 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 
> dcbbbaf797d4467bfd0bb1ee91ee9ce843e7d546 
>   src/slave/containerizer/mesos/provisioner/store.hpp 
> 1d477ef13ddd24fd8badae0decaa4a2271ecc746 
>   src/tests/containerizer/provisioner_appc_tests.cpp 
> 84fe52b6937c3b7d7628b17a2f045eec2f386b4d 
> 
> Diff: https://reviews.apache.org/r/46498/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>

Re: Review Request 46498: Add runtime for Appc Spec ex: command, workingdir and environment.

2016-05-14 Thread Guangya Liu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46498/#review133256
---



Some early comments, can you please split this to small patches? You can refer 
to https://reviews.apache.org/r/43021/ patch chain for how does run time 
isolator did this.

I saw that you also have patches https://reviews.apache.org/r/46107 and 
https://reviews.apache.org/r/46182/ , seems they are duplicate with this?


include/mesos/appc/spec.proto (line 58)


blank line above



include/mesos/appc/spec.proto (lines 67 - 68)


Why 6, 7? I think should be 2, 3



include/mesos/appc/spec.proto (line 68)


s/environment/environments



include/mesos/slave/isolator.proto (line 21)


blank line below



include/mesos/slave/isolator.proto (lines 86 - 91)


s/Appc/AppC

Why not `optional appc.spec.ImageManifest manifest = 6;`

Or 

message Appc {
  required appc.spec.ImageManifest manifest = 1;
}

optional Appc appc = 6;

I think that the field in `AppC` should be `required`



src/Makefile.am (line 948)


align with others



src/Makefile.am (line 971)


align with others



src/slave/containerizer/mesos/containerizer.cpp (line 79)


I prefer that you put it into a new #ifdef as it is a new isolator.

#ifdef __linux__
#include "slave/containerizer/mesos/isolators/mesos/runtime.hpp"
#endif



src/slave/containerizer/mesos/isolators/appc/runtime.cpp (line 27)


kill this



src/slave/containerizer/mesos/isolators/appc/runtime.cpp (line 199)


kill this



src/slave/containerizer/mesos/isolators/appc/runtime.cpp (lines 209 - 212)


I think that we still have `argv`, why you are ignoring `argv` here? It is 
better use a table same as `DockerRuntimeIsolatorProcess` to describe the 
behavior here.



src/slave/containerizer/mesos/provisioner/provisioner.hpp (lines 24 - 25)


#include 

#include 


- Guangya Liu


On 五月 14, 2016, 4:20 a.m., Srinivas Brahmaroutu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46498/
> ---
> 
> (Updated 五月 14, 2016, 4:20 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add runtime for Appc Spec ex: command, workingdir and environment.
> 
> 
> Diffs
> -
> 
>   include/mesos/appc/spec.proto 4ef0473748c2f47aff1729c1d969185803fe72d4 
>   include/mesos/slave/isolator.proto 60a9bb637e12593a97ed1a7c510ebccd4e5a9615 
>   src/Makefile.am 447bc2ab511ad173d3d911be10992be0974f4584 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 75e5a32a3e70ec60a6800e21a621673184ea0956 
>   src/slave/containerizer/mesos/isolators/appc/runtime.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/appc/runtime.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/appc/store.cpp 
> 33e97fc645a9b7fbc9ae47f67c1b5dacf999fce0 
>   src/slave/containerizer/mesos/provisioner/provisioner.hpp 
> 5c96e9f6603d39889e6bc807874d35d0cb3556be 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 
> dcbbbaf797d4467bfd0bb1ee91ee9ce843e7d546 
>   src/slave/containerizer/mesos/provisioner/store.hpp 
> 1d477ef13ddd24fd8badae0decaa4a2271ecc746 
>   src/tests/containerizer/provisioner_appc_tests.cpp 
> 84fe52b6937c3b7d7628b17a2f045eec2f386b4d 
> 
> Diff: https://reviews.apache.org/r/46498/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>

Re: Review Request 44839: Enabled mesos containerizer force_pull_image for appc.

2016-05-14 Thread Mesos ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44839/#review133255
---



Patch looks great!

Reviews applied: [44837, 44838, 44839]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 14, 2016, 1:29 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44839/
> ---
> 
> (Updated May 14, 2016, 1:29 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu.
> 
> 
> Bugs: MESOS-4886
> https://issues.apache.org/jira/browse/MESOS-4886
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled mesos containerizer force_pull_image for appc.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/appc/store.cpp 
> 33e97fc645a9b7fbc9ae47f67c1b5dacf999fce0 
> 
> Diff: https://reviews.apache.org/r/44839/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 47324: Update leveldb.

2016-05-14 Thread Tomasz Janiszewski


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47324/
---

(Updated May 14, 2016, 7:33 a.m.)


Review request for mesos, Bing Li, Benjamin Mahler, Zhiwei Chen, and haosdent 
huang.


Bugs: MESOS-970
https://issues.apache.org/jira/browse/MESOS-970


Repository: mesos


Description
---

Update leveldb.


Diffs (updated)
-

  3rdparty/cmake/Versions.cmake 86c51edb3aa2daf6451459aaf18278f09b91b000 
  3rdparty/leveldb-1.18.patch PRE-CREATION 
  3rdparty/leveldb-1.18.tar.gz PRE-CREATION 
  3rdparty/leveldb-1.4.patch b899f0141d633b1ffb2321e573395256fc893b16 
  3rdparty/leveldb-1.4.tar.gz 2ddbc0c2e02054406ff0ea43ddc10d14979de8d8 
  3rdparty/versions.am 7dcd6bf914de3213755ec9d4e701a190750424e9 
  LICENSE eb39f6d69a165f59c00e8bb0ba9e15be8c958a5b 
  src/python/native_common/ext_modules.py.in 
2d4a45efa224b32f80ace4542a00062c5ccb06d5 

Diff: https://reviews.apache.org/r/47324/diff/


Testing
---

Tested on Ubuntu amd_64 need to test on PPC


Thanks,

Tomasz Janiszewski

Re: Review Request 47360: Updated dynamic reservation and persistent volume docs.

2016-05-14 Thread Mesos ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47360/#review133252
---



Patch looks great!

Reviews applied: [47359, 47360]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 14, 2016, 12:39 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47360/
> ---
> 
> (Updated May 14, 2016, 12:39 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Neil Conway.
> 
> 
> Bugs: MESOS-5215
> https://issues.apache.org/jira/browse/MESOS-5215
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch updates the documentation of RESERVE and
> CREATE operations, both via offer operations and
> operator endpoints. Specifically, we clarify the
> Mesos master's expectations for the values of the
> `principal` fields found in `ReservationInfo` and
> `DiskInfo.Persistence`.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md e5f2836c8867d5221da9e4f89167850ef9dab8ec 
>   docs/reservation.md a400d19aec7a48d122ba1c9c23d38d792b8dbe6f 
> 
> Diff: https://reviews.apache.org/r/47360/diff/
> 
> 
> Testing
> ---
> 
> Viewed with the Mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

39 matches

Mail list logo