Re: Review Request 46093: Enhanced the error message for invalid duration unit.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46093/
---

(Updated 五月 16, 2016, 6:18 a.m.)


Review request for mesos and Alexander Rukletsov.


Changes
---

Rebase


Bugs: MESOS-5179
https://issues.apache.org/jira/browse/MESOS-5179


Repository: mesos


Description
---

Enhanced the error message for invalid duration unit.


Diffs (updated)
-

  3rdparty/stout/include/stout/duration.hpp 
aea280830731a0e8c1aacd3fb6aef27291cc6f0b 

Diff: https://reviews.apache.org/r/46093/diff/


Testing
---

LiuGuangyas-MacBook-Pro:build gyliu$ ./bin/mesos-master.sh --offer_timeout=4cc
Failed to load flag 'offer_timeout': Failed to load value '4cc': Unknown 
duration unit 'cc', the supported units are 'ns', 'us', 'ms', 'secs', 'mins', 
'hrs', 'days' and 'weeks'


Thanks,

Guangya Liu

Re: Review Request 39845: Added REASON_RESOURCE_OVERSUBSCRIBED to mesos proto.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39845/
---

(Updated 五月 16, 2016, 6:10 a.m.)


Review request for mesos, Niklas Nielsen and Vinod Kone.


Bugs: MESOS-2647
https://issues.apache.org/jira/browse/MESOS-2647


Repository: mesos


Description
---

Added REASON_RESOURCE_OVERSUBSCRIBED to mesos proto.


Diffs (updated)
-

  include/mesos/mesos.proto 887ffe9c5f04e25539a4c6b3d52ce5299c65e8d3 
  include/mesos/v1/mesos.proto 9e59aed20965d50ee10989ff6b75db742cf2b83b 

Diff: https://reviews.apache.org/r/39845/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 39848: Validated revocable resources before run task.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39848/
---

(Updated 五月 16, 2016, 6:10 a.m.)


Review request for mesos, Niklas Nielsen and Vinod Kone.


Summary (updated)
-

Validated revocable resources before run task.


Bugs: MESOS-2647
https://issues.apache.org/jira/browse/MESOS-2647


Repository: mesos


Description (updated)
---

Validated revocable resources before run task.


Diffs (updated)
-

  src/slave/slave.cpp bea35e5f7e22ced32514706827b4331c956ee674 

Diff: https://reviews.apache.org/r/39848/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 47324: Update leveldb to 1.18.

[Zhiwei Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47324/#review133327
---


Ship it!




I tested on ppc64le with ssl and libevent enabled, it passed.

- Zhiwei Chen


On May 14, 2016, 11:01 p.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47324/
> ---
> 
> (Updated May 14, 2016, 11:01 p.m.)
> 
> 
> Review request for mesos, Bing Li, Benjamin Mahler, Zhiwei Chen, and haosdent 
> huang.
> 
> 
> Bugs: MESOS-970
> https://issues.apache.org/jira/browse/MESOS-970
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Leveldb in modern version is required to support s390x.
> It's also required to replace default byte-wise comparator
> with varint comparator in `src/log/leveldb.cpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/cmake/Versions.cmake 86c51edb3aa2daf6451459aaf18278f09b91b000 
>   3rdparty/leveldb-1.18.patch PRE-CREATION 
>   3rdparty/leveldb-1.18.tar.gz PRE-CREATION 
>   3rdparty/leveldb-1.4.patch b899f0141d633b1ffb2321e573395256fc893b16 
>   3rdparty/leveldb-1.4.tar.gz 2ddbc0c2e02054406ff0ea43ddc10d14979de8d8 
>   3rdparty/versions.am 7dcd6bf914de3213755ec9d4e701a190750424e9 
>   LICENSE eb39f6d69a165f59c00e8bb0ba9e15be8c958a5b 
>   src/python/native_common/ext_modules.py.in 
> 2d4a45efa224b32f80ace4542a00062c5ccb06d5 
> 
> Diff: https://reviews.apache.org/r/47324/diff/
> 
> 
> Testing
> ---
> 
> Tested on Ubuntu amd_64 need to test on PPC
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Review Request 44209: Closed the input ifstream before return error.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44209/
---

Review request for mesos, Gilbert Song, Jie Yu, and Timothy Chen.


Repository: mesos


Description
---

Closed the input ifstream before return error.


Diffs
-

  src/log/tool/benchmark.cpp 7e1350675bdfe6c44e86b082bc01f692cc72b850 

Diff: https://reviews.apache.org/r/44209/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 47404: Stout: Implemented `HANDLE` versions of file descriptor functions.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47404/#review133324
---



Patch looks great!

Reviews applied: [47052, 47053, 47221, 47054, 41632, 47168, 47169, 47386, 
47387, 47388, 47389, 47390, 47391, 47403, 47404]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 16, 2016, 3:23 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47404/
> ---
> 
> (Updated May 16, 2016, 3:23 a.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
> Remoortere, and Michael Park.
> 
> 
> Bugs: MESOS-5386
> https://issues.apache.org/jira/browse/MESOS-5386
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Stout: Implemented `HANDLE` versions of file descriptor functions.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/windows/fcntl.hpp 
> 14734317d7fb40053ee808745ac3ba8c706a7669 
>   3rdparty/stout/include/stout/os/windows/read.hpp 
> a10df7358205da9bc9d3176e27db12556bf0e6ae 
>   3rdparty/stout/include/stout/os/windows/write.hpp 
> 9f75568b88db11f9706beb4e7eb45c6e7759b779 
>   3rdparty/stout/include/stout/protobuf.hpp 
> eb4ac8cd738859a119f4f64bf52ae49a5bbef899 
> 
> Diff: https://reviews.apache.org/r/47404/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 47055: Make the proper contrast ratio in web page for accessibility.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47055/#review133321
---



Patch looks great!

Reviews applied: [47055]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 16, 2016, 2:47 a.m., Chen Nan Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47055/
> ---
> 
> (Updated May 16, 2016, 2:47 a.m.)
> 
> 
> Review request for mesos, Zhiwei Chen and haosdent huang.
> 
> 
> Bugs: MESOS-5204
> https://issues.apache.org/jira/browse/MESOS-5204
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Make the proper contrast ratio in web page for accessibility.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/css/mesos.css 
> 5b1227e9d64757f9fc106e497f7fa3ed72112c10 
> 
> Diff: https://reviews.apache.org/r/47055/diff/
> 
> 
> Testing
> ---
> 
> Ensuring that a contrast ratio of at least 4.5:1 exists between text (and 
> images of text) and background behind the text.
> 
> refer to https://www.w3.org/TR/WCAG20-TECHS/G18.html
> 
> 
> Thanks,
> 
> Chen Nan Li
> 
>

Review Request 47404: Stout: Implemented `HANDLE` versions of file descriptor functions.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47404/
---

Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
Remoortere, and Michael Park.


Bugs: MESOS-5386
https://issues.apache.org/jira/browse/MESOS-5386


Repository: mesos


Description
---

Stout: Implemented `HANDLE` versions of file descriptor functions.


Diffs
-

  3rdparty/stout/include/stout/os/windows/fcntl.hpp 
14734317d7fb40053ee808745ac3ba8c706a7669 
  3rdparty/stout/include/stout/os/windows/read.hpp 
a10df7358205da9bc9d3176e27db12556bf0e6ae 
  3rdparty/stout/include/stout/os/windows/write.hpp 
9f75568b88db11f9706beb4e7eb45c6e7759b779 
  3rdparty/stout/include/stout/protobuf.hpp 
eb4ac8cd738859a119f4f64bf52ae49a5bbef899 

Diff: https://reviews.apache.org/r/47404/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 46954: Ensuring that id attributes are unique on a Web page.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46954/#review133318
---


Ship it!




Ship It!

- haosdent huang


On May 6, 2016, 8:57 a.m., Chen Nan Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46954/
> ---
> 
> (Updated May 6, 2016, 8:57 a.m.)
> 
> 
> Review request for mesos, Zhiwei Chen and haosdent huang.
> 
> 
> Bugs: MESOS-5201
> https://issues.apache.org/jira/browse/MESOS-5201
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ensuring that id attributes are unique on a Web page.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/directives/tableHeader.html 
> 448f67ef20c279fdd542890158fb9f96a10ebebc 
> 
> Diff: https://reviews.apache.org/r/46954/diff/
> 
> 
> Testing
> ---
> 
> Have checked with the patch by firebug, the ID of each table header is 
> different with each other.
> 
> For details refer to https://www.w3.org/TR/2014/NOTE-WCAG20-TECHS-20140311/H93
> 
> 
> Thanks,
> 
> Chen Nan Li
> 
>

Re: Review Request 46954: Ensuring that id attributes are unique on a Web page.

[Chen Nan Li]

> On 五月 13, 2016, 2:58 p.m., haosdent huang wrote:
> > src/webui/master/static/directives/tableHeader.html, line 3
> > 
> >
> > Seems `id` here is unnecessary, I think could remove it.
> > 
> > ```
> > {{headerTitle}}
> > ```

I think both ok for this. Let's keep it. thanks


- Chen Nan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46954/#review133119
---


On 五月 6, 2016, 8:57 a.m., Chen Nan Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46954/
> ---
> 
> (Updated 五月 6, 2016, 8:57 a.m.)
> 
> 
> Review request for mesos, Zhiwei Chen and haosdent huang.
> 
> 
> Bugs: MESOS-5201
> https://issues.apache.org/jira/browse/MESOS-5201
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ensuring that id attributes are unique on a Web page.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/directives/tableHeader.html 
> 448f67ef20c279fdd542890158fb9f96a10ebebc 
> 
> Diff: https://reviews.apache.org/r/46954/diff/
> 
> 
> Testing
> ---
> 
> Have checked with the patch by firebug, the ID of each table header is 
> different with each other.
> 
> For details refer to https://www.w3.org/TR/2014/NOTE-WCAG20-TECHS-20140311/H93
> 
> 
> Thanks,
> 
> Chen Nan Li
> 
>

Re: Review Request 47055: Make the proper contrast ratio in web page for accessibility.

[Chen Nan Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47055/
---

(Updated 五月 16, 2016, 2:47 a.m.)


Review request for mesos, Zhiwei Chen and haosdent huang.


Changes
---

drive comments


Bugs: MESOS-5204
https://issues.apache.org/jira/browse/MESOS-5204


Repository: mesos


Description
---

Make the proper contrast ratio in web page for accessibility.


Diffs (updated)
-

  src/webui/master/static/css/mesos.css 
5b1227e9d64757f9fc106e497f7fa3ed72112c10 

Diff: https://reviews.apache.org/r/47055/diff/


Testing
---

Ensuring that a contrast ratio of at least 4.5:1 exists between text (and 
images of text) and background behind the text.

refer to https://www.w3.org/TR/WCAG20-TECHS/G18.html


Thanks,

Chen Nan Li

Re: Review Request 47208: Fixed mesos test installation build.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47208/#review133315
---


Ship it!




Ship It!

- Vinod Kone


On May 15, 2016, 6:20 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47208/
> ---
> 
> (Updated May 15, 2016, 6:20 p.m.)
> 
> 
> Review request for mesos, James Peach and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change modifies a couple of existing tests to make them
> pass when the mesos tests are configured to be installed. This
> also brings the `TestHTTPFramework` test to be at parity with
> the `TestFramework` code around finding the executor path logic.
> 
> 
> Diffs
> -
> 
>   src/examples/test_http_framework.cpp 
> 683384d986082a24b052505ef6be22b4dc20db00 
>   src/tests/dynamic_reservation_framework_test.sh 
> 00a10f18b98df941089d93f0163b644ce537fb04 
> 
> Diff: https://reviews.apache.org/r/47208/diff/
> 
> 
> Testing
> ---
> 
> make check
> $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none passes now
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 45200: Add deprecated flag names.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45200/#review133314
---



LGTM, modulo un-needed tests. 

Can you follow up with a review that actually changes the flag variables (e.g., 
flags.slave_rereigster_timeout) from slave -> agent as well?


src/tests/flags_tests.cpp (line 2)


I don't think we need these tests since we already have tests for 
deprecated flag names. Just kill this file.


- Vinod Kone


On May 15, 2016, 11:27 a.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45200/
> ---
> 
> (Updated May 15, 2016, 11:27 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3781
> https://issues.apache.org/jira/browse/MESOS-3781
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Replace 'slave' with 'agent' in flag names. Original names are marked
> as deprecated.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am ce5245883f3d2661812272702c0d2060513b6d88 
>   src/master/flags.cpp b97f01149b428a736d052cf7aece8ae092ca8cd4 
>   src/slave/flags.cpp b7df8f760d0f75459f1e80e3d8e18d49a3995df8 
>   src/tests/flags_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45200/diff/
> 
> 
> Testing
> ---
> 
> ./configure --with-network-isolator
> make check (on OSX and Ubuntu)
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 47055: Make the proper contrast ratio in web page for accessibility.

[Chen Nan Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47055/#review133313
---




src/webui/master/static/css/mesos.css (line 2)


ok thanks



src/webui/master/static/css/mesos.css (line 9)


ok that's more standard. thanks



src/webui/master/static/css/mesos.css (line 21)


ok thanks



src/webui/master/static/css/mesos.css (line 30)


I overwirte the background-color from #777 to #555 for the contrast of the 
"Master" in the html header



src/webui/master/static/css/mesos.css (line 42)


Thanks.


- Chen Nan Li


On 五月 6, 2016, 8:58 a.m., Chen Nan Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47055/
> ---
> 
> (Updated 五月 6, 2016, 8:58 a.m.)
> 
> 
> Review request for mesos, Zhiwei Chen and haosdent huang.
> 
> 
> Bugs: MESOS-5204
> https://issues.apache.org/jira/browse/MESOS-5204
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Make the proper contrast ratio in web page for accessibility.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/css/mesos.css 
> 5b1227e9d64757f9fc106e497f7fa3ed72112c10 
> 
> Diff: https://reviews.apache.org/r/47055/diff/
> 
> 
> Testing
> ---
> 
> Ensuring that a contrast ratio of at least 4.5:1 exists between text (and 
> images of text) and background behind the text.
> 
> refer to https://www.w3.org/TR/WCAG20-TECHS/G18.html
> 
> 
> Thanks,
> 
> Chen Nan Li
> 
>

Re: Review Request 47209: Establish TCP connection after backing off.

[Qian Zhang]

> On May 14, 2016, 10:01 a.m., Qian Zhang wrote:
> > src/slave/slave.cpp, line 1020
> > 
> >
> > If we do the link here, that means we still establish TCP connection 
> > with master right after a new master is detected, right? But I think we 
> > want to do the link after the initial backoff to avoid SYN flood.
> 
> Cong Wang wrote:
> Authentication code path doesn't have a backoff, so we don't want to 
> touch it in this patch.

Thanks, so that means if there are a large number of agents in the cluster and 
each agent has authentication enabled, when new master is detected, it is still 
possible all those agents try to connect with master at the same time?


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47209/#review133243
---


On May 13, 2016, 11:37 a.m., David Robinson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47209/
> ---
> 
> (Updated May 13, 2016, 11:37 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Ian Downes, and Cong Wang.
> 
> 
> Bugs: MESOS-5330
> https://issues.apache.org/jira/browse/MESOS-5330
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Establish TCP connection after backing off.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp 116ea59b72950db4a7cd721b7ba5bfbb2e1c1454 
> 
> Diff: https://reviews.apache.org/r/47209/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Also started a master and agent and captured a tcpdump to verify the 
> connection is only established _after_ the registration backoff.
> 
> 
> Thanks,
> 
> David Robinson
> 
>

Re: Review Request 47403: Stout: Set `_fmode` to binary in `protobuf.hpp`.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47403/#review133311
---



Patch looks great!

Reviews applied: [47052, 47053, 47221, 47054, 41632, 47168, 47169, 47386, 
47387, 47388, 47389, 47390, 47391, 47403]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 15, 2016, 10:28 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47403/
> ---
> 
> (Updated May 15, 2016, 10:28 p.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
> Remoortere, and Michael Park.
> 
> 
> Bugs: MESOS-3443 and MESOS-3658
> https://issues.apache.org/jira/browse/MESOS-3443
> https://issues.apache.org/jira/browse/MESOS-3658
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In Windows, the I/O subsystem will automatically convert linefeed
> endings if the I/O is done on "text" files. For binary files, this
> effect is almost never desirable.
> 
> This commit will turn of these conversions for protobuf I/O operations.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/protobuf.hpp 
> eb4ac8cd738859a119f4f64bf52ae49a5bbef899 
> 
> Diff: https://reviews.apache.org/r/47403/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Review Request 47403: Stout: Set `_fmode` to binary in `protobuf.hpp`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47403/
---

Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
Remoortere, and Michael Park.


Bugs: MESOS-3443 and MESOS-3658
https://issues.apache.org/jira/browse/MESOS-3443
https://issues.apache.org/jira/browse/MESOS-3658


Repository: mesos


Description
---

In Windows, the I/O subsystem will automatically convert linefeed
endings if the I/O is done on "text" files. For binary files, this
effect is almost never desirable.

This commit will turn of these conversions for protobuf I/O operations.


Diffs
-

  3rdparty/stout/include/stout/protobuf.hpp 
eb4ac8cd738859a119f4f64bf52ae49a5bbef899 

Diff: https://reviews.apache.org/r/47403/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 47401: Corrected using order in authorizer.cpp.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47401/#review133307
---



Patch looks great!

Reviews applied: [47401]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 15, 2016, 9:25 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47401/
> ---
> 
> (Updated May 15, 2016, 9:25 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Mesos uses case-insensitive ordering of `using`.
> 
> 
> Diffs
> -
> 
>   src/authorizer/local/authorizer.cpp 
> e95435327bb3b6f447e814b8657bce8084535346 
> 
> Diff: https://reviews.apache.org/r/47401/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 47401: Corrected using order in authorizer.cpp.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47401/
---

(Updated May 15, 2016, 9:25 p.m.)


Review request for mesos and Alexander Rukletsov.


Summary (updated)
-

Corrected using order in authorizer.cpp.


Repository: mesos


Description
---

Mesos uses case-insensitive ordering of `using`.


Diffs
-

  src/authorizer/local/authorizer.cpp e95435327bb3b6f447e814b8657bce8084535346 

Diff: https://reviews.apache.org/r/47401/diff/


Testing
---


Thanks,

Joerg Schad

Re: Review Request 47402: Fixed agent to properly handle killTask during agent restart.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47402/#review133306
---



Patch looks great!

Reviews applied: [47402]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 15, 2016, 8:06 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47402/
> ---
> 
> (Updated May 15, 2016, 8:06 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-5380
> https://issues.apache.org/jira/browse/MESOS-5380
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If the agent restarts after handling killTask but before sending
> shutdown message to the executor, we ensure the executor terminates.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp bea35e5f7e22ced32514706827b4331c956ee674 
>   src/tests/slave_recovery_tests.cpp 70fdd0dae4ada1ccbdbc809c7e805d9738346b02 
>   src/tests/slave_tests.cpp 4b1cfbb9f8de0e60a8a2c1f48b78c62be9fbaa40 
> 
> Diff: https://reviews.apache.org/r/47402/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 47401: Corrected include order in authorizer.cpp.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47401/
---

(Updated May 15, 2016, 8:07 p.m.)


Review request for mesos and Alexander Rukletsov.


Repository: mesos


Description (updated)
---

Mesos uses case-insensitive ordering of `using`.


Diffs
-

  src/authorizer/local/authorizer.cpp e95435327bb3b6f447e814b8657bce8084535346 

Diff: https://reviews.apache.org/r/47401/diff/


Testing
---


Thanks,

Joerg Schad

Review Request 47402: Fixed agent to properly handle killTask during agent restart.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47402/
---

Review request for mesos and Jie Yu.


Bugs: MESOS-5380
https://issues.apache.org/jira/browse/MESOS-5380


Repository: mesos


Description
---

If the agent restarts after handling killTask but before sending
shutdown message to the executor, we ensure the executor terminates.


Diffs
-

  src/slave/slave.cpp bea35e5f7e22ced32514706827b4331c956ee674 
  src/tests/slave_recovery_tests.cpp 70fdd0dae4ada1ccbdbc809c7e805d9738346b02 
  src/tests/slave_tests.cpp 4b1cfbb9f8de0e60a8a2c1f48b78c62be9fbaa40 

Diff: https://reviews.apache.org/r/47402/diff/


Testing
---

make check


Thanks,

Vinod Kone

Review Request 47401: Corrected include order in authorizer.cpp.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47401/
---

Review request for mesos and Alexander Rukletsov.


Repository: mesos


Description
---

Mesos uses case-insensitive ordering of includes.


Diffs
-

  src/authorizer/local/authorizer.cpp e95435327bb3b6f447e814b8657bce8084535346 

Diff: https://reviews.apache.org/r/47401/diff/


Testing
---


Thanks,

Joerg Schad

Re: Review Request 47208: Fixed mesos test installation build.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47208/#review133304
---



Patch looks great!

Reviews applied: [47208]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 15, 2016, 6:20 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47208/
> ---
> 
> (Updated May 15, 2016, 6:20 p.m.)
> 
> 
> Review request for mesos, James Peach and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change modifies a couple of existing tests to make them
> pass when the mesos tests are configured to be installed. This
> also brings the `TestHTTPFramework` test to be at parity with
> the `TestFramework` code around finding the executor path logic.
> 
> 
> Diffs
> -
> 
>   src/examples/test_http_framework.cpp 
> 683384d986082a24b052505ef6be22b4dc20db00 
>   src/tests/dynamic_reservation_framework_test.sh 
> 00a10f18b98df941089d93f0163b644ce537fb04 
> 
> Diff: https://reviews.apache.org/r/47208/diff/
> 
> 
> Testing
> ---
> 
> make check
> $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none passes now
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 47400: Documentation quota authorization changes in 0.29.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47400/#review133303
---



Patch looks great!

Reviews applied: [47274, 47399, 47400]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 15, 2016, 5:43 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47400/
> ---
> 
> (Updated May 15, 2016, 5:43 p.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-5155 and MESOS-5336
> https://issues.apache.org/jira/browse/MESOS-5155
> https://issues.apache.org/jira/browse/MESOS-5336
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documentation quota authorization changes in 0.29.
> 
> 
> Diffs
> -
> 
>   docs/authorization.md 0db5c345b3239814b3b9d2e8a87601ff69d0f869 
>   docs/quota.md 797e134605381ae576d9aa93875e0314889ab047 
>   docs/upgrades.md 4f0c86db4c8d51f70487c03b2e75c1a4189b67b9 
> 
> Diff: https://reviews.apache.org/r/47400/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 47208: Fixed mesos test installation build.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47208/
---

(Updated May 15, 2016, 6:20 p.m.)


Review request for mesos, James Peach and Vinod Kone.


Changes
---

Review comments from Vinod


Summary (updated)
-

Fixed mesos test installation build.


Repository: mesos


Description (updated)
---

This change modifies a couple of existing tests to make them
pass when the mesos tests are configured to be installed. This
also brings the `TestHTTPFramework` test to be at parity with
the `TestFramework` code around finding the executor path logic.


Diffs (updated)
-

  src/examples/test_http_framework.cpp 683384d986082a24b052505ef6be22b4dc20db00 
  src/tests/dynamic_reservation_framework_test.sh 
00a10f18b98df941089d93f0163b644ce537fb04 

Diff: https://reviews.apache.org/r/47208/diff/


Testing (updated)
---

make check
$PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none passes now


Thanks,

Anand Mazumdar

Re: Review Request 47208: Fixed mesos test installation build.

[Anand Mazumdar]

> On May 15, 2016, 12:57 a.m., Vinod Kone wrote:
> > src/examples/test_framework.cpp, line 197
> > 
> >
> > This was added by jpeach for making tests run from the installation 
> > directory, IIRC. Does this not break that?

Good catch. I added him as a reviewer now. My bad, I needed to fix the other 2 
tests that were not consistent with this test.

[~jpeach] I hope we add adequate documentation for posterity after introducing 
new build/install flags so that we are not caught off guard again. Ideally, 
MESOS-4012 should have been resolved as part of committing MESOS-3608.


- Anand


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47208/#review133294
---


On May 15, 2016, 6:20 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47208/
> ---
> 
> (Updated May 15, 2016, 6:20 p.m.)
> 
> 
> Review request for mesos, James Peach and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change modifies a couple of existing tests to make them
> pass when the mesos tests are configured to be installed. This
> also brings the `TestHTTPFramework` test to be at parity with
> the `TestFramework` code around finding the executor path logic.
> 
> 
> Diffs
> -
> 
>   src/examples/test_http_framework.cpp 
> 683384d986082a24b052505ef6be22b4dc20db00 
>   src/tests/dynamic_reservation_framework_test.sh 
> 00a10f18b98df941089d93f0163b644ce537fb04 
> 
> Diff: https://reviews.apache.org/r/47208/diff/
> 
> 
> Testing
> ---
> 
> make check
> $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none passes now
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Review Request 47400: Documentation quota authorization changes in 0.29.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47400/
---

Review request for mesos, Adam B and Alexander Rukletsov.


Bugs: MESOS-5155 and MESOS-5336
https://issues.apache.org/jira/browse/MESOS-5155
https://issues.apache.org/jira/browse/MESOS-5336


Repository: mesos


Description
---

Documentation quota authorization changes in 0.29.


Diffs
-

  docs/authorization.md 0db5c345b3239814b3b9d2e8a87601ff69d0f869 
  docs/quota.md 797e134605381ae576d9aa93875e0314889ab047 
  docs/upgrades.md 4f0c86db4c8d51f70487c03b2e75c1a4189b67b9 

Diff: https://reviews.apache.org/r/47400/diff/


Testing
---


Thanks,

Zhitao Li

Re: Review Request 47399: New update_quotas ACL for both set and remove cases.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47399/#review133301
---



Patch looks great!

Reviews applied: [47274, 47399]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 15, 2016, 4:30 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47399/
> ---
> 
> (Updated May 15, 2016, 4:30 p.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-5155
> https://issues.apache.org/jira/browse/MESOS-5155
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> New update_quotas ACL for both set and remove cases.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/acls.proto 
> 9adae8c2a2e1b2ee4b9068ea50fcebb0544f2e5d 
>   include/mesos/authorizer/authorizer.proto 
> 32492a59ad95df3bb673ec42321518f86c11af59 
>   src/authorizer/local/authorizer.hpp 
> d15d3a6c9f3d7c432e593cfe78cc48d672848d02 
>   src/authorizer/local/authorizer.cpp 
> e95435327bb3b6f447e814b8657bce8084535346 
>   src/master/master.hpp 3e55114ee7866e06513071e86e15608099dae052 
>   src/master/quota_handler.cpp 6590519d8440f352f5bf00fda805414a5aad725c 
>   src/tests/authorization_tests.cpp f50ac69c32d0551a63391d97f31559ff4f414011 
>   src/tests/master_quota_tests.cpp 9ce7e2e481706c74f080d54b6f58d57874a27e64 
> 
> Diff: https://reviews.apache.org/r/47399/diff/
> 
> 
> Testing
> ---
> 
> Unit tests.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Review Request 47399: New update_quotas ACL for both set and remove cases.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47399/
---

Review request for mesos, Adam B and Alexander Rukletsov.


Bugs: MESOS-5155
https://issues.apache.org/jira/browse/MESOS-5155


Repository: mesos


Description
---

New update_quotas ACL for both set and remove cases.


Diffs
-

  include/mesos/authorizer/acls.proto 9adae8c2a2e1b2ee4b9068ea50fcebb0544f2e5d 
  include/mesos/authorizer/authorizer.proto 
32492a59ad95df3bb673ec42321518f86c11af59 
  src/authorizer/local/authorizer.hpp d15d3a6c9f3d7c432e593cfe78cc48d672848d02 
  src/authorizer/local/authorizer.cpp e95435327bb3b6f447e814b8657bce8084535346 
  src/master/master.hpp 3e55114ee7866e06513071e86e15608099dae052 
  src/master/quota_handler.cpp 6590519d8440f352f5bf00fda805414a5aad725c 
  src/tests/authorization_tests.cpp f50ac69c32d0551a63391d97f31559ff4f414011 
  src/tests/master_quota_tests.cpp 9ce7e2e481706c74f080d54b6f58d57874a27e64 

Diff: https://reviews.apache.org/r/47399/diff/


Testing
---

Unit tests.


Thanks,

Zhitao Li

Re: Review Request 47396: Added aufs provisioning backend.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47396/#review133300
---




src/slave/containerizer/mesos/provisioner/backend.cpp (line 32)


Move this above `bind.hpp`

#ifdef __linux__
#include "slave/containerizer/mesos/provisioner/backends/aufs.hpp"
#endif


- Guangya Liu


On 五月 15, 2016, 10:52 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47396/
> ---
> 
> (Updated 五月 15, 2016, 10:52 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Guangya Liu, and Jie Yu.
> 
> 
> Bugs: MESOS-4672
> https://issues.apache.org/jira/browse/MESOS-4672
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added aufs provisioning backend.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am ce5245883f3d2661812272702c0d2060513b6d88 
>   src/linux/fs.hpp 5951f3f289552d65bc854074135f5177c052caf1 
>   src/linux/fs.cpp 3190fcec572eddef3e3d5e81f5e508798deee1bd 
>   src/slave/containerizer/mesos/provisioner/backend.cpp 
> b2a20b7c08fa790da09ba05b725248e42b8d3bc4 
>   src/slave/containerizer/mesos/provisioner/backends/aufs.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/backends/aufs.cpp PRE-CREATION 
>   src/tests/containerizer/provisioner_backend_tests.cpp 
> bc04760c9504ea55cd4bb72c7e9012e43a5911aa 
>   src/tests/environment.cpp 011451b6dd463c83adb98c800e3b777c01fc6826 
> 
> Diff: https://reviews.apache.org/r/47396/diff/
> 
> 
> Testing
> ---
> 
> - Make check on ubuntu 14.04 64bit
> - Test manually: start slave with aufs backend, and write a simple script 
> that launches tasks with alpine/ubuntu images
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 47396: Added aufs provisioning backend.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47396/#review133299
---




src/slave/containerizer/mesos/provisioner/backends/aufs.cpp (lines 72 - 79)


I think this is not needed as it was already checked when creat the auts 
backend.



src/slave/containerizer/mesos/provisioner/backends/aufs.cpp (line 137)


blank line above

s/dir/directory



src/slave/containerizer/mesos/provisioner/backends/aufs.cpp (line 150)


blank line above


- Guangya Liu


On 五月 15, 2016, 10:52 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47396/
> ---
> 
> (Updated 五月 15, 2016, 10:52 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Guangya Liu, and Jie Yu.
> 
> 
> Bugs: MESOS-4672
> https://issues.apache.org/jira/browse/MESOS-4672
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added aufs provisioning backend.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am ce5245883f3d2661812272702c0d2060513b6d88 
>   src/linux/fs.hpp 5951f3f289552d65bc854074135f5177c052caf1 
>   src/linux/fs.cpp 3190fcec572eddef3e3d5e81f5e508798deee1bd 
>   src/slave/containerizer/mesos/provisioner/backend.cpp 
> b2a20b7c08fa790da09ba05b725248e42b8d3bc4 
>   src/slave/containerizer/mesos/provisioner/backends/aufs.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/backends/aufs.cpp PRE-CREATION 
>   src/tests/containerizer/provisioner_backend_tests.cpp 
> bc04760c9504ea55cd4bb72c7e9012e43a5911aa 
>   src/tests/environment.cpp 011451b6dd463c83adb98c800e3b777c01fc6826 
> 
> Diff: https://reviews.apache.org/r/47396/diff/
> 
> 
> Testing
> ---
> 
> - Make check on ubuntu 14.04 64bit
> - Test manually: start slave with aufs backend, and write a simple script 
> that launches tasks with alpine/ubuntu images
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 45200: Add deprecated flag names.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45200/#review133298
---



Patch looks great!

Reviews applied: [45200]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 15, 2016, 11:27 a.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45200/
> ---
> 
> (Updated May 15, 2016, 11:27 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3781
> https://issues.apache.org/jira/browse/MESOS-3781
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Replace 'slave' with 'agent' in flag names. Original names are marked
> as deprecated.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am ce5245883f3d2661812272702c0d2060513b6d88 
>   src/master/flags.cpp b97f01149b428a736d052cf7aece8ae092ca8cd4 
>   src/slave/flags.cpp b7df8f760d0f75459f1e80e3d8e18d49a3995df8 
>   src/tests/flags_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45200/diff/
> 
> 
> Testing
> ---
> 
> ./configure --with-network-isolator
> make check (on OSX and Ubuntu)
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 47396: Added aufs provisioning backend.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47396/#review133297
---



Patch looks great!

Reviews applied: [47396]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 15, 2016, 10:52 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47396/
> ---
> 
> (Updated May 15, 2016, 10:52 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Guangya Liu, and Jie Yu.
> 
> 
> Bugs: MESOS-4672
> https://issues.apache.org/jira/browse/MESOS-4672
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added aufs provisioning backend.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am ce5245883f3d2661812272702c0d2060513b6d88 
>   src/linux/fs.hpp 5951f3f289552d65bc854074135f5177c052caf1 
>   src/linux/fs.cpp 3190fcec572eddef3e3d5e81f5e508798deee1bd 
>   src/slave/containerizer/mesos/provisioner/backend.cpp 
> b2a20b7c08fa790da09ba05b725248e42b8d3bc4 
>   src/slave/containerizer/mesos/provisioner/backends/aufs.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/backends/aufs.cpp PRE-CREATION 
>   src/tests/containerizer/provisioner_backend_tests.cpp 
> bc04760c9504ea55cd4bb72c7e9012e43a5911aa 
>   src/tests/environment.cpp 011451b6dd463c83adb98c800e3b777c01fc6826 
> 
> Diff: https://reviews.apache.org/r/47396/diff/
> 
> 
> Testing
> ---
> 
> - Make check on ubuntu 14.04 64bit
> - Test manually: start slave with aufs backend, and write a simple script 
> that launches tasks with alpine/ubuntu images
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 45200: Add deprecated flag names.

[Jay Guo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45200/
---

(Updated May 15, 2016, 11:27 a.m.)


Review request for mesos and Vinod Kone.


Changes
---

rebase


Summary (updated)
-

Add deprecated flag names.


Bugs: MESOS-3781
https://issues.apache.org/jira/browse/MESOS-3781


Repository: mesos


Description (updated)
---

Replace 'slave' with 'agent' in flag names. Original names are marked
as deprecated.


Diffs (updated)
-

  src/Makefile.am ce5245883f3d2661812272702c0d2060513b6d88 
  src/master/flags.cpp b97f01149b428a736d052cf7aece8ae092ca8cd4 
  src/slave/flags.cpp b7df8f760d0f75459f1e80e3d8e18d49a3995df8 
  src/tests/flags_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/45200/diff/


Testing
---

./configure --with-network-isolator
make check (on OSX and Ubuntu)


Thanks,

Jay Guo

Re: Review Request 47396: Added aufs provisioning backend.

[Shuai Lin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47396/
---

(Updated May 15, 2016, 10:52 a.m.)


Review request for mesos, Gilbert Song, Guangya Liu, and Jie Yu.


Bugs: MESOS-4672
https://issues.apache.org/jira/browse/MESOS-4672


Repository: mesos


Description
---

Added aufs provisioning backend.


Diffs (updated)
-

  src/Makefile.am ce5245883f3d2661812272702c0d2060513b6d88 
  src/linux/fs.hpp 5951f3f289552d65bc854074135f5177c052caf1 
  src/linux/fs.cpp 3190fcec572eddef3e3d5e81f5e508798deee1bd 
  src/slave/containerizer/mesos/provisioner/backend.cpp 
b2a20b7c08fa790da09ba05b725248e42b8d3bc4 
  src/slave/containerizer/mesos/provisioner/backends/aufs.hpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/backends/aufs.cpp PRE-CREATION 
  src/tests/containerizer/provisioner_backend_tests.cpp 
bc04760c9504ea55cd4bb72c7e9012e43a5911aa 
  src/tests/environment.cpp 011451b6dd463c83adb98c800e3b777c01fc6826 

Diff: https://reviews.apache.org/r/47396/diff/


Testing
---

- Make check on ubuntu 14.04 64bit
- Test manually: start slave with aufs backend, and write a simple script that 
launches tasks with alpine/ubuntu images


Thanks,

Shuai Lin

Review Request 47396: Added aufs provisioning backend.

[Shuai Lin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47396/
---

Review request for mesos, Gilbert Song, Guangya Liu, and Jie Yu.


Bugs: MESOS-4672
https://issues.apache.org/jira/browse/MESOS-4672


Repository: mesos


Description
---

Added aufs provisioning backend.


Diffs
-

  src/Makefile.am ce5245883f3d2661812272702c0d2060513b6d88 
  src/linux/fs.hpp 5951f3f289552d65bc854074135f5177c052caf1 
  src/linux/fs.cpp 3190fcec572eddef3e3d5e81f5e508798deee1bd 
  src/slave/containerizer/mesos/provisioner/backend.cpp 
b2a20b7c08fa790da09ba05b725248e42b8d3bc4 
  src/slave/containerizer/mesos/provisioner/backends/aufs.hpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/backends/aufs.cpp PRE-CREATION 
  src/tests/containerizer/provisioner_backend_tests.cpp 
bc04760c9504ea55cd4bb72c7e9012e43a5911aa 
  src/tests/environment.cpp 011451b6dd463c83adb98c800e3b777c01fc6826 

Diff: https://reviews.apache.org/r/47396/diff/


Testing
---

- Make check on ubuntu 14.04 64bit
- Test manually: start slave with aufs backend, and write a simple script that 
launches tasks with alpine/ubuntu images


Thanks,

Shuai Lin