Re: Review Request 47693: Added more error info for mesos ps.

2016-05-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47693/#review134258 --- Patch looks great! Reviews applied: [47693] Passed command:

Review Request 47693: Added more error info for mesos ps.

2016-05-21 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47693/ --- Review request for mesos, Benjamin Mahler, Gilbert Song, Jie Yu, and Vinod Kone.

Re: Review Request 47559: Added authorization based filtering to /state-summary.

2016-05-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47559/#review134252 --- Patch looks great! Reviews applied: [47453, 47490, 47069, 46613,

Re: Review Request 47559: Added authorization based filtering to /state-summary.

2016-05-21 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47559/ --- (Updated May 21, 2016, 9:41 p.m.) Review request for mesos and Michael Park.

Re: Review Request 47558: Added filter interface to authorizer.

2016-05-21 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47558/ --- (Updated May 21, 2016, 9:40 p.m.) Review request for mesos, Michael Park and

Re: Review Request 46613: Introduced filtering relevant actions and acls.

2016-05-21 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46613/ --- (Updated May 21, 2016, 9:29 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 47069: Added `user` field to `Task` protobuf message.

2016-05-21 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47069/#review134250 --- src/common/http.cpp (lines 288 - 290)

Re: Review Request 47671: Windows: Removed the virtual inheritance in FlagsBase use.

2016-05-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47671/#review134242 --- Patch looks great! Reviews applied: [47473, 47492, 47486, 47474,

Re: Review Request 47559: Added authorization based filtering to /state-summary.

2016-05-21 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47559/ --- (Updated May 21, 2016, 5:50 p.m.) Review request for mesos and Michael Park.

Re: Review Request 47558: Added filter interface to authorizer.

2016-05-21 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47558/ --- (Updated May 21, 2016, 5:49 p.m.) Review request for mesos, Michael Park and

Re: Review Request 46613: Introduced filtering relevant actions and acls.

2016-05-21 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46613/ --- (Updated May 21, 2016, 5:48 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 47490: Moved `Task` to public protobufs.

2016-05-21 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47490/ --- (Updated May 21, 2016, 5:44 p.m.) Review request for mesos and Michael Park.

Re: Review Request 47671: Windows: Removed the virtual inheritance in FlagsBase use.

2016-05-21 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47671/ --- (Updated May 21, 2016, 4:52 p.m.) Review request for mesos, Alex Naparu, Artem

Re: Review Request 47559: Added authorization based filtering to /state-summary.

2016-05-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47559/#review134239 --- Bad patch! Reviews applied: [47559, 47558, 46613, 47491, 47069,

Re: Review Request 47559: Added authorization based filtering to /state-summary.

2016-05-21 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47559/ --- (Updated May 21, 2016, 3:53 p.m.) Review request for mesos and Michael Park.

Re: Review Request 47558: Added filter interface to authorizer.

2016-05-21 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47558/ --- (Updated May 21, 2016, 3:52 p.m.) Review request for mesos, Michael Park and

Re: Review Request 47558: WIP: Added filter interface to authorizer.

2016-05-21 Thread Joerg Schad
> On May 21, 2016, 4:45 a.m., Adam B wrote: > > include/mesos/authorizer/authorizer.hpp, lines 39-40 > > > > > > Does `filter()==true` mean that the subject is authorized for the > > object? Or does it mean that the

Re: Review Request 47558: WIP: Added filter interface to authorizer.

2016-05-21 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47558/ --- (Updated May 21, 2016, 3:47 p.m.) Review request for mesos, Michael Park and

Re: Review Request 47069: Added `user` field to `Task` protobuf message.

2016-05-21 Thread Joerg Schad
> On May 21, 2016, 5:49 a.m., Michael Park wrote: > > Do we not need to update other parts such as `bool operator==(const Task&, > > const Task&);`, and exposing the `user` field in `/state`, etc? Nice catch, added. - Joerg --- This

Re: Review Request 47069: Added `user` field to `Task` protobuf message.

2016-05-21 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47069/ --- (Updated May 21, 2016, 8:32 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 47633: Isolation/networking: check if IPv6 is loaded before trying to disable it

2016-05-21 Thread Zhengju Sha
> On 五月 20, 2016, 5:02 a.m., Cong Wang wrote: > > src/slave/containerizer/mesos/isolators/network/port_mapping.cpp, line 3927 > > > > > > You need to move this check into the script rather than in the C++ > >