Re: Review Request 50482: Fixed the CORS error when redirect in webui.

2016-07-26 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50482/#review143677 --- LGTM and verified that the web UI issue was solved.

Re: Review Request 43569: Updated log message if container not found.

2016-07-26 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43569/ --- (Updated 七月 27, 2016, 5:45 a.m.) Review request for mesos, Jie Yu and Timothy

Re: Review Request 50477: Fixed use-after-close bug when using libevent and SSL.

2016-07-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50477/#review143671 --- Patch looks great! Reviews applied: [50477] Passed command:

Re: Review Request 50215: Updated pre exec commands as non-shell in docker volume isolator.

2016-07-26 Thread James DeFelice
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50215/#review143666 ---

Re: Review Request 50482: Fixed the CORS error when redirect in webui.

2016-07-26 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50482/ --- (Updated July 27, 2016, 3:41 a.m.) Review request for mesos, Adam B, Jie Yu,

Review Request 50482: Fixed the CORS error when redirect in webui.

2016-07-26 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50482/ --- Review request for mesos, Adam B, Jie Yu, and Vinod Kone. Bugs: MESOS-5911

Re: Review Request 50327: Added scripts to build sample framework executables.

2016-07-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50327/#review143659 --- Patch looks great! Reviews applied: [50064, 50179, 50323, 50324,

Re: Review Request 50123: Added GPU scheduler for docker containerizer.

2016-07-26 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/#review143639 --- Some early comments. src/slave/containerizer/docker.hpp (line

Re: Review Request 49851: Implemented `MemorySubsystem`.

2016-07-26 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/#review143517 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp

Review Request 50477: Fixed use-after-close bug when using libevent and SSL.

2016-07-26 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50477/ --- Review request for mesos, Joris Van Remoortere and Joseph Wu. Bugs: MESOS-5913

Re: Review Request 50472: Added MESOS-5388 to 1.0 CHANGELOG.

2016-07-26 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50472/#review143647 --- Ship it! Ship It! - Vinod Kone On July 26, 2016, 10:37

Re: Review Request 50463: Added code to build libmesosjava shared library.

2016-07-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50463/#review143646 --- Bad patch! Reviews applied: [50463, 50460, 50459, 50458, 50457,

Re: Review Request 50254: Added an example test for the V0/V1 Mesos java implementation.

2016-07-26 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50254/#review143645 --- src/Makefile.am (line 1535)

Re: Review Request 50327: Added scripts to build sample framework executables.

2016-07-26 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50327/ --- (Updated July 26, 2016, 11:48 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 50326: Added script to build mesos-resolve.

2016-07-26 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50326/ --- (Updated July 26, 2016, 11:47 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 50325: Added script to build mesos-log tool.

2016-07-26 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50325/ --- (Updated July 26, 2016, 11:45 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 50253: Added native implementation for the V0 Mesos Adapter.

2016-07-26 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50253/#review143635 --- src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp (line 64)

Re: Review Request 50324: Added script to build mesos-execute.

2016-07-26 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50324/ --- (Updated July 26, 2016, 11:43 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 50323: Added build script for mesos-local executable.

2016-07-26 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50323/ --- (Updated July 26, 2016, 11:42 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 41787: Speed up SlaveRecoveryTest.*.

2016-07-26 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41787/#review143643 --- src/tests/slave_recovery_tests.cpp (lines 419 - 428)

Re: Review Request 43558: Speed up ExamplesTest.PersistentVolumeFramework.

2016-07-26 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43558/#review143640 --- Fix it, then Ship it!

Re: Review Request 45011: Fix numify() to handle negative numbers consistently (MESOS-4070).

2016-07-26 Thread Greg Mann
> On July 26, 2016, 8:30 p.m., Greg Mann wrote: > > Hi Yong, > > Do you still have interest in getting this committed? If so, it looks like > > it needs to be rebased. > > Yong Tang wrote: > Thanks Greg. I tried to rebase but my local copy has been lost. Don't > know how to recover so I

Re: Review Request 45011: Fix numify() to handle negative numbers consistently (MESOS-4070).

2016-07-26 Thread Yong Tang
> On July 26, 2016, 8:30 p.m., Greg Mann wrote: > > Hi Yong, > > Do you still have interest in getting this committed? If so, it looks like > > it needs to be rebased. Thanks Greg. I tried to rebase but my local copy has been lost. Don't know how to recover so I just created a new review

Review Request 50473: Fix numify() to handle negative numbers consistently (MESOS-4070).

2016-07-26 Thread Yong Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50473/ --- Review request for mesos, Greg Mann, Jie Yu, Neil Conway, and Cong Wang. Bugs:

Re: Review Request 50252: Added native implementation for v1 Mesos interface.

2016-07-26 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50252/#review143630 --- src/java/jni/org_apache_mesos_v1_scheduler_JNIMesos.cpp (line

Review Request 50472: Added MESOS-5388 to 1.0 CHANGELOG.

2016-07-26 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50472/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 50251: Added java implementations for the V0/V1 implementation for Mesos.

2016-07-26 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50251/#review143276 --- src/Makefile.am (lines 1518 - 1521)

Re: Review Request 50250: Added v1 Scheduler/Mesos interface in Java.

2016-07-26 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50250/#review143627 --- src/java/src/org/apache/mesos/v1/scheduler/Mesos.java (line 33)

Re: Review Request 50250: Added v1 Scheduler/Mesos interface in Java.

2016-07-26 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50250/#review143274 --- src/Makefile.am (lines 1518 - 1519)

Re: Review Request 50248: Added helper functions for v1 JNI `construct()`/`convert()`.

2016-07-26 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50248/#review143273 --- src/java/jni/construct.cpp (line 460)

Re: Review Request 50247: Added a abstract base class for scheduler library.

2016-07-26 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50247/#review143272 --- include/mesos/v1/scheduler.hpp (line 44)

Re: Review Request 49817: Implemented `CgroupsIsolatorProcess::recover`.

2016-07-26 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49817/#review143625 --- 'recover' sounds like the most complex one. Can you rebase this

Re: Review Request 49819: Implemented `CgroupsIsolatorProcess::prepare`.

2016-07-26 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49819/#review143618 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp

Review Request 50463: Added code to build libmesosjava shared library.

2016-07-26 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50463/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5902

Review Request 50460: Added code to build libstate shared library.

2016-07-26 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50460/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5902

Re: Review Request 50454: Fixed ExamplesTest.DiskFullFramework on non-root Linux builds.

2016-07-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50454/#review143622 --- Patch looks great! Reviews applied: [50454] Passed command:

Re: Review Request 40512: Libprocess Reinit: Add a test-only method to reinitialize libprocess.

2016-07-26 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40512/ --- (Updated July 26, 2016, 2:17 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 40268: Libprocess Reinit: Change Socket::DEFAULT_KIND to a non-static value.

2016-07-26 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40268/ --- (Updated July 26, 2016, 2:15 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 50215: Updated pre exec commands as non-shell in docker volume isolator.

2016-07-26 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50215/ --- (Updated July 26, 2016, 2:08 p.m.) Review request for mesos, Artem

Re: Review Request 40410: Libprocess Reinit: Move MetricsProcess instantiation into process.cpp.

2016-07-26 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40410/ --- (Updated July 26, 2016, 2:13 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 50215: Updated pre exec commands as non-shell in docker volume isolator.

2016-07-26 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50215/#review143620 --- Ship it! Ship It! - Jie Yu On July 26, 2016, 9:08 p.m.,

Re: Review Request 50454: Fixed ExamplesTest.DiskFullFramework on non-root Linux builds.

2016-07-26 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50454/#review143617 --- Ship it! LGTM - Anand Mazumdar On July 26, 2016, 9 p.m.,

Re: Review Request 50454: Fixed ExamplesTest.DiskFullFramework on non-root Linux builds.

2016-07-26 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50454/ --- (Updated July 26, 2016, 2 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 50454: Fixed ExamplesTest.DiskFullFramework on non-root Linux builds.

2016-07-26 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50454/#review143606 --- AFAICT, there are a couple of issues at play here: - The test

Re: Review Request 50454: Fixed ExamplesTest.DiskFullFramework on non-root Linux builds.

2016-07-26 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50454/ --- (Updated July 26, 2016, 1:31 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 45011: Fix numify() to handle negative numbers consistently (MESOS-4070).

2016-07-26 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45011/#review143603 --- Hi Yong, Do you still have interest in getting this committed? If

Re: Review Request 43569: Updated log message if container not found.

2016-07-26 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43569/#review143602 --- src/slave/containerizer/docker.cpp (line 379)

Review Request 50459: Added code to generate JNI Header files.

2016-07-26 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50459/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5902

Review Request 50458: Added code to build mesos-java.jar.

2016-07-26 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50458/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5902

Review Request 50457: Added code to generate MesosNativeLibrary.java.

2016-07-26 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50457/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5902

Review Request 50456: Added custom command to generate Java protobufs.

2016-07-26 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50456/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5902

Review Request 50454: Fixed ExamplesTest.DiskFullFramework on non-root Linux builds.

2016-07-26 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50454/ --- Review request for mesos, Artem Harutyunyan and Vinod Kone. Bugs: MESOS-5907

Review Request 50455: Enabled Java builds if Java is found.

2016-07-26 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50455/ --- Review request for mesos. Bugs: MESOS-5902

Re: Review Request 50415: Added build step to build Java Protobuf.

2016-07-26 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50415/ --- (Updated July 26, 2016, 7:34 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 50414: Added variables for building Java Protobuf.

2016-07-26 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50414/ --- (Updated July 26, 2016, 7:34 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 50214: Supported non-shell command in MesosLaunch to avoid arbitrary commands.

2016-07-26 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50214/#review143589 --- Fix it, then Ship it!

Re: Review Request 49855: Enabled cgroups unified isolator in isolation.

2016-07-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49855/#review143572 --- Patch looks great! Reviews applied: [50038, 49814, 49817, 49819,

Re: Review Request 50439: Made the log in `cgroups::prepare` more accurate.

2016-07-26 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50439/#review143567 --- Ship it! Ship It! - Jie Yu On July 26, 2016, 12:51 p.m.,

Re: Review Request 49855: Enabled cgroups unified isolator in isolation.

2016-07-26 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49855/ --- (Updated July 26, 2016, 5:18 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49855: Enabled cgroups unified isolator in isolation.

2016-07-26 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49855/ --- (Updated July 26, 2016, 5:16 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49853: Implemented `PerfEventSubsystem`.

2016-07-26 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49853/ --- (Updated July 26, 2016, 5:15 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 45573: Add `PerfEventHandleManager`.

2016-07-26 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45573/ --- (Updated July 26, 2016, 5:15 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49852: Implemented `NetClsSubsystem`.

2016-07-26 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49852/ --- (Updated July 26, 2016, 5:15 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49851: Implemented `MemorySubsystem`.

2016-07-26 Thread haosdent huang
> On July 26, 2016, 1:40 a.m., haosdent huang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp, line 498 > > > > > > ``` > > if (info->updatedLimit || limit > currentLimit.get()) { > >

Re: Review Request 49851: Implemented `MemorySubsystem`.

2016-07-26 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/ --- (Updated July 26, 2016, 5:13 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49850: Implemented `CpuacctSubsystem`.

2016-07-26 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49850/ --- (Updated July 26, 2016, 5:13 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49849: Implemented `CpuSubsystem`.

2016-07-26 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49849/ --- (Updated July 26, 2016, 5:12 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49828: Added default methods implementations for `Subsystem` base class.

2016-07-26 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49828/ --- (Updated July 26, 2016, 5:12 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49825: Implemented `CgroupsIsolatorProcess::status`.

2016-07-26 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49825/ --- (Updated July 26, 2016, 5:11 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49827: Implemented `CgroupsIsolatorProcess::cleanup`.

2016-07-26 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49827/ --- (Updated July 26, 2016, 5:11 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49823: Implemented `CgroupsIsolatorProcess::update`.

2016-07-26 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49823/ --- (Updated July 26, 2016, 5:11 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49824: Implemented `CgroupsIsolatorProcess::usage`.

2016-07-26 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49824/ --- (Updated July 26, 2016, 5:11 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49821: Implemented `CgroupsIsolatorProcess::watch`.

2016-07-26 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49821/ --- (Updated July 26, 2016, 5:10 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49817: Implemented `CgroupsIsolatorProcess::recover`.

2016-07-26 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49817/ --- (Updated July 26, 2016, 5:09 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49819: Implemented `CgroupsIsolatorProcess::prepare`.

2016-07-26 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49819/ --- (Updated July 26, 2016, 5:10 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

2016-07-26 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/#review143040 --- Haven't commented on tests. Will look at them together with other

Re: Review Request 50439: Made the log in `cgroups::prepare` more accurate.

2016-07-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50439/#review143542 --- Patch looks great! Reviews applied: [50439] Passed command:

Re: Review Request 49851: Implemented `MemorySubsystem`.

2016-07-26 Thread Qian Zhang
> On July 26, 2016, 9:40 a.m., haosdent huang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp, line 498 > > > > > > ``` > > if (info->updatedLimit || limit > currentLimit.get()) { > >

Re: Review Request 50441: Added a blank line in common/resources.cpp.

2016-07-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50441/#review143520 --- Patch looks great! Reviews applied: [50441] Passed command:

Re: Review Request 48291: Use varint comparator in replica log.

2016-07-26 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48291/#review143516 --- Ship it! Ship It! - haosdent huang On June 6, 2016, 7:54

Re: Review Request 49850: Implemented `CpuacctSubsystem`.

2016-07-26 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49850/#review143512 --- Fix it, then Ship it!

Re: Review Request 49849: Implemented `CpuSubsystem`.

2016-07-26 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49849/#review143513 --- src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp

Re: Review Request 50439: Made the log in `cgroups::prepare` more accurate.

2016-07-26 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50439/ --- (Updated July 26, 2016, 12:51 p.m.) Review request for mesos, Zhiwei Chen and

Re: Review Request 50439: Made the log in `cgroups::prepare` more accurate.

2016-07-26 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50439/#review143510 --- Fix it, then Ship it! src/linux/cgroups.cpp (line 432)

Re: Review Request 50439: Made the log in `cgroups::prepare` more accurate.

2016-07-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50439/#review143508 --- Patch looks great! Reviews applied: [50439] Passed command:

Re: Review Request 49616: Add suppression benchmark.

2016-07-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49616/#review143504 --- Patch looks great! Reviews applied: [49616] Passed command:

Review Request 50441: Added a blank line in common/resources.cpp.

2016-07-26 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50441/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

2016-07-26 Thread Jay Guo
> On Oct. 21, 2015, 7:02 a.m., Klaus Ma wrote: > > src/module/manager.hpp, line 94 > > > > > > Should we merge with `moduleParameters[moduleName]` or replace it? IMO, > > prefer to merge them; I'd like to leave it

Review Request 50439: Made the log in `cgroups::prepare` more accurate.

2016-07-26 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50439/ --- Review request for mesos, Zhiwei Chen and Jie Yu. Repository: mesos

Re: Review Request 49616: Add suppression benchmark.

2016-07-26 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49616/#review143492 --- src/tests/hierarchical_allocator_tests.cpp (lines 3792 - 3816)

Re: Review Request 49616: Add suppression benchmark.

2016-07-26 Thread Jacob Janco
> On July 26, 2016, 6 a.m., Guangya Liu wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 3637 > > > > > > Add the elapse time of adding slave here, an example here > >

Re: Review Request 49616: Add suppression benchmark.

2016-07-26 Thread Jacob Janco
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49616/ --- (Updated July 26, 2016, 7:03 a.m.) Review request for mesos, James Peach,

Re: Review Request 49616: Add suppression benchmark.

2016-07-26 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49616/#review143488 --- There seems to be some redundant files for this patch.

Re: Review Request 49616: Add suppression benchmark.

2016-07-26 Thread Guangya Liu
> On 七月 26, 2016, 6 a.m., Guangya Liu wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 3625 > > > > > > What about adding some check for the ranges? > > > > An example is here: > > > >

Re: Review Request 49616: Add suppression benchmark.

2016-07-26 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49616/#review143484 --- src/tests/hierarchical_allocator_tests.cpp (line 3577)