Re: Review Request 50827: Windows: Disable modules tests and related helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50827/#review144877 --- Patch looks great! Reviews applied: [50827] Passed command:

Re: Review Request 50763: Updated Linux 'MountInfoTable' entries to be sorted as expected.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50763/ --- (Updated Aug. 5, 2016, 5:47 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 50556: Added benchmark test for `Resources::filter`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50556/ --- (Updated 八月 5, 2016, 5:47 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50126: Fixed tests interfaces for GPU docker containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50126/ --- (Updated 八月 5, 2016, 5:42 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50463: Added code to build libmesosjava shared library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50463/#review144866 --- Patch looks great! Reviews applied: [50414, 50415, 50455, 50456,

Re: Review Request 50741: Replaced CHECK in SSL socket's `send()` with a log message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50741/#review144860 --- Thanks for the fix Greg! Shouldn't we apply the same fix to

Re: Review Request 50551: Added benchmark test for `Resources::contains`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50551/ --- (Updated 八月 5, 2016, 2:38 a.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 50380: Made resources benchmark test for ports `-=/-` more accurate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50380/ --- (Updated 八月 5, 2016, 2:32 a.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 50421: Added code to detect proper zookeeper home directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50421/#review144861 --- Patch looks great! Reviews applied: [50421] Passed command:

Re: Review Request 50387: Updated allocated number of range to 100 for sorter benchmark test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50387/#review144858 --- Ship it! Ship It! - Benjamin Mahler On July 25, 2016, 9:21

Re: Review Request 50621: Libprocess reinit: Moved HttpProxy finalization and destruction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50621/#review144856 --- 3rdparty/libprocess/src/process.cpp (line 1201)

Review Request 50827: Windows: Disable modules tests and related helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50827/ --- Review request for mesos, Daniel Pravat, Artem Harutyunyan, Alex Clemmer, and

Re: Review Request 49571: Added a benchmark test for allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49571/#review144852 --- Patch looks great! Reviews applied: [45960, 45961, 45962, 45963,

Re: Review Request 50723: Fixed the master to recover resources/update state for orphan tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50723/#review144848 --- Ship it! Ship It! - Vinod Kone On Aug. 4, 2016, 7:17 p.m.,

Re: Review Request 50815: Fixed a bug around handling orphaned tasks in `GET_TASKS` call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50815/#review144847 --- Ship it! Ship It! - Vinod Kone On Aug. 4, 2016, 7:17 p.m.,

Re: Review Request 40266: Libprocess Reinit: Cleanup SocketManager alongside ProcessManager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40266/#review144841 --- Fix it, then Ship it! 3rdparty/libprocess/src/process.cpp

Re: Review Request 50568: Updated -=/+= to subtract/add for resource object.

> On 八月 1, 2016, 10:39 p.m., Jiang Yan Xu wrote: > > Can we keep add/subtract private? The fact they were added to save some > > redudant work suggests their `private` nature. Otherwise what if people use > > `add` directly instead of `+=`? > > > > Looks like they were changed to public just

Re: Review Request 50723: Fixed the master to recover resources/update state for orphan tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50723/#review144835 --- Patch looks great! Reviews applied: [50815, 50723] Passed

Re: Review Request 50741: Replaced CHECK in SSL socket's `send()` with a log message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50741/ --- (Updated Aug. 4, 2016, 9:57 p.m.) Review request for mesos, Anand Mazumdar,

Review Request 50741: Replaced CHECK in SSL socket's `send()` with a log message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50741/ --- Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.

Re: Review Request 50463: Added code to build libmesosjava shared library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50463/ --- (Updated Aug. 4, 2016, 9:17 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 49863: Added Test Modules that are loaded by mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49863/ --- (Updated Aug. 4, 2016, 9:10 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 49863: Added Test Modules that are loaded by mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49863/ --- (Updated Aug. 4, 2016, 9:08 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 49863: Added Test Modules that are loaded by mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49863/ --- (Updated Aug. 4, 2016, 9:06 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 49863: Added Test Modules that are loaded by mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49863/ --- (Updated Aug. 4, 2016, 9:02 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 50421: Added code to detect proper zookeeper home directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50421/ --- (Updated Aug. 4, 2016, 8:49 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 50568: Updated -=/+= to subtract/add for resource object.

> On Aug. 1, 2016, 3:39 p.m., Jiang Yan Xu wrote: > > Can we keep add/subtract private? The fact they were added to save some > > redudant work suggests their `private` nature. Otherwise what if people use > > `add` directly instead of `+=`? > > > > Looks like they were changed to public just

Re: Review Request 50463: Added code to build libmesosjava shared library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50463/ --- (Updated Aug. 4, 2016, 8:42 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 50460: Added code to build libstate shared library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50460/ --- (Updated Aug. 4, 2016, 8:41 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 50810: Fixed provisioner appc support on windows build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50810/#review144819 --- Patch looks great! Reviews applied: [50810] Passed command:

Re: Review Request 50459: Added code to generate JNI Header files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50459/ --- (Updated Aug. 4, 2016, 8:38 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 50458: Added code to build mesos-java.jar.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50458/ --- (Updated Aug. 4, 2016, 8:36 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 50457: Added code to generate MesosNativeLibrary.java.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50457/ --- (Updated Aug. 4, 2016, 8:30 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/ --- (Updated Aug. 4, 2016, 8:26 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 45966: Offer shared resources to frameworks only if opted in.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45966/ --- (Updated Aug. 4, 2016, 8:26 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45963: Allow tasks to set persistent volume as readonly or readwrite resource.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45963/ --- (Updated Aug. 4, 2016, 8:26 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45964: Add unit tests for sharing of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45964/ --- (Updated Aug. 4, 2016, 8:26 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 49571: Added a benchmark test for allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49571/ --- (Updated Aug. 4, 2016, 8:26 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45967: Added documentation for shareable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45967/ --- (Updated Aug. 4, 2016, 8:26 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45962: Added a persistent volume test framework for shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/ --- (Updated Aug. 4, 2016, 8:26 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45960: Added interfaces to handle and track shareable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45960/ --- (Updated Aug. 4, 2016, 8:26 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 50456: Added custom command to generate Java protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50456/ --- (Updated Aug. 4, 2016, 8:26 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 50456: Added custom command to generate Java protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50456/ --- (Updated Aug. 4, 2016, 8:26 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 50455: Enabled Java builds if Java is found.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50455/ --- (Updated Aug. 4, 2016, 8:23 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 50414: Added variables for building Java Protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50414/ --- (Updated Aug. 4, 2016, 8:18 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 50415: Added build step to build Java Protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50415/ --- (Updated Aug. 4, 2016, 8:12 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 50414: Added variables for building Java Protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50414/ --- (Updated Aug. 4, 2016, 8:11 p.m.) Review request for mesos, Alex Clemmer and

Review Request 50815: Fixed a bug around handling orphaned tasks in `GET_TASKS` call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50815/ --- Review request for mesos, Vinod Kone and Zhitao Li. Bugs: MESOS-5930

Re: Review Request 50723: Fixed the master to recover resources/update state for orphan tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50723/ --- (Updated Aug. 4, 2016, 7:17 p.m.) Review request for mesos, Adam B, Neil

Re: Review Request 50723: Fixed the master to recover resources/update state for orphan tasks.

> On Aug. 3, 2016, 6:12 p.m., Neil Conway wrote: > > src/tests/master_tests.cpp, line 4665 > > > > > > Should we also check that the task correctly transitions to a terminal > > state in the master? > > Anand

Re: Review Request 50463: Added code to build libmesosjava shared library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50463/#review144811 --- Bad patch! Reviews applied: [50463, 50460, 50459, 50458, 50457,

Re: Review Request 49851: Implemented `MemorySubsystem`.

> On July 27, 2016, 2:05 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp, line 494 > > > > > > How do we recover this field `updatedLimit`? I mean during agent > >

Re: Review Request 50327: Added scripts to build sample framework executables.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50327/#review144801 --- Patch looks great! Reviews applied: [50064, 50179, 50323, 50324,

Re: Review Request 50763: Updated Linux 'MountInfoTable' entries to be sorted as expected.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50763/#review144686 --- src/linux/fs.hpp (lines 222 - 223)

Re: Review Request 50812: Updated `HealthCheck` protobuf for HTTP and TCP health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50812/ --- (Updated Aug. 4, 2016, 5:18 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 50812: Updated `HealthCheck` protobuf for HTTP and TCP health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50812/ --- (Updated Aug. 4, 2016, 5:12 p.m.) Review request for mesos, Adam B, Alexander

Review Request 50812: Updated `HealthCheck` protobuf for HTTP and TCP health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50812/ --- Review request for mesos, Adam B, Alexander Rukletsov, and Gastón Kleiman.

Review Request 50810: Fixed provisioner appc support on windows build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50810/ --- Review request for mesos, Artem Harutyunyan, Alex Clemmer, Jie Yu, and Joseph

Re: Review Request 50609: Moved check for '--version' in master and agent 'main.cpp'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50609/#review144778 --- Ship it! Ship It! - Vinod Kone On Aug. 2, 2016, 11:04 p.m.,

Re: Review Request 50463: Added code to build libmesosjava shared library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50463/ --- (Updated Aug. 4, 2016, 4:19 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/#review144776 --- src/health-check/health_checker.hpp (line 283)

Re: Review Request 50739: Updated '--fetcher_cache_dir' help string.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50739/#review144772 --- Patch looks great! Reviews applied: [50739] Passed command:

Re: Review Request 49360: Supported TCP check in health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49360/#review144767 --- include/mesos/mesos.proto (lines 348 - 355)

Re: Review Request 50325: Added script to build mesos-log tool.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50325/ --- (Updated Aug. 4, 2016, 3:28 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 50327: Added scripts to build sample framework executables.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50327/ --- (Updated Aug. 4, 2016, 3:28 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 50326: Added script to build mesos-resolve.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50326/ --- (Updated Aug. 4, 2016, 3:28 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 50127: Added NvidiaGpuDockerContainerizerTest.ROOT_DOCKER_LaunchWithGpu.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50127/#review144762 --- src/tests/containerizer/nvidia_gpu_isolator_tests.cpp (line 17)

Re: Review Request 50737: Parametrized libprocess HTTPTests by SSL configuration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50737/#review144764 --- Bad patch! Reviews applied: [50737, 50736, 40512, 40268, 40413,

Re: Review Request 50739: Updated '--fetcher_cache_dir' help string.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50739/ --- (Updated Aug. 4, 2016, 1:58 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 50723: Fixed the master to recover resources/update state for orphan tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50723/#review144748 --- Patch looks great! Reviews applied: [50723] Passed command:

Re: Review Request 50713: Documented behavior of content-type header in presence of errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50713/#review144741 --- Patch looks great! Reviews applied: [50713] Passed command:

Re: Review Request 50125: Added mesos-docker-executor support for device control.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/#review144725 --- Another comment is that I found it is difficult to review those

Re: Review Request 50723: Fixed the master to recover resources/update state for orphan tasks.

> On Aug. 3, 2016, 6:12 p.m., Neil Conway wrote: > > src/tests/master_tests.cpp, line 4665 > > > > > > Should we also check that the task correctly transitions to a terminal > > state in the master? > > Anand

Re: Review Request 50769: Fixed a broken link to CNI repo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50769/#review144729 --- Patch looks great! Reviews applied: [50769] Passed command:

Re: Review Request 50771: Added coverity build to build_docker.sh.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50771/#review144716 --- Patch looks great! Reviews applied: [50771] Passed command: