Re: Review Request 50827: Windows: Disable modules tests and related helpers.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50827/#review144877
---



Patch looks great!

Reviews applied: [50827]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Aug. 5, 2016, 12:41 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50827/
> ---
> 
> (Updated Aug. 5, 2016, 12:41 a.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Artem Harutyunyan, Alex Clemmer, and 
> Joris Van Remoortere.
> 
> 
> Bugs: MESOS-5994
> https://issues.apache.org/jira/browse/MESOS-5994
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Building and linking modules has some extra challenges on Windows
> (see MESOS-5994).
> 
> This patch #ifdef's some module-specific tests on Windows.
> NOTE: Most module tests are already parameterized to run the same code,
> once as a built-in class and once as a module.
> 
> 
> Diffs
> -
> 
>   src/tests/authorization_tests.cpp 5d7e17b67821357b8cb538798acc883945c8f8fd 
>   src/tests/container_logger_tests.cpp 
> efadceafca5721bce4dbffadb35f54fd5365abb0 
>   src/tests/containerizer/isolator_tests.cpp 
> 488747347f71a6a1bb6bc01477143d077d4fd3eb 
>   src/tests/cram_md5_authentication_tests.cpp 
> 56c249f48a09e86e1652362b54dca1fea5fc448b 
>   src/tests/http_authentication_tests.cpp 
> e73f21f7bd5ebb776ce5e950e1035182b32018ad 
>   src/tests/main.cpp e1507bae8267a10c85e631d10f243f299ff81dc9 
>   src/tests/master_authorization_tests.cpp 
> e43b264b9f67d4cd965aee143cc42a1034ac9952 
>   src/tests/slave_authorization_tests.cpp 
> 6f120b6ab5d86c3737e979cdcdb5b6cca008d1ff 
> 
> Diff: https://reviews.apache.org/r/50827/diff/
> 
> 
> Testing
> ---
> 
> make check (OSX)
> 
> TODO: Test this on Linux and Windows.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 50763: Updated Linux 'MountInfoTable' entries to be sorted as expected.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50763/
---

(Updated Aug. 5, 2016, 5:47 a.m.)


Review request for mesos, Benjamin Mahler and Jie Yu.


Changes
---

Updated the algorithm to build the sorted MountInfoTable entries.
Also added a test to verify the correctly sorted order.


Bugs: MESOS-5969
https://issues.apache.org/jira/browse/MESOS-5969


Repository: mesos


Description
---

Many places in the codebase assume that the mountinfo table is sorted
according to the order: 'parent mount point < child mount point'.

However, in some cases this may not be true if (for example), a parent
mount point (say '/') is remounted to add some extra flags to it.
When this happens, the remounted file system will appear in the
mountinfo table at the point where it was remounted.

We actually encountered this problem in the wild for the case of '/'
being remounted after '/run' was mounted -- causing problems in the
'NvidiaVolume' which assumes the 'parent < child' ordering.

This commit fixes this problem by building the list of MountInfoTable
entries in sorted order when 'read()' is called. An optional flag can
be used to disable sorting produce the the original ordering.


Diffs (updated)
-

  src/linux/fs.hpp ec3b5b8cd6926b1f69ad499de1c13b989766a84e 
  src/linux/fs.cpp f57db80ad0d7235d47910e05d663c77e233f8228 
  src/tests/containerizer/fs_tests.cpp 4cfafad28daac6bed849992a254660117d7ff30b 

Diff: https://reviews.apache.org/r/50763/diff/


Testing
---

GTEST_FILTER="" make -j check
src/mesos-tests
sudo src/mesos-tests

Appeared to have one unrelated flaky test fail: 
`ResourceOffersTest.ResourcesGetReofferedAfterTaskInfoError`
Rerunning the tests a second time passed.


Thanks,

Kevin Klues

Re: Review Request 50556: Added benchmark test for `Resources::filter`.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50556/
---

(Updated 八月 5, 2016, 5:47 a.m.)


Review request for mesos, Benjamin Mahler, Joris Van Remoortere, and Klaus Ma.


Summary (updated)
-

Added benchmark test for `Resources::filter`.


Bugs: MESOS-5700
https://issues.apache.org/jira/browse/MESOS-5700


Repository: mesos


Description (updated)
---

This benchmark test is using nonRevocable, revocable, unreserved
and reserved API benchmark test to test the API of filter for
Resources.


Diffs (updated)
-

  src/tests/resources_tests.cpp e61bdeffd5114ab481903c1178d9ecb3452ec85b 

Diff: https://reviews.apache.org/r/50556/diff/


Testing (updated)
---

make
make check

```
[==] Running 1 test from 1 test case.
[--] Global test environment set-up.
[--] 1 test from Resources_BENCHMARK_Test
[ RUN  ] Resources_BENCHMARK_Test.Filters
Took 853840us to perform 5 'r.nonRevocable()' operations on cpus(*):1; 
gpus(*):1; mem(*):128; disk(*):256
Took 188532us to perform 5 'r.revocable()' operations on cpus(*){REV}:1
Took 836740us to perform 5 'r.unreserved()' operations on cpus(*):1; 
gpus(*):1; mem(*):128; disk(*):256
Took 1.029417secs to perform 5 'r.reserved(role)' operations on 
cpus(role):1; gpus(role):1; mem(role):128; disk(role):256
[   OK ] Resources_BENCHMARK_Test.Filters (2909 ms)
[--] 1 test from Resources_BENCHMARK_Test (2909 ms total)

[--] Global test environment tear-down
[==] 1 test from 1 test case ran. (2932 ms total)
[  PASSED  ] 1 test.
```


Thanks,

Guangya Liu

Re: Review Request 50126: Fixed tests interfaces for GPU docker containerizer.

[Yubo Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50126/
---

(Updated 八月 5, 2016, 5:42 a.m.)


Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull.


Bugs: MESOS-5795
https://issues.apache.org/jira/browse/MESOS-5795


Repository: mesos


Description
---

This fixed API changes of testing module against docker containerizer
API changes to support GPU.


Diffs
-

  src/tests/mesos.hpp e4eccfc3810bed3649a3ab80e252849470de4c72 
  src/tests/mesos.cpp d073d79c5797ecb021f0294ab6586a000f3ca600 

Diff: https://reviews.apache.org/r/50126/diff/


Testing
---

make check


Thanks,

Yubo Li

Re: Review Request 50463: Added code to build libmesosjava shared library.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50463/#review144866
---



Patch looks great!

Reviews applied: [50414, 50415, 50455, 50456, 50457, 50458, 50459, 50460, 50463]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Aug. 4, 2016, 9:17 p.m., Srinivas Brahmaroutu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50463/
> ---
> 
> (Updated Aug. 4, 2016, 9:17 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Bugs: MESOS-5902
> https://issues.apache.org/jira/browse/MESOS-5902
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added code to build libmesosjava shared library.
> 
> 
> Diffs
> -
> 
>   cmake/MesosConfigure.cmake 6650c7c12b188b08c70cfee72b3200e83e7a1cd2 
>   src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 
> 
> Diff: https://reviews.apache.org/r/50463/diff/
> 
> 
> Testing
> ---
> 
> cmake && make mesosjava
> 
> Build /src/libmesosjava.* shared libraries.
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>

Re: Review Request 50741: Replaced CHECK in SSL socket's `send()` with a log message.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50741/#review144860
---



Thanks for the fix Greg! Shouldn't we apply the same fix to sendfile? Also made 
a minor suggestion below.


3rdparty/libprocess/src/libevent_ssl_socket.cpp (lines 704 - 713)


Don't we need the same fix in `sendfile`?

It seems a bit odd that we go ahead and write to the buffer event when we 
know that the socket has encountered an error or the receiving side has closed, 
because we've already sent a `Future(0)` back to the caller.

How about something like this?

```
// Check if the socket disconnected in the interim
// (i.e. we received an EOF (receiver closed) or ERROR event).
//
// TODO(bmahler): If we receive an EOF because the receiving
// side only shutdown writes on its socket, we can technically
// still send data on the socket!
//   See: http://www.unixguide.net/network/socketfaq/2.6.shtml

bool disconnected = false;

synchronized (self->lock) {
  if (self->send_request.get() == nullptr) {
disconnected = true;
  }
}

if (!disconnected) {
  int result = bufferevent_write_buffer(self->bev, buffer);
  CHECK_EQ(0, result);
}

evbuffer_free(buffer);
```

It looks like we treat EOF as the socket no longer being writable, which 
isn't necessarily true! I.e. if the caller shuts down writes it may still be 
interesting in reading: http://www.unixguide.net/network/socketfaq/2.6.shtml

How about introducing a TODO for this in the event callback code that deals 
with EOF?

```
// TODO(bmahler): If we receive an EOF because the receiving
// side only shutdown writes on its socket, we can technically
// still send data on the socket!
//   See: http://www.unixguide.net/network/socketfaq/2.6.shtml
```

Or just filing a ticket to investigate this further, because libprocess 
makes the same assumption and we've never received a report of clients that 
shutdown their write end early:

https://github.com/apache/mesos/blob/1.0.0/3rdparty/libprocess/src/process.cpp#L692-L697


- Benjamin Mahler


On Aug. 4, 2016, 9:57 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50741/
> ---
> 
> (Updated Aug. 4, 2016, 9:57 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-5986
> https://issues.apache.org/jira/browse/MESOS-5986
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The lambda placed on the event loop by the libevent SSL
> socket's `send()` method previously used a `CHECK` to
> ensure that the socket's `send_request` member was not
> `nullptr`. This patch removes this check and replaces it
> with a log message, since `send_request` may become
> `nullptr` any time the socket receives an EOF or ERROR
> event.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/libevent_ssl_socket.cpp 
> 97af3c25a350f4490f526e096678bb1eab066174 
> 
> Diff: https://reviews.apache.org/r/50741/diff/
> 
> 
> Testing
> ---
> 
> Ran a modified test case repeatedly to see this message printed when an SSL 
> socket receives an EOF at the appropriate time.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 50551: Added benchmark test for `Resources::contains`.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50551/
---

(Updated 八月 5, 2016, 2:38 a.m.)


Review request for mesos, Benjamin Mahler and Klaus Ma.


Bugs: MESOS-5700
https://issues.apache.org/jira/browse/MESOS-5700


Repository: mesos


Description
---

Added benchmark test for `Resources::contains`.


Diffs (updated)
-

  src/tests/resources_tests.cpp e61bdeffd5114ab481903c1178d9ecb3452ec85b 

Diff: https://reviews.apache.org/r/50551/diff/


Testing (updated)
---

make
make check

```
[==] Running 4 tests from 1 test case.
[--] Global test environment set-up.
[--] 4 tests from ResourcesOperators/Resources_BENCHMARK_Test
[ RUN  ] ResourcesOperators/Resources_BENCHMARK_Test.Contains/0
Took 933707us to perform 5 'initial.contains(r)' operations on cpus(*):1; 
gpus(*):1; mem(*):128; disk(*):256 with initial resources cpus(*):1; gpus(*):1; 
mem(*):128; disk(*):256
[   OK ] ResourcesOperators/Resources_BENCHMARK_Test.Contains/0 (934 ms)
[ RUN  ] ResourcesOperators/Resources_BENCHMARK_Test.Contains/1
Took 28.93978secs to perform 10 'initial.contains(r)' operations on cpus(0, 
principal_0, {key_0: value_0}):1; gpus(... with initial resources cpus(0, 
principal_0, {key_0: value_0}):1; gpus(...
[   OK ] ResourcesOperators/Resources_BENCHMARK_Test.Contains/1 (28998 ms)
[ RUN  ] ResourcesOperators/Resources_BENCHMARK_Test.Contains/2
Took 467295us to perform 1000 'initial.contains(r)' operations on 
ports(*):[1-2, 4-5, 7-8, 10-11, 13-14, 16-17, 1... with initial resources 
ports(*):[3-5]
[   OK ] ResourcesOperators/Resources_BENCHMARK_Test.Contains/2 (468 ms)
[ RUN  ] ResourcesOperators/Resources_BENCHMARK_Test.Contains/3
Took 1.115281secs to perform 5 'initial.contains(r)' operations on 
cpus(*):1; mem(*):128; disk(test)[persistentId:... with initial resources 
cpus(*):1; mem(*):128; disk(test)[persistentId:...
[   OK ] ResourcesOperators/Resources_BENCHMARK_Test.Contains/3 (1115 ms)
[--] 4 tests from ResourcesOperators/Resources_BENCHMARK_Test (31515 ms 
total)

[--] Global test environment tear-down
[==] 4 tests from 1 test case ran. (31534 ms total)
[  PASSED  ] 4 tests.
```


Thanks,

Guangya Liu

Re: Review Request 50380: Made resources benchmark test for ports `-=/-` more accurate.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50380/
---

(Updated 八月 5, 2016, 2:32 a.m.)


Review request for mesos, Benjamin Mahler and Klaus Ma.


Changes
---

Rebase with shared resources.


Bugs: MESOS-5898
https://issues.apache.org/jira/browse/MESOS-5898


Repository: mesos


Description
---

When run benchmark test for `ports` resources, the `-=` and `-` only
consumed about 10ms, this cannot reflect the real time of operating
1000 `ports` with `-=` and `-`.

The root cause is that the current calculation is always using same
port range, with port, the formula for `+` is `a+a+a+a+...+a==a`;
for `-`, it will be `a-a=0` and `0-a=0`.

With `0-a=0`, the code here
https://github.com/apache/mesos/blob/master/src/common/values.cpp#L544
will cause there is no validation as the `left` is empty after the
`ports` was subtracted to 0.

The fix is adding a new parameter `inital` act as the intial resources
for differente benchmark test. For `ports` resource, using an initial
`ports` which is different from the `resources`, this can make sure
the`ports` resources will never be subtracted to 0.


Diffs (updated)
-

  src/tests/resources_tests.cpp e61bdeffd5114ab481903c1178d9ecb3452ec85b 

Diff: https://reviews.apache.org/r/50380/diff/


Testing
---

make
make check

Before fix:
```
[ RUN  ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/2
Took 2.844742secs to perform 1000 'total += r' operations on ports(*):[1-2, 
4-5, 7-8, 10-11, 13-14, 16-17, 1...
Took 9ms to perform 1000 'total -= r' operations on ports(*):[1-2, 4-5, 7-8, 
10-11, 13-14, 16-17, 1...
Took 2.977936secs to perform 1000 'total = total + r' operations on 
ports(*):[1-2, 4-5, 7-8, 10-11, 13-14, 16-17, 1...
Took 9576us to perform 1000 'total = total - r' operations on ports(*):[1-2, 
4-5, 7-8, 10-11, 13-14, 16-17, 1...
[   OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/2 (5843 ms)
[--] 1 test from ResourcesOperators/Resources_BENCHMARK_Test (5843 ms 
total)
```

After fix:
```
[ RUN  ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/2
Took 2.728995secs to perform 1000 'total += r' operations on ports(*):[1-2, 
4-5, 7-8, 10-11, 13-14, 16-17, 1... with initial resources 
ports(*):[3-5]
Took 3.641868secs to perform 1000 'total -= r' operations on ports(*):[1-2, 
4-5, 7-8, 10-11, 13-14, 16-17, 1... with initial resources 
ports(*):[3-5]
Took 2.957178secs to perform 1000 'total = total + r' operations on 
ports(*):[1-2, 4-5, 7-8, 10-11, 13-14, 16-17, 1... with initial resources 
ports(*):[3-5]
Took 3.631125secs to perform 1000 'total = total - r' operations on 
ports(*):[1-2, 4-5, 7-8, 10-11, 13-14, 16-17, 1... with initial resources 
ports(*):[3-5]
[   OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/2 (12961 ms)
```


Thanks,

Guangya Liu

Re: Review Request 50421: Added code to detect proper zookeeper home directory.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50421/#review144861
---



Patch looks great!

Reviews applied: [50421]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Aug. 4, 2016, 8:49 p.m., Srinivas Brahmaroutu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50421/
> ---
> 
> (Updated Aug. 4, 2016, 8:49 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Bugs: MESOS-5905
> https://issues.apache.org/jira/browse/MESOS-5905
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added code to detect proper zookeeper home directory.
> 
> 
> Diffs
> -
> 
>   src/tests/zookeeper.cpp d29b100b9d38f2c70160cbd59dfffdcbd1690f47 
> 
> Diff: https://reviews.apache.org/r/50421/diff/
> 
> 
> Testing
> ---
> 
> cmake && make
> 
> test with autotools to make sure the tests run.
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>

Re: Review Request 50387: Updated allocated number of range to 100 for sorter benchmark test.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50387/#review144858
---


Ship it!




Ship It!

- Benjamin Mahler


On July 25, 2016, 9:21 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50387/
> ---
> 
> (Updated July 25, 2016, 9:21 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If setting port range fragments as 16, then the performance of
> `AgentAndClientCount/Sorter_BENCHMARK_Test.FullSort/35` does not
> improve much after the resource validation was removed when doing
> port range `+=` operations.
> 
> We should increase the port range fragments to increase the workload
> of the benchmark test for sorter port range fragments calculation.
> 
> After the port range fragments was increased to 100, we can see that
> the performance of this benchmark test was improved by 10x when adding
> port resources with and without resource validation.
> 
> 
> Diffs
> -
> 
>   src/tests/sorter_tests.cpp ade356cbbba5b93a6d3e5c9de30eefd3982d15c1 
> 
> Diff: https://reviews.apache.org/r/50387/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> Without resource validation:
> ```
> [==] Running 1 test from 1 test case.
> [--] Global test environment set-up.
> [--] 1 test from AgentAndClientCount/Sorter_BENCHMARK_Test
> [ RUN  ] AgentAndClientCount/Sorter_BENCHMARK_Test.FullSort/35
> Using 5 agents and 1000 clients
> Added 1000 clients in 20019us
> Added 5 agents in 1.112101secs
> Added allocations for 5 agents in 4.532103secs
> Full sort of 1000 clients took 41520us
> No-op sort of 1000 clients took 395us
> [   OK ] AgentAndClientCount/Sorter_BENCHMARK_Test.FullSort/35 (6886 ms)
> [--] 1 test from AgentAndClientCount/Sorter_BENCHMARK_Test (6886 ms 
> total)
> 
> [--] Global test environment tear-down
> [==] 1 test from 1 test case ran. (6907 ms total)
> [  PASSED  ] 1 test.
> ```
> 
> With resource validation:
> ```
> [==] Running 1 test from 1 test case.
> [--] Global test environment set-up.
> [--] 1 test from AgentAndClientCount/Sorter_BENCHMARK_Test
> [ RUN  ] AgentAndClientCount/Sorter_BENCHMARK_Test.FullSort/35
> Using 5 agents and 1000 clients
> Added 1000 clients in 22417us
> Added 5 agents in 1.273512secs
> Added allocations for 5 agents in 43.449178secs
> Full sort of 1000 clients took 31946us
> No-op sort of 1000 clients took 307us
> [   OK ] AgentAndClientCount/Sorter_BENCHMARK_Test.FullSort/35 (45996 ms)
> [--] 1 test from AgentAndClientCount/Sorter_BENCHMARK_Test (45996 ms 
> total)
> 
> [--] Global test environment tear-down
> [==] 1 test from 1 test case ran. (46019 ms total)
> [  PASSED  ] 1 test.
> ```
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 50621: Libprocess reinit: Moved HttpProxy finalization and destruction.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50621/#review144856
---




3rdparty/libprocess/src/process.cpp (line 1201)


I don't think this `Sequence` is actually used any more - the code which 
used it seems to have been removed with this commit: 
https://github.com/apache/mesos/commit/19dfc49fe
but we failed to remove `authentications` from `HttpProxy` at that time.


- Greg Mann


On July 29, 2016, 11:54 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50621/
> ---
> 
> (Updated July 29, 2016, 11:54 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Artem Harutyunyan, Joris Van Remoortere, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-3910
> https://issues.apache.org/jira/browse/MESOS-3910
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moves the destructor code in `HttpProxy` into the `Process::finalize`
> function.  And changes the `HttpProxy`s termination logic to 
> terminate via `UPID` which guards against double-termination.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> 7f331b812de2f0437838f48e0959441c8e04c358 
> 
> Diff: https://reviews.apache.org/r/50621/diff/
> 
> 
> Testing
> ---
> 
> make
> 
> (More testing doen later in the chain)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Review Request 50827: Windows: Disable modules tests and related helpers.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50827/
---

Review request for mesos, Daniel Pravat, Artem Harutyunyan, Alex Clemmer, and 
Joris Van Remoortere.


Bugs: MESOS-5994
https://issues.apache.org/jira/browse/MESOS-5994


Repository: mesos


Description
---

Building and linking modules has some extra challenges on Windows
(see MESOS-5994).

This patch #ifdef's some module-specific tests on Windows.
NOTE: Most module tests are already parameterized to run the same code,
once as a built-in class and once as a module.


Diffs
-

  src/tests/authorization_tests.cpp 5d7e17b67821357b8cb538798acc883945c8f8fd 
  src/tests/container_logger_tests.cpp efadceafca5721bce4dbffadb35f54fd5365abb0 
  src/tests/containerizer/isolator_tests.cpp 
488747347f71a6a1bb6bc01477143d077d4fd3eb 
  src/tests/cram_md5_authentication_tests.cpp 
56c249f48a09e86e1652362b54dca1fea5fc448b 
  src/tests/http_authentication_tests.cpp 
e73f21f7bd5ebb776ce5e950e1035182b32018ad 
  src/tests/main.cpp e1507bae8267a10c85e631d10f243f299ff81dc9 
  src/tests/master_authorization_tests.cpp 
e43b264b9f67d4cd965aee143cc42a1034ac9952 
  src/tests/slave_authorization_tests.cpp 
6f120b6ab5d86c3737e979cdcdb5b6cca008d1ff 

Diff: https://reviews.apache.org/r/50827/diff/


Testing
---

make check (OSX)

TODO: Test this on Linux and Windows.


Thanks,

Joseph Wu

Re: Review Request 49571: Added a benchmark test for allocations.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49571/#review144852
---



Patch looks great!

Reviews applied: [45960, 45961, 45962, 45963, 45964, 45966, 45967, 49571]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Aug. 4, 2016, 8:26 p.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49571/
> ---
> 
> (Updated Aug. 4, 2016, 8:26 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5771
> https://issues.apache.org/jira/browse/MESOS-5771
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Allocations test has the following configurations:
> (1) REGULAR: Offers from every slave have regular resources.
> (2) SHARED: Offers from every slave include a shared resource.
> (3) REGULAR: Offers from every alternate slave contain only regular
> resources; and offers from every other alternate slave contains
> a shared resource.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> cbed333f497016fe2811f755028796012b41db77 
> 
> Diff: https://reviews.apache.org/r/49571/diff/
> 
> 
> Testing
> ---
> 
> All tests passed.
> 
> Allocations benchmark test results
> ==
> Support of shared resources has a small impact on runtime performance in 
> allocations. Also, there is no visible impact in performance when shared 
> resources are added in the tests.
> 
> With the patch (and no shared resources)
> 
> round 0 allocate took 3.3096secs to make 2000 offers
> round 50 allocate took 3.302636secs to make 2000 offers
> round 100 allocate took 3.321002secs to make 2000 offers
> round 150 allocate took 3.305755secs to make 2000 offers
> round 199 allocate took 3.305825secs to make 2000 offers
> 
> With the patch (and shared resources on all agents)
> ---
> round 0 allocate took 3.361138secs to make 2000 offers
> round 50 allocate took 3.375249secs to make 2000 offers
> round 100 allocate took 3.36454secs to make 2000 offers
> round 150 allocate took 3.366206secs to make 2000 offers
> round 199 allocate took 3.365199secs to make 2000 offers
> 
> With the patch (and shared resources on alternate agents)
> -
> round 0 allocate took 3.335685secs to make 2000 offers
> round 50 allocate took 3.341063secs to make 2000 offers
> round 100 allocate took 3.341839secs to make 2000 offers
> round 150 allocate took 3.335622secs to make 2000 offers
> round 199 allocate took 3.337968secs to make 2000 offers
> 
> Based on HEAD, with all regular resources (no shared resources in HEAD 
> supported)
> -
> round 0 allocate took 3.00921secs to make 2000 offers
> round 50 allocate took 3.006498secs to make 2000 offers
> round 100 allocate took 3.004949secs to make 2000 offers
> round 150 allocate took 3.00702secs to make 2000 offers
> round 199 allocate took 3.00633secs to make 2000 offers
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 50723: Fixed the master to recover resources/update state for orphan tasks.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50723/#review144848
---


Ship it!




Ship It!

- Vinod Kone


On Aug. 4, 2016, 7:17 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50723/
> ---
> 
> (Updated Aug. 4, 2016, 7:17 p.m.)
> 
> 
> Review request for mesos, Adam B, Neil Conway, and Vinod Kone.
> 
> 
> Bugs: MESOS-5930
> https://issues.apache.org/jira/browse/MESOS-5930
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The master's status handler function used to ignore the status updates
> from the agents for frameworks not yet re-connected with the master
> upon a failover. This change modifies that logic to still update
> the local state and not bail out early.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 17d5c5875647bb35e2518cc2bd9e134b020c05bf 
>   src/tests/master_tests.cpp 6709818d599c068c289bcb714446018577082d8b 
> 
> Diff: https://reviews.apache.org/r/50723/diff/
> 
> 
> Testing
> ---
> 
> make check (gtest_repeat=100)
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 50815: Fixed a bug around handling orphaned tasks in `GET_TASKS` call.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50815/#review144847
---


Ship it!




Ship It!

- Vinod Kone


On Aug. 4, 2016, 7:17 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50815/
> ---
> 
> (Updated Aug. 4, 2016, 7:17 p.m.)
> 
> 
> Review request for mesos, Vinod Kone and Zhitao Li.
> 
> 
> Bugs: MESOS-5930
> https://issues.apache.org/jira/browse/MESOS-5930
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We erroneously wrapped the orphaned tasks loop with the loop
> for known frameworks. This means that we would append the list
> of orphaned tasks multiple times per framework. If there are
> no active frameworks, we won't even return any orphaned tasks.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp e26dc2ff19fdfebc4d57009f355ebc92df3b62fd 
> 
> Diff: https://reviews.apache.org/r/50815/diff/
> 
> 
> Testing
> ---
> 
> make check (tested as part of MESOS-5930)
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 40266: Libprocess Reinit: Cleanup SocketManager alongside ProcessManager.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40266/#review144841
---


Fix it, then Ship it!





3rdparty/libprocess/src/process.cpp (line 1113)


Remove `gc` from this list, since it now gets deleted in the destructor



3rdparty/libprocess/src/process.cpp (lines 1116 - 1118)


It's not clear to me precisely which logic this comment refers to - HTTP 
authentication logic occurs in `ProcessBase` rather than `ProcessManager`, so 
perhaps it's a typo. AFAIK all HTTP authentication happens within libprocess 
processes, so terminating all processes should be sufficient to complete any 
pending authentication requests and exit safely, but perhaps it's worth 
checking with Alexander to see exactly what he meant here?



3rdparty/libprocess/src/process.cpp (line 2433)


s/ProcessManager/`ProcessManager`/


- Greg Mann


On July 29, 2016, 11:53 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40266/
> ---
> 
> (Updated July 29, 2016, 11:53 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Artem Harutyunyan, Joris Van Remoortere, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-3910
> https://issues.apache.org/jira/browse/MESOS-3910
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The `SocketManager` and `ProcessManager` are highly inter-dependent, 
> which requires some untangling in `process::finalize`.
> 
> * Logic originally found in `~ProcessManager` has been split into 
>   `ProcessManager::finalize` due to what happens during cleanup.
> * The future from `__s__->accept()` must be explicitly discarded as 
>   libevent does not detect a locally closed socket.
> * Terminating `HttpProxy`s must close the associated socket.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> 7f331b812de2f0437838f48e0959441c8e04c358 
> 
> Diff: https://reviews.apache.org/r/40266/diff/
> 
> 
> Testing
> ---
> 
> `make check` (libev)
> `make check` (--enable-libevent --enable-ssl)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 50568: Updated -=/+= to subtract/add for resource object.

[Guangya Liu]

> On 八月 1, 2016, 10:39 p.m., Jiang Yan Xu wrote:
> > Can we keep add/subtract private? The fact they were added to save some 
> > redudant work suggests their `private` nature. Otherwise what if people use 
> > `add` directly instead of `+=`?
> > 
> > Looks like they were changed to public just so it can be called from the 
> > free-standing `convertJSON`, which is a private util method itself. We can 
> > just friend it right?
> 
> Benjamin Mahler wrote:
> Making it private sounds good and having a friend sounds good.
> 
> Guangya Liu wrote:
> Thanks Jinag Yan and Ben, I will follow up a patch later.
> 
> Jiang Yan Xu wrote:
> Hey Guangya have you started on it? If not we can take care of it because 
> we'd like to also consolidate `Resources::add(const Resource& r)` and 
> `add(const Resource_& r);`

Yes, I was working on this but found one issue and still checking. Currently, 
the function `static Try convertJSON` is a `static` function and the 
`friend` do not support `static` function so here we may need to make the 
`Try convertJSON` as a non-static function if we want to make it a 
`friend`, what do you think of this?

BTW: Can we make this and `consolidate Resources::add(const Resource& r) and 
add(const Resource_& r);` as separate patches?


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50568/#review144394
---


On 七月 29, 2016, 1:34 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50568/
> ---
> 
> (Updated 七月 29, 2016, 1:34 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Joris Van Remoortere, and Klaus Ma.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is a follow up action for MESOS-5919. Based on the patch of
> https://reviews.apache.org/r/50553/ and
> https://reviews.apache.org/r/50557/ , we should update -=/+= to
> subtract/add if the resource object is from resources object.
> 
> 
> Diffs
> -
> 
>   include/mesos/resources.hpp 88a9feabf66ed34e7e5b1c6cb7e831818e7f7883 
>   include/mesos/v1/resources.hpp 054ed00a03319ae5e350542add34f497eaf79152 
>   src/common/resources.cpp 3dbff24d6859d3b1ed8589cec50170a5202cfbcb 
>   src/v1/resources.cpp 3c85dc8aa8125962b44e60806ece83a7653d0dc7 
> 
> Diff: https://reviews.apache.org/r/50568/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 50723: Fixed the master to recover resources/update state for orphan tasks.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50723/#review144835
---



Patch looks great!

Reviews applied: [50815, 50723]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Aug. 4, 2016, 7:17 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50723/
> ---
> 
> (Updated Aug. 4, 2016, 7:17 p.m.)
> 
> 
> Review request for mesos, Adam B, Neil Conway, and Vinod Kone.
> 
> 
> Bugs: MESOS-5930
> https://issues.apache.org/jira/browse/MESOS-5930
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The master's status handler function used to ignore the status updates
> from the agents for frameworks not yet re-connected with the master
> upon a failover. This change modifies that logic to still update
> the local state and not bail out early.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 17d5c5875647bb35e2518cc2bd9e134b020c05bf 
>   src/tests/master_tests.cpp 6709818d599c068c289bcb714446018577082d8b 
> 
> Diff: https://reviews.apache.org/r/50723/diff/
> 
> 
> Testing
> ---
> 
> make check (gtest_repeat=100)
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 50741: Replaced CHECK in SSL socket's `send()` with a log message.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50741/
---

(Updated Aug. 4, 2016, 9:57 p.m.)


Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.


Bugs: MESOS-5986
https://issues.apache.org/jira/browse/MESOS-5986


Repository: mesos


Description
---

The lambda placed on the event loop by the libevent SSL
socket's `send()` method previously used a `CHECK` to
ensure that the socket's `send_request` member was not
`nullptr`. This patch removes this check and replaces it
with a log message, since `send_request` may become
`nullptr` any time the socket receives an EOF or ERROR
event.


Diffs
-

  3rdparty/libprocess/src/libevent_ssl_socket.cpp 
97af3c25a350f4490f526e096678bb1eab066174 

Diff: https://reviews.apache.org/r/50741/diff/


Testing (updated)
---

Ran a modified test case repeatedly to see this message printed when an SSL 
socket receives an EOF at the appropriate time.


Thanks,

Greg Mann

Review Request 50741: Replaced CHECK in SSL socket's `send()` with a log message.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50741/
---

Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.


Bugs: MESOS-5986
https://issues.apache.org/jira/browse/MESOS-5986


Repository: mesos


Description
---

The lambda placed on the event loop by the libevent SSL
socket's `send()` method previously used a `CHECK` to
ensure that the socket's `send_request` member was not
`nullptr`. This patch removes this check and replaces it
with a log message, since `send_request` may become
`nullptr` any time the socket receives an EOF or ERROR
event.


Diffs
-

  3rdparty/libprocess/src/libevent_ssl_socket.cpp 
97af3c25a350f4490f526e096678bb1eab066174 

Diff: https://reviews.apache.org/r/50741/diff/


Testing
---

Ran a modified test case repeatedly to see this message printed when an SSL 
socket receives an EOF at the appropriate time. Also ran the test contained in


Thanks,

Greg Mann

Re: Review Request 50463: Added code to build libmesosjava shared library.

[Srinivas Brahmaroutu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50463/
---

(Updated Aug. 4, 2016, 9:17 p.m.)


Review request for mesos, Alex Clemmer and Joseph Wu.


Bugs: MESOS-5902
https://issues.apache.org/jira/browse/MESOS-5902


Repository: mesos


Description (updated)
---

Added code to build libmesosjava shared library.


Diffs (updated)
-

  cmake/MesosConfigure.cmake 6650c7c12b188b08c70cfee72b3200e83e7a1cd2 
  src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 

Diff: https://reviews.apache.org/r/50463/diff/


Testing
---

cmake && make mesosjava

Build /src/libmesosjava.* shared libraries.


Thanks,

Srinivas Brahmaroutu

Re: Review Request 49863: Added Test Modules that are loaded by mesos tests.

[Srinivas Brahmaroutu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49863/
---

(Updated Aug. 4, 2016, 9:10 p.m.)


Review request for mesos, Alex Clemmer and Joseph Wu.


Bugs: MESOS-5792
https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description (updated)
---

Builds shared libraries for dynamically loading them by various tests:
libexamplemodule, libtestauthorizer, libtestisolator,
libtestresource_estimator, libtestallocator, libtestcontainer_logger,
libtestmastercontender, libtestanonymous, libtesthook,
libtestmasterdetector, libtestauthentication, libtesthttpauthenticator,
libtestqos_controller.


Diffs
-

  CMakeLists.txt ee8f565586b958929bc4e95b09827244d6d4155f 
  cmake/MesosConfigure.cmake 6650c7c12b188b08c70cfee72b3200e83e7a1cd2 
  src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 
  src/examples/CMakeLists.txt PRE-CREATION 
  src/examples/cmake/ExamplesConfigure.cmake PRE-CREATION 

Diff: https://reviews.apache.org/r/49863/diff/


Testing
---

cmake .. && make


Thanks,

Srinivas Brahmaroutu

Re: Review Request 49863: Added Test Modules that are loaded by mesos tests.

[Srinivas Brahmaroutu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49863/
---

(Updated Aug. 4, 2016, 9:08 p.m.)


Review request for mesos, Alex Clemmer and Joseph Wu.


Bugs: MESOS-5792
https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description (updated)
---

Builds shared libraries for dynamically loading them by various tests:
libexamplemodule, libtestauthorizer, libtestisolator, 
libtestresource_estimator, libtestallocator, libtestcontainer_logger, 
libtestmastercontender, libtestanonymous, libtesthook, libtestmasterdetector, 
libtestauthentication, libtesthttpauthenticator, libtestqos_controller.


Diffs
-

  CMakeLists.txt ee8f565586b958929bc4e95b09827244d6d4155f 
  cmake/MesosConfigure.cmake 6650c7c12b188b08c70cfee72b3200e83e7a1cd2 
  src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 
  src/examples/CMakeLists.txt PRE-CREATION 
  src/examples/cmake/ExamplesConfigure.cmake PRE-CREATION 

Diff: https://reviews.apache.org/r/49863/diff/


Testing
---

cmake .. && make


Thanks,

Srinivas Brahmaroutu

Re: Review Request 49863: Added Test Modules that are loaded by mesos tests.

[Srinivas Brahmaroutu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49863/
---

(Updated Aug. 4, 2016, 9:06 p.m.)


Review request for mesos, Alex Clemmer and Joseph Wu.


Bugs: MESOS-5792
https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description (updated)
---

Builds shared libraries for dynamically loading them by various tests:
libexamplemodule, libtestauthorizer, libtestisolator, 
libtestresource_estimator, 
libtestallocator, libtestcontainer_logger, libtestmastercontender, 
libtestanonymous, libtesthook, libtestmasterdetector, libtestauthentication, 
libtesthttpauthenticator, libtestqos_controller.


Diffs
-

  CMakeLists.txt ee8f565586b958929bc4e95b09827244d6d4155f 
  cmake/MesosConfigure.cmake 6650c7c12b188b08c70cfee72b3200e83e7a1cd2 
  src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 
  src/examples/CMakeLists.txt PRE-CREATION 
  src/examples/cmake/ExamplesConfigure.cmake PRE-CREATION 

Diff: https://reviews.apache.org/r/49863/diff/


Testing
---

cmake .. && make


Thanks,

Srinivas Brahmaroutu

Re: Review Request 49863: Added Test Modules that are loaded by mesos tests.

[Srinivas Brahmaroutu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49863/
---

(Updated Aug. 4, 2016, 9:02 p.m.)


Review request for mesos, Alex Clemmer and Joseph Wu.


Bugs: MESOS-5792
https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description
---

Added Test Modules that are loaded by mesos tests.


Diffs (updated)
-

  CMakeLists.txt ee8f565586b958929bc4e95b09827244d6d4155f 
  cmake/MesosConfigure.cmake 6650c7c12b188b08c70cfee72b3200e83e7a1cd2 
  src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 
  src/examples/CMakeLists.txt PRE-CREATION 
  src/examples/cmake/ExamplesConfigure.cmake PRE-CREATION 

Diff: https://reviews.apache.org/r/49863/diff/


Testing
---

cmake .. && make


Thanks,

Srinivas Brahmaroutu

Re: Review Request 50421: Added code to detect proper zookeeper home directory.

[Srinivas Brahmaroutu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50421/
---

(Updated Aug. 4, 2016, 8:49 p.m.)


Review request for mesos, Alex Clemmer and Joseph Wu.


Changes
---

This path is required to handle the new installation structure with
cmake builds. Earlier on auto tools zookeeper jar would be found at
/3rdparty/zookeeper-3.4.8/zookeeper-3.4.8.jar and with
cmake build system we have an additional directory structure added like
/3rdparty/zookeeper-3.4.8/src/zookeeper-3.4.8/zookeeper-3.4.8.jar.
This patch allows to set classpath from any of these locations by looking for
both.


Bugs: MESOS-5905
https://issues.apache.org/jira/browse/MESOS-5905


Repository: mesos


Description (updated)
---

Added code to detect proper zookeeper home directory.


Diffs (updated)
-

  src/tests/zookeeper.cpp d29b100b9d38f2c70160cbd59dfffdcbd1690f47 

Diff: https://reviews.apache.org/r/50421/diff/


Testing
---

cmake && make

test with autotools to make sure the tests run.


Thanks,

Srinivas Brahmaroutu

Re: Review Request 50568: Updated -=/+= to subtract/add for resource object.

[Jiang Yan Xu]

> On Aug. 1, 2016, 3:39 p.m., Jiang Yan Xu wrote:
> > Can we keep add/subtract private? The fact they were added to save some 
> > redudant work suggests their `private` nature. Otherwise what if people use 
> > `add` directly instead of `+=`?
> > 
> > Looks like they were changed to public just so it can be called from the 
> > free-standing `convertJSON`, which is a private util method itself. We can 
> > just friend it right?
> 
> Benjamin Mahler wrote:
> Making it private sounds good and having a friend sounds good.
> 
> Guangya Liu wrote:
> Thanks Jinag Yan and Ben, I will follow up a patch later.

Hey Guangya have you started on it? If not we can take care of it because we'd 
like to also consolidate `Resources::add(const Resource& r)` and `add(const 
Resource_& r);`


- Jiang Yan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50568/#review144394
---


On July 28, 2016, 6:34 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50568/
> ---
> 
> (Updated July 28, 2016, 6:34 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Joris Van Remoortere, and Klaus Ma.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is a follow up action for MESOS-5919. Based on the patch of
> https://reviews.apache.org/r/50553/ and
> https://reviews.apache.org/r/50557/ , we should update -=/+= to
> subtract/add if the resource object is from resources object.
> 
> 
> Diffs
> -
> 
>   include/mesos/resources.hpp 88a9feabf66ed34e7e5b1c6cb7e831818e7f7883 
>   include/mesos/v1/resources.hpp 054ed00a03319ae5e350542add34f497eaf79152 
>   src/common/resources.cpp 3dbff24d6859d3b1ed8589cec50170a5202cfbcb 
>   src/v1/resources.cpp 3c85dc8aa8125962b44e60806ece83a7653d0dc7 
> 
> Diff: https://reviews.apache.org/r/50568/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 50463: Added code to build libmesosjava shared library.

[Srinivas Brahmaroutu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50463/
---

(Updated Aug. 4, 2016, 8:42 p.m.)


Review request for mesos, Alex Clemmer and Joseph Wu.


Bugs: MESOS-5902
https://issues.apache.org/jira/browse/MESOS-5902


Repository: mesos


Description (updated)
---

Builds the shared library 'mesosjava' that allow interaction 
with Java components and share state information.


Diffs
-

  cmake/MesosConfigure.cmake 6650c7c12b188b08c70cfee72b3200e83e7a1cd2 
  src/CMakeLists.txt 32a8ae2320ee3dada8a19dd815eccb4710c18159 

Diff: https://reviews.apache.org/r/50463/diff/


Testing
---

cmake && make mesosjava

Build /src/libmesosjava.* shared libraries.


Thanks,

Srinivas Brahmaroutu

Re: Review Request 50460: Added code to build libstate shared library.

[Srinivas Brahmaroutu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50460/
---

(Updated Aug. 4, 2016, 8:41 p.m.)


Review request for mesos, Alex Clemmer and Joseph Wu.


Bugs: MESOS-5902
https://issues.apache.org/jira/browse/MESOS-5902


Repository: mesos


Description (updated)
---

The patch build libstate a convenient library that allows
state abstraction by providing necessary hooks to leveldb
and zookeeper.


Diffs (updated)
-

  cmake/MesosConfigure.cmake 6650c7c12b188b08c70cfee72b3200e83e7a1cd2 
  src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 
  src/state/CMakeLists.txt PRE-CREATION 

Diff: https://reviews.apache.org/r/50460/diff/


Testing
---

cmake .. && make state 

build libstate dynamic library.


Thanks,

Srinivas Brahmaroutu

Re: Review Request 50810: Fixed provisioner appc support on windows build.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50810/#review144819
---



Patch looks great!

Reviews applied: [50810]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Aug. 4, 2016, 5:05 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50810/
> ---
> 
> (Updated Aug. 4, 2016, 5:05 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Jie Yu, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed provisioner appc support on windows build.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 
> 40ee1da5ea453127c1e5e4cdf4b9a49bc998698a 
> 
> Diff: https://reviews.apache.org/r/50810/diff/
> 
> 
> Testing
> ---
> 
> N/A.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 50459: Added code to generate JNI Header files.

[Srinivas Brahmaroutu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50459/
---

(Updated Aug. 4, 2016, 8:38 p.m.)


Review request for mesos, Alex Clemmer and Joseph Wu.


Bugs: MESOS-5902
https://issues.apache.org/jira/browse/MESOS-5902


Repository: mesos


Description (updated)
---

This patch generates C++ jni bindings, the header files that will 
allow calling Java classes from C++.


Diffs (updated)
-

  cmake/MesosConfigure.cmake 6650c7c12b188b08c70cfee72b3200e83e7a1cd2 
  src/java/CMakeLists.txt PRE-CREATION 

Diff: https://reviews.apache.org/r/50459/diff/


Testing
---

cmake && make mesos-jni-header
check to see if all the headers are generated.
/include/java/jni/org_apache_mesos_Log.h
/include/java/jni/org_apache_mesos_Log_Entry.h
/include/java/jni/org_apache_mesos_Log_OperationFailedException.h
/include/java/jni/org_apache_mesos_Log_Position.h
/include/java/jni/org_apache_mesos_Log_Reader.h
/include/java/jni/org_apache_mesos_Log_Writer.h
/include/java/jni/org_apache_mesos_Log_WriterFailedException.h
/include/java/jni/org_apache_mesos_MesosExecutorDriver.h
/include/java/jni/org_apache_mesos_MesosSchedulerDriver.h
/include/java/jni/org_apache_mesos_state_AbstractState.h
/include/java/jni/org_apache_mesos_state_AbstractState_ExpungeFuture.h
/include/java/jni/org_apache_mesos_state_AbstractState_FetchFuture.h
/include/java/jni/org_apache_mesos_state_AbstractState_NamesFuture.h
/include/java/jni/org_apache_mesos_state_AbstractState_StoreFuture.h
/include/java/jni/org_apache_mesos_state_LevelDBState.h
/include/java/jni/org_apache_mesos_state_LogState.h
/include/java/jni/org_apache_mesos_state_Variable.h
/include/java/jni/org_apache_mesos_state_ZooKeeperState.h


Thanks,

Srinivas Brahmaroutu

Re: Review Request 50458: Added code to build mesos-java.jar.

[Srinivas Brahmaroutu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50458/
---

(Updated Aug. 4, 2016, 8:36 p.m.)


Review request for mesos, Alex Clemmer and Joseph Wu.


Changes
---

The patch builds 'mesos-java.jar; that contains the compiled
java sources under mesos source tree along with generated 
protobuf java sources from 'mesos-java-protos' target.


Bugs: MESOS-5902
https://issues.apache.org/jira/browse/MESOS-5902


Repository: mesos


Description
---

Added code to build mesos-java.jar.


Diffs (updated)
-

  cmake/MesosConfigure.cmake 6650c7c12b188b08c70cfee72b3200e83e7a1cd2 
  src/java/CMakeLists.txt PRE-CREATION 

Diff: https://reviews.apache.org/r/50458/diff/


Testing
---

cmake && make mesos-java 
Check to see if /src/java/mesos-java.jar


Thanks,

Srinivas Brahmaroutu

Re: Review Request 50457: Added code to generate MesosNativeLibrary.java.

[Srinivas Brahmaroutu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50457/
---

(Updated Aug. 4, 2016, 8:30 p.m.)


Review request for mesos, Alex Clemmer and Joseph Wu.


Changes
---

MesosNativeLibrary.java.in is one of many input files that uses 
variable substitutions using cmake build variables to generate 
final output files that will be compiled into the target binaries.
The patch provides a generic function to translate any *.in files 
using configure_file builtin routine similar to config.status.
Also we translate MesosNativeLibrary.java.in to MesosNativeLibrary.java.


Bugs: MESOS-5902
https://issues.apache.org/jira/browse/MESOS-5902


Repository: mesos


Description
---

Added code to generate MesosNativeLibrary.java.


Diffs (updated)
-

  cmake/MesosCommon.cmake PRE-CREATION 
  src/java/CMakeLists.txt PRE-CREATION 

Diff: https://reviews.apache.org/r/50457/diff/


Testing
---

cmake .. 
Check to see if 
/src/java/generated/org/apache/mesos/MesosNativeLibrary.java is 
generated.


Thanks,

Srinivas Brahmaroutu

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45961/
---

(Updated Aug. 4, 2016, 8:26 p.m.)


Review request for mesos, Benjamin Mahler, Joris Van Remoortere, Michael Park, 
and Jiang Yan Xu.


Changes
---

Rebased.


Bugs: MESOS-4431
https://issues.apache.org/jira/browse/MESOS-4431


Repository: mesos


Description
---

o Each shared resource is accouted via its share count. This count is
  updated based on the resource operations (such as add and subtract)
  in various scenarios such as task launch and terminate at multiple
  modules such as master, allocator, sorter, etc.
o Only allow DESTROY if there are no running or pending tasks using
  the volume. However, if the volume is in a pending offer to one or
  more frameworks, rescind that offer before processing the DESTROY.
o To allow multiple tasks to be launched in the same ACCEPT call
  using the same shared resource, we update the allocator and
  sorter with additional copies of shared resources to reflect the
  true shared count of allocated shared resources.


Diffs (updated)
-

  src/common/resources.cpp 2470c0280db7d48d9484c42bc2150e53e7ce6e1c 
  src/common/resources_utils.cpp 8e881a09500b0966b577e514077460f724868a8d 
  src/master/allocator/mesos/hierarchical.hpp 
bdbc6d3b5b959990538f4e3b7b1a3b031d9aea05 
  src/master/allocator/mesos/hierarchical.cpp 
7d4064535a20b93950f5a95eef1ad3f0d37d305b 
  src/master/allocator/sorter/drf/sorter.hpp 
bc6bfb2d5d3b32d55be055a0514861b4e7d889bb 
  src/master/allocator/sorter/drf/sorter.cpp 
ac85b327fc33d34246788e6a8c8bf5a486c61434 
  src/master/http.cpp e26dc2ff19fdfebc4d57009f355ebc92df3b62fd 
  src/master/master.hpp 6decff6f4b9c3434de030fd5c06df4c683a7abad 
  src/master/master.cpp 17d5c5875647bb35e2518cc2bd9e134b020c05bf 
  src/master/validation.hpp 43d876b00511d4ef652c2685d4950c994b5eef31 
  src/master/validation.cpp af18e5aef3be59830b0a7b0235bbc739dba1029c 
  src/tests/master_validation_tests.cpp 
9eb82a569f7c48caa96d4d54a93b199ccac74385 
  src/tests/sorter_tests.cpp ade356cbbba5b93a6d3e5c9de30eefd3982d15c1 
  src/v1/resources.cpp 6c4e3b299e701d477947dd7427c31d2ae64c05ae 

Diff: https://reviews.apache.org/r/45961/diff/


Testing
---

Tests successful.


Thanks,

Anindya Sinha

Re: Review Request 45966: Offer shared resources to frameworks only if opted in.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45966/
---

(Updated Aug. 4, 2016, 8:26 p.m.)


Review request for mesos and Jiang Yan Xu.


Changes
---

Rebased.


Bugs: MESOS-4325
https://issues.apache.org/jira/browse/MESOS-4325


Repository: mesos


Description
---

Added a new capability SHARED_RESOURCES that frameworks need to opt
in if they are interested in receiving shared resources in their
offers.


Diffs (updated)
-

  include/mesos/mesos.proto 8c74d0bdc1d15074b55d1be84816307bb9478a38 
  include/mesos/v1/mesos.proto 94b59dd75abfa9e8601e59f7a20dfd94bc88fa70 
  src/examples/persistent_shared_volume_framework.cpp PRE-CREATION 
  src/master/allocator/mesos/hierarchical.hpp 
bdbc6d3b5b959990538f4e3b7b1a3b031d9aea05 
  src/master/allocator/mesos/hierarchical.cpp 
7d4064535a20b93950f5a95eef1ad3f0d37d305b 
  src/tests/hierarchical_allocator_tests.cpp 
cbed333f497016fe2811f755028796012b41db77 

Diff: https://reviews.apache.org/r/45966/diff/


Testing
---

Tests updated with new capability.
Tests successful.


Thanks,

Anindya Sinha

Re: Review Request 45963: Allow tasks to set persistent volume as readonly or readwrite resource.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45963/
---

(Updated Aug. 4, 2016, 8:26 p.m.)


Review request for mesos and Jiang Yan Xu.


Changes
---

Rebased.


Bugs: MESOS-4324
https://issues.apache.org/jira/browse/MESOS-4324


Repository: mesos


Description
---

Allow the task to specify the persistent volume access to be read-only
or read-write. Note that the persistent volume is always created as
read-write.
If the task is the first consumer of the shared persistent volume, then
set the ownership of the persistent volume to match that of the task.
Otherwise, allow the task to be executed only if the ownership of the
persistent volume matches that of the task.
Added an option to run the test in mixed (default) mode or shared-only
mode. In mixed mode, multiple shards alternate between shared and
unshared persistent volumes for the tasks. In shared-only mode, all
shards use shared persistent volumes for the tasks.


Diffs (updated)
-

  src/examples/persistent_shared_volume_framework.cpp PRE-CREATION 
  src/master/validation.hpp 43d876b00511d4ef652c2685d4950c994b5eef31 
  src/master/validation.cpp af18e5aef3be59830b0a7b0235bbc739dba1029c 
  src/slave/containerizer/mesos/isolators/filesystem/linux.hpp 
0a85935550e36c9142d845465cfa70a1634a647a 
  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
6bf9a4a6438697657750f62980480205c558b6cc 
  src/slave/containerizer/mesos/isolators/filesystem/posix.hpp 
794b6e5990db5f8eb21a6535872f284ca02e0553 
  src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
af427c6e5691f1770ab3ebef79502eb2c2176c4a 

Diff: https://reviews.apache.org/r/45963/diff/


Testing
---

Tests successful.


Thanks,

Anindya Sinha

Re: Review Request 45964: Add unit tests for sharing of resources.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45964/
---

(Updated Aug. 4, 2016, 8:26 p.m.)


Review request for mesos and Jiang Yan Xu.


Changes
---

Rebased.


Bugs: MESOS-4324
https://issues.apache.org/jira/browse/MESOS-4324


Repository: mesos


Description
---

Add unit tests for sharing of resources.


Diffs (updated)
-

  src/tests/hierarchical_allocator_tests.cpp 
cbed333f497016fe2811f755028796012b41db77 
  src/tests/master_validation_tests.cpp 
9eb82a569f7c48caa96d4d54a93b199ccac74385 
  src/tests/mesos.hpp 9174a3810d0da34b99dc257e9c77f83107fdd9f5 
  src/tests/persistent_volume_tests.cpp 
a6f97c4bb5fb29d610c01255036095e2b30c44c5 
  src/tests/resources_tests.cpp e61bdeffd5114ab481903c1178d9ecb3452ec85b 

Diff: https://reviews.apache.org/r/45964/diff/


Testing
---

Tests for shared resources added for allocator, resources and sorter.
Tests successful.


Thanks,

Anindya Sinha

Re: Review Request 49571: Added a benchmark test for allocations.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49571/
---

(Updated Aug. 4, 2016, 8:26 p.m.)


Review request for mesos and Jiang Yan Xu.


Changes
---

Rebased.


Bugs: MESOS-5771
https://issues.apache.org/jira/browse/MESOS-5771


Repository: mesos


Description
---

Allocations test has the following configurations:
(1) REGULAR: Offers from every slave have regular resources.
(2) SHARED: Offers from every slave include a shared resource.
(3) REGULAR: Offers from every alternate slave contain only regular
resources; and offers from every other alternate slave contains
a shared resource.


Diffs (updated)
-

  src/tests/hierarchical_allocator_tests.cpp 
cbed333f497016fe2811f755028796012b41db77 

Diff: https://reviews.apache.org/r/49571/diff/


Testing
---

All tests passed.

Allocations benchmark test results
==
Support of shared resources has a small impact on runtime performance in 
allocations. Also, there is no visible impact in performance when shared 
resources are added in the tests.

With the patch (and no shared resources)

round 0 allocate took 3.3096secs to make 2000 offers
round 50 allocate took 3.302636secs to make 2000 offers
round 100 allocate took 3.321002secs to make 2000 offers
round 150 allocate took 3.305755secs to make 2000 offers
round 199 allocate took 3.305825secs to make 2000 offers

With the patch (and shared resources on all agents)
---
round 0 allocate took 3.361138secs to make 2000 offers
round 50 allocate took 3.375249secs to make 2000 offers
round 100 allocate took 3.36454secs to make 2000 offers
round 150 allocate took 3.366206secs to make 2000 offers
round 199 allocate took 3.365199secs to make 2000 offers

With the patch (and shared resources on alternate agents)
-
round 0 allocate took 3.335685secs to make 2000 offers
round 50 allocate took 3.341063secs to make 2000 offers
round 100 allocate took 3.341839secs to make 2000 offers
round 150 allocate took 3.335622secs to make 2000 offers
round 199 allocate took 3.337968secs to make 2000 offers

Based on HEAD, with all regular resources (no shared resources in HEAD 
supported)
-
round 0 allocate took 3.00921secs to make 2000 offers
round 50 allocate took 3.006498secs to make 2000 offers
round 100 allocate took 3.004949secs to make 2000 offers
round 150 allocate took 3.00702secs to make 2000 offers
round 199 allocate took 3.00633secs to make 2000 offers


Thanks,

Anindya Sinha

Re: Review Request 45967: Added documentation for shareable resources.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45967/
---

(Updated Aug. 4, 2016, 8:26 p.m.)


Review request for mesos and Jiang Yan Xu.


Changes
---

Rebased.


Bugs: MESOS-4325
https://issues.apache.org/jira/browse/MESOS-4325


Repository: mesos


Description
---

Added documentation for shareable resources.


Diffs (updated)
-

  docs/home.md 80451f4a9b2327dc728b9454938b6205043bebbb 
  docs/shared-resources.md PRE-CREATION 

Diff: https://reviews.apache.org/r/45967/diff/


Testing
---

Tests successful.


Thanks,

Anindya Sinha

Re: Review Request 45962: Added a persistent volume test framework for shared volumes.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45962/
---

(Updated Aug. 4, 2016, 8:26 p.m.)


Review request for mesos and Jiang Yan Xu.


Changes
---

Rebased.


Bugs: MESOS-4431
https://issues.apache.org/jira/browse/MESOS-4431


Repository: mesos


Description
---

Added a persistent volume test framework for shared volumes.


Diffs (updated)
-

  src/Makefile.am 1a9b083493612cf610b80ac5a1c11c29d6302933 
  src/examples/persistent_shared_volume_framework.cpp PRE-CREATION 
  src/tests/examples_tests.cpp 52fac33733cc86dd718c7836c5031999f1597a5c 
  src/tests/persistent_shared_volume_framework_test.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/45962/diff/


Testing
---

New test framework for shared resources added.
Tests successful.


Thanks,

Anindya Sinha

Re: Review Request 45960: Added interfaces to handle and track shareable resources.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45960/
---

(Updated Aug. 4, 2016, 8:26 p.m.)


Review request for mesos and Jiang Yan Xu.


Changes
---

Rebased.


Bugs: MESOS-4431
https://issues.apache.org/jira/browse/MESOS-4431


Repository: mesos


Description
---

Added interfaces to handle and track shareable resources.


Diffs (updated)
-

  include/mesos/resources.hpp bdbe8ea03a50cd1361640bde13a2342909723fc5 
  include/mesos/v1/resources.hpp c05cb634c7a5add78da00cb84fc75d3472a341bc 
  src/common/resources.cpp 2470c0280db7d48d9484c42bc2150e53e7ce6e1c 
  src/v1/resources.cpp 6c4e3b299e701d477947dd7427c31d2ae64c05ae 

Diff: https://reviews.apache.org/r/45960/diff/


Testing
---

Tests successful.


Thanks,

Anindya Sinha

Re: Review Request 50456: Added custom command to generate Java protobufs.

[Srinivas Brahmaroutu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50456/
---

(Updated Aug. 4, 2016, 8:26 p.m.)


Review request for mesos, Alex Clemmer and Joseph Wu.


Bugs: MESOS-5902
https://issues.apache.org/jira/browse/MESOS-5902


Repository: mesos


Description (updated)
---

This path generates java sources for all the relevant
protbuf definitions. It uses protoc to output the 
generated classes.


Diffs (updated)
-

  cmake/MesosConfigure.cmake 6650c7c12b188b08c70cfee72b3200e83e7a1cd2 
  src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 
  src/java/CMakeLists.txt PRE-CREATION 

Diff: https://reviews.apache.org/r/50456/diff/


Testing
---

cmake .. && make mesos-java-protos.
check to see if java/generated folder has all the new java files created.
/src/java/generated/org/apache/mesos/containerizer/Protos.java
/src/java/generated/org/apache/mesos/fetcher/Protos.java
/src/java/generated/org/apache/mesos/Protos.java
/src/java/generated/org/apache/mesos/scheduler/Protos.java
/src/java/generated/org/apache/mesos/v1/executor/Protos.java
/src/java/generated/org/apache/mesos/v1/Protos.java
/src/java/generated/org/apache/mesos/v1/scheduler/Protos.java


Thanks,

Srinivas Brahmaroutu

Re: Review Request 50456: Added custom command to generate Java protobufs.

[Srinivas Brahmaroutu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50456/
---

(Updated Aug. 4, 2016, 8:26 p.m.)


Review request for mesos, Alex Clemmer and Joseph Wu.


Bugs: MESOS-5902
https://issues.apache.org/jira/browse/MESOS-5902


Repository: mesos


Description (updated)
---

This patch generates java sources for all the relevant
protbuf definitions. It uses protoc to output the 
generated classes.


Diffs
-

  cmake/MesosConfigure.cmake 6650c7c12b188b08c70cfee72b3200e83e7a1cd2 
  src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 
  src/java/CMakeLists.txt PRE-CREATION 

Diff: https://reviews.apache.org/r/50456/diff/


Testing
---

cmake .. && make mesos-java-protos.
check to see if java/generated folder has all the new java files created.
/src/java/generated/org/apache/mesos/containerizer/Protos.java
/src/java/generated/org/apache/mesos/fetcher/Protos.java
/src/java/generated/org/apache/mesos/Protos.java
/src/java/generated/org/apache/mesos/scheduler/Protos.java
/src/java/generated/org/apache/mesos/v1/executor/Protos.java
/src/java/generated/org/apache/mesos/v1/Protos.java
/src/java/generated/org/apache/mesos/v1/scheduler/Protos.java


Thanks,

Srinivas Brahmaroutu

Re: Review Request 50455: Enabled Java builds if Java is found.

[Srinivas Brahmaroutu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50455/
---

(Updated Aug. 4, 2016, 8:23 p.m.)


Review request for mesos, Alex Clemmer and Joseph Wu.


Changes
---

Run cmake with ENABLE_JAVA=1 or ON, then the script will look
for java on the host and sets the Java path variables including 
classpath and java executable locations. Also the include directory
paths set up for using with JNI bindings.


Bugs: MESOS-5902
https://issues.apache.org/jira/browse/MESOS-5902


Repository: mesos


Description
---

Enabled Java builds if Java is found.


Diffs (updated)
-

  cmake/MesosConfigure.cmake 6650c7c12b188b08c70cfee72b3200e83e7a1cd2 

Diff: https://reviews.apache.org/r/50455/diff/


Testing (updated)
---

cmake -DENABLE_JAVA=ON 
check build variables set for Java.
cmake should output
-- 
-- Java Found and will be enabled
-- 


Thanks,

Srinivas Brahmaroutu

Re: Review Request 50414: Added variables for building Java Protobuf.

[Srinivas Brahmaroutu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50414/
---

(Updated Aug. 4, 2016, 8:18 p.m.)


Review request for mesos, Alex Clemmer and Joseph Wu.


Changes
---

Added variables for building Java Protobuf.


Bugs: MESOS-5902
https://issues.apache.org/jira/browse/MESOS-5902


Repository: mesos


Description (updated)
---

In this protobuf_java external project is added.
This definition allow to download source and build
source at /3rdparty/protobuf_java-2.6.1/
src/protobuf_java-2.6.1 directory,  PROTOBUF_JAVA_ROOT is
set to that directory and the build output for this is
${PROTOBUF_JAVA_ROOT}/java/target/protobuf-java-2.6.1.jar.
The jar is currently not copied from this location.


Diffs
-

  3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
497f6107567ef47c16a0c906238bc7dfdcf84701 

Diff: https://reviews.apache.org/r/50414/diff/


Testing
---

cmake .. && make


Thanks,

Srinivas Brahmaroutu

Re: Review Request 50415: Added build step to build Java Protobuf.

[Srinivas Brahmaroutu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50415/
---

(Updated Aug. 4, 2016, 8:12 p.m.)


Review request for mesos, Alex Clemmer and Joseph Wu.


Bugs: MESOS-5902
https://issues.apache.org/jira/browse/MESOS-5902


Repository: mesos


Description
---

Added build step to build Java Protobuf.


Diffs (updated)
-

  3rdparty/CMakeLists.txt 770a3828a6e0ffaa4f185392fdc1a2152446449d 

Diff: https://reviews.apache.org/r/50415/diff/


Testing
---

cmake && make protobuf-2.6.1-java 
check if 
3rdparty/protobuf-2.6.1/src/protobuf-2.6.1-java/java/target/protobuf-java-2.6.1.jar


Thanks,

Srinivas Brahmaroutu

Re: Review Request 50414: Added variables for building Java Protobuf.

[Srinivas Brahmaroutu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50414/
---

(Updated Aug. 4, 2016, 8:11 p.m.)


Review request for mesos, Alex Clemmer and Joseph Wu.


Bugs: MESOS-5902
https://issues.apache.org/jira/browse/MESOS-5902


Repository: mesos


Description
---

Added variables for building Java Protobuf.


Diffs (updated)
-

  3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
497f6107567ef47c16a0c906238bc7dfdcf84701 

Diff: https://reviews.apache.org/r/50414/diff/


Testing
---

cmake .. && make


Thanks,

Srinivas Brahmaroutu

Review Request 50815: Fixed a bug around handling orphaned tasks in `GET_TASKS` call.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50815/
---

Review request for mesos, Vinod Kone and Zhitao Li.


Bugs: MESOS-5930
https://issues.apache.org/jira/browse/MESOS-5930


Repository: mesos


Description
---

We erroneously wrapped the orphaned tasks loop with the loop
for known frameworks. This means that we would append the list
of orphaned tasks multiple times per framework. If there are
no active frameworks, we won't even return any orphaned tasks.


Diffs
-

  src/master/http.cpp e26dc2ff19fdfebc4d57009f355ebc92df3b62fd 

Diff: https://reviews.apache.org/r/50815/diff/


Testing
---

make check (tested as part of MESOS-5930)


Thanks,

Anand Mazumdar

Re: Review Request 50723: Fixed the master to recover resources/update state for orphan tasks.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50723/
---

(Updated Aug. 4, 2016, 7:17 p.m.)


Review request for mesos, Adam B, Neil Conway, and Vinod Kone.


Changes
---

Added logic for also verifying if the task state has been updated on master


Bugs: MESOS-5930
https://issues.apache.org/jira/browse/MESOS-5930


Repository: mesos


Description
---

The master's status handler function used to ignore the status updates
from the agents for frameworks not yet re-connected with the master
upon a failover. This change modifies that logic to still update
the local state and not bail out early.


Diffs (updated)
-

  src/master/master.cpp 17d5c5875647bb35e2518cc2bd9e134b020c05bf 
  src/tests/master_tests.cpp 6709818d599c068c289bcb714446018577082d8b 

Diff: https://reviews.apache.org/r/50723/diff/


Testing
---

make check (gtest_repeat=100)


Thanks,

Anand Mazumdar

Re: Review Request 50723: Fixed the master to recover resources/update state for orphan tasks.

[Anand Mazumdar]

> On Aug. 3, 2016, 6:12 p.m., Neil Conway wrote:
> > src/tests/master_tests.cpp, line 4665
> > 
> >
> > Should we also check that the task correctly transitions to a terminal 
> > state in the master?
> 
> Anand Mazumdar wrote:
> I had punted on this for now and just ensuring if the resources have been 
> correctly recovered. I left a TODO to address this for later.
> 
> Neil Conway wrote:
> The observed behavior in the bug report is about task statuses, not 
> resource allocation; those are fairly different things. I'd personally prefer 
> to see a test for task statuses be included as part of this change.

hmm, They might be fairly different things from the view point of the user but 
are closely aligned from the perspective of our code.

1. This is how the general flow of the code is in `updateTask()`:

```cpp
task.set_state(state);

if (terminated(state)) {
  allocator->recoverResources(...);
}
```

Hence, what the test currently does is a _strict_ superset by checking for 
recovered resources. Of course, the end user who is not familiar with the 
internals would only look for what they see on the UI via the `/state` call!

2. The only way I could think of to ensure that the task was _updated_ was to 
make another call to `/state` endpoint. That seemed un-necessary due to 1. and 
too verbose and hence I left a TODO.

But then, I thought that I would just go ahead and address the `TODO` now and 
found another bug in the `GET_TASKS` implementation in the master. CR: 
https://reviews.apache.org/r/50815 :(


- Anand


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50723/#review144633
---


On Aug. 3, 2016, 11:14 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50723/
> ---
> 
> (Updated Aug. 3, 2016, 11:14 p.m.)
> 
> 
> Review request for mesos, Adam B, Neil Conway, and Vinod Kone.
> 
> 
> Bugs: MESOS-5930
> https://issues.apache.org/jira/browse/MESOS-5930
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The master's status handler function used to ignore the status updates
> from the agents for frameworks not yet re-connected with the master
> upon a failover. This change modifies that logic to still update
> the local state and not bail out early.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 17d5c5875647bb35e2518cc2bd9e134b020c05bf 
>   src/tests/master_tests.cpp 6709818d599c068c289bcb714446018577082d8b 
> 
> Diff: https://reviews.apache.org/r/50723/diff/
> 
> 
> Testing
> ---
> 
> make check (gtest_repeat=100)
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 50463: Added code to build libmesosjava shared library.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50463/#review144811
---



Bad patch!

Reviews applied: [50463, 50460, 50459, 50458, 50457, 50456, 50455, 50415, 50414]

Failed command: ./support/apply-review.sh -n -r 50463

Error:
2016-08-04 18:58:42 URL:https://reviews.apache.org/r/50463/diff/raw/ 
[2107/2107] -> "50463.patch" [1]
error: patch failed: src/CMakeLists.txt:542
error: src/CMakeLists.txt: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/14639/console

- Mesos ReviewBot


On Aug. 4, 2016, 4:19 p.m., Srinivas Brahmaroutu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50463/
> ---
> 
> (Updated Aug. 4, 2016, 4:19 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Bugs: MESOS-5902
> https://issues.apache.org/jira/browse/MESOS-5902
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added code to build libmesosjava shared library.
> 
> 
> Diffs
> -
> 
>   cmake/MesosConfigure.cmake 6650c7c12b188b08c70cfee72b3200e83e7a1cd2 
>   src/CMakeLists.txt 32a8ae2320ee3dada8a19dd815eccb4710c18159 
> 
> Diff: https://reviews.apache.org/r/50463/diff/
> 
> 
> Testing
> ---
> 
> cmake && make mesosjava
> 
> Build /src/libmesosjava.* shared libraries.
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>

Re: Review Request 49851: Implemented `MemorySubsystem`.

[haosdent huang]

> On July 27, 2016, 2:05 a.m., Qian Zhang wrote:
> > src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp, line 494
> > 
> >
> > How do we recover this field `updatedLimit`? I mean during agent 
> > recovery, `updatedLimit` of each Info will be reset to `false`, right? But 
> > I think that is not correct.
> 
> haosdent huang wrote:
> I think this problem exists at `mem.cpp` as well, and update the limit 
> twice here does not bring problems here. So I drop this. Feel free to reopen 
> this if you think it would bring problems here.
> 
> Qian Zhang wrote:
> Yes, it is also a bug in `mem.cpp` which uses `info->pid` to check if it 
> is the first time to update the memory limit, but the value of `info->pid` 
> will also be lost during agent recovery.
> 
> And I think updating the memory hard limit twice will bring some 
> problems, as mentioned in this comments 
> (https://github.com/apache/mesos/blob/1.0.0/src/slave/containerizer/mesos/isolators/cgroups/mem.cpp#L369:#L371),
>  decreasing memory hard limit may induce an OOM.
> 
> I had a discussion with Jie on this issue, and his suggestion is that we 
> should not use such kind of field (e.g., `pid` or `updatedLimit`) because 
> they can not be recovered, instead, before updating the hard limit, we should 
> check if its current value is still the initial value (should be -1? And it 
> may be different in different Linux distributions, so you may need to double 
> check it), if it is, then that means it is the first time to update the hard 
> limit, then we can just update it, if it is not, then that means it is not 
> the first time, then we can only increase it but not decrease it.

Thank you for your help. The initial value of limit_in_bytes is -1 (unlimited). 
Let's update to check by this.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49851/#review143517
---


On Aug. 3, 2016, 5:58 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49851/
> ---
> 
> (Updated Aug. 3, 2016, 5:58 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.
> 
> 
> Bugs: MESOS-5045
> https://issues.apache.org/jira/browse/MESOS-5045
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented `MemorySubsystem`.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 
> b191b2a52a9645fc902a35ed52909b2142f0b4c0 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
> 2659252d8cffcefc233bc85fb4707c8147272737 
>   src/slave/containerizer/mesos/isolators/cgroups/constants.hpp 
> c45d88092f3fe497373dfeaa8346aef9126c7b8b 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
> 5f52a076a1fa3a21d886cb961ddeed5046a38d7c 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
> a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 
> 
> Diff: https://reviews.apache.org/r/49851/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 50327: Added scripts to build sample framework executables.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50327/#review144801
---



Patch looks great!

Reviews applied: [50064, 50179, 50323, 50324, 50325, 50326, 50327]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Aug. 4, 2016, 3:28 p.m., Srinivas Brahmaroutu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50327/
> ---
> 
> (Updated Aug. 4, 2016, 3:28 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Bugs: MESOS-5792
> https://issues.apache.org/jira/browse/MESOS-5792
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added scripts to build sample framework executables.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt ee8f565586b958929bc4e95b09827244d6d4155f 
>   cmake/MesosConfigure.cmake 6650c7c12b188b08c70cfee72b3200e83e7a1cd2 
>   src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 
>   src/examples/CMakeLists.txt PRE-CREATION 
>   src/examples/cmake/ExamplesConfigure.cmake PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50327/diff/
> 
> 
> Testing
> ---
> 
> cmake .. && make dynamic-reservation-framework test-http-framework 
> test-framework test-executor test-http-executor long-lived-framework 
> long-lived-executor no-executor-framework docker-no-executor-framework 
> balloon-framework balloon-executor load-generator-framework 
> persistent-volume-framework
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>

Re: Review Request 50763: Updated Linux 'MountInfoTable' entries to be sorted as expected.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50763/#review144686
---




src/linux/fs.hpp (lines 222 - 223)


I'd prefer putting parameters in the next line to be less jagged:
```
static Try read(
const Option& pid = None(),
bool hierarchicalSort = true);
```



src/linux/fs.cpp (lines 86 - 87)


Ditto on parameters on the next line.



src/linux/fs.cpp (line 104)


space before `==`



src/linux/fs.cpp (lines 123 - 124)


There is a problem here. You don't update the hashmap `parentToFirstChild` 
if an entry already exists for the key. But with the new insertion, it's likely 
that the invariant `first child entry that lists another entry as its parent` 
might already be broken. You still have to update it.

For instance, think about the following mount table  :

```
<2, 5>
<7, 10>
<5, 10>
<10, 11>
```



src/linux/fs.cpp (line 124)


indentation


- Jie Yu


On Aug. 3, 2016, 7:10 p.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50763/
> ---
> 
> (Updated Aug. 3, 2016, 7:10 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Jie Yu.
> 
> 
> Bugs: MESOS-5969
> https://issues.apache.org/jira/browse/MESOS-5969
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Many places in the codebase assume that the mountinfo table is sorted
> according to the order: 'parent mount point < child mount point'.
> 
> However, in some cases this may not be true if (for example), a parent
> mount point (say '/') is remounted to add some extra flags to it.
> When this happens, the remounted file system will appear in the
> mountinfo table at the point where it was remounted.
> 
> We actually encountered this problem in the wild for the case of '/'
> being remounted after '/run' was mounted -- causing problems in the
> 'NvidiaVolume' which assumes the 'parent < child' ordering.
> 
> This commit fixes this problem by building the list of MountInfoTable
> entries in sorted order when 'read()' is called. An optional flag can
> be used to disable sorting produce the the original ordering.
> 
> 
> Diffs
> -
> 
>   src/linux/fs.hpp ec3b5b8cd6926b1f69ad499de1c13b989766a84e 
>   src/linux/fs.cpp f57db80ad0d7235d47910e05d663c77e233f8228 
> 
> Diff: https://reviews.apache.org/r/50763/diff/
> 
> 
> Testing
> ---
> 
> GTEST_FILTER="" make -j check
> src/mesos-tests
> sudo src/mesos-tests
> 
> Appeared to have one unrelated flaky test fail: 
> `ResourceOffersTest.ResourcesGetReofferedAfterTaskInfoError`
> Rerunning the tests a second time passed.
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 50812: Updated `HealthCheck` protobuf for HTTP and TCP health check.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50812/
---

(Updated Aug. 4, 2016, 5:18 p.m.)


Review request for mesos, Adam B, Alexander Rukletsov, and Gastón Kleiman.


Bugs: MESOS-5987
https://issues.apache.org/jira/browse/MESOS-5987


Repository: mesos


Description
---

Updated `HealthCheck` protobuf for HTTP and TCP health check.


Diffs
-

  include/mesos/mesos.proto 8c74d0bdc1d15074b55d1be84816307bb9478a38 
  include/mesos/v1/mesos.proto 94b59dd75abfa9e8601e59f7a20dfd94bc88fa70 

Diff: https://reviews.apache.org/r/50812/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 50812: Updated `HealthCheck` protobuf for HTTP and TCP health check.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50812/
---

(Updated Aug. 4, 2016, 5:12 p.m.)


Review request for mesos, Adam B, Alexander Rukletsov, and Gastón Kleiman.


Changes
---

Rebase.


Repository: mesos


Description
---

Updated `HealthCheck` protobuf for HTTP and TCP health check.


Diffs (updated)
-

  include/mesos/mesos.proto 8c74d0bdc1d15074b55d1be84816307bb9478a38 
  include/mesos/v1/mesos.proto 94b59dd75abfa9e8601e59f7a20dfd94bc88fa70 

Diff: https://reviews.apache.org/r/50812/diff/


Testing
---


Thanks,

haosdent huang

Review Request 50812: Updated `HealthCheck` protobuf for HTTP and TCP health check.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50812/
---

Review request for mesos, Adam B, Alexander Rukletsov, and Gastón Kleiman.


Repository: mesos


Description
---

Updated `HealthCheck` protobuf for HTTP and TCP health check.


Diffs
-

  CHANGELOG 6fc56a9df162b88b0a4afb4e3c930c80063f12b9 
  include/mesos/mesos.proto 8c74d0bdc1d15074b55d1be84816307bb9478a38 
  include/mesos/v1/mesos.proto 94b59dd75abfa9e8601e59f7a20dfd94bc88fa70 
  src/master/main.cpp 4a1a8e70ab0535aa131681b2b09a99e51c20158e 
  src/slave/main.cpp 8c9d241890ffa85f88096385e07789e6fc945ddb 

Diff: https://reviews.apache.org/r/50812/diff/


Testing
---


Thanks,

haosdent huang

Review Request 50810: Fixed provisioner appc support on windows build.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50810/
---

Review request for mesos, Artem Harutyunyan, Alex Clemmer, Jie Yu, and Joseph 
Wu.


Repository: mesos


Description
---

Fixed provisioner appc support on windows build.


Diffs
-

  src/slave/containerizer/mesos/provisioner/provisioner.cpp 
40ee1da5ea453127c1e5e4cdf4b9a49bc998698a 

Diff: https://reviews.apache.org/r/50810/diff/


Testing
---

N/A.


Thanks,

Gilbert Song

Re: Review Request 50609: Moved check for '--version' in master and agent 'main.cpp'.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50609/#review144778
---


Ship it!




Ship It!

- Vinod Kone


On Aug. 2, 2016, 11:04 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50609/
> ---
> 
> (Updated Aug. 2, 2016, 11:04 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Pierre Cheynier.
> 
> 
> Bugs: MESOS-5928
> https://issues.apache.org/jira/browse/MESOS-5928
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The recent removal of the agent's default `work_dir`
> requires us to check for the presence of the `--version`
> flag before we check for errors in flag loading; this
> patch makes that change, and also moves the
> corresponding code in the master for consistency.
> 
> 
> Diffs
> -
> 
>   src/master/main.cpp e202973e92ee065b93c0b431cae0bc066cbd7dc7 
>   src/slave/main.cpp a4d971a00f18af661a8bf2cb4f580d35f7c76d10 
> 
> Diff: https://reviews.apache.org/r/50609/diff/
> 
> 
> Testing
> ---
> 
> Ran the mesos agent and master binaries with and without the '--version' flag 
> to verify correct behavior and return code.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 50463: Added code to build libmesosjava shared library.

[Srinivas Brahmaroutu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50463/
---

(Updated Aug. 4, 2016, 4:19 p.m.)


Review request for mesos, Alex Clemmer and Joseph Wu.


Bugs: MESOS-5902
https://issues.apache.org/jira/browse/MESOS-5902


Repository: mesos


Description
---

Added code to build libmesosjava shared library.


Diffs (updated)
-

  cmake/MesosConfigure.cmake 6650c7c12b188b08c70cfee72b3200e83e7a1cd2 
  src/CMakeLists.txt 32a8ae2320ee3dada8a19dd815eccb4710c18159 

Diff: https://reviews.apache.org/r/50463/diff/


Testing
---

cmake && make mesosjava

Build /src/libmesosjava.* shared libraries.


Thanks,

Srinivas Brahmaroutu

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36816/#review144776
---




src/health-check/health_checker.hpp (line 283)


We should use `libcurl` to execute http health check to avoid our https 
health check depends on SSL compile flag.


- haosdent huang


On Aug. 1, 2016, 1:15 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36816/
> ---
> 
> (Updated Aug. 1, 2016, 1:15 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gilbert Song, 
> Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-2533
> https://issues.apache.org/jira/browse/MESOS-2533
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Supported HTTP/HTTPS in health check.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 590e169108b2ce5881734ec7f4b01cef9937461a 
>   include/mesos/v1/mesos.proto 94b59dd75abfa9e8601e59f7a20dfd94bc88fa70 
>   src/health-check/health_checker.hpp 
> b28a9cf3c6c9217c0b2453ac6e34d88e1f648d61 
> 
> Diff: https://reviews.apache.org/r/36816/diff/
> 
> 
> Testing
> ---
> 
> * Add unit test cases: HealthCheckTest.HealthyTaskViaHttp and 
> HealthCheckTest.HealthyTaskNotMatchHttpStatuses
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 50739: Updated '--fetcher_cache_dir' help string.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50739/#review144772
---



Patch looks great!

Reviews applied: [50739]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Aug. 4, 2016, 1:58 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50739/
> ---
> 
> (Updated Aug. 4, 2016, 1:58 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Now that the fetcher binary fetches files as the
> task's user, it is necessary for all such Unix users
> to have access to the fetcher cache directory. This
> patch updates the flag's help string to make note of
> this.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md d6a7eb02b9f3e0011d52ccfd3093167bb6adccd3 
>   src/slave/flags.cpp b8ecc98721c52dcd59a0cc1333421d4f024fbe96 
> 
> Diff: https://reviews.apache.org/r/50739/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 49360: Supported TCP check in health check.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49360/#review144767
---




include/mesos/mesos.proto (lines 348 - 355)


Here is my suggestion for the proto:
```
 message Socket {
   enum Protocol {
 UNKNOWN = 0;
 TCP = 1;
 UDP = 2;  // This is post-MVP.
   }

   required Protocol protocol = 1 [default = TCP];

   // Port expected to be open.
   required uint32 port = 2;
 }
```



include/mesos/mesos.proto (line 349)


I can imagine using UDP in the future, hence the name may be a bit 
unfortunate.



include/mesos/mesos.proto (line 354)


As discussed on the community slack, we may avoid this and deduce the 
domain ourselves.


- Alexander Rukletsov


On Aug. 1, 2016, 1:15 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49360/
> ---
> 
> (Updated Aug. 1, 2016, 1:15 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gilbert Song, 
> Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-3567
> https://issues.apache.org/jira/browse/MESOS-3567
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Supported TCP check in health check.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 590e169108b2ce5881734ec7f4b01cef9937461a 
>   include/mesos/v1/mesos.proto 94b59dd75abfa9e8601e59f7a20dfd94bc88fa70 
>   src/health-check/health_checker.hpp 
> b28a9cf3c6c9217c0b2453ac6e34d88e1f648d61 
>   src/health-check/health_checker.cpp 
> 585a0b565d948cfa292bad818a710501a4ce0daf 
> 
> Diff: https://reviews.apache.org/r/49360/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 50325: Added script to build mesos-log tool.

[Srinivas Brahmaroutu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50325/
---

(Updated Aug. 4, 2016, 3:28 p.m.)


Review request for mesos, Alex Clemmer and Joseph Wu.


Bugs: MESOS-5792
https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description (updated)
---

Added script to build mesos-log tool.


Diffs (updated)
-

  src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 
  src/log/CMakeLists.txt PRE-CREATION 

Diff: https://reviews.apache.org/r/50325/diff/


Testing
---

cmake .. && make mesos-log


Thanks,

Srinivas Brahmaroutu

Re: Review Request 50327: Added scripts to build sample framework executables.

[Srinivas Brahmaroutu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50327/
---

(Updated Aug. 4, 2016, 3:28 p.m.)


Review request for mesos, Alex Clemmer and Joseph Wu.


Bugs: MESOS-5792
https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description (updated)
---

Added scripts to build sample framework executables.


Diffs (updated)
-

  CMakeLists.txt ee8f565586b958929bc4e95b09827244d6d4155f 
  cmake/MesosConfigure.cmake 6650c7c12b188b08c70cfee72b3200e83e7a1cd2 
  src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 
  src/examples/CMakeLists.txt PRE-CREATION 
  src/examples/cmake/ExamplesConfigure.cmake PRE-CREATION 

Diff: https://reviews.apache.org/r/50327/diff/


Testing
---

cmake .. && make dynamic-reservation-framework test-http-framework 
test-framework test-executor test-http-executor long-lived-framework 
long-lived-executor no-executor-framework docker-no-executor-framework 
balloon-framework balloon-executor load-generator-framework 
persistent-volume-framework


Thanks,

Srinivas Brahmaroutu

Re: Review Request 50326: Added script to build mesos-resolve.

[Srinivas Brahmaroutu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50326/
---

(Updated Aug. 4, 2016, 3:28 p.m.)


Review request for mesos, Alex Clemmer and Joseph Wu.


Bugs: MESOS-5792
https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description (updated)
---

Added script to build mesos-resolve.


Diffs (updated)
-

  src/cli/CMakeLists.txt c0120cd7f4ef8dc275edbd5cb1a4a6e23952ec63 

Diff: https://reviews.apache.org/r/50326/diff/


Testing
---

cmake .. && make mesos-resolve


Thanks,

Srinivas Brahmaroutu

Re: Review Request 50127: Added NvidiaGpuDockerContainerizerTest.ROOT_DOCKER_LaunchWithGpu.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50127/#review144762
---




src/tests/containerizer/nvidia_gpu_isolator_tests.cpp (line 17)


You are losing the following incldue:
```
#include 
```



src/tests/containerizer/nvidia_gpu_isolator_tests.cpp (lines 61 - 62)


move this between Line 50 and Line 51



src/tests/containerizer/nvidia_gpu_isolator_tests.cpp (line 65)


It is not suggested to use `namespace` directly, so I think that you need 
keep the following:

```
using process::Future;
using process::Owned;
```

And add the one as you code.



src/tests/containerizer/nvidia_gpu_isolator_tests.cpp (lines 81 - 141)


Seems those are from docker_containerizer_test.cpp, I think that we do not 
need to copy the code here but add the test case to 
docker_containerizer_test.cpp as you want to test docker containerizer.



src/tests/containerizer/nvidia_gpu_isolator_tests.cpp (line 745)


This will cause test failed if the system do not have nvml.

Can you please add a filter to filter out the test if the nvml is not 
avaiable?

You can refer to 
https://github.com/apache/mesos/blob/master/src/tests/environment.cpp#L279-L313 
for how to add a filter.



src/tests/containerizer/nvidia_gpu_isolator_tests.cpp (line 758)


Do you need this with docker containerizer?



src/tests/containerizer/nvidia_gpu_isolator_tests.cpp (line 770)


s/.get()/->



src/tests/containerizer/nvidia_gpu_isolator_tests.cpp (line 815)


s/offers.get().size()/offers->size()



src/tests/containerizer/nvidia_gpu_isolator_tests.cpp (line 851)


```
driver.launchTasks(offers1->at(0).id(), {task});
```



src/tests/containerizer/nvidia_gpu_isolator_tests.cpp (lines 898 - 899)


```
EXPECT_EQ(1, 
statusRunning.get().container_status().network_infos(0).ip_addresses().size()); 
// NOLINT(whitespace/line_length)
```



src/tests/containerizer/nvidia_gpu_isolator_tests.cpp (line 920)


s/unsigned int/size_t


- Guangya Liu


On 八月 2, 2016, 2:23 p.m., Yubo Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50127/
> ---
> 
> (Updated 八月 2, 2016, 2:23 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull.
> 
> 
> Bugs: MESOS-5795
> https://issues.apache.org/jira/browse/MESOS-5795
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This added a testing case for end-to-end GPU support for docker
> containerizer.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/nvidia_gpu_isolator_tests.cpp 
> fea1f9f0a03373692ef2a6dd2bc5722dc6f46d5b 
> 
> Diff: https://reviews.apache.org/r/50127/diff/
> 
> 
> Testing
> ---
> 
> GTEST_FILTER="NvidiaGpuDockerContainerizerTest.ROOT_DOCKER_LaunchWithGpu" 
> make -j check
> 
> 
> Thanks,
> 
> Yubo Li
> 
>

Re: Review Request 50737: Parametrized libprocess HTTPTests by SSL configuration.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50737/#review144764
---



Bad patch!

Reviews applied: [50737, 50736, 40512, 40268, 40413, 40411, 40410, 50621, 
40266, 46146, 46094, 45999, 45996, 45995, 45991]

Failed command: ./support/apply-review.sh -n -r 50621

Error:
2016-08-04 14:38:59 URL:https://reviews.apache.org/r/50621/diff/raw/ 
[2739/2739] -> "50621.patch" [1]
error: patch failed: 3rdparty/libprocess/src/process.cpp:1230
error: 3rdparty/libprocess/src/process.cpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/14636/console

- Mesos ReviewBot


On Aug. 3, 2016, 5:37 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50737/
> ---
> 
> (Updated Aug. 3, 2016, 5:37 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Joseph Wu, and Vinod Kone.
> 
> 
> Bugs: MESOS-5966
> https://issues.apache.org/jira/browse/MESOS-5966
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch parametrizes the HTTP tests in libprocess so
> that they run with SSL both enabled and disabled when
> the library has been compiled with SSL support.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/http_tests.cpp 
> 8a0d61eb57f9ae972eedf3481f131844b283abc5 
> 
> Diff: https://reviews.apache.org/r/50737/diff/
> 
> 
> Testing
> ---
> 
> Tested on OSX with `GTEST_REPEAT=100 GTEST_BREAK_ON_FAILURE=1 
> GTEST_FILTER="*HTTPTest*" 3rdparty/libprocess/libprocess-tests`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 50739: Updated '--fetcher_cache_dir' help string.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50739/
---

(Updated Aug. 4, 2016, 1:58 p.m.)


Review request for mesos and Jie Yu.


Repository: mesos


Description
---

Now that the fetcher binary fetches files as the
task's user, it is necessary for all such Unix users
to have access to the fetcher cache directory. This
patch updates the flag's help string to make note of
this.


Diffs
-

  docs/configuration.md d6a7eb02b9f3e0011d52ccfd3093167bb6adccd3 
  src/slave/flags.cpp b8ecc98721c52dcd59a0cc1333421d4f024fbe96 

Diff: https://reviews.apache.org/r/50739/diff/


Testing
---


Thanks,

Greg Mann

Re: Review Request 50723: Fixed the master to recover resources/update state for orphan tasks.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50723/#review144748
---



Patch looks great!

Reviews applied: [50723]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Aug. 3, 2016, 11:14 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50723/
> ---
> 
> (Updated Aug. 3, 2016, 11:14 p.m.)
> 
> 
> Review request for mesos, Adam B, Neil Conway, and Vinod Kone.
> 
> 
> Bugs: MESOS-5930
> https://issues.apache.org/jira/browse/MESOS-5930
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The master's status handler function used to ignore the status updates
> from the agents for frameworks not yet re-connected with the master
> upon a failover. This change modifies that logic to still update
> the local state and not bail out early.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 17d5c5875647bb35e2518cc2bd9e134b020c05bf 
>   src/tests/master_tests.cpp 6709818d599c068c289bcb714446018577082d8b 
> 
> Diff: https://reviews.apache.org/r/50723/diff/
> 
> 
> Testing
> ---
> 
> make check (gtest_repeat=100)
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 50713: Documented behavior of content-type header in presence of errors.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50713/#review144741
---



Patch looks great!

Reviews applied: [50713]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Aug. 3, 2016, 10:12 p.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50713/
> ---
> 
> (Updated Aug. 3, 2016, 10:12 p.m.)
> 
> 
> Review request for mesos and Anand Mazumdar.
> 
> 
> Bugs: MESOS-5853
> https://issues.apache.org/jira/browse/MESOS-5853
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When an error response is generated for http v1 api, default
> contentType is "text/plain; charset=utf-8". This has been
> documented for the docs of http v1 api in this patch.
> 
> 
> Diffs
> -
> 
>   docs/executor-http-api.md fb70f75c43c2751ff430a571ed8d4630d29a7ef8 
>   docs/operator-http-api.md 4f4c39e7b4b6de32af1933c34eba21f126fae8ac 
>   docs/scheduler-http-api.md 4be961214c63e4e3b25c5c350b2c4f0e66863817 
> 
> Diff: https://reviews.apache.org/r/50713/diff/
> 
> 
> Testing
> ---
> 
> Viewed with "rake dev".
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 50125: Added mesos-docker-executor support for device control.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50125/#review144725
---



Another comment is that I found it is difficult to review those patches in such 
an order, can you please reverse the order of your patch chain? Implement 
overall logic first, then detail the logic in following patch chain?


src/docker/executor.hpp (line 81)


s/--device/`--device`



src/docker/executor.hpp (line 82)



s/'PathInHost:PathInContainer:Permission'/`PathInHost:PathInContainer:Permission`



src/docker/executor.hpp (line 83)


s/'/dev/tty:/dev/tty:mrw' for '/dev/tty' fully 
exposed./`/dev/tty:/dev/tty:mrw` for `/dev/tty` fully exposed.



src/docker/executor.cpp (line 170)


remove `` at the end



src/docker/executor.cpp (line 171)


remove period at the end



src/docker/executor.cpp (line 827)


the default value of `string device` is already empty, no need to 
initialize it.


- Guangya Liu


On 八月 2, 2016, 2:21 p.m., Yubo Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50125/
> ---
> 
> (Updated 八月 2, 2016, 2:21 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull.
> 
> 
> Bugs: MESOS-5795
> https://issues.apache.org/jira/browse/MESOS-5795
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a new flag '--device' to mesos-docker-executor, and gave its
> feature to control device exposition, isolation, and access permission.
> 
> 
> Diffs
> -
> 
>   src/docker/executor.hpp 7b63d784d6b8685912598b77fb38cf6e70646ae3 
>   src/docker/executor.cpp 445628c9164facdd8bd812c5b45e3b2b886ebf0e 
> 
> Diff: https://reviews.apache.org/r/50125/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Yubo Li
> 
>

Re: Review Request 50723: Fixed the master to recover resources/update state for orphan tasks.

[Neil Conway]

> On Aug. 3, 2016, 6:12 p.m., Neil Conway wrote:
> > src/tests/master_tests.cpp, line 4665
> > 
> >
> > Should we also check that the task correctly transitions to a terminal 
> > state in the master?
> 
> Anand Mazumdar wrote:
> I had punted on this for now and just ensuring if the resources have been 
> correctly recovered. I left a TODO to address this for later.

The observed behavior in the bug report is about task statuses, not resource 
allocation; those are fairly different things. I'd personally prefer to see a 
test for task statuses be included as part of this change.


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50723/#review144633
---


On Aug. 3, 2016, 11:14 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50723/
> ---
> 
> (Updated Aug. 3, 2016, 11:14 p.m.)
> 
> 
> Review request for mesos, Adam B, Neil Conway, and Vinod Kone.
> 
> 
> Bugs: MESOS-5930
> https://issues.apache.org/jira/browse/MESOS-5930
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The master's status handler function used to ignore the status updates
> from the agents for frameworks not yet re-connected with the master
> upon a failover. This change modifies that logic to still update
> the local state and not bail out early.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 17d5c5875647bb35e2518cc2bd9e134b020c05bf 
>   src/tests/master_tests.cpp 6709818d599c068c289bcb714446018577082d8b 
> 
> Diff: https://reviews.apache.org/r/50723/diff/
> 
> 
> Testing
> ---
> 
> make check (gtest_repeat=100)
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 50769: Fixed a broken link to CNI repo.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50769/#review144729
---



Patch looks great!

Reviews applied: [50769]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Aug. 3, 2016, 9:42 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50769/
> ---
> 
> (Updated Aug. 3, 2016, 9:42 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-5985
> https://issues.apache.org/jira/browse/MESOS-5985
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed a broken link to CNI repo.
> 
> 
> Diffs
> -
> 
>   docs/networking.md f6652f58b02edee08e0b2410c23b2beb4d25e83b 
> 
> Diff: https://reviews.apache.org/r/50769/diff/
> 
> 
> Testing
> ---
> 
> Launched the mesos website and verified the link.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 50771: Added coverity build to build_docker.sh.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50771/#review144716
---



Patch looks great!

Reviews applied: [50771]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Aug. 3, 2016, 9:24 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50771/
> ---
> 
> (Updated Aug. 3, 2016, 9:24 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5984
> https://issues.apache.org/jira/browse/MESOS-5984
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This review adds an coverity build option
> to build_docker.sh in order to enable
> regular coverity builds on the ASF infrastructure.
> 
> 
> Diffs
> -
> 
>   support/docker_build.sh 8ae1aadbc12b12e44984d34ccfbcb8a97bf05bcf 
> 
> Diff: https://reviews.apache.org/r/50771/diff/
> 
> 
> Testing
> ---
> 
> ran build with and without COVERITY_TOKEN.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>