Re: Review Request 50910: Added a python linter to mesos-style.cpp.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50910/#review145305
---




support/mesos-style.py (line 219)


is this the right URL?



support/mesos-style.py (line 227)


s/pylint_proc/p/ to be consistent with CppLinter()



support/mesos-style.py (lines 228 - 234)


this indentation looks weird? or is it just RB?



support/mesos-style.py (line 238)


this looks different than how we extracted stderr in CppLinter(); can we 
make it consistent?



support/mesos-style.py (line 242)


Don't follow this comment?


- Vinod Kone


On Aug. 8, 2016, 10:10 p.m., Haris Choudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50910/
> ---
> 
> (Updated Aug. 8, 2016, 10:10 p.m.)
> 
> 
> Review request for mesos, Kevin Klues and Vinod Kone.
> 
> 
> Bugs: Mesos-6006
> https://issues.apache.org/jira/browse/Mesos-6006
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> It currently doesn't run over any files in the code base, but we will
> be adding the new python CLI in a subsequent commit, which will use
> this new linter.
> 
> 
> Diffs
> -
> 
>   support/mesos-style.py 061cbe711bd9407b7341fa146f8c723eaa9fc438 
> 
> Diff: https://reviews.apache.org/r/50910/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Haris Choudhary
> 
>

Re: Review Request 50907: Abstracted mesos-style.py to wrap the cpp linter in a class.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50907/#review145304
---


Ship it!




Ship It!

- Vinod Kone


On Aug. 8, 2016, 7:49 p.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50907/
> ---
> 
> (Updated Aug. 8, 2016, 7:49 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Bugs: MESOS-6006
> https://issues.apache.org/jira/browse/MESOS-6006
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously, mesos-style.py was just a collection of functions that
> checked the style of relevant files in the mesos code base.  However,
> the script assumed that we always wanted to run cpplint over every
> file we were checking. Since we are planning on adding a python linter
> to the codebase soon, it makes sense to abstract the common
> functionality from this script into a class so that a cpp-based linter
> and a python-based linter can inherit the same set of common
> functionality.
> 
> This commit builds this abstraction and implements a 'CppLinter()' in
> terms of it.
> 
> 
> Diffs
> -
> 
>   support/mesos-style.py 061cbe711bd9407b7341fa146f8c723eaa9fc438 
> 
> Diff: https://reviews.apache.org/r/50907/diff/
> 
> 
> Testing
> ---
> 
> Ran `support/mesos-style.py` over the whole code base.
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 49817: Implemented `CgroupsIsolatorProcess::recover`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49817/
---

(Updated Aug. 10, 2016, 2 a.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Fix some of @jieyu's comments.


Bugs: MESOS-5041
https://issues.apache.org/jira/browse/MESOS-5041


Repository: mesos


Description
---

Implemented `CgroupsIsolatorProcess::recover`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 
b191b2a52a9645fc902a35ed52909b2142f0b4c0 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
2659252d8cffcefc233bc85fb4707c8147272737 

Diff: https://reviews.apache.org/r/49817/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 50941: Added a section on "Adding/Modifying/Deleting CNI configuration".

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50941/
---

(Updated Aug. 10, 2016, 1:41 a.m.)


Review request for mesos, Jie Yu and Qian Zhang.


Changes
---

Modified the section heading and re-ordered the text.


Bugs: MESOS-5985
https://issues.apache.org/jira/browse/MESOS-5985


Repository: mesos


Description
---

Added a section on "Adding/Modifying/Deleting CNI configuration".


Diffs (updated)
-

  docs/cni.md 7cceca566e3bd1d1981afd0b41ffc3c14596d851 

Diff: https://reviews.apache.org/r/50941/diff/


Testing
---

Launched the webiste and verified the changes.


Thanks,

Avinash sridharan

Re: Review Request 50941: Added a section on "Adding/Modifying/Deleting CNI configuration".

[Avinash sridharan]

> On Aug. 10, 2016, 1:26 a.m., Qian Zhang wrote:
> > docs/cni.md, lines 221-222
> > 
> >
> > I think it keeps an in-memory copy in 
> > `NetworkCniIsolatorProcess::NetworkConfigInfo::config`.

NetworkCniIsolatorProcess::NetworkConfigInfo::config only pieces of the CNI 
config, namely the "name" and the "type", and I guess the results from invoking 
the plugin. However, the actual CNI config is never stored in-memory. So I 
guess the statement should hold?


- Avinash


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50941/#review145297
---


On Aug. 10, 2016, 1:13 a.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50941/
> ---
> 
> (Updated Aug. 10, 2016, 1:13 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-5985
> https://issues.apache.org/jira/browse/MESOS-5985
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a section on "Adding/Modifying/Deleting CNI configuration".
> 
> 
> Diffs
> -
> 
>   docs/cni.md 7cceca566e3bd1d1981afd0b41ffc3c14596d851 
> 
> Diff: https://reviews.apache.org/r/50941/diff/
> 
> 
> Testing
> ---
> 
> Launched the webiste and verified the changes.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 50941: Added a section on "Adding/Modifying/Deleting CNI configuration".

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50941/#review145297
---




docs/cni.md (lines 221 - 222)


I think it keeps an in-memory copy in 
`NetworkCniIsolatorProcess::NetworkConfigInfo::config`.


- Qian Zhang


On Aug. 10, 2016, 9:13 a.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50941/
> ---
> 
> (Updated Aug. 10, 2016, 9:13 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-5985
> https://issues.apache.org/jira/browse/MESOS-5985
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a section on "Adding/Modifying/Deleting CNI configuration".
> 
> 
> Diffs
> -
> 
>   docs/cni.md 7cceca566e3bd1d1981afd0b41ffc3c14596d851 
> 
> Diff: https://reviews.apache.org/r/50941/diff/
> 
> 
> Testing
> ---
> 
> Launched the webiste and verified the changes.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Review Request 50941: Added a section on "Adding/Modifying/Deleting CNI configuration".

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50941/
---

Review request for mesos.


Bugs: MESOS-5985
https://issues.apache.org/jira/browse/MESOS-5985


Repository: mesos


Description
---

Added a section on "Adding/Modifying/Deleting CNI configuration".


Diffs
-

  docs/cni.md 7cceca566e3bd1d1981afd0b41ffc3c14596d851 

Diff: https://reviews.apache.org/r/50941/diff/


Testing
---

Launched the webiste and verified the changes.


Thanks,

Avinash sridharan

Re: Review Request 50769: Fixed a broken link to CNI repo.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50769/
---

(Updated Aug. 10, 2016, 1:11 a.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-5985
https://issues.apache.org/jira/browse/MESOS-5985


Repository: mesos


Description
---

Fixed a broken link to CNI repo.


Diffs (updated)
-

  docs/networking.md f6652f58b02edee08e0b2410c23b2beb4d25e83b 

Diff: https://reviews.apache.org/r/50769/diff/


Testing
---

Launched the mesos website and verified the link.


Thanks,

Avinash sridharan

Review Request 50940: Removed a limitation.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50940/
---

Review request for mesos, Jie Yu and Qian Zhang.


Bugs: MESOS-5985
https://issues.apache.org/jira/browse/MESOS-5985


Repository: mesos


Description
---

Removed a limitation.


Diffs
-

  docs/cni.md 7cceca566e3bd1d1981afd0b41ffc3c14596d851 

Diff: https://reviews.apache.org/r/50940/diff/


Testing
---

Launched website and verfied the changes.


Thanks,

Avinash sridharan

Re: Review Request 50771: Added coverity build to build_docker.sh.

[Joerg Schad]

> On Aug. 9, 2016, 9:58 p.m., Vinod Kone wrote:
> > support/docker_build.sh, line 134
> > 
> >
> > can the email be d...@mesos.apache.org?

Done


- Joerg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50771/#review145273
---


On Aug. 10, 2016, 12:58 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50771/
> ---
> 
> (Updated Aug. 10, 2016, 12:58 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5984
> https://issues.apache.org/jira/browse/MESOS-5984
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This review adds an coverity build option
> to build_docker.sh in order to enable
> regular coverity builds on the ASF infrastructure.
> 
> 
> Diffs
> -
> 
>   support/docker_build.sh 8ae1aadbc12b12e44984d34ccfbcb8a97bf05bcf 
> 
> Diff: https://reviews.apache.org/r/50771/diff/
> 
> 
> Testing
> ---
> 
> ran build with and without COVERITY_TOKEN.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 50771: Added coverity build to build_docker.sh.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50771/
---

(Updated Aug. 10, 2016, 12:58 a.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-5984
https://issues.apache.org/jira/browse/MESOS-5984


Repository: mesos


Description
---

This review adds an coverity build option
to build_docker.sh in order to enable
regular coverity builds on the ASF infrastructure.


Diffs (updated)
-

  support/docker_build.sh 8ae1aadbc12b12e44984d34ccfbcb8a97bf05bcf 

Diff: https://reviews.apache.org/r/50771/diff/


Testing
---

ran build with and without COVERITY_TOKEN.


Thanks,

Joerg Schad

Re: Review Request 50936: Kept poll socket alive while sending.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50936/
---

(Updated Aug. 10, 2016, 12:06 a.m.)


Review request for mesos, Benjamin Mahler, Joseph Wu, and Vinod Kone.


Bugs: MESOS-5988
https://issues.apache.org/jira/browse/MESOS-5988


Repository: mesos


Description (updated)
---

Currently, the poll socket implementation doesn't keep
the socket alive after `PollSocketImpl.send(data, length)`
passes execution off to a continuation, with the same bug
also present in `sendfile()`. This patch passes a copy of
the socket along to the continuation, keeping the socket
alive.


Diffs
-

  3rdparty/libprocess/src/poll_socket.cpp 
d14dd1ae210e112b917329803dfb09d98386b966 

Diff: https://reviews.apache.org/r/50936/diff/


Testing
---

Ran `make check` on OSX.

Also: I was able to expose the poll socket bug with the following test case. It 
triggers a "Bad file descriptor" error after 100-200 repetitions on my OSX 
machine. After applying this patch, I can run the test thousands of times with 
no failures:

```
TEST(HTTPTest, ClosedSocketFailure)
{
  const Try server_create = Socket::create();
  ASSERT_SOME(server_create);

  Socket server = server_create.get();
  LOG(INFO) << "*** server fd: " << server.get();

  Future sent;
  Future _socket;

  string data;
  for (auto i = 0; i < 26000; i++) {
data += "abcdefghijklmnopqrstuvwxyz0123456789abcdefghijklmnopqrstuvwxyz012";
  }
  const char* data_cstr = data.c_str();

  {
const Try client_create = Socket::create();
ASSERT_SOME(client_create);

Socket client = client_create.get();
LOG(INFO) << "*** client fd: " << client.get();

const Try listen = server.listen(5);
ASSERT_SOME(listen);

const Try server_address = server.address();
ASSERT_SOME(server_address);

_socket = server.accept();

const Future connect = client.connect(server_address.get());

// Wait for the server to have accepted the client connection.
AWAIT_ASSERT_READY(_socket);
Socket socket = _socket.get(); // TODO(jmlvanre): Remove const copy.

// Verify that the client also views the connection as established.
AWAIT_ASSERT_READY(connect);

// Send a message from the client to the server.
sent = client.send(data_cstr, data.size());
LOG(INFO) << "*** exiting scope";
  }

  AWAIT_READY(sent);

  LOG(INFO) << "*** exiting test case";
}
```


Thanks,

Greg Mann

Re: Review Request 50936: Kept poll socket alive while sending.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50936/#review145293
---


Ship it!




Ship It!

- Benjamin Mahler


On Aug. 9, 2016, 11:31 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50936/
> ---
> 
> (Updated Aug. 9, 2016, 11:31 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Joseph Wu, and Vinod Kone.
> 
> 
> Bugs: MESOS-5988
> https://issues.apache.org/jira/browse/MESOS-5988
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Currently, the poll socket implementation doesn't keep
> the socket alive after `PollSocketImpl.send(data, length)`
> passes execution off to a continuation. This patch passes
> a shared pointer of the socket implementation along to the
> continuation, keeping the socket alive.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/poll_socket.cpp 
> d14dd1ae210e112b917329803dfb09d98386b966 
> 
> Diff: https://reviews.apache.org/r/50936/diff/
> 
> 
> Testing
> ---
> 
> Ran `make check` on OSX.
> 
> Also: I was able to expose the poll socket bug with the following test case. 
> It triggers a "Bad file descriptor" error after 100-200 repetitions on my OSX 
> machine. After applying this patch, I can run the test thousands of times 
> with no failures:
> 
> ```
> TEST(HTTPTest, ClosedSocketFailure)
> {
>   const Try server_create = Socket::create();
>   ASSERT_SOME(server_create);
> 
>   Socket server = server_create.get();
>   LOG(INFO) << "*** server fd: " << server.get();
> 
>   Future sent;
>   Future _socket;
> 
>   string data;
>   for (auto i = 0; i < 26000; i++) {
> data += 
> "abcdefghijklmnopqrstuvwxyz0123456789abcdefghijklmnopqrstuvwxyz012";
>   }
>   const char* data_cstr = data.c_str();
> 
>   {
> const Try client_create = Socket::create();
> ASSERT_SOME(client_create);
> 
> Socket client = client_create.get();
> LOG(INFO) << "*** client fd: " << client.get();
> 
> const Try listen = server.listen(5);
> ASSERT_SOME(listen);
> 
> const Try server_address = server.address();
> ASSERT_SOME(server_address);
> 
> _socket = server.accept();
> 
> const Future connect = client.connect(server_address.get());
> 
> // Wait for the server to have accepted the client connection.
> AWAIT_ASSERT_READY(_socket);
> Socket socket = _socket.get(); // TODO(jmlvanre): Remove const copy.
> 
> // Verify that the client also views the connection as established.
> AWAIT_ASSERT_READY(connect);
> 
> // Send a message from the client to the server.
> sent = client.send(data_cstr, data.size());
> LOG(INFO) << "*** exiting scope";
>   }
> 
>   AWAIT_READY(sent);
> 
>   LOG(INFO) << "*** exiting test case";
> }
> ```
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 50936: Kept poll socket alive while sending.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50936/
---

(Updated Aug. 9, 2016, 11:31 p.m.)


Review request for mesos, Benjamin Mahler, Joseph Wu, and Vinod Kone.


Summary (updated)
-

Kept poll socket alive while sending.


Bugs: MESOS-5988
https://issues.apache.org/jira/browse/MESOS-5988


Repository: mesos


Description
---

Currently, the poll socket implementation doesn't keep
the socket alive after `PollSocketImpl.send(data, length)`
passes execution off to a continuation. This patch passes
a shared pointer of the socket implementation along to the
continuation, keeping the socket alive.


Diffs
-

  3rdparty/libprocess/src/poll_socket.cpp 
d14dd1ae210e112b917329803dfb09d98386b966 

Diff: https://reviews.apache.org/r/50936/diff/


Testing
---

Ran `make check` on OSX.

Also: I was able to expose the poll socket bug with the following test case. It 
triggers a "Bad file descriptor" error after 100-200 repetitions on my OSX 
machine. After applying this patch, I can run the test thousands of times with 
no failures:

```
TEST(HTTPTest, ClosedSocketFailure)
{
  const Try server_create = Socket::create();
  ASSERT_SOME(server_create);

  Socket server = server_create.get();
  LOG(INFO) << "*** server fd: " << server.get();

  Future sent;
  Future _socket;

  string data;
  for (auto i = 0; i < 26000; i++) {
data += "abcdefghijklmnopqrstuvwxyz0123456789abcdefghijklmnopqrstuvwxyz012";
  }
  const char* data_cstr = data.c_str();

  {
const Try client_create = Socket::create();
ASSERT_SOME(client_create);

Socket client = client_create.get();
LOG(INFO) << "*** client fd: " << client.get();

const Try listen = server.listen(5);
ASSERT_SOME(listen);

const Try server_address = server.address();
ASSERT_SOME(server_address);

_socket = server.accept();

const Future connect = client.connect(server_address.get());

// Wait for the server to have accepted the client connection.
AWAIT_ASSERT_READY(_socket);
Socket socket = _socket.get(); // TODO(jmlvanre): Remove const copy.

// Verify that the client also views the connection as established.
AWAIT_ASSERT_READY(connect);

// Send a message from the client to the server.
sent = client.send(data_cstr, data.size());
LOG(INFO) << "*** exiting scope";
  }

  AWAIT_READY(sent);

  LOG(INFO) << "*** exiting test case";
}
```


Thanks,

Greg Mann

Re: Review Request 50936: Kept poll socket alive during 'send()' continuations.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50936/
---

(Updated Aug. 9, 2016, 11:30 p.m.)


Review request for mesos, Benjamin Mahler, Joseph Wu, and Vinod Kone.


Changes
---

Addressed comments.


Bugs: MESOS-5988
https://issues.apache.org/jira/browse/MESOS-5988


Repository: mesos


Description
---

Currently, the poll socket implementation doesn't keep
the socket alive after `PollSocketImpl.send(data, length)`
passes execution off to a continuation. This patch passes
a shared pointer of the socket implementation along to the
continuation, keeping the socket alive.


Diffs (updated)
-

  3rdparty/libprocess/src/poll_socket.cpp 
d14dd1ae210e112b917329803dfb09d98386b966 

Diff: https://reviews.apache.org/r/50936/diff/


Testing (updated)
---

Ran `make check` on OSX.

Also: I was able to expose the poll socket bug with the following test case. It 
triggers a "Bad file descriptor" error after 100-200 repetitions on my OSX 
machine. After applying this patch, I can run the test thousands of times with 
no failures:

```
TEST(HTTPTest, ClosedSocketFailure)
{
  const Try server_create = Socket::create();
  ASSERT_SOME(server_create);

  Socket server = server_create.get();
  LOG(INFO) << "*** server fd: " << server.get();

  Future sent;
  Future _socket;

  string data;
  for (auto i = 0; i < 26000; i++) {
data += "abcdefghijklmnopqrstuvwxyz0123456789abcdefghijklmnopqrstuvwxyz012";
  }
  const char* data_cstr = data.c_str();

  {
const Try client_create = Socket::create();
ASSERT_SOME(client_create);

Socket client = client_create.get();
LOG(INFO) << "*** client fd: " << client.get();

const Try listen = server.listen(5);
ASSERT_SOME(listen);

const Try server_address = server.address();
ASSERT_SOME(server_address);

_socket = server.accept();

const Future connect = client.connect(server_address.get());

// Wait for the server to have accepted the client connection.
AWAIT_ASSERT_READY(_socket);
Socket socket = _socket.get(); // TODO(jmlvanre): Remove const copy.

// Verify that the client also views the connection as established.
AWAIT_ASSERT_READY(connect);

// Send a message from the client to the server.
sent = client.send(data_cstr, data.size());
LOG(INFO) << "*** exiting scope";
  }

  AWAIT_READY(sent);

  LOG(INFO) << "*** exiting test case";
}
```


Thanks,

Greg Mann

Re: Review Request 49828: Added default methods implementations for `Subsystem` base class.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49828/#review145288
---


Ship it!




Ship It!

- Jie Yu


On Aug. 9, 2016, 6:38 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49828/
> ---
> 
> (Updated Aug. 9, 2016, 6:38 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.
> 
> 
> Bugs: MESOS-5039
> https://issues.apache.org/jira/browse/MESOS-5039
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added default methods implementations for `Subsystem` base class.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
> 5f52a076a1fa3a21d886cb961ddeed5046a38d7c 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
> a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 
> 
> Diff: https://reviews.apache.org/r/49828/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 50936: Kept poll socket alive during 'send()' continuations.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50936/#review145284
---



Thanks Greg!


3rdparty/libprocess/src/poll_socket.cpp (line 166)


Can we avoid passing the int and just get the int from the Socket::Impl? 
(If we had followed the pattern of pulling the int out of the Socket::Impl we 
wouldn't have had this lifetime issue :)).



3rdparty/libprocess/src/poll_socket.cpp (lines 259 - 260)


Don't you need to handle the sendfile path as well?


- Benjamin Mahler


On Aug. 9, 2016, 9:56 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50936/
> ---
> 
> (Updated Aug. 9, 2016, 9:56 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Joseph Wu, and Vinod Kone.
> 
> 
> Bugs: MESOS-5988
> https://issues.apache.org/jira/browse/MESOS-5988
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Currently, the poll socket implementation doesn't keep
> the socket alive after `PollSocketImpl.send(data, length)`
> passes execution off to a continuation. This patch passes
> a shared pointer of the socket implementation along to the
> continuation, keeping the socket alive.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/poll_socket.cpp 
> d14dd1ae210e112b917329803dfb09d98386b966 
> 
> Diff: https://reviews.apache.org/r/50936/diff/
> 
> 
> Testing
> ---
> 
> I was able to expose the poll socket bug with the following test case. It 
> triggers a "Bad file descriptor" error after 100-200 repetitions on my OSX 
> machine. After applying this patch, I can run the test thousands of times 
> with no failures:
> 
> ```
> TEST(HTTPTest, ClosedSocketFailure)
> {
>   const Try server_create = Socket::create();
>   ASSERT_SOME(server_create);
> 
>   Socket server = server_create.get();
>   LOG(INFO) << "*** server fd: " << server.get();
> 
>   Future sent;
>   Future _socket;
> 
>   string data;
>   for (auto i = 0; i < 26000; i++) {
> data += 
> "abcdefghijklmnopqrstuvwxyz0123456789abcdefghijklmnopqrstuvwxyz012";
>   }
>   const char* data_cstr = data.c_str();
> 
>   {
> const Try client_create = Socket::create();
> ASSERT_SOME(client_create);
> 
> Socket client = client_create.get();
> LOG(INFO) << "*** client fd: " << client.get();
> 
> const Try listen = server.listen(5);
> ASSERT_SOME(listen);
> 
> const Try server_address = server.address();
> ASSERT_SOME(server_address);
> 
> _socket = server.accept();
> 
> const Future connect = client.connect(server_address.get());
> 
> // Wait for the server to have accepted the client connection.
> AWAIT_ASSERT_READY(_socket);
> Socket socket = _socket.get(); // TODO(jmlvanre): Remove const copy.
> 
> // Verify that the client also views the connection as established.
> AWAIT_ASSERT_READY(connect);
> 
> // Send a message from the client to the server.
> sent = client.send(data_cstr, data.size());
> LOG(INFO) << "*** exiting scope";
>   }
> 
>   AWAIT_READY(sent);
> 
>   LOG(INFO) << "*** exiting test case";
> }
> ```
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 50871: Supported auto backend in Unified Containerizer.

[Guangya Liu]

> On 八月 6, 2016, 1:06 p.m., Guangya Liu wrote:
> > src/slave/containerizer/mesos/provisioner/provisioner.cpp, lines 295-299
> > 
> >
> > I think we may need a test case to cover select backend smartly?
> 
> Gilbert Song wrote:
> This really depends on different OS and default kernel medules. It would 
> be hard to keep consistent behavior. BTW, we may add aufs later.

Agree, but I think that we can always construct some pre-conditions for the 
test cases and then using `expect` to validate the expected backend. In my 
understanding, the `auto backend` is also a feature and it is better to have a 
test case to cover this. ;-)


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50871/#review145032
---


On 八月 5, 2016, 11:27 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50871/
> ---
> 
> (Updated 八月 5, 2016, 11:27 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-5931
> https://issues.apache.org/jira/browse/MESOS-5931
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Supported auto backend in Unified Containerizer.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md d6a7eb02b9f3e0011d52ccfd3093167bb6adccd3 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 
> 6fc56522a72cda41d8af91a054feb7bfb9048531 
>   src/slave/flags.hpp 58fba4a22d988ac6612fc3af8a9346f0b8f8bb51 
>   src/slave/flags.cpp b8ecc98721c52dcd59a0cc1333421d4f024fbe96 
>   src/tests/containerizer/provisioner_appc_tests.cpp 
> b3ba176e506a6d1528290c07a8a0555b12c8cf70 
> 
> Diff: https://reviews.apache.org/r/50871/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> sudo ./bin/mesos-tests.sh
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 50266: Introduced linux capabilities API.

[Jie Yu]

> On July 22, 2016, 12:32 a.m., Jie Yu wrote:
> > src/linux/capabilities.cpp, lines 34-39
> > 
> >
> > Any reason why we need to declare them here? Shouldn't 
> > `` already declared them?
> 
> Benjamin Bannier wrote:
> These are libc function mapping to sys calls which are only exposed via 
> libcap development headers. Declaring them here ourself allows us to not 
> depend on the presence of the development header files. I agree this is not 
> something we do often. Should we just introduce the dependency on the dev 
> files and do away with our own decls of these functions here?

OK. Please add more comments here (basically what you describe here).


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50266/#review143038
---


On Aug. 9, 2016, 12:30 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50266/
> ---
> 
> (Updated Aug. 9, 2016, 12:30 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-5051
> https://issues.apache.org/jira/browse/MESOS-5051
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change introduces basic API for linux capabilities. This is not a
> comprehensive API but is strictly limited to the need for securing Mesos
> containers using linux capabilities.
> 
> This patch is based on the work in https://reviews.apache.org/r/46370/.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 
>   src/Makefile.am 1a9b083493612cf610b80ac5a1c11c29d6302933 
>   src/linux/capabilities.hpp PRE-CREATION 
>   src/linux/capabilities.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50266/diff/
> 
> 
> Testing
> ---
> 
> `make check` and `sudo make check` (Debian jessie, gcc-4.9.2, w/o 
> optimizations)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 50266: Introduced linux capabilities API.

[Jie Yu]

> On July 22, 2016, 12:32 a.m., Jie Yu wrote:
> > src/linux/capabilities.hpp, lines 108-110
> > 
> >
> > No need to for this friend unqulified function. This can just be a 
> > member function.
> 
> Benjamin Bannier wrote:
> I am not sure I follow. This provides a way to insert a 
> `ProcessCapabilities` into an `ostream` for printing, and I believe this is 
> the canonical form. If implemented as a member the use would be completely 
> different (`set.printOn(stream)`?).

Oops. My bad. Didn't realized that `<<` (unlike `+` or `-`) does not allow 
being defined as a member function.


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50266/#review143038
---


On Aug. 9, 2016, 12:30 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50266/
> ---
> 
> (Updated Aug. 9, 2016, 12:30 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-5051
> https://issues.apache.org/jira/browse/MESOS-5051
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change introduces basic API for linux capabilities. This is not a
> comprehensive API but is strictly limited to the need for securing Mesos
> containers using linux capabilities.
> 
> This patch is based on the work in https://reviews.apache.org/r/46370/.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 
>   src/Makefile.am 1a9b083493612cf610b80ac5a1c11c29d6302933 
>   src/linux/capabilities.hpp PRE-CREATION 
>   src/linux/capabilities.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50266/diff/
> 
> 
> Testing
> ---
> 
> `make check` and `sudo make check` (Debian jessie, gcc-4.9.2, w/o 
> optimizations)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 50771: Added coverity build to build_docker.sh.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50771/#review145273
---


Fix it, then Ship it!





support/docker_build.sh (line 125)


space after #



support/docker_build.sh (line 128)


space after #



support/docker_build.sh (line 134)


can the email be d...@mesos.apache.org?


- Vinod Kone


On Aug. 3, 2016, 9:24 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50771/
> ---
> 
> (Updated Aug. 3, 2016, 9:24 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5984
> https://issues.apache.org/jira/browse/MESOS-5984
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This review adds an coverity build option
> to build_docker.sh in order to enable
> regular coverity builds on the ASF infrastructure.
> 
> 
> Diffs
> -
> 
>   support/docker_build.sh 8ae1aadbc12b12e44984d34ccfbcb8a97bf05bcf 
> 
> Diff: https://reviews.apache.org/r/50771/diff/
> 
> 
> Testing
> ---
> 
> ran build with and without COVERITY_TOKEN.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 50936: Kept poll socket alive during 'send()' continuations.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50936/
---

(Updated Aug. 9, 2016, 9:56 p.m.)


Review request for mesos, Benjamin Mahler, Joseph Wu, and Vinod Kone.


Bugs: MESOS-5988
https://issues.apache.org/jira/browse/MESOS-5988


Repository: mesos


Description (updated)
---

Currently, the poll socket implementation doesn't keep
the socket alive after `PollSocketImpl.send(data, length)`
passes execution off to a continuation. This patch passes
a shared pointer of the socket implementation along to the
continuation, keeping the socket alive.


Diffs
-

  3rdparty/libprocess/src/poll_socket.cpp 
d14dd1ae210e112b917329803dfb09d98386b966 

Diff: https://reviews.apache.org/r/50936/diff/


Testing
---

I was able to expose the poll socket bug with the following test case. It 
triggers a "Bad file descriptor" error after 100-200 repetitions on my OSX 
machine. After applying this patch, I can run the test thousands of times with 
no failures:

```
TEST(HTTPTest, ClosedSocketFailure)
{
  const Try server_create = Socket::create();
  ASSERT_SOME(server_create);

  Socket server = server_create.get();
  LOG(INFO) << "*** server fd: " << server.get();

  Future sent;
  Future _socket;

  string data;
  for (auto i = 0; i < 26000; i++) {
data += "abcdefghijklmnopqrstuvwxyz0123456789abcdefghijklmnopqrstuvwxyz012";
  }
  const char* data_cstr = data.c_str();

  {
const Try client_create = Socket::create();
ASSERT_SOME(client_create);

Socket client = client_create.get();
LOG(INFO) << "*** client fd: " << client.get();

const Try listen = server.listen(5);
ASSERT_SOME(listen);

const Try server_address = server.address();
ASSERT_SOME(server_address);

_socket = server.accept();

const Future connect = client.connect(server_address.get());

// Wait for the server to have accepted the client connection.
AWAIT_ASSERT_READY(_socket);
Socket socket = _socket.get(); // TODO(jmlvanre): Remove const copy.

// Verify that the client also views the connection as established.
AWAIT_ASSERT_READY(connect);

// Send a message from the client to the server.
sent = client.send(data_cstr, data.size());
LOG(INFO) << "*** exiting scope";
  }

  AWAIT_READY(sent);

  LOG(INFO) << "*** exiting test case";
}
```


Thanks,

Greg Mann

Review Request 50936: Kept poll socket alive during 'send()' continuations.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50936/
---

Review request for mesos, Benjamin Mahler, Joseph Wu, and Vinod Kone.


Bugs: MESOS-5988
https://issues.apache.org/jira/browse/MESOS-5988


Repository: mesos


Description
---

Currently, the poll socket implementation doesn't keep
the socket alive after `PollSocketImpl.send(data, length)`
passes execution off to a continuation. This patch passes
a shared pointer of the socket along to the continuation,
keeping the socket alive.


Diffs
-

  3rdparty/libprocess/src/poll_socket.cpp 
d14dd1ae210e112b917329803dfb09d98386b966 

Diff: https://reviews.apache.org/r/50936/diff/


Testing
---

I was able to expose the poll socket bug with the following test case. It 
triggers a "Bad file descriptor" error after 100-200 repetitions on my OSX 
machine. After applying this patch, I can run the test thousands of times with 
no failures:

```
TEST(HTTPTest, ClosedSocketFailure)
{
  const Try server_create = Socket::create();
  ASSERT_SOME(server_create);

  Socket server = server_create.get();
  LOG(INFO) << "*** server fd: " << server.get();

  Future sent;
  Future _socket;

  string data;
  for (auto i = 0; i < 26000; i++) {
data += "abcdefghijklmnopqrstuvwxyz0123456789abcdefghijklmnopqrstuvwxyz012";
  }
  const char* data_cstr = data.c_str();

  {
const Try client_create = Socket::create();
ASSERT_SOME(client_create);

Socket client = client_create.get();
LOG(INFO) << "*** client fd: " << client.get();

const Try listen = server.listen(5);
ASSERT_SOME(listen);

const Try server_address = server.address();
ASSERT_SOME(server_address);

_socket = server.accept();

const Future connect = client.connect(server_address.get());

// Wait for the server to have accepted the client connection.
AWAIT_ASSERT_READY(_socket);
Socket socket = _socket.get(); // TODO(jmlvanre): Remove const copy.

// Verify that the client also views the connection as established.
AWAIT_ASSERT_READY(connect);

// Send a message from the client to the server.
sent = client.send(data_cstr, data.size());
LOG(INFO) << "*** exiting scope";
  }

  AWAIT_READY(sent);

  LOG(INFO) << "*** exiting test case";
}
```


Thanks,

Greg Mann

Re: Review Request 46676: Slave/Agent Rename Phase I: Rename '/include/mesos/slave' folder.

[Jie Yu]

> On Aug. 9, 2016, 9:26 p.m., Jie Yu wrote:
> > src/Makefile.am, line 535
> > 
> >
> > This will break agent headers.
> > 
> > FOr instance, isolator.hpp has the following:
> > ```
> > #include 
> > ```
> 
> Jie Yu wrote:
> See details in: https://issues.apache.org/jira/browse/MESOS-6012

NVM, saw the slave -> agent symlink


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46676/#review145265
---


On April 27, 2016, 1:57 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46676/
> ---
> 
> (Updated April 27, 2016, 1:57 a.m.)
> 
> 
> Review request for mesos, Kevin Klues and Vinod Kone.
> 
> 
> Bugs: mesos-5230
> https://issues.apache.org/jira/browse/mesos-5230
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch did the following changes:
> 
> 1. Change the 'make install' headers installation location from
> '$(DESTDIR)/include/mesos/slave' to '$(DESTDIR)include/mesos/agent'
> 
> 2. As we do not change the folder name from 'include/mesos/slave'
> to 'include/mesos/agent', create a 'slave -> agent' symlink in dir
> '$(DESTDIR)/include/mesos'
> 
> 
> Diffs
> -
> 
>   CHANGELOG 57f5457640c9b7ca2cb7707f2962dd0421f090f7 
>   src/Makefile.am e024c6d65608a55765e527a8668c415723dcfcca 
> 
> Diff: https://reviews.apache.org/r/46676/diff/
> 
> 
> Testing
> ---
> 
> cd mesos
> ./bootstrap
> mkdir build
> cd build
> ../configure --prefix=${HOME}/install/mesos
> make
> make check
> make install
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 46676: Slave/Agent Rename Phase I: Rename '/include/mesos/slave' folder.

[Kevin Klues]

> On Aug. 9, 2016, 9:26 p.m., Jie Yu wrote:
> >
> 
> Kevin Klues wrote:
> Look back at the thread above started by Vinod. This was dicussed in 
> there, though it's not clear what the outcome was.
> 
> Kevin Klues wrote:
> Also, if you look further down in the patch, the line:
> 
> ```
>   ln -s $(DESTDIR)/$(includedir)/mesos/agent \
> $(DESTDIR)/$(includedir)/mesos/slave
> ```
> 
> Should have accommodated for this.

Thought this should probably be a relative symlink rather than an absolute one, 
i.e.,
```
ln -s agent $(DESTDIR)/$(includedir)/mesos/slave
```


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46676/#review145265
---


On April 27, 2016, 1:57 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46676/
> ---
> 
> (Updated April 27, 2016, 1:57 a.m.)
> 
> 
> Review request for mesos, Kevin Klues and Vinod Kone.
> 
> 
> Bugs: mesos-5230
> https://issues.apache.org/jira/browse/mesos-5230
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch did the following changes:
> 
> 1. Change the 'make install' headers installation location from
> '$(DESTDIR)/include/mesos/slave' to '$(DESTDIR)include/mesos/agent'
> 
> 2. As we do not change the folder name from 'include/mesos/slave'
> to 'include/mesos/agent', create a 'slave -> agent' symlink in dir
> '$(DESTDIR)/include/mesos'
> 
> 
> Diffs
> -
> 
>   CHANGELOG 57f5457640c9b7ca2cb7707f2962dd0421f090f7 
>   src/Makefile.am e024c6d65608a55765e527a8668c415723dcfcca 
> 
> Diff: https://reviews.apache.org/r/46676/diff/
> 
> 
> Testing
> ---
> 
> cd mesos
> ./bootstrap
> mkdir build
> cd build
> ../configure --prefix=${HOME}/install/mesos
> make
> make check
> make install
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 46676: Slave/Agent Rename Phase I: Rename '/include/mesos/slave' folder.

[Kevin Klues]

> On Aug. 9, 2016, 9:26 p.m., Jie Yu wrote:
> >
> 
> Kevin Klues wrote:
> Look back at the thread above started by Vinod. This was dicussed in 
> there, though it's not clear what the outcome was.

Also, if you look further down in the patch, the line:

```
ln -s $(DESTDIR)/$(includedir)/mesos/agent \
  $(DESTDIR)/$(includedir)/mesos/slave
```

Should have accommodated for this.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46676/#review145265
---


On April 27, 2016, 1:57 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46676/
> ---
> 
> (Updated April 27, 2016, 1:57 a.m.)
> 
> 
> Review request for mesos, Kevin Klues and Vinod Kone.
> 
> 
> Bugs: mesos-5230
> https://issues.apache.org/jira/browse/mesos-5230
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch did the following changes:
> 
> 1. Change the 'make install' headers installation location from
> '$(DESTDIR)/include/mesos/slave' to '$(DESTDIR)include/mesos/agent'
> 
> 2. As we do not change the folder name from 'include/mesos/slave'
> to 'include/mesos/agent', create a 'slave -> agent' symlink in dir
> '$(DESTDIR)/include/mesos'
> 
> 
> Diffs
> -
> 
>   CHANGELOG 57f5457640c9b7ca2cb7707f2962dd0421f090f7 
>   src/Makefile.am e024c6d65608a55765e527a8668c415723dcfcca 
> 
> Diff: https://reviews.apache.org/r/46676/diff/
> 
> 
> Testing
> ---
> 
> cd mesos
> ./bootstrap
> mkdir build
> cd build
> ../configure --prefix=${HOME}/install/mesos
> make
> make check
> make install
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 46676: Slave/Agent Rename Phase I: Rename '/include/mesos/slave' folder.

[Kevin Klues]

> On Aug. 9, 2016, 9:26 p.m., Jie Yu wrote:
> >

Look back at the thread above started by Vinod. This was dicussed in there, 
though it's not clear what the outcome was.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46676/#review145265
---


On April 27, 2016, 1:57 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46676/
> ---
> 
> (Updated April 27, 2016, 1:57 a.m.)
> 
> 
> Review request for mesos, Kevin Klues and Vinod Kone.
> 
> 
> Bugs: mesos-5230
> https://issues.apache.org/jira/browse/mesos-5230
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch did the following changes:
> 
> 1. Change the 'make install' headers installation location from
> '$(DESTDIR)/include/mesos/slave' to '$(DESTDIR)include/mesos/agent'
> 
> 2. As we do not change the folder name from 'include/mesos/slave'
> to 'include/mesos/agent', create a 'slave -> agent' symlink in dir
> '$(DESTDIR)/include/mesos'
> 
> 
> Diffs
> -
> 
>   CHANGELOG 57f5457640c9b7ca2cb7707f2962dd0421f090f7 
>   src/Makefile.am e024c6d65608a55765e527a8668c415723dcfcca 
> 
> Diff: https://reviews.apache.org/r/46676/diff/
> 
> 
> Testing
> ---
> 
> cd mesos
> ./bootstrap
> mkdir build
> cd build
> ../configure --prefix=${HOME}/install/mesos
> make
> make check
> make install
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 46676: Slave/Agent Rename Phase I: Rename '/include/mesos/slave' folder.

[Jie Yu]

> On Aug. 9, 2016, 9:26 p.m., Jie Yu wrote:
> > src/Makefile.am, line 535
> > 
> >
> > This will break agent headers.
> > 
> > FOr instance, isolator.hpp has the following:
> > ```
> > #include 
> > ```

See details in: https://issues.apache.org/jira/browse/MESOS-6012


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46676/#review145265
---


On April 27, 2016, 1:57 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46676/
> ---
> 
> (Updated April 27, 2016, 1:57 a.m.)
> 
> 
> Review request for mesos, Kevin Klues and Vinod Kone.
> 
> 
> Bugs: mesos-5230
> https://issues.apache.org/jira/browse/mesos-5230
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch did the following changes:
> 
> 1. Change the 'make install' headers installation location from
> '$(DESTDIR)/include/mesos/slave' to '$(DESTDIR)include/mesos/agent'
> 
> 2. As we do not change the folder name from 'include/mesos/slave'
> to 'include/mesos/agent', create a 'slave -> agent' symlink in dir
> '$(DESTDIR)/include/mesos'
> 
> 
> Diffs
> -
> 
>   CHANGELOG 57f5457640c9b7ca2cb7707f2962dd0421f090f7 
>   src/Makefile.am e024c6d65608a55765e527a8668c415723dcfcca 
> 
> Diff: https://reviews.apache.org/r/46676/diff/
> 
> 
> Testing
> ---
> 
> cd mesos
> ./bootstrap
> mkdir build
> cd build
> ../configure --prefix=${HOME}/install/mesos
> make
> make check
> make install
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 46676: Slave/Agent Rename Phase I: Rename '/include/mesos/slave' folder.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46676/#review145265
---




src/Makefile.am (line 535)


This will break agent headers.

FOr instance, isolator.hpp has the following:
```
#include 
```


- Jie Yu


On April 27, 2016, 1:57 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46676/
> ---
> 
> (Updated April 27, 2016, 1:57 a.m.)
> 
> 
> Review request for mesos, Kevin Klues and Vinod Kone.
> 
> 
> Bugs: mesos-5230
> https://issues.apache.org/jira/browse/mesos-5230
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch did the following changes:
> 
> 1. Change the 'make install' headers installation location from
> '$(DESTDIR)/include/mesos/slave' to '$(DESTDIR)include/mesos/agent'
> 
> 2. As we do not change the folder name from 'include/mesos/slave'
> to 'include/mesos/agent', create a 'slave -> agent' symlink in dir
> '$(DESTDIR)/include/mesos'
> 
> 
> Diffs
> -
> 
>   CHANGELOG 57f5457640c9b7ca2cb7707f2962dd0421f090f7 
>   src/Makefile.am e024c6d65608a55765e527a8668c415723dcfcca 
> 
> Diff: https://reviews.apache.org/r/46676/diff/
> 
> 
> Testing
> ---
> 
> cd mesos
> ./bootstrap
> mkdir build
> cd build
> ../configure --prefix=${HOME}/install/mesos
> make
> make check
> make install
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 49817: Implemented `CgroupsIsolatorProcess::recover`.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49817/#review145259
---




src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line 164)


This is not necessary. A failed recovery will cause the agent to exit 
anyway.



src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (lines 185 - 190)


Hum, I don't like this approach of chaining. Can we just move orphan 
container logic to `_recover`?

```
return await(recovers)
  .then(defer(..., &_recover, ...));
```



src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (lines 195 - 197)


what you need here is essentially the top level cgroups, right?

We should improve cgroups::get to take an additional `recursive` flag.



src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line 200)


Ditto. This is not needed.



src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line 201)


Please add more context on the failure:
```
Failed to list cgroups under ...
```



src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (lines 234 - 238)


I'd prefer we log the error if it fails.


- Jie Yu


On Aug. 9, 2016, 6:38 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49817/
> ---
> 
> (Updated Aug. 9, 2016, 6:38 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.
> 
> 
> Bugs: MESOS-5041
> https://issues.apache.org/jira/browse/MESOS-5041
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented `CgroupsIsolatorProcess::recover`.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 
> b191b2a52a9645fc902a35ed52909b2142f0b4c0 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
> 2659252d8cffcefc233bc85fb4707c8147272737 
> 
> Diff: https://reviews.apache.org/r/49817/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 49855: Enabled cgroups unified isolator in isolation.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49855/#review145257
---



Patch looks great!

Reviews applied: [49819, 49820, 49821, 49823, 49824, 49825, 49827, 50627, 
50642, 50643, 49817, 49828, 49849, 49850, 49851, 49852, 45573, 49853, 49854, 
49855]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Aug. 9, 2016, 6:42 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49855/
> ---
> 
> (Updated Aug. 9, 2016, 6:42 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.
> 
> 
> Bugs: MESOS-5652
> https://issues.apache.org/jira/browse/MESOS-5652
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled cgroups unified isolator in isolation.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 86a8d8a85b6a33c87798108cb65af85bb9bbbc77 
> 
> Diff: https://reviews.apache.org/r/49855/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 50837: Fixed minor code style.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50837/#review145249
---


Ship it!




Ship It!

- Joseph Wu


On Aug. 5, 2016, 1:15 a.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50837/
> ---
> 
> (Updated Aug. 5, 2016, 1:15 a.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed minor code style.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/protobuf.hpp 
> 695c6e6572852d2c4afbaacc6b63771ed035fd65 
> 
> Diff: https://reviews.apache.org/r/50837/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 50914: Removed the external containerizer.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50914/
---

(Updated Aug. 9, 2016, 1:12 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Till 
Toenshoff, and Vinod Kone.


Bugs: MESOS-3370
https://issues.apache.org/jira/browse/MESOS-3370


Repository: mesos


Description
---

Removed the external containerizer.


Diffs (updated)
-

  configure.ac f82c6314d65a8ea3eb118bab8e110063cae46121 
  docs/committers.md a4cf837e3058686347bc721dc7f0745f88c4fa81 
  docs/configuration.md d6a7eb02b9f3e0011d52ccfd3093167bb6adccd3 
  docs/containerizer-internals.md 1839c7290c2c7681c516b3514face7496ffb2521 
  docs/external-containerizer.md eece9e73d47c13cc50074ef77235147f09cd380a 
  docs/fetcher.md 688984552ae243eb59a3c1bfb7abd3898e4fac67 
  docs/home.md 80451f4a9b2327dc728b9454938b6205043bebbb 
  docs/sandbox.md db973e311b8562aa25fcdcdabefa1f342d25e26e 
  include/mesos/containerizer/containerizer.proto 
4d8e82791c263c6578bf06f4e94ebe853042be59 
  src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 
  src/Makefile.am 1a9b083493612cf610b80ac5a1c11c29d6302933 
  src/examples/python/test-containerizer.in 
5066b45d11ce0418d6c8ae8374b5103cb0eaa249 
  src/examples/python/test_containerizer.py 
8e154b0e8e0db3cfc5d3f695d509b0e49bcec652 
  src/slave/containerizer/containerizer.cpp 
ba3b3f62fe0cf755fdbebf52350d9069cb2efca8 
  src/slave/containerizer/external_containerizer.hpp 
feeb0278a3d8fec8c7177a9a3dc443ee0c198c5c 
  src/slave/containerizer/external_containerizer.cpp 
9ee137a7731e66754bbf86424071765962423969 
  src/slave/flags.hpp 58fba4a22d988ac6612fc3af8a9346f0b8f8bb51 
  src/slave/flags.cpp b8ecc98721c52dcd59a0cc1333421d4f024fbe96 
  src/tests/containerizer/external_containerizer_test.cpp 
226eac56725e908040abda306a2e5e3c96bce9d7 

Diff: https://reviews.apache.org/r/50914/diff/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 50810: Fixed provisioner appc support on windows build.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50810/#review145251
---


Ship it!




Note: The original code compiles on Windows :)

- Joseph Wu


On Aug. 9, 2016, 12:24 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50810/
> ---
> 
> (Updated Aug. 9, 2016, 12:24 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Jie Yu, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed provisioner appc support on windows build.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 
> 6fc56522a72cda41d8af91a054feb7bfb9048531 
> 
> Diff: https://reviews.apache.org/r/50810/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 50810: Fixed provisioner appc support on windows build.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50810/
---

(Updated Aug. 9, 2016, 12:24 p.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, Jie Yu, and Joseph 
Wu.


Repository: mesos


Description
---

Fixed provisioner appc support on windows build.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/provisioner.cpp 
6fc56522a72cda41d8af91a054feb7bfb9048531 

Diff: https://reviews.apache.org/r/50810/diff/


Testing (updated)
---

make check


Thanks,

Gilbert Song

Re: Review Request 50922: Moved the implementation of health check to health_checker.cpp.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50922/#review145244
---



Patch looks great!

Reviews applied: [50922]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Aug. 9, 2016, 6:13 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50922/
> ---
> 
> (Updated Aug. 9, 2016, 6:13 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Gastón 
> Kleiman.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moved the implementation of health check to health_checker.cpp.
> 
> 
> Diffs
> -
> 
>   src/health-check/health_checker.hpp 
> b28a9cf3c6c9217c0b2453ac6e34d88e1f648d61 
>   src/health-check/health_checker.cpp 
> 585a0b565d948cfa292bad818a710501a4ce0daf 
> 
> Diff: https://reviews.apache.org/r/50922/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 50750: Removed CgroupsNetClsIsolatorProcess.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50750/
---

(Updated Aug. 9, 2016, 6:45 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5976
https://issues.apache.org/jira/browse/MESOS-5976


Repository: mesos


Description
---

Removed CgroupsNetClsIsolatorProcess.


Diffs (updated)
-

  src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 
  src/Makefile.am 39e3199a03860edf7321b442b87582b0564a318c 
  src/slave/containerizer/mesos/containerizer.cpp 
86a8d8a85b6a33c87798108cb65af85bb9bbbc77 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 
b3fd8c85476bf46368bd79f052b7923ad9d32199 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
5f52a076a1fa3a21d886cb961ddeed5046a38d7c 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 
  src/tests/containerizer/isolator_tests.cpp 
827c9f06b97191a5b74bb8fa2ef716c4282e7518 

Diff: https://reviews.apache.org/r/50750/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 50751: Removed CgroupsPerfEventIsolatorProcess.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50751/
---

(Updated Aug. 9, 2016, 6:45 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5975
https://issues.apache.org/jira/browse/MESOS-5975


Repository: mesos


Description
---

Removed CgroupsPerfEventIsolatorProcess.


Diffs (updated)
-

  src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 
  src/Makefile.am 39e3199a03860edf7321b442b87582b0564a318c 
  src/slave/containerizer/mesos/containerizer.cpp 
86a8d8a85b6a33c87798108cb65af85bb9bbbc77 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
5f52a076a1fa3a21d886cb961ddeed5046a38d7c 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 
  src/tests/containerizer/isolator_tests.cpp 
827c9f06b97191a5b74bb8fa2ef716c4282e7518 

Diff: https://reviews.apache.org/r/50751/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 50749: Removed CgroupsDevicesIsolatorProcess.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50749/
---

(Updated Aug. 9, 2016, 6:44 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5977
https://issues.apache.org/jira/browse/MESOS-5977


Repository: mesos


Description
---

Removed CgroupsDevicesIsolatorProcess.


Diffs (updated)
-

  src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 
  src/Makefile.am 39e3199a03860edf7321b442b87582b0564a318c 
  src/slave/containerizer/mesos/containerizer.cpp 
86a8d8a85b6a33c87798108cb65af85bb9bbbc77 
  src/slave/containerizer/mesos/isolators/cgroups/devices.hpp 
7ad96440b21a380c5d9af27b0168e9abf47769af 

Diff: https://reviews.apache.org/r/50749/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 50748: Removed CgroupsMemIsolatorProcess.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50748/
---

(Updated Aug. 9, 2016, 6:42 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5974
https://issues.apache.org/jira/browse/MESOS-5974


Repository: mesos


Description
---

Removed CgroupsMemIsolatorProcess.


Diffs (updated)
-

  src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 
  src/Makefile.am 39e3199a03860edf7321b442b87582b0564a318c 
  src/docker/docker.cpp e8d2cb9662af34d75c9e2d822004f58fac76e7e0 
  src/slave/containerizer/mesos/containerizer.cpp 
86a8d8a85b6a33c87798108cb65af85bb9bbbc77 
  src/slave/containerizer/mesos/isolators/cgroups/mem.hpp 
b3ce6ed2505312bdd2d800164c2f57cd7625c9fa 
  src/tests/containerizer/isolator_tests.cpp 
827c9f06b97191a5b74bb8fa2ef716c4282e7518 

Diff: https://reviews.apache.org/r/50748/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 50733: Removed CgroupsCpushareIsolatorProcess.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50733/
---

(Updated Aug. 9, 2016, 6:42 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5973
https://issues.apache.org/jira/browse/MESOS-5973


Repository: mesos


Description
---

Removed CgroupsCpushareIsolatorProcess.


Diffs (updated)
-

  src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 
  src/Makefile.am 39e3199a03860edf7321b442b87582b0564a318c 
  src/docker/docker.cpp e8d2cb9662af34d75c9e2d822004f58fac76e7e0 
  src/slave/containerizer/mesos/containerizer.cpp 
86a8d8a85b6a33c87798108cb65af85bb9bbbc77 
  src/slave/containerizer/mesos/isolators/cgroups/cpushare.hpp 
74982a610b6c0a74734165a0c6aa8c9f72f54deb 
  src/slave/containerizer/mesos/isolators/cgroups/cpushare.cpp 
221e814a448c4b5df9dab98de597451a24e2b89c 
  src/tests/containerizer/isolator_tests.cpp 
827c9f06b97191a5b74bb8fa2ef716c4282e7518 

Diff: https://reviews.apache.org/r/50733/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 49855: Enabled cgroups unified isolator in isolation.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49855/
---

(Updated Aug. 9, 2016, 6:42 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5652
https://issues.apache.org/jira/browse/MESOS-5652


Repository: mesos


Description
---

Enabled cgroups unified isolator in isolation.


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.cpp 
86a8d8a85b6a33c87798108cb65af85bb9bbbc77 

Diff: https://reviews.apache.org/r/49855/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 49854: Implemented `DevicesSubsystem`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49854/
---

(Updated Aug. 9, 2016, 6:41 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5651
https://issues.apache.org/jira/browse/MESOS-5651


Repository: mesos


Description
---

Implemented `DevicesSubsystem`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
2659252d8cffcefc233bc85fb4707c8147272737 
  src/slave/containerizer/mesos/isolators/cgroups/constants.hpp 
c45d88092f3fe497373dfeaa8346aef9126c7b8b 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
5f52a076a1fa3a21d886cb961ddeed5046a38d7c 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 

Diff: https://reviews.apache.org/r/49854/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 49853: Implemented `PerfEventSubsystem`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49853/
---

(Updated Aug. 9, 2016, 6:41 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5047
https://issues.apache.org/jira/browse/MESOS-5047


Repository: mesos


Description
---

Implemented `PerfEventSubsystem`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
2659252d8cffcefc233bc85fb4707c8147272737 
  src/slave/containerizer/mesos/isolators/cgroups/constants.hpp 
c45d88092f3fe497373dfeaa8346aef9126c7b8b 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
5f52a076a1fa3a21d886cb961ddeed5046a38d7c 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 

Diff: https://reviews.apache.org/r/49853/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45573: Added `PerfEventHandleManager`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45573/
---

(Updated Aug. 9, 2016, 6:40 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5047
https://issues.apache.org/jira/browse/MESOS-5047


Repository: mesos


Description
---

Added `PerfEventHandleManager`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/perf_event.hpp 
4abde12af68a26b94b3706cdb38bf9890d811039 
  src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp 
31f35385691681ef5da14be747edfb5f57c5d05a 

Diff: https://reviews.apache.org/r/45573/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 49852: Implemented `NetClsSubsystem`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49852/
---

(Updated Aug. 9, 2016, 6:40 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5046
https://issues.apache.org/jira/browse/MESOS-5046


Repository: mesos


Description
---

Implemented `NetClsSubsystem`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
2659252d8cffcefc233bc85fb4707c8147272737 
  src/slave/containerizer/mesos/isolators/cgroups/constants.hpp 
c45d88092f3fe497373dfeaa8346aef9126c7b8b 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
5f52a076a1fa3a21d886cb961ddeed5046a38d7c 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 

Diff: https://reviews.apache.org/r/49852/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 49851: Implemented `MemorySubsystem`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49851/
---

(Updated Aug. 9, 2016, 6:40 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Address @qianzhang's comment.


Bugs: MESOS-5045
https://issues.apache.org/jira/browse/MESOS-5045


Repository: mesos


Description
---

Implemented `MemorySubsystem`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 
b191b2a52a9645fc902a35ed52909b2142f0b4c0 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
2659252d8cffcefc233bc85fb4707c8147272737 
  src/slave/containerizer/mesos/isolators/cgroups/constants.hpp 
c45d88092f3fe497373dfeaa8346aef9126c7b8b 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
5f52a076a1fa3a21d886cb961ddeed5046a38d7c 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 

Diff: https://reviews.apache.org/r/49851/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 49849: Implemented `CpuSubsystem`.

[haosdent huang]

> On Aug. 7, 2016, 1 p.m., Qian Zhang wrote:
> > src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp, lines 172-175
> > 
> >
> > Just curious why we need this method? When will it be called?

Now it called in LOG messages.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49849/#review145039
---


On Aug. 9, 2016, 6:39 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49849/
> ---
> 
> (Updated Aug. 9, 2016, 6:39 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.
> 
> 
> Bugs: MESOS-5042
> https://issues.apache.org/jira/browse/MESOS-5042
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented `CpuSubsystem`.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
> 2659252d8cffcefc233bc85fb4707c8147272737 
>   src/slave/containerizer/mesos/isolators/cgroups/constants.hpp 
> c45d88092f3fe497373dfeaa8346aef9126c7b8b 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
> 5f52a076a1fa3a21d886cb961ddeed5046a38d7c 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
> a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 
> 
> Diff: https://reviews.apache.org/r/49849/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 49850: Implemented `CpuacctSubsystem`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49850/
---

(Updated Aug. 9, 2016, 6:39 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5043
https://issues.apache.org/jira/browse/MESOS-5043


Repository: mesos


Description
---

Implemented `CpuacctSubsystem`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
2659252d8cffcefc233bc85fb4707c8147272737 
  src/slave/containerizer/mesos/isolators/cgroups/constants.hpp 
c45d88092f3fe497373dfeaa8346aef9126c7b8b 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
5f52a076a1fa3a21d886cb961ddeed5046a38d7c 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 

Diff: https://reviews.apache.org/r/49850/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 49849: Implemented `CpuSubsystem`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49849/
---

(Updated Aug. 9, 2016, 6:39 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5042
https://issues.apache.org/jira/browse/MESOS-5042


Repository: mesos


Description
---

Implemented `CpuSubsystem`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
2659252d8cffcefc233bc85fb4707c8147272737 
  src/slave/containerizer/mesos/isolators/cgroups/constants.hpp 
c45d88092f3fe497373dfeaa8346aef9126c7b8b 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
5f52a076a1fa3a21d886cb961ddeed5046a38d7c 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 

Diff: https://reviews.apache.org/r/49849/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 49828: Added default methods implementations for `Subsystem` base class.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49828/
---

(Updated Aug. 9, 2016, 6:38 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5039
https://issues.apache.org/jira/browse/MESOS-5039


Repository: mesos


Description
---

Added default methods implementations for `Subsystem` base class.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
5f52a076a1fa3a21d886cb961ddeed5046a38d7c 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 

Diff: https://reviews.apache.org/r/49828/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 49817: Implemented `CgroupsIsolatorProcess::recover`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49817/
---

(Updated Aug. 9, 2016, 6:38 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5041
https://issues.apache.org/jira/browse/MESOS-5041


Repository: mesos


Description
---

Implemented `CgroupsIsolatorProcess::recover`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 
b191b2a52a9645fc902a35ed52909b2142f0b4c0 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
2659252d8cffcefc233bc85fb4707c8147272737 

Diff: https://reviews.apache.org/r/49817/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 50540: Add systemd watchdog support.

[Ian Downes]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50540/#review144525
---




configure.ac (lines 615 - 616)


What are the implications of linking this in for people that have systemd 
but don't want to manage Mesos with systemd? Should this be a configure option?



src/Makefile.am (line 2145)


Formatting should be 8 ts which I don't think this is. Use "set ts=8" in 
Vim.



src/Makefile.am (line 2193)


Ditto, formatting.



src/linux/systemd.hpp (lines 20 - 21)


We alphabetize includes so process.hpp comes before subprocess.hpp. See the 
style guide.



src/linux/systemd.hpp (line 36)


const reference?

Does the period need to change for different calls? Why not make it a 
static instance variable?



src/linux/systemd.hpp (line 38)


Check style, I think it's to include comment on close of #ifdef, e.g.,

#endif // HAVE_LIBSYSTEMD



src/linux/systemd.cpp (line 31)


Do you need this conditional compilation *within* the linux/systemd.cpp 
file, or is inclusion of the entire file conditional?



src/linux/systemd.cpp (line 195)


ditto



src/linux/systemd.cpp (line 196)


Is there any behavior defined if the variable is set but with no value? As 
opposed to being unset?



src/linux/systemd.cpp (line 199)


use os::getenv()



src/linux/systemd.cpp (line 200)


use numify<>()



src/linux/systemd.cpp (line 201)


Watchdog* watchdog

What's the lifetime of this object!? Who (and when) releases it?



src/linux/systemd.cpp (line 212)


ditto



src/linux/systemd.cpp (line 213)


This would be const& but see earlier.



src/tests/linux/systemd_test_helper.cpp (lines 19 - 21)


split these



src/tests/linux/systemd_test_helper.cpp (line 34)


Is this universally true across all distributions?



src/tests/linux/systemd_test_helper.cpp (line 35)


Can't assume cgroups are mounted here. Tests use TEST_CGROUPS_HIERARCHY?



src/tests/linux/systemd_tests.cpp (lines 17 - 22)


alphabetize please.



src/tests/linux/systemd_tests.cpp (line 44)


Is there any way to create the service files outside of the system 
directory to avoid polluting it (especially if the test crashes)?

And, systemd-test-helper is a pretty generic name...



src/tests/linux/systemd_tests.cpp (line 45)


import this and std::cout etc.



src/tests/linux/systemd_tests.cpp (line 47)


std::endl on preceeding line?



src/tests/linux/systemd_tests.cpp (lines 65 - 68)


Use stout's os::write(path, message).



src/tests/linux/systemd_tests.cpp (line 71)


Don't use informational logging, use assertions with logging:
ASSERT(false) << "Ooops!";



src/tests/linux/systemd_tests.cpp (line 79)


ditto



src/tests/linux/systemd_tests.cpp (line 87)


no, no! bad... what can you set up to wait on to determine when it's been 
started?



src/tests/linux/systemd_tests.cpp (line 89)


Use path::join()



src/tests/linux/systemd_tests.cpp (line 90)


ditto



src/tests/linux/systemd_tests.cpp (lines 101 - 109)


Use os::read(tmpout) to get a Result and avoid all of this.



src/tests/linux/systemd_tests.cpp (lines 112 - 113)


Use stout's `bool strings::contains()`



src/tests/linux/systemd_tests.cpp (line 116)


ditto

Re: Review Request 50922: Moved the implementation of health check to health_checker.cpp.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50922/
---

(Updated Aug. 9, 2016, 6:13 p.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Gastón 
Kleiman.


Repository: mesos


Description
---

Moved the implementation of health check to health_checker.cpp.


Diffs
-

  src/health-check/health_checker.hpp b28a9cf3c6c9217c0b2453ac6e34d88e1f648d61 
  src/health-check/health_checker.cpp 585a0b565d948cfa292bad818a710501a4ce0daf 

Diff: https://reviews.apache.org/r/50922/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 50921: Fixed the incorrect order of header files in executor.cpp.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50921/#review145233
---


Ship it!




Ship It!

- Alexander Rukletsov


On Aug. 9, 2016, 10:18 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50921/
> ---
> 
> (Updated Aug. 9, 2016, 10:18 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Gastón 
> Kleiman.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed the incorrect order of header files in executor.cpp.
> 
> 
> Diffs
> -
> 
>   src/docker/executor.cpp 445628c9164facdd8bd812c5b45e3b2b886ebf0e 
> 
> Diff: https://reviews.apache.org/r/50921/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 50920: Removed extra spaces in docker.cpp.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50920/#review145232
---


Ship it!




Ship It!

- Alexander Rukletsov


On Aug. 9, 2016, 10:18 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50920/
> ---
> 
> (Updated Aug. 9, 2016, 10:18 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Gastón 
> Kleiman.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed extra spaces in docker.cpp.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.cpp e8d2cb9662af34d75c9e2d822004f58fac76e7e0 
> 
> Diff: https://reviews.apache.org/r/50920/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 50810: Fixed provisioner appc support on windows build.

[Gilbert Song]

> On Aug. 9, 2016, 10:06 a.m., Jie Yu wrote:
> > Second thought. we should just to the following in `__provision`:
> > ```
> > #ifdef WINDOWS
> > return ProvisionInfo{...};
> > #else
> > // the original logic.
> > #endif
> > ```

Agree. Obviously more clear in this way. Will fix it.


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50810/#review145223
---


On Aug. 4, 2016, 10:05 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50810/
> ---
> 
> (Updated Aug. 4, 2016, 10:05 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Jie Yu, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed provisioner appc support on windows build.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 
> 40ee1da5ea453127c1e5e4cdf4b9a49bc998698a 
> 
> Diff: https://reviews.apache.org/r/50810/diff/
> 
> 
> Testing
> ---
> 
> N/A.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 50810: Fixed provisioner appc support on windows build.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50810/#review145223
---



Second thought. we should just to the following in `__provision`:
```
#ifdef WINDOWS
return ProvisionInfo{...};
#else
// the original logic.
#endif
```

- Jie Yu


On Aug. 4, 2016, 5:05 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50810/
> ---
> 
> (Updated Aug. 4, 2016, 5:05 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Jie Yu, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed provisioner appc support on windows build.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 
> 40ee1da5ea453127c1e5e4cdf4b9a49bc998698a 
> 
> Diff: https://reviews.apache.org/r/50810/diff/
> 
> 
> Testing
> ---
> 
> N/A.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 50810: Fixed provisioner appc support on windows build.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50810/#review145221
---


Ship it!




Ship It!

- Jie Yu


On Aug. 4, 2016, 5:05 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50810/
> ---
> 
> (Updated Aug. 4, 2016, 5:05 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Jie Yu, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed provisioner appc support on windows build.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 
> 40ee1da5ea453127c1e5e4cdf4b9a49bc998698a 
> 
> Diff: https://reviews.apache.org/r/50810/diff/
> 
> 
> Testing
> ---
> 
> N/A.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 50871: Supported auto backend in Unified Containerizer.

[Gilbert Song]

> On Aug. 6, 2016, 6:06 a.m., Guangya Liu wrote:
> > src/slave/containerizer/mesos/provisioner/provisioner.cpp, lines 282-283
> > 
> >
> > what about a new line here?

I did it on purpose. But you are right. One more line looks better.

I will fix it. Thanks Guangya.


> On Aug. 6, 2016, 6:06 a.m., Guangya Liu wrote:
> > src/slave/containerizer/mesos/provisioner/provisioner.cpp, lines 286-292
> > 
> >
> > Just a question here: Since now the overlay backend support both single 
> > layer and multiple layer images, do we still need to keep the bind backend? 
> > Seems it can be covered by overly backend?

yeah, overlay cover most of cases. but for some huge one-layer image. bind may 
be the fatest choice.


> On Aug. 6, 2016, 6:06 a.m., Guangya Liu wrote:
> > src/slave/containerizer/mesos/provisioner/provisioner.cpp, lines 295-299
> > 
> >
> > I think we may need a test case to cover select backend smartly?

This really depends on different OS and default kernel medules. It would be 
hard to keep consistent behavior. BTW, we may add aufs later.


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50871/#review145032
---


On Aug. 5, 2016, 4:27 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50871/
> ---
> 
> (Updated Aug. 5, 2016, 4:27 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-5931
> https://issues.apache.org/jira/browse/MESOS-5931
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Supported auto backend in Unified Containerizer.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md d6a7eb02b9f3e0011d52ccfd3093167bb6adccd3 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 
> 6fc56522a72cda41d8af91a054feb7bfb9048531 
>   src/slave/flags.hpp 58fba4a22d988ac6612fc3af8a9346f0b8f8bb51 
>   src/slave/flags.cpp b8ecc98721c52dcd59a0cc1333421d4f024fbe96 
>   src/tests/containerizer/provisioner_appc_tests.cpp 
> b3ba176e506a6d1528290c07a8a0555b12c8cf70 
> 
> Diff: https://reviews.apache.org/r/50871/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> sudo ./bin/mesos-tests.sh
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 50763: Updated Linux 'MountInfoTable' entries to be sorted as expected.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50763/#review145218
---


Ship it!




Ship It!

- Jie Yu


On Aug. 9, 2016, 6:19 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50763/
> ---
> 
> (Updated Aug. 9, 2016, 6:19 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Jie Yu.
> 
> 
> Bugs: MESOS-5969
> https://issues.apache.org/jira/browse/MESOS-5969
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Many places in the codebase assume that the mountinfo table is sorted
> according to the order: 'parent mount point < child mount point'.
> 
> However, in some cases this may not be true if (for example), a parent
> mount point (say '/') is remounted to add some extra flags to it.
> When this happens, the remounted file system will appear in the
> mountinfo table at the point where it was remounted.
> 
> We actually encountered this problem in the wild for the case of '/'
> being remounted after '/run' was mounted -- causing problems in the
> 'NvidiaVolume' which assumes the 'parent < child' ordering.
> 
> This commit fixes this problem by building the list of MountInfoTable
> entries in sorted order when 'read()' is called. An optional flag can
> be used to disable sorting produce the the original ordering.
> 
> 
> Diffs
> -
> 
>   src/linux/fs.hpp ec3b5b8cd6926b1f69ad499de1c13b989766a84e 
>   src/linux/fs.cpp f57db80ad0d7235d47910e05d663c77e233f8228 
>   src/tests/containerizer/fs_tests.cpp 
> 4cfafad28daac6bed849992a254660117d7ff30b 
> 
> Diff: https://reviews.apache.org/r/50763/diff/
> 
> 
> Testing
> ---
> 
> GTEST_FILTER="" make -j check
> src/mesos-tests
> sudo src/mesos-tests
> 
> Appeared to have one unrelated flaky test fail: 
> `ResourceOffersTest.ResourcesGetReofferedAfterTaskInfoError`
> Rerunning the tests a second time passed.
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 50923: Updated the links of Homebrew in release-guide.md.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50923/#review145217
---


Ship it!




Ship It!

- Vinod Kone


On Aug. 9, 2016, 9:25 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50923/
> ---
> 
> (Updated Aug. 9, 2016, 9:25 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the links of Homebrew in release-guide.md.
> 
> 
> Diffs
> -
> 
>   docs/release-guide.md 7139315a30e32e235227814cc75f75bda25fad29 
> 
> Diff: https://reviews.apache.org/r/50923/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 50922: Moved the implementation of health check to health_checker.cpp.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50922/#review145214
---



Patch looks great!

Reviews applied: [50920, 50921, 50922]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Aug. 9, 2016, 10:18 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50922/
> ---
> 
> (Updated Aug. 9, 2016, 10:18 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Gastón 
> Kleiman.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moved the implementation of health check to health_checker.cpp.
> 
> 
> Diffs
> -
> 
>   src/health-check/health_checker.hpp 
> b28a9cf3c6c9217c0b2453ac6e34d88e1f648d61 
>   src/health-check/health_checker.cpp 
> 585a0b565d948cfa292bad818a710501a4ce0daf 
> 
> Diff: https://reviews.apache.org/r/50922/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 50266: Introduced linux capabilities API.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50266/
---

(Updated Aug. 9, 2016, 2:30 p.m.)


Review request for mesos and Jie Yu.


Changes
---

Another round of review comments addressed, more to come.


Bugs: MESOS-5051
https://issues.apache.org/jira/browse/MESOS-5051


Repository: mesos


Description
---

This change introduces basic API for linux capabilities. This is not a
comprehensive API but is strictly limited to the need for securing Mesos
containers using linux capabilities.

This patch is based on the work in https://reviews.apache.org/r/46370/.


Diffs (updated)
-

  src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 
  src/Makefile.am 1a9b083493612cf610b80ac5a1c11c29d6302933 
  src/linux/capabilities.hpp PRE-CREATION 
  src/linux/capabilities.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/50266/diff/


Testing
---

`make check` and `sudo make check` (Debian jessie, gcc-4.9.2, w/o optimizations)


Thanks,

Benjamin Bannier

Re: Review Request 50889: Introduce parsing and stringification of `CapabilityInfo`s.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50889/
---

(Updated Aug. 9, 2016, 2:30 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-50501
https://issues.apache.org/jira/browse/MESOS-50501


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  include/mesos/type_utils.hpp d0d23566f6262d8c4073c7870cb5546d39017e68 
  src/common/parse.hpp 5dc795d7f54209abe64ad48360f538faac7616f0 
  src/common/type_utils.cpp 7110d87ba8078a5cc00669c82f8cd36f103c14b3 

Diff: https://reviews.apache.org/r/50889/diff/


Testing
---

`make check` (OS X, clang/trunk, not optimized)


Thanks,

Benjamin Bannier

Re: Review Request 50269: Added basic tests for capabilities API.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50269/
---

(Updated Aug. 9, 2016, 2:30 p.m.)


Review request for mesos and Jie Yu.


Changes
---

Rebased.


Bugs: MESOS-5228
https://issues.apache.org/jira/browse/MESOS-5228


Repository: mesos


Description
---

This test is based on the work in https://reviews.apache.org/r/46371/.


Diffs (updated)
-

  src/Makefile.am 1a9b083493612cf610b80ac5a1c11c29d6302933 
  src/tests/capabilities_test_helper.hpp PRE-CREATION 
  src/tests/capabilities_test_helper.cpp PRE-CREATION 
  src/tests/capabilities_test_helper_main.cpp PRE-CREATION 
  src/tests/capabilities_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/50269/diff/


Testing
---

`make check` and `sudo make check` (Debian jessie, gcc-4.9.2, w/o optimizations)


Thanks,

Benjamin Bannier

Re: Review Request 50923: Updated the links of Homebrew in release-guide.md.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50923/#review145199
---



Patch looks great!

Reviews applied: [50923]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Aug. 9, 2016, 9:25 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50923/
> ---
> 
> (Updated Aug. 9, 2016, 9:25 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the links of Homebrew in release-guide.md.
> 
> 
> Diffs
> -
> 
>   docs/release-guide.md 7139315a30e32e235227814cc75f75bda25fad29 
> 
> Diff: https://reviews.apache.org/r/50923/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 50921: Fixed the incorrect order of header files in executor.cpp.

[Gastón Kleiman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50921/#review145196
---


Ship it!




Ship It!

- Gastón Kleiman


On Aug. 9, 2016, 10:18 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50921/
> ---
> 
> (Updated Aug. 9, 2016, 10:18 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Gastón 
> Kleiman.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed the incorrect order of header files in executor.cpp.
> 
> 
> Diffs
> -
> 
>   src/docker/executor.cpp 445628c9164facdd8bd812c5b45e3b2b886ebf0e 
> 
> Diff: https://reviews.apache.org/r/50921/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 50897: Added compiler information to the output of ./configure.

[Gastón Kleiman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50897/#review145195
---



While working on https://reviews.apache.org/r/50853/, I thought that it wasn't 
easy to get the C++ compiler vendor/version info from the output of the build 
process, but I clearly missed the following lines:

```
checking for C++ compiler vendor... clang
checking for a sed that does not truncate output... /usr/bin/sed
checking for C++ compiler version... 7.0.2
checking for C++ compiler vendor... (cached) clang
```

Which is why I'm discarding this RR. Sorry for the inconvenience!

- Gastón Kleiman


On Aug. 8, 2016, 3:57 p.m., Gastón Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50897/
> ---
> 
> (Updated Aug. 8, 2016, 3:57 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Kapil Arya, 
> and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> With this change, the output of `./configure` contains a message like:
> `configure: Using Clang 7.0.2`.
> 
> 
> Diffs
> -
> 
>   configure.ac f82c6314d65a8ea3eb118bab8e110063cae46121 
> 
> Diff: https://reviews.apache.org/r/50897/diff/
> 
> 
> Testing
> ---
> 
> Tested with:
> 
> `GCC 4.8.1, 4.8.4, 4.8.5, 4.9.2, 5.3.1`
> `Clang 7.0.2`
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>

Re: Review Request 50920: Removed extra spaces in docker.cpp.

[Gastón Kleiman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50920/#review145194
---


Ship it!




Ship It!

- Gastón Kleiman


On Aug. 9, 2016, 10:18 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50920/
> ---
> 
> (Updated Aug. 9, 2016, 10:18 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Gastón 
> Kleiman.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed extra spaces in docker.cpp.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.cpp e8d2cb9662af34d75c9e2d822004f58fac76e7e0 
> 
> Diff: https://reviews.apache.org/r/50920/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 50922: Moved the implementation of health check to health_checker.cpp.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50922/
---

(Updated Aug. 9, 2016, 10:18 a.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Gastón 
Kleiman.


Changes
---

Rebase.


Repository: mesos


Description
---

Moved the implementation of health check to health_checker.cpp.


Diffs (updated)
-

  src/health-check/health_checker.hpp b28a9cf3c6c9217c0b2453ac6e34d88e1f648d61 
  src/health-check/health_checker.cpp 585a0b565d948cfa292bad818a710501a4ce0daf 

Diff: https://reviews.apache.org/r/50922/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 50920: Removed extra spaces in docker.cpp.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50920/
---

(Updated Aug. 9, 2016, 10:18 a.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Gastón 
Kleiman.


Changes
---

Rebase.


Repository: mesos


Description
---

Removed extra spaces in docker.cpp.


Diffs (updated)
-

  src/docker/docker.cpp e8d2cb9662af34d75c9e2d822004f58fac76e7e0 

Diff: https://reviews.apache.org/r/50920/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 50921: Fixed the incorrect order of header files in executor.cpp.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50921/
---

(Updated Aug. 9, 2016, 10:18 a.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Gastón 
Kleiman.


Changes
---

Rebase.


Repository: mesos


Description
---

Fixed the incorrect order of header files in executor.cpp.


Diffs (updated)
-

  src/docker/executor.cpp 445628c9164facdd8bd812c5b45e3b2b886ebf0e 

Diff: https://reviews.apache.org/r/50921/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 50900: Removed unneeded extra space in libprocess code base.

[Tomasz Janiszewski]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50900/#review145191
---


Ship it!




Ship It!

- Tomasz Janiszewski


On Aug. 8, 2016, 4:19 p.m., Gaojin CAO wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50900/
> ---
> 
> (Updated Aug. 8, 2016, 4:19 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Guangya Liu, and haosdent huang.
> 
> 
> Bugs: MESOS-5830
> https://issues.apache.org/jira/browse/MESOS-5830
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch is part of MESOS-5830, specially working on cleaning up
> unneeded space in project libprocess.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/async.hpp 
> e7d846288791221f4dfa03d7de89d9bde177f1ca 
>   3rdparty/libprocess/include/process/protobuf.hpp 
> 695c6e6572852d2c4afbaacc6b63771ed035fd65 
>   3rdparty/libprocess/include/process/reap.hpp 
> 1a9709c618c5ddc9d2b7492cc1855a11f1fc4fb9 
>   3rdparty/libprocess/include/process/sequence.hpp 
> c9a46f28b770023ca621696493521445762a3fd1 
>   3rdparty/libprocess/include/process/statistics.hpp 
> 13aa464329c2cc77b017868a1dcbf5b77c53635d 
>   3rdparty/libprocess/src/reap.cpp f8d2fdc3449744cfd6a974170484b676e8f3ac7b 
>   3rdparty/libprocess/src/tests/benchmarks.cpp 
> 9fac45e21bd03ccea19d0ef7d8bb2efc408e60b5 
>   3rdparty/libprocess/src/tests/http_tests.cpp 
> 8a0d61eb57f9ae972eedf3481f131844b283abc5 
>   3rdparty/libprocess/src/tests/metrics_tests.cpp 
> 4ddd35b61f222ca674e41875a6d0ee43d12cbfbd 
>   3rdparty/libprocess/src/tests/reap_tests.cpp 
> 0cbe9f139d59ac154695d84638c551fbe098cb10 
>   3rdparty/libprocess/src/tests/shared_tests.cpp 
> 8f94cca107ebe1fdefc19fb1f65e4c205f96 
>   3rdparty/libprocess/src/tests/statistics_tests.cpp 
> db9817ff182f37b7a04358fb59b8b800b16a7e1e 
> 
> Diff: https://reviews.apache.org/r/50900/diff/
> 
> 
> Testing
> ---
> 
> Pass `make` and `make tests`.
> 
> 
> Thanks,
> 
> Gaojin CAO
> 
>

Re: Review Request 50899: Removed unneeded extra space in stout code base.

[Tomasz Janiszewski]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50899/#review145190
---


Ship it!




Ship It!

- Tomasz Janiszewski


On Aug. 8, 2016, 4:17 p.m., Gaojin CAO wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50899/
> ---
> 
> (Updated Aug. 8, 2016, 4:17 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Guangya Liu, and haosdent huang.
> 
> 
> Bugs: MESOS-5830
> https://issues.apache.org/jira/browse/MESOS-5830
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch is part of MESOS-5830, specially working on cleaning up
> unneeded space in project stout.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/flags.hpp 
> 169f959ab2770744d615cc235062ba2becc8af64 
>   3rdparty/stout/include/stout/interval.hpp 
> e6deeac39855488548678c59ed4c69646fc02602 
>   3rdparty/stout/include/stout/json.hpp 
> 51b1ada87846d4d25cbc8a6bbb97ba91e02a9cab 
>   3rdparty/stout/include/stout/linkedhashmap.hpp 
> 6e06260bcce2dbe0f9134f3d0fd7a2b47b0d3286 
>   3rdparty/stout/include/stout/os/osx.hpp 
> ca77bb0bbda0cee07d85435350dc4ccc176d4013 
>   3rdparty/stout/include/stout/os/sunos.hpp 
> ec8e1f7562d5747113631351e6d8ff8989cf0fed 
>   3rdparty/stout/include/stout/os/sysctl.hpp 
> 6db7bf6f139770ce978d171f451e932072cdaf5f 
>   3rdparty/stout/include/stout/proc.hpp 
> b543432c1a8419093c508c1d0e72b9757df04463 
>   3rdparty/stout/include/stout/protobuf.hpp 
> 91305e104c01d649bd435a27b15954036c27 
>   3rdparty/stout/include/stout/strings.hpp 
> 7f7f1cffcebfe16cb986917b1d90c1ae4a480989 
>   3rdparty/stout/tests/flags_tests.cpp 
> 77f3a6af110da1ffcdf2b7ab2b66431a6b5c91d3 
>   3rdparty/stout/tests/ip_tests.cpp 4d1f1c9a4dd35da2a21bef1349a662af44bb4ba1 
>   3rdparty/stout/tests/mac_tests.cpp 1ff60cf5506c1855547400aa20107ec5086d8431 
>   3rdparty/stout/tests/multimap_tests.cpp 
> 2f606eb16fbaa3c755e597a05e97cd30d3bfd9f4 
>   3rdparty/stout/tests/option_tests.cpp 
> 36abe137bdae1e6aaf65f39bf302d9e7a76fefdd 
>   3rdparty/stout/tests/os/process_tests.cpp 
> b536e664d22370e30c49a8f953189e92a1358709 
>   3rdparty/stout/tests/os_tests.cpp e67444077eae55fd25945b451164b5bcc37552b0 
>   3rdparty/stout/tests/proc_tests.cpp 
> 17b909368405d9ddb7e7127e89d0422a9a2baa11 
>   3rdparty/stout/tests/strings_tests.cpp 
> b54a9dbf162403310b8bba687442e184a473f5a6 
> 
> Diff: https://reviews.apache.org/r/50899/diff/
> 
> 
> Testing
> ---
> 
> Pass `make` and `make tests`.
> 
> 
> Thanks,
> 
> Gaojin CAO
> 
>

Re: Review Request 50887: Trimmed unneeded extra space between right angle brackets.

[Tomasz Janiszewski]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50887/#review145189
---


Ship it!




Ship It!

- Tomasz Janiszewski


On Aug. 8, 2016, 4:13 p.m., Gaojin CAO wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50887/
> ---
> 
> (Updated Aug. 8, 2016, 4:13 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Guangya Liu, and haosdent huang.
> 
> 
> Bugs: MESOS-5830
> https://issues.apache.org/jira/browse/MESOS-5830
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Mesos codebase has been evolved and no more need an extra space
> between two right angle brackets, e.g. vector, to
> work around C++98 parsing deficiencies(see MESOS-5830).
> 
> 
> Diffs
> -
> 
>   include/mesos/log/log.hpp 0f69848bd72372e7a58f6e3789e86bf826eaeab7 
>   include/mesos/zookeeper/contender.hpp 
> 0ef9d56c15c4c5dd1d36f2866324ac95d55901d1 
>   include/mesos/zookeeper/detector.hpp 
> a953997b98e1242bea10efc791e2f31fa3252593 
>   src/authentication/cram_md5/auxprop.cpp 
> 85403417c8169c0796ffa16484aa85da2d5220ba 
>   src/cli/mesos.cpp 81e2325c1978d56487479848966115ffd14b7cb0 
>   src/cli/resolve.cpp ac6be05e64c5e66703081068d992ebb0d6ca6c70 
>   src/files/files.cpp 793d68ec700c792fc9dd73b09ee2616108b88f4f 
>   src/java/jni/org_apache_mesos_Log.cpp 
> 04f8afd99b4383e7941a93bfd565806a9988c870 
>   src/java/jni/org_apache_mesos_state_AbstractState.cpp 
> 3101352e42e8505a93d8760ad657d9fe35761080 
>   src/launcher/executor.cpp 9333dc0832cd04305e307ce750195c0fbc860ab2 
>   src/linux/ns.hpp e905aefe5ab178c8471cfe801e6432540d3dea67 
>   src/log/consensus.cpp 27f2c58c4c54cc3fe5b92873261096b6011ff15d 
>   src/log/coordinator.hpp 9fa4f1988c531a9765c9522a017b39fafb0a9cea 
>   src/log/coordinator.cpp ecf457ff266f447938ee6d2872a8ef3b6d50517e 
>   src/log/log.cpp 0940f9288509409c1d593c27da48cfa2a50545c9 
>   src/log/main.cpp 171c312562442836a2cf8f61f0a83615c18d0971 
>   src/log/network.hpp 8750880e6cecb6edf4efab4f2b9afe3d8a4d5964 
>   src/log/recover.hpp 97793b6e1a26f92b4ae20b82e7da18d063776ce6 
>   src/log/recover.cpp eaf3fd334f7b66f9ba05f3856ee885bab9af62f6 
>   src/log/tool/benchmark.cpp da35b08b5448c965cedd3d9349d06b4a99fabfce 
>   src/master/registrar.cpp 4d1eaa04fcc7f3330bf3abab8533428848691f2c 
>   src/slave/gc.hpp 9a09e7b3585217754a26597b77ea51e706ecb933 
>   src/slave/gc.cpp a0af68b8d713a31bea533b24637861e81ca167e3 
>   src/slave/state.cpp 91dee118d1e6866fb2b968765cfe7c6f1b5a3325 
>   src/slave/status_update_manager.cpp 
> 9c67b8526915cb529b5c5afd5b5e4a451bf94d61 
>   src/tests/allocator.hpp c4d835afe180bcc2404cc3772af5f7c4885771bb 
>   src/tests/containerizer.hpp ded331bc60078196abf9e1d338c23b9b962a3ad2 
>   src/tests/containerizer.cpp 105ca9c0416b16fd26d396a4fdef7fbc8a43b8a4 
>   src/tests/containerizer/composing_containerizer_tests.cpp 
> e7e3b622b6606a812aef046c761bf92368d34af2 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 4e5b1fd1628504d346cced545f7911d6b6443773 
>   src/tests/containerizer/docker_tests.cpp 
> 7b73a4939da33d0b7dd08fdcf56525b6403eada3 
>   src/tests/containerizer/external_containerizer_test.cpp 
> 226eac56725e908040abda306a2e5e3c96bce9d7 
>   src/tests/containerizer/isolator_tests.cpp 
> 827c9f06b97191a5b74bb8fa2ef716c4282e7518 
>   src/tests/containerizer/launcher.hpp 
> 49f8ecb47abb098bf76017f79b7d00380401efe4 
>   src/tests/containerizer/port_mapping_tests.cpp 
> 94d6d7589a4d9accff6f43ad6abbf05bf3be7ee5 
>   src/tests/disk_quota_tests.cpp f379a6e351fbcf8b41d7db6ed62865ce55b0060e 
>   src/tests/environment.cpp 6960c2a0165c4bb34851a0412c6b22b7da645540 
>   src/tests/exception_tests.cpp a9b1c23d3e8460c5c67c8f399346f85f2ac8addf 
>   src/tests/health_check_tests.cpp 47c35d15a259d470f21f81303879077787c125e7 
>   src/tests/master_allocator_tests.cpp 
> 32e3a4638273fa1c792c3c9425e0b2ff8f6bed03 
>   src/tests/master_authorization_tests.cpp 
> 16f1ab46a92137de01313a29dac2b18f18f5e816 
>   src/tests/master_contender_detector_tests.cpp 
> 2970986830d0cfaedbf17f3b002c40ac5c28bd2a 
>   src/tests/master_slave_reconciliation_tests.cpp 
> 03405e33d3f1cccbd5298810f5cd818c1dac8593 
>   src/tests/mesos.hpp 9174a3810d0da34b99dc257e9c77f83107fdd9f5 
>   src/tests/reconciliation_tests.cpp 492560c430eba45e3a9f7a767ee761dfa0cacb05 
>   src/tests/registrar_tests.cpp ba7c66ff83f09d68fb5324a3f85d2875068a35a6 
>   src/tests/registrar_zookeeper_tests.cpp 
> 98a5e312a8b2701dc8dc9b6593178bb52cd5e13c 
>   src/tests/slave_recovery_tests.cpp af442cac40fb7b34e362dbfb2d864e7c8a010087 
>   src/tests/state_tests.cpp 4ba42673eedfb4ab5633e2250a79bdde667eff95 
>   src/tests/status_update_manager_tests.cpp 
> f5313a124c59eba3da86a173817d0c2a6a943e17 
>   src/tests/zookeeper.cpp 

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

[Yubo Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50841/
---

(Updated 八月 9, 2016, 9:25 a.m.)


Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat 
Phull.


Changes
---

Changed to use sub-thread to work with GPU allocation and not block main thread


Bugs: MESOS-5795
https://issues.apache.org/jira/browse/MESOS-5795


Repository: mesos


Description
---

Added control logic to allocate/deallocate GPUs to GPU-related task
when the task is started/terminated.


Diffs (updated)
-

  src/slave/containerizer/docker.hpp 43ca4317d608b3b43dd7bd0d1b55c721e7364885 
  src/slave/containerizer/docker.cpp 12bad2db03bcf755317c654f028b628c5c407a62 

Diff: https://reviews.apache.org/r/50841/diff/


Testing
---

make check


Thanks,

Yubo Li

Review Request 50923: Updated the links of Homebrew in release-guide.md.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50923/
---

Review request for mesos and Vinod Kone.


Repository: mesos


Description
---

Updated the links of Homebrew in release-guide.md.


Diffs
-

  docs/release-guide.md 7139315a30e32e235227814cc75f75bda25fad29 

Diff: https://reviews.apache.org/r/50923/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 50922: Moved the implementation of health check to health_checker.cpp.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50922/
---

(Updated Aug. 9, 2016, 9:17 a.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Gastón 
Kleiman.


Changes
---

Fix compile error.


Repository: mesos


Description
---

Moved the implementation of health check to health_checker.cpp.


Diffs (updated)
-

  src/health-check/health_checker.hpp b28a9cf3c6c9217c0b2453ac6e34d88e1f648d61 
  src/health-check/health_checker.cpp 585a0b565d948cfa292bad818a710501a4ce0daf 

Diff: https://reviews.apache.org/r/50922/diff/


Testing
---


Thanks,

haosdent huang

Review Request 50922: Moved the implementation of health check to health_checker.cpp.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50922/
---

Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Gastón 
Kleiman.


Repository: mesos


Description
---

Moved the implementation of health check to health_checker.cpp.


Diffs
-

  src/health-check/health_checker.hpp b28a9cf3c6c9217c0b2453ac6e34d88e1f648d61 
  src/health-check/health_checker.cpp 585a0b565d948cfa292bad818a710501a4ce0daf 

Diff: https://reviews.apache.org/r/50922/diff/


Testing
---


Thanks,

haosdent huang

Review Request 50921: Fixed the incorrect order of header files in executor.cpp.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50921/
---

Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Gastón 
Kleiman.


Repository: mesos


Description
---

Fixed the incorrect order of header files in executor.cpp.


Diffs
-

  src/docker/executor.cpp 445628c9164facdd8bd812c5b45e3b2b886ebf0e 

Diff: https://reviews.apache.org/r/50921/diff/


Testing
---


Thanks,

haosdent huang

Review Request 50920: Removed extra spaces in docker.cpp.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50920/
---

Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Gastón 
Kleiman.


Repository: mesos


Description
---

Removed extra spaces in docker.cpp.


Diffs
-

  src/docker/docker.cpp e8d2cb9662af34d75c9e2d822004f58fac76e7e0 

Diff: https://reviews.apache.org/r/50920/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 50763: Updated Linux 'MountInfoTable' entries to be sorted as expected.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50763/#review145179
---



Patch looks great!

Reviews applied: [50762, 50763]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Aug. 9, 2016, 6:19 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50763/
> ---
> 
> (Updated Aug. 9, 2016, 6:19 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Jie Yu.
> 
> 
> Bugs: MESOS-5969
> https://issues.apache.org/jira/browse/MESOS-5969
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Many places in the codebase assume that the mountinfo table is sorted
> according to the order: 'parent mount point < child mount point'.
> 
> However, in some cases this may not be true if (for example), a parent
> mount point (say '/') is remounted to add some extra flags to it.
> When this happens, the remounted file system will appear in the
> mountinfo table at the point where it was remounted.
> 
> We actually encountered this problem in the wild for the case of '/'
> being remounted after '/run' was mounted -- causing problems in the
> 'NvidiaVolume' which assumes the 'parent < child' ordering.
> 
> This commit fixes this problem by building the list of MountInfoTable
> entries in sorted order when 'read()' is called. An optional flag can
> be used to disable sorting produce the the original ordering.
> 
> 
> Diffs
> -
> 
>   src/linux/fs.hpp ec3b5b8cd6926b1f69ad499de1c13b989766a84e 
>   src/linux/fs.cpp f57db80ad0d7235d47910e05d663c77e233f8228 
>   src/tests/containerizer/fs_tests.cpp 
> 4cfafad28daac6bed849992a254660117d7ff30b 
> 
> Diff: https://reviews.apache.org/r/50763/diff/
> 
> 
> Testing
> ---
> 
> GTEST_FILTER="" make -j check
> src/mesos-tests
> sudo src/mesos-tests
> 
> Appeared to have one unrelated flaky test fail: 
> `ResourceOffersTest.ResourcesGetReofferedAfterTaskInfoError`
> Rerunning the tests a second time passed.
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 50763: Updated Linux 'MountInfoTable' entries to be sorted as expected.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50763/
---

(Updated Aug. 9, 2016, 6:19 a.m.)


Review request for mesos, Benjamin Mahler and Jie Yu.


Changes
---

Added check to make sure that the `MountInfoTable` we are trying to sort 
hierarchically doesn't have any cycles in it.


Bugs: MESOS-5969
https://issues.apache.org/jira/browse/MESOS-5969


Repository: mesos


Description
---

Many places in the codebase assume that the mountinfo table is sorted
according to the order: 'parent mount point < child mount point'.

However, in some cases this may not be true if (for example), a parent
mount point (say '/') is remounted to add some extra flags to it.
When this happens, the remounted file system will appear in the
mountinfo table at the point where it was remounted.

We actually encountered this problem in the wild for the case of '/'
being remounted after '/run' was mounted -- causing problems in the
'NvidiaVolume' which assumes the 'parent < child' ordering.

This commit fixes this problem by building the list of MountInfoTable
entries in sorted order when 'read()' is called. An optional flag can
be used to disable sorting produce the the original ordering.


Diffs (updated)
-

  src/linux/fs.hpp ec3b5b8cd6926b1f69ad499de1c13b989766a84e 
  src/linux/fs.cpp f57db80ad0d7235d47910e05d663c77e233f8228 
  src/tests/containerizer/fs_tests.cpp 4cfafad28daac6bed849992a254660117d7ff30b 

Diff: https://reviews.apache.org/r/50763/diff/


Testing
---

GTEST_FILTER="" make -j check
src/mesos-tests
sudo src/mesos-tests

Appeared to have one unrelated flaky test fail: 
`ResourceOffersTest.ResourcesGetReofferedAfterTaskInfoError`
Rerunning the tests a second time passed.


Thanks,

Kevin Klues