Re: Review Request 52972: Replaced POSIX `int` with `int_fd` abstraction in `stout` folder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52972/ --- (Updated Nov. 30, 2016, 7:55 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 52544: Introduced `int_fd` class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52544/ --- (Updated Nov. 30, 2016, 7:54 a.m.) Review request for mesos, Alex Naparu, Alex

Re: Review Request 53706: Implemented `os::user' on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53706/ --- (Updated Nov. 30, 2016, 7:54 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 52544: Introduced `int_fd` class.

> On Nov. 19, 2016, 3:28 a.m., Michael Park wrote: > > 3rdparty/stout/include/stout/os/windows/filedescriptor.hpp, lines 381-384 > > > > > > Do we actually need this? I think the `int` on the rhs should implicit >

Re: Review Request 54192: Made IOSwitchboard an isolator.

> On Nov. 30, 2016, 3:36 a.m., Kevin Klues wrote: > > include/mesos/slave/container_logger.hpp, lines 121-123 > > > > > > I haven't usually seen member variables ending in `_` like this. Is > > this a standard

Re: Review Request 53690: Add namespaces/ipc documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53690/#review157369 --- Bad patch! Reviews applied: [53690, 53689, 53688, 53628, 53627,

Review Request 54196: Added API handler for LAUNCH_NESTED_CONTAINER_SESSION.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54196/ --- Review request for mesos and Anand Mazumdar. Bugs: MESOS-6471

Review Request 54194: Added `devolve` helper for `ContainerID`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54194/ --- Review request for mesos and Anand Mazumdar. Bugs: MESOS-6471

Review Request 54193: Refactored `Slave::Http::launcNestedContainer()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54193/ --- Review request for mesos and Anand Mazumdar. Bugs: MESOS-6471

Re: Review Request 54174: Removed superseded `slavePreLaunchDockerHook` hook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54174/#review157364 --- Bad patch! Reviews applied: [54174, 54165, 54129, 54128, 54068,

Re: Review Request 53974: Added support to handle ATTACH_CONTAINER_OUPUT in the io switchbaord.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53974/ --- (Updated Nov. 30, 2016, 3:51 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 54148: Updated the io switchboard to launch an external io switchboard server.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54148/ --- (Updated Nov. 30, 2016, 3:48 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 54147: Added a server side component for the IOSwitchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54147/ --- (Updated Nov. 30, 2016, 3:46 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 54192: Made IOSwitchboard an isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54192/#review157361 --- Fix it, then Ship it! Looks good overall. I'd probably add

Re: Review Request 53460: Refactored network::Address into inet::Address.

> On Nov. 20, 2016, 11:31 p.m., James Peach wrote: > > 3rdparty/libprocess/include/process/address.hpp, line 241 > > > > > > My usual pattern for dealing with socket addresses is to use a union, > > which avoids

Review Request 54192: Made IOSwitchboard an isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54192/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-6651

Review Request 54183: Improved management of unreachable and completed tasks in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54183/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6619

Review Request 54182: Improved various comments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54182/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Review Request 54181: Synchronized v1 and unversioned master.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54181/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Review Request 54179: Updated master to use BoundedHashMap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54179/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6619

Review Request 54180: Updated agent to use BoundedHashMap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54180/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6619

Re: Review Request 54112: Added support for http::connect to take an network::Address.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54112/#review157342 --- Patch looks great! Reviews applied: [53457, 53458, 53459, 53460,

Review Request 54178: Added a fixed-capacity hashmap to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54178/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6619

Review Request 54177: Slightly simplified two test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54177/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6619

Re: Review Request 53460: Refactored network::Address into inet::Address.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53460/#review157341 --- A small followup commit: ``` commit

Re: Review Request 53938: Added helper to get the io switchboard server address.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53938/#review157339 --- Ship it! I rebased it for you as BenH removed the

Re: Review Request 53626: Add net::setDomainname() helper API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53626/ --- (Updated Nov. 29, 2016, 9:19 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 53628: Document the namespaces/uts isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53628/ --- (Updated Nov. 29, 2016, 9:19 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 53690: Add namespaces/ipc documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53690/ --- (Updated Nov. 29, 2016, 9:19 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 53688: Implement a namespace/ipc isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53688/ --- (Updated Nov. 29, 2016, 9:19 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 53627: Implement a namespaces/uts isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53627/ --- (Updated Nov. 29, 2016, 9:19 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 54174: Removed superseded `slavePreLaunchDockerHook` hook.

> On Nov. 29, 2016, 8:37 p.m., Kapil Arya wrote: > > src/examples/test_hook_module.cpp, line 228 > > > > > > Do we have a test where we are testing for the presence of `foo`?

Re: Review Request 54148: Updated the io switchboard to launch an external io switchboard server.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54148/ --- (Updated Nov. 29, 2016, 8:38 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 54147: Added a server side component for the IOSwitchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54147/ --- (Updated Nov. 29, 2016, 8:37 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 54129: Removed superseded `slavePreLaunchDockerEnvironmentDecorator` hook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54129/#review157324 --- Ship it! Ship It! - Kapil Arya On Nov. 29, 2016, 2:54 p.m.,

Re: Review Request 54174: Removed superseded `slavePreLaunchDockerHook` hook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54174/#review157322 --- Fix it, then Ship it! Ship It!

Re: Review Request 54165: Fixed conflict in hook result handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54165/#review157323 --- Ship it! Ship It! - Kapil Arya On Nov. 29, 2016, 11:37

Re: Review Request 54128: Added test for `slavePreLaunchDockerTaskExecutorDecorator` hook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54128/#review157287 --- Ship it! - Kapil Arya On Nov. 29, 2016, 11:38 a.m., Till

Re: Review Request 54114: Updated http::Connection::disconnect to do a complete socket shutdown.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54114/ --- (Updated Nov. 29, 2016, 8:24 p.m.) Review request for mesos and Benjamin

Re: Review Request 54113: Added support for specifying how a socket should be shutdown.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54113/ --- (Updated Nov. 29, 2016, 8:24 p.m.) Review request for mesos and Benjamin

Re: Review Request 54112: Added support for http::connect to take an network::Address.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54112/ --- (Updated Nov. 29, 2016, 8:23 p.m.) Review request for mesos and Benjamin

Re: Review Request 54111: Removed unused Socket from Encoder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54111/ --- (Updated Nov. 29, 2016, 8:23 p.m.) Review request for mesos and Benjamin

Re: Review Request 54109: Changes in Mesos to make http::Request::client optional.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54109/ --- (Updated Nov. 29, 2016, 8:23 p.m.) Review request for mesos and Benjamin

Re: Review Request 54108: Changes in libprocess to make http::Request::client optional.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54108/ --- (Updated Nov. 29, 2016, 8:23 p.m.) Review request for mesos and Benjamin

Re: Review Request 53462: Updated usage of network::Address and network::Socket in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53462/ --- (Updated Nov. 29, 2016, 8:22 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 53461: Inlined function only used one place.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53461/ --- (Updated Nov. 29, 2016, 8:22 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 53459: Refactored `Socket` to support a templated version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53459/ --- (Updated Nov. 29, 2016, 8:22 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 54173: Refactor necessary after removing default Address constructor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54173/ --- (Updated Nov. 29, 2016, 8:22 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 53460: Refactored network::Address into inet::Address.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53460/ --- (Updated Nov. 29, 2016, 8:22 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 53457: Updated Socket::Impl::accept to return std::shared_ptr.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53457/ --- (Updated Nov. 29, 2016, 8:21 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 53458: Removed `Socket` dependency on `Socket::Impl`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53458/ --- (Updated Nov. 29, 2016, 8:21 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 54110: Added `process::loop` abstraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54110/#review157318 --- 3rdparty/libprocess/include/process/loop.hpp (lines 126 - 127)

Re: Review Request 54113: Added support for specifying how a socket should be shutdown.

> On Nov. 28, 2016, 6:25 p.m., Greg Mann wrote: > > 3rdparty/libprocess/include/process/socket.hpp, lines 394-396 > > > > > > BenM pointed out on my similar review that we need to alter our Windows > > headers to

Re: Review Request 53460: Refactored network::Address into inet::Address.

> On Nov. 28, 2016, 10:08 p.m., Jie Yu wrote: > > 3rdparty/libprocess/include/process/socket.hpp, line 433 > > > > > > inline is not necessary for template specification? Let's be consistent > > here (either use

Re: Review Request 53460: Refactored network::Address into inet::Address.

> On Nov. 20, 2016, 11:31 p.m., James Peach wrote: > > 3rdparty/libprocess/include/process/address.hpp, line 129 > > > > > > Suggest that this should be `explicit`. There's some risk that strings > > like

Re: Review Request 53627: Implement a namespaces/uts isolator.

> On Nov. 29, 2016, 6:48 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/namespaces/uts.cpp, lines 70-79 > > > > > > Wouldn't this conflict with what we are doing in the `network/cni` > >

Re: Review Request 54101: Removed MesosContainerizerLaunchTest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54101/#review157314 --- ``` commit a85e284013a10e0ca036ab16128530c8cfd17087 Author:

Re: Review Request 54173: Refactor necessary after removing default Address constructor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54173/#review157312 --- Ship it! Ship It! - Jie Yu On Nov. 29, 2016, 7:27 p.m.,

Re: Review Request 54129: Removed superseded `slavePreLaunchDockerEnvironmentDecorator` hook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54129/ --- (Updated Nov. 29, 2016, 7:54 p.m.) Review request for mesos, Adam B and Kapil

Re: Review Request 54174: Removed superseded `slavePreLaunchDockerHook` hook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54174/ --- (Updated Nov. 29, 2016, 7:54 p.m.) Review request for mesos, Adam B, Benjamin

Review Request 54174: Removed superseded `slavePreLaunchDockerHook` hook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54174/ --- Review request for mesos, Adam B, Benjamin Bannier, Gastón Kleiman, and Kapil

Re: Review Request 54129: Removed superseded `slavePreLaunchDockerEnvironmentDecorator` hook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54129/ --- (Updated Nov. 29, 2016, 7:52 p.m.) Review request for mesos, Adam B and Kapil

Re: Review Request 54110: Added `process::loop` abstraction.

> On Nov. 28, 2016, 6:47 p.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/include/process/loop.hpp, line 137 > > > > > > Future condition = true; > > > > while (condition.get()) { > > Future next

Re: Review Request 53627: Implement a namespaces/uts isolator.

> On Nov. 29, 2016, 7:02 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/launch.cpp, line 431 > > > > > > Wouldn't we need to set up something in `/etc/hosts`. I believe DNS > > lookups on the

Re: Review Request 53627: Implement a namespaces/uts isolator.

> On Nov. 29, 2016, 7:02 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/launch.cpp, line 431 > > > > > > Wouldn't we need to set up something in `/etc/hosts`. I believe DNS > > lookups on the

Re: Review Request 53627: Implement a namespaces/uts isolator.

> On Nov. 29, 2016, 7:02 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/launch.cpp, line 431 > > > > > > Wouldn't we need to set up something in `/etc/hosts`. I believe DNS > > lookups on the

Review Request 54173: Refactor necessary after removing default Address constructor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54173/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 54099: Used environment to pass flags to launch helper.

> On Nov. 28, 2016, 10:39 p.m., Kevin Klues wrote: > > src/slave/containerizer/mesos/containerizer.cpp, lines 1559-1570 > > > > > > Hmm. As it is written, an environment variable set on the agent will > > override

Re: Review Request 54167: Removed cyclic header dependency in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54167/#review157301 --- Patch looks great! Reviews applied: [54167] Passed command:

Re: Review Request 53627: Implement a namespaces/uts isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53627/#review157300 --- src/slave/containerizer/mesos/launch.cpp (line 431)

Re: Review Request 53627: Implement a namespaces/uts isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53627/#review157294 --- src/slave/containerizer/mesos/isolators/namespaces/uts.cpp

Re: Review Request 53897: Changed how master represents "recovered" frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53897/ --- (Updated Nov. 29, 2016, 5:55 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 54165: Fixed conflict in hook result handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54165/#review157276 --- Patch looks great! Reviews applied: [54165] Passed command:

Re: Review Request 54128: Added test for `slavePreLaunchDockerTaskExecutorDecorator` hook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54128/ --- (Updated Nov. 29, 2016, 4:38 p.m.) Review request for mesos, Adam B, Gastón

Re: Review Request 54165: Fixed conflict in hook result handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54165/ --- (Updated Nov. 29, 2016, 4:37 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 52695: Harden libprocess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52695/ --- (Updated Nov. 29, 2016, 4:26 p.m.) Review request for mesos, James Peach,

Re: Review Request 52696: Harden stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52696/ --- (Updated Nov. 29, 2016, 4:24 p.m.) Review request for mesos, James Peach,

Re: Review Request 52645: Harden Mesos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52645/ --- (Updated Nov. 29, 2016, 4:21 p.m.) Review request for mesos, James Peach,

Re: Review Request 54165: Fixed conflict in hook result handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54165/#review157265 --- Ship it! - Benjamin Bannier On Nov. 29, 2016, 4:32 p.m.,

Re: Review Request 52645: Harden Mesos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52645/ --- (Updated Nov. 29, 2016, 4:15 p.m.) Review request for mesos, James Peach,

Re: Review Request 52645: Harden Mesos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52645/ --- (Updated Nov. 29, 2016, 4:13 p.m.) Review request for mesos, James Peach,

Re: Review Request 54167: Removed cyclic header dependency in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54167/#review157261 --- Ship it! Ship It! - Benjamin Bannier On Nov. 29, 2016, 4:39

Re: Review Request 54167: Removed cyclic header dependency in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54167/ --- (Updated Nov. 29, 2016, 3:39 p.m.) Review request for mesos and Benjamin

Review Request 54165: Fixed conflict in hook result handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54165/ --- Review request for mesos, Adam B, Benjamin Bannier, Gastón Kleiman, and Kapil

Review Request 54167: Removed cyclic header dependency in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54167/ --- Review request for mesos and Benjamin Bannier. Bugs: MESOS-6647

Re: Review Request 53541: Added authorization actions for Nested Container and Debug API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53541/ --- (Updated Nov. 29, 2016, 4:18 p.m.) Review request for mesos, Adam B, Kapil

Re: Review Request 53541: Added authorization actions for Nested Container and Debug API.

> On Nov. 29, 2016, 10:47 a.m., Adam B wrote: > > src/authorizer/local/authorizer.cpp, line 471 > > > > > > Why check the command_info? It's optional either way, so leave it out. > > Your current logic would

Re: Review Request 53982: Added documentation for posix/rlimit isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53982/#review157254 --- I'd still like to see more discussion of how someone might

Re: Review Request 53982: Added documentation for posix/rlimit isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53982/#review157253 --- Patch looks great! Reviews applied: [53982] Passed command:

Re: Review Request 53982: Added documentation for posix/rlimit isolator.

> On Nov. 28, 2016, 8:36 p.m., Neil Conway wrote: > > docs/posix_rlimits.md, line 48 > > > > > > s/In addition many limits defined on Linux/Linux defines a number of > > additional resource limits that are not

Re: Review Request 53982: Added documentation for posix/rlimit isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53982/ --- (Updated Nov. 29, 2016, 1:54 p.m.) Review request for mesos, Jie Yu and Neil