Review Request 54348: Fixed small bug in `IOSwitchboardServerProcess::acceptLoop()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54348/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 54297: Added support for ATTACH_CONTAINER_INPUT to the io switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54297/ --- (Updated Dec. 4, 2016, 6:55 a.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 53897: Changed how master represents "recovered" frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53897/ --- (Updated Dec. 4, 2016, 2:06 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 53897: Changed how master represents "recovered" frameworks.

> On Dec. 3, 2016, 2:12 a.m., Vinod Kone wrote: > > src/master/master.cpp, line 2478 > > > > > > Can you add a comment on when we are here. It is not very obvious. > > Maybe copy paste the comment from #2708? I

Re: Review Request 54297: Added support for ATTACH_CONTAINER_INPUT to the io switchboard.

> On Dec. 3, 2016, 8:36 p.m., Anand Mazumdar wrote: > > src/slave/containerizer/mesos/io/switchboard.cpp, line 916 > > > > > > hmm, this message is a bit mis-leading given that you only start > > processing the

Re: Review Request 54297: Added support for ATTACH_CONTAINER_INPUT to the io switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54297/#review157914 --- Just a few more minor things to clean up.

Re: Review Request 54344: Added `setWindowSize()` to stout for setting a TTY's window size.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54344/ --- (Updated Dec. 4, 2016, 12:56 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 54297: Added support for ATTACH_CONTAINER_INPUT to the io switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54297/ --- (Updated Dec. 4, 2016, 12:54 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 54347: Cleaned up the 'IOSwitchboard.RedirectLog' test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54347/ --- (Updated Dec. 4, 2016, 12:54 a.m.) Review request for mesos and Anand

Re: Review Request 54344: Added `setWindowSize()` to stout for setting a TTY's window size.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54344/ --- (Updated Dec. 4, 2016, 12:53 a.m.) Review request for mesos and Jie Yu.

Review Request 54347: Cleaned up the 'IOSwitchboard.RedirectLog' test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54347/ --- Review request for mesos and Anand Mazumdar. Repository: mesos Description

Re: Review Request 54297: Added support for ATTACH_CONTAINER_INPUT to the io switchboard.

> On Dec. 3, 2016, 8:36 p.m., Anand Mazumdar wrote: > > src/slave/containerizer/mesos/io/switchboard.cpp, line 916 > > > > > > hmm, this message is a bit mis-leading given that you only start > > processing the

Re: Review Request 54297: Added support for ATTACH_CONTAINER_INPUT to the io switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54297/ --- (Updated Dec. 4, 2016, 12:30 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 54297: Added support for ATTACH_CONTAINER_INPUT to the io switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54297/ --- (Updated Dec. 4, 2016, 12:30 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 54344: Added `setWindowSize()` to stout for setting a TTY's window size.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54344/#review157912 --- Patch looks great! Reviews applied: [54274, 54296, 54297, 54344]

Re: Review Request 54297: Added support for ATTACH_CONTAINER_INPUT to the io switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54297/ --- (Updated Dec. 3, 2016, 11:45 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 54297: Added support for ATTACH_CONTAINER_INPUT to the io switchboard.

> On Dec. 3, 2016, 8:36 p.m., Anand Mazumdar wrote: > > src/slave/containerizer/mesos/io/switchboard.cpp, line 885 > > > > > > Can you add a comment here for posterity as to why these are not > > invariant checks

Re: Review Request 54337: Fixed the attach input call validation on the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54337/#review157910 --- Ship it! Ship It! - Vinod Kone On Dec. 3, 2016, 7:19 p.m.,

Re: Review Request 54342: Fixed the Agent API to return `BadRequest` for deserialization errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54342/#review157909 --- Ship it! Ship It! - Vinod Kone On Dec. 3, 2016, 7:48 p.m.,

Re: Review Request 54343: Pulled the validation code from `deserializer()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54343/#review157908 --- Patch looks great! Reviews applied: [54342, 54337, 54340, 54343]

Re: Review Request 54344: Added `setWindowSize()` to stout for setting a TTY's window size.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54344/#review157906 --- Ship it! Ship It! - Jie Yu On Dec. 3, 2016, 7:57 p.m.,

Re: Review Request 54297: Added support for ATTACH_CONTAINER_INPUT to the io switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54297/#review157901 --- Modulo Jie's comments. Did an initial pass. Looks pretty good!

Re: Review Request 53939: Added implementation for containerizer 'attach()' call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53939/ --- (Updated Dec. 3, 2016, 8:03 p.m.) Review request for mesos, Benjamin Hindman,

Review Request 54344: Added `setWindowSize()` to stout for setting a TTY's window size.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54344/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Review Request 54343: Pulled the validation code from `deserializer()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54343/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 54342: Fixed the Agent API to return `BadRequest` for deserialization errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54342/ --- (Updated Dec. 3, 2016, 7:48 p.m.) Review request for mesos and Vinod Kone.

Review Request 54342: Made the `deserializer()` not validate the Agent API calls too.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54342/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 54337: Fixed the attach input call validation on the agent.

> On Dec. 3, 2016, 6:57 p.m., Vinod Kone wrote: > > src/tests/api_tests.cpp, line 3828 > > > > > > hmm. InternalServerError instead of a BadRequest sounds wrong. > > > > for non-streaming requests, looks

Re: Review Request 54337: Fixed the attach input call validation on the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54337/ --- (Updated Dec. 3, 2016, 7:19 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 54340: Fixed an attach container input test impacted by stricter validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54340/#review157898 --- Ship it! Ship It! - Vinod Kone On Dec. 3, 2016, 6:04 p.m.,

Re: Review Request 54337: Fixed the attach input call validation on the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54337/#review157897 --- src/tests/api_tests.cpp (line 3828)

Review Request 54340: Fixed an attach container input test impacted by stricter validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54340/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 54333: Fixed error messages to say "form body" rather than "query parameter".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54333/#review157894 --- Patch looks great! Reviews applied: [54333] Passed command:

Re: Review Request 54297: Added support for ATTACH_CONTAINER_INPUT to the io switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54297/#review157891 --- Patch looks great! Reviews applied: [54274, 54296, 54297]