Review Request 60184: Resources: Adjusted the `operator<<` to the new resource format [4/N].

2017-06-18 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60184/ --- Review request for mesos and Neil Conway. Bugs: MESOS-7655

Review Request 60182: Resources: Adjusted the predicates to the new resource format [2/N].

2017-06-18 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60182/ --- Review request for mesos and Neil Conway. Bugs: MESOS-7655

Re: Review Request 60181: Resources: Updated the comment to mention the resource format [1/N].

2017-06-18 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60181/#review178178 --- Ship it! Ship It! - Neil Conway On June 19, 2017, 5:17

Re: Review Request 60015: Introduced a utility function `Resources::reservationRole`.

2017-06-18 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60015/#review178177 --- Ship it! src/common/resources.cpp Line 1041 (original), 1041

Review Request 60181: Resources: Updated the comment to mention the resource format [1/N].

2017-06-18 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60181/ --- Review request for mesos and Neil Conway. Bugs: MESOS-7655

Re: Review Request 60036: Avoided exposing `role` in JSON for resources with refined reservations.

2017-06-18 Thread Michael Park
> On June 18, 2017, 6:46 p.m., Neil Conway wrote: > > src/common/http.cpp > > Lines 519 (patched) > > > > > > Backticks not double quotes? Eh... I'm referring to fields in a JSON object here, I feel like

Re: Review Request 60178: Added test for endpoint resource format.

2017-06-18 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60178/ --- (Updated June 19, 2017, 1:40 a.m.) Review request for mesos and Michael Park.

Re: Review Request 60036: Avoided exposing `role` in JSON for resources with refined reservations.

2017-06-18 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60036/#review178172 --- Tests, can do later. src/common/http.hpp Lines 131 (patched)

Re: Review Request 60036: Avoided exposing `role` in JSON for resources with refined reservations.

2017-06-18 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60036/#review178173 --- Ship it! Ship It! - Neil Conway On June 15, 2017, 7:39

Re: Review Request 60022: Introduced `convertResourceFormat` to convert between resource formats.

2017-06-18 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60022/#review178170 --- src/common/resources_utils.hpp Lines 61 (patched)

Review Request 60179: Introduced a utility function `Resources::hasRefinedReservations`.

2017-06-18 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60179/ --- Review request for mesos. Repository: mesos Description --- Introduced

Re: Review Request 60178: Added test for endpoint resource format.

2017-06-18 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60178/#review178171 --- Fix it, then Ship it! src/tests/master_validation_tests.cpp

Re: Review Request 60178: Added test for endpoint resource format.

2017-06-18 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60178/ --- (Updated June 19, 2017, 1:12 a.m.) Review request for mesos and Michael Park.

Re: Review Request 60174: Updated the resources validation logic to allow for the endpoint format.

2017-06-18 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60174/#review178168 --- Ship it! Ship It! - Neil Conway On June 18, 2017, 10:02

Review Request 60178: Added test for endpoint resource format.

2017-06-18 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60178/ --- Review request for mesos and Michael Park. Repository: mesos Description

Re: Review Request 60174: Updated the resources validation logic to allow for the endpoint format.

2017-06-18 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60174/#review178165 --- In the commit message, can we explain why we need to update

Re: Review Request 60175: Introduced a utility function `Resources::hasRefinedReservations`.

2017-06-18 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60175/#review178164 --- Ship it! Is it worth adding coverage of this to the tests? -

Review Request 60175: Introduced a utility function `Resources::hasRefinedReservations`.

2017-06-18 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60175/ --- Review request for mesos and Neil Conway. Repository: mesos Description

Review Request 60174: Updated the resources validation logic to allow for the endpoint format.

2017-06-18 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60174/ --- Review request for mesos and Neil Conway. Bugs: MESOS-7655

Re: Review Request 59454: Adjust tests to account for GCC 7.1 fix in bytes.hpp.

2017-06-18 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59454/#review178163 --- Ship it! lgtm, although I'll change the commit message --

Re: Review Request 59989: Added a test `ProtobufTest.JsonifyMap`.

2017-06-18 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59989/ --- (Updated June 18, 2017, 8:43 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 59988: Added a new protobuf message `MapMessage` for protobuf tests.

2017-06-18 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59988/ --- (Updated June 18, 2017, 8:42 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 59987: Added protobuf map support.

2017-06-18 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59987/ --- (Updated June 18, 2017, 8:42 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 59988: Added a new protobuf message `MapMessage` for protobuf tests.

2017-06-18 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59988/ --- (Updated June 18, 2017, 8:40 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 59987: Added protobuf map support.

2017-06-18 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59987/ --- (Updated June 18, 2017, 8:39 p.m.) Review request for mesos, Anand Mazumdar