Re: Review Request 58898: Do not kill non partition aware tasks.

2017-08-05 Thread Megha Sharma
> On May 10, 2017, 11:24 p.m., Neil Conway wrote: > > My apologies for the delay in reviewing this. > > > > High-level comments: > > > > (a) Can we improve the description of the problem in the commit summary? It > > took me quite a while to figure out what is actually going on here. My > >

Re: Review Request 58898: Do not kill non partition aware tasks.

2017-08-05 Thread Megha Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58898/ --- (Updated Aug. 6, 2017, 4:35 a.m.) Review request for mesos, Neil Conway and

Re: Review Request 61406: Introduced `--disallow_top_level_pid_ns_sharing` agent flag.

2017-08-05 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61406/#review182256 --- src/slave/flags.hpp Lines 95 (patched)

Re: Review Request 61428: Added pid ns sharing based on agent flag and protobuf message field.

2017-08-05 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61428/ --- (Updated Aug. 5, 2017, 11:06 p.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 61406: Introduced `--disallow_top_level_pid_ns_sharing` agent flag.

2017-08-05 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61406/ --- (Updated Aug. 5, 2017, 11:06 p.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 61406: Introduced `--disallow_top_level_pid_ns_sharing` agent flag.

2017-08-05 Thread Qian Zhang
> On Aug. 5, 2017, 8:44 a.m., Gastón Kleiman wrote: > > docs/configuration.md > > Lines 2052-2054 (patched) > > > > > > s/pid namespace/PID namespace/g I took a look at other docs (e.g., `mesos-containerizer.md`

Re: Review Request 61428: Added pid ns sharing based on agent flag and protobuf message field.

2017-08-05 Thread Qian Zhang
> On Aug. 5, 2017, 8:33 a.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/namespaces/pid.cpp > > Lines 130 (patched) > > > > > > Could we reverse two logics above? so that we can avoid the size

Re: Review Request 61428: Added pid ns sharing based on agent flag and protobuf message field.

2017-08-05 Thread Qian Zhang
> On Aug. 5, 2017, 8:42 a.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/namespaces/pid.cpp > > Lines 85-86 (patched) > > > > > > I know in proto2 and proto3 `boolean` defaults to be `false`. But