date:20180216

Re: Review Request 64211: Added options to build the Python CLI and run unit tests.

2018-02-16 Thread Mesos Reviewbot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64211/#review197710
---



Patch looks great!

Reviews applied: [65585, 64211]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Feb. 16, 2018, 10:54 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64211/
> ---
> 
> (Updated Feb. 16, 2018, 10:54 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Kevin Klues.
> 
> 
> Bugs: MESOS-8240
> https://issues.apache.org/jira/browse/MESOS-8240
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> An update of the discarded review /r/52543.
> 
> Works with Autotools and CMake.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 6702f02245e3867c06bbd9efbbf4e3b961a7d9aa 
>   cmake/CompilationConfigure.cmake 50cddf9476c8c5196c4824a7b060c2680a96b277 
>   cmake/MesosConfigure.cmake 0954a9cd31fa290ff9099be4b06d69d96b701f1e 
>   configure.ac 30fbadc32d1d96f719d45fa8067f975283c25507 
>   docs/configuration/cmake.md 1e34657ea55fa324f65f865f7d0a67084c6719d9 
>   src/CMakeLists.txt 0c135034982a6a4844509cd0e9b2cc41804333ef 
>   src/Makefile.am a2ba1e6de0868c7a4fe58304ec479dce039bc288 
>   src/python/cli_new/CMakeLists.txt PRE-CREATION 
>   src/python/cli_new/tests/CMakeLists.txt PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/64211/diff/10/
> 
> 
> Testing
> ---
> 
> Testing done on Fedora 25.
> 
> For Autotools:
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ ../configure --enable-new-cli --disable-java --disable-python
> $ make check
> ```
> 
> For CMake:
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ cmake .. -DENABLE_NEW_CLI=1
> $ cmake --build . -- -j16
> $ ./src/mesos
> Mesos CLI
> 
> Usage:
>   mesos (-h | --help)
>   mesos --version
>   mesos  [...]
> 
> Options:
>   -h --help  Show this screen.
>   --version  Show version info.
> 
> Commands:
>   agent   Interacts with the Mesos agents
>   config  Interacts with the Mesos CLI configuration file
>   taskInteracts with the tasks running in a Mesos cluster
> 
> See 'mesos help ' for more information on a specific command.
> $ cmake --build . --target tests -- -j16
> $ ctest -R CLI
> Test project /home/agrillet/apache-mesos/build
> Start 4: CLITests
> 1/1 Test #4: CLITests .   Passed3.63 sec
> 
> 100% tests passed, 0 tests failed out of 1
> ```
> 
> Checked that the the CLI tests were run, that the content of the directory 
> `build/src/cli` was as expected, and that `build/src/mesos` was correctly 
> running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 65683: Added discard handling to Docker library functions.

2018-02-16 Thread Mesos Reviewbot Windows


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65683/#review197709
---



PASS: Mesos patch 65683 was successfully built and tested.

Reviews applied: `['65683']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65683

- Mesos Reviewbot Windows


On Feb. 17, 2018, 2:37 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65683/
> ---
> 
> (Updated Feb. 17, 2018, 2:37 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Gilbert Song.
> 
> 
> Bugs: MESOS-8575
> https://issues.apache.org/jira/browse/MESOS-8575
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added discard handling to Docker library functions.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.cpp 3df370e988fce12d323ff6b441da15dab27bdd28 
> 
> 
> Diff: https://reviews.apache.org/r/65683/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 64211: Added options to build the Python CLI and run unit tests.

2018-02-16 Thread Mesos Reviewbot Windows


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64211/#review197708
---



PASS: Mesos patch 64211 was successfully built and tested.

Reviews applied: `['65585', '64211']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64211

- Mesos Reviewbot Windows


On Feb. 17, 2018, 12:54 a.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64211/
> ---
> 
> (Updated Feb. 17, 2018, 12:54 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Kevin Klues.
> 
> 
> Bugs: MESOS-8240
> https://issues.apache.org/jira/browse/MESOS-8240
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> An update of the discarded review /r/52543.
> 
> Works with Autotools and CMake.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 6702f02245e3867c06bbd9efbbf4e3b961a7d9aa 
>   cmake/CompilationConfigure.cmake 50cddf9476c8c5196c4824a7b060c2680a96b277 
>   cmake/MesosConfigure.cmake 0954a9cd31fa290ff9099be4b06d69d96b701f1e 
>   configure.ac 30fbadc32d1d96f719d45fa8067f975283c25507 
>   docs/configuration/cmake.md 1e34657ea55fa324f65f865f7d0a67084c6719d9 
>   src/CMakeLists.txt 0c135034982a6a4844509cd0e9b2cc41804333ef 
>   src/Makefile.am a2ba1e6de0868c7a4fe58304ec479dce039bc288 
>   src/python/cli_new/CMakeLists.txt PRE-CREATION 
>   src/python/cli_new/tests/CMakeLists.txt PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/64211/diff/10/
> 
> 
> Testing
> ---
> 
> Testing done on Fedora 25.
> 
> For Autotools:
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ ../configure --enable-new-cli --disable-java --disable-python
> $ make check
> ```
> 
> For CMake:
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ cmake .. -DENABLE_NEW_CLI=1
> $ cmake --build . -- -j16
> $ ./src/mesos
> Mesos CLI
> 
> Usage:
>   mesos (-h | --help)
>   mesos --version
>   mesos  [...]
> 
> Options:
>   -h --help  Show this screen.
>   --version  Show version info.
> 
> Commands:
>   agent   Interacts with the Mesos agents
>   config  Interacts with the Mesos CLI configuration file
>   taskInteracts with the tasks running in a Mesos cluster
> 
> See 'mesos help ' for more information on a specific command.
> $ cmake --build . --target tests -- -j16
> $ ctest -R CLI
> Test project /home/agrillet/apache-mesos/build
> Start 4: CLITests
> 1/1 Test #4: CLITests .   Passed3.63 sec
> 
> 100% tests passed, 0 tests failed out of 1
> ```
> 
> Checked that the the CLI tests were run, that the content of the directory 
> `build/src/cli` was as expected, and that `build/src/mesos` was correctly 
> running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 65695: Made the default executor allow schedulers to retry task kills.

2018-02-16 Thread Mesos Reviewbot Windows


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65695/#review197707
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['65692', '65693', '65694', '65695']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65695

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65695/logs/mesos-tests-stdout.log):

```

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (33 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (40 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (74 ms 
total)

[--] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN  ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[   OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2556 ms)
[--] 1 test from IsolationFlag/CpuIsolatorTest (2580 ms total)

[--] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN  ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2460 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (2483 ms total)

[--] Global test environment tear-down
[==] 906 tests from 90 test cases ran. (464637 ms total)
[  PASSED  ] 903 tests.
[  FAILED  ] 3 tests, listed below:
[  FAILED  ] MesosContainerizer/DefaultExecutorTest.KillTask/0, where 
GetParam() = "mesos"
[  FAILED  ] MesosContainerizer/DefaultExecutorTest.KillMultipleTasks/0, where 
GetParam() = "mesos"
[  FAILED  ] MesosContainerizer/DefaultExecutorTest.CommitSuicideOnKillTask/0, 
where GetParam() = "mesos"

 3 FAILED TESTS
  YOU HAVE 211 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65695/logs/mesos-tests-stderr.log):

```
I0217 02:51:24.176358  6436 slave.cpp:3879] Shutting down framework 
60e5ecc8-9d45-4dca-9829-0308832a3de6-
I0217 02:51:24.176358  4732 master.cpp:10249] Updating the state of task 
6988de1f-8545-4e3a-b811-49eabacd14c8 of framework 
60e5ecc8-9d45-4dca-9829-0308832a3de6- (latest state: TASK_KILLI0217 
02:51:23.502336  9936 exec.cpp:162] Version: 1.6.0
I0217 02:51:23.526335  4932 exec.cpp:236] Executor registered on agent 
60e5ecc8-9d45-4dca-9829-0308832a3de6-S0
I0217 02:51:23.530336  9936 executor.cpp:174] Received SUBSCRIBED event
I0217 02:51:23.534332  9936 executor.cpp:178] Subscribed executor on 
build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0217 02:51:23.534332  9936 executor.cpp:174] Received LAUNCH event
I0217 02:51:23.537350  9936 executor.cpp:646] Starting task 
6988de1f-8545-4e3a-b811-49eabacd14c8
I0217 02:51:23.611337  9936 executor.cpp:481] Running 
'D:\DCOS\mesos\src\mesos-containerizer.exe launch '
I0217 02:51:24.148334  9936 executor.cpp:659] Forked command at 6464
I0217 02:51:24.178335  7248 exec.cpp:445] Executor asked to shutdown
I0217 02:51:24.179335  9936 executor.cpp:174] Received SHUTDOWN event
I0217 02:51:24.179335  9936 executor.cpp:756] Shutting down
I0217 02:51:24.179335  9936 executor.cpp:866] Sending SIGTERM to process tree 
at pid 6ED, status update state: TASK_KILLED)
I0217 02:51:24.176358  6436 slave.cpp:6586] Shutting down executor 
'6988de1f-8545-4e3a-b811-49eabacd14c8' of framework 
60e5ecc8-9d45-4dca-9829-0308832a3de6- at executor(1)@10.3.1.11:62887
I0217 02:51:24.177357  6436 slave.cpp:922] Agent terminating
W0217 02:51:24.178335  6436 slave.cpp:3875] Ignoring shutdown framework 
60e5ecc8-9d45-4dca-9829-0308832a3de6- because it is terminating
I0217 02:51:24.179335  4732 master.cpp:10348] Removing task 
6988de1f-8545-4e3a-b811-49eabacd14c8 with resources cpus(allocated: *):4; 
mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: 
*):[31000-32000] of framework 60e5ecc8-9d45-4dca-9829-0308832a3de6- on 
agent 60e5ecc8-9d45-4dca-9829-0308832a3de6-S0 at slave(392)@10.3.1.11:62866 
(build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0217 02:51:24.181335  6436 containerizer.cpp:2338] Destroying container 
87af1d2d-501c-485b-ad57-50ff6bf830f2 in RUNNING state
I0217 02:51:24.181335  6436 containerizer.cpp:2952] Transitioning the state of 
container 87af1d2d-501c-485b-ad57-50ff6bf830f2 from RUNNING to DESTROYING
I0217 02:51:24.182337  4732 master.cpp:1307] Agent 
60e5ecc8-9d45-4dca-9829-0308832a3de6-S0 at slave(392)@10.3.1.11:62866 
(build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0217 02:51:24.182337  4732

Re: Review Request 65683: Added discard handling to Docker library functions.

2018-02-16 Thread Greg Mann


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65683/
---

(Updated Feb. 17, 2018, 2:37 a.m.)


Review request for mesos, Andrei Budnik and Gilbert Song.


Bugs: MESOS-8575
https://issues.apache.org/jira/browse/MESOS-8575


Repository: mesos


Description
---

Added discard handling to Docker library functions.


Diffs
-

  src/docker/docker.cpp 3df370e988fce12d323ff6b441da15dab27bdd28 


Diff: https://reviews.apache.org/r/65683/diff/2/


Testing
---


Thanks,

Greg Mann

Re: Review Request 65696: Allowed base64-decoding with whitespaces.

2018-02-16 Thread Mesos Reviewbot Windows


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65696/#review197705
---



PASS: Mesos patch 65696 was successfully built and tested.

Reviews applied: `['65696']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65696

- Mesos Reviewbot Windows


On Feb. 17, 2018, 8:27 a.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65696/
> ---
> 
> (Updated Feb. 17, 2018, 8:27 a.m.)
> 
> 
> Review request for mesos, Michael Park and Till Toenshoff.
> 
> 
> Bugs: MESOS-8569
> https://issues.apache.org/jira/browse/MESOS-8569
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Most base64 decoders do not fail on encountering whitespace characters
> as several encoders embed newlines to enforce line-width in encoded
> data.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/base64.hpp 
> eabc9b0f0ad794ffccda44e338ea855b8c4a796f 
>   3rdparty/stout/tests/base64_tests.cpp 
> a6837c820384e3311d2c030885039a7dd7f01a66 
> 
> 
> Diff: https://reviews.apache.org/r/65696/diff/1/
> 
> 
> Testing
> ---
> 
> Updated base64 tests and ran make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 64387: Windows: Ported docker health check tests.

2018-02-16 Thread Andrew Schwartzmeyer


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64387/#review197704
---


Ship it!




Ship It!

- Andrew Schwartzmeyer


On Feb. 16, 2018, 3:49 p.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64387/
> ---
> 
> (Updated Feb. 16, 2018, 3:49 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston 
> Kleiman, Jie Yu, Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-8498
> https://issues.apache.org/jira/browse/MESOS-8498
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The `HealthCheckTest.ROOT_DOCKER_*` and
> `DockerContainerizerHealthCheckTest.*` tests now work on Windows.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_common.hpp PRE-CREATION 
>   src/tests/environment.cpp 931e647c9531dc27c31a02b9e8aca15ef441a5b6 
>   src/tests/health_check_tests.cpp 1893c85169f5e94e164434b93e6a24268224225d 
> 
> 
> Diff: https://reviews.apache.org/r/64387/diff/12/
> 
> 
> Testing
> ---
> 
> Windows Server:
> [==] Running 5 tests from 2 test cases.
> [--] Global test environment set-up.
> [--] 2 tests from HealthCheckTest
> [ RUN  ] HealthCheckTest.ROOT_DOCKER_DockerHealthyTask
> [   OK ] HealthCheckTest.ROOT_DOCKER_DockerHealthyTask (21263 ms)
> [ RUN  ] HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange
> [   OK ] HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange (23512 ms)
> [--] 2 tests from HealthCheckTest (44835 ms total)
> 
> [--] 3 tests from NetworkProtocol/DockerContainerizerHealthCheckTest
> [ RUN  ] 
> NetworkProtocol/DockerContainerizerHealthCheckTest.ROOT_DOCKER_USERNETWORK_NETNAMESPACE_HealthyTaskViaHTTP/0
> [   OK ] 
> NetworkProtocol/DockerContainerizerHealthCheckTest.ROOT_DOCKER_USERNETWORK_NETNAMESPACE_HealthyTaskViaHTTP/0
>  (28487 ms)
> [ RUN  ] 
> NetworkProtocol/DockerContainerizerHealthCheckTest.ROOT_DOCKER_USERNETWORK_NETNAMESPACE_HealthyTaskViaHTTPS/0
> [   OK ] 
> NetworkProtocol/DockerContainerizerHealthCheckTest.ROOT_DOCKER_USERNETWORK_NETNAMESPACE_HealthyTaskViaHTTPS/0
>  (26447 ms)
> [ RUN  ] 
> NetworkProtocol/DockerContainerizerHealthCheckTest.ROOT_DOCKER_USERNETWORK_NETNAMESPACE_HealthyTaskViaTCP/0
> [   OK ] 
> NetworkProtocol/DockerContainerizerHealthCheckTest.ROOT_DOCKER_USERNETWORK_NETNAMESPACE_HealthyTaskViaTCP/0
>  (26264 ms)
> [--] 3 tests from NetworkProtocol/DockerContainerizerHealthCheckTest 
> (81268 ms total)
> 
> [--] Global test environment tear-down
> [==] 5 tests from 2 test cases ran. (126559 ms total)
> [  PASSED  ] 5 tests
> 
> Rest of tests pass.
> 
> Windows Client (Disabled network health checks):
> Proof that network health checks are skipped on Windows Client.
> C:\Program Files\Docker\Docker\Resources\bin\docker.exe: Error response from 
> daemon: sharing of hyperv containers network is not supported.
> 356b087e7fa640f83fe27ebeb3396bfc7b2bbebd917aeaec0508b887b41d31f4
> -
> We cannot run any Docker health checks tests because:
> Running in another container's namespace is not supported on this version of 
> Windows.
> 
> Rest rests pass.
> 
> Linux:
> make check passes
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Re: Review Request 65615: Added docker constants and common functions file.

2018-02-16 Thread Andrew Schwartzmeyer


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65615/#review197703
---


Ship it!




Ship It!

- Andrew Schwartzmeyer


On Feb. 16, 2018, 3:30 p.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65615/
> ---
> 
> (Updated Feb. 16, 2018, 3:30 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, and 
> Gaston Kleiman.
> 
> 
> Bugs: MESOS-8498
> https://issues.apache.org/jira/browse/MESOS-8498
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch is in preparation of porting docker tests to Windows. There
> were a few hardcoded values that were used throughout the codebase,
> such as the `alpine` image, that are defined as a constant in a single
> file.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am a2ba1e6de0868c7a4fe58304ec479dce039bc288 
>   src/tests/containerizer/docker_common.hpp PRE-CREATION 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> d1e657050d623ad0412208b3aa3e3101e3654e99 
>   src/tests/health_check_tests.cpp 1893c85169f5e94e164434b93e6a24268224225d 
>   src/tests/mesos.hpp f088cfdd490054ec605e33bd8c361a9d0939e22d 
> 
> 
> Diff: https://reviews.apache.org/r/65615/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Re: Review Request 64604: Windows: Updated heath-checks.md with Windows implementation.

2018-02-16 Thread Mesos Reviewbot Windows


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64604/#review197702
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['65393', '65394', '65395', '65396', '65419', '65127', 
'65615', '64387', '64604']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64604

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64604/logs/mesos-tests-stdout.log):

```
[   OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (105 ms)
[--] 9 tests from Endpoint/SlaveEndpointTest (990 ms total)

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (32 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (38 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (73 ms 
total)

[--] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN  ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[   OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2416 ms)
[--] 1 test from IsolationFlag/CpuIsolatorTest (2440 ms total)

[--] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN  ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2372 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (2397 ms total)

[--] Global test environment tear-down
[==] 906 tests from 90 test cases ran. (419565 ms total)
[  PASSED  ] 906 tests.
[  FAILED  ] 0 tests, listed below:

 0 FAILED TESTS

  YOU HAVE 211 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64604/logs/mesos-tests-stderr.log):

```
I0217 00:38:27.422452  1200 master.cpp:10249] Updating the state of task 
9fde43fa-d011-4dd0-9181-cd2b25c21ce8 of framework 
4c52e543-1863-4751-8c8f-e508933745b8- (latest state: TASK_KILLED, status 
update state: TASK_KILLED)
I0217 00:38:27.422452  5408 slave.cpp:3879] Shutting down framework 
4c52e543-1863-4751-8c8f-e508933745b8-
I0217 00:38:27.422452  5408 slave.cpp:6586] Shutting down executor 
'9fde43fa-d011-4dd0-9181-cd2b25c21ce8' of framework 
4c52e543-1863-4751-8c8f-e508933745b8- at executor(1)@10.3.1.11:5I0217 
00:38:26.755448  3904 exec.cpp:162] Version: 1.6.0
I0217 00:38:26.779450  6968 exec.cpp:236] Executor registered on agent 
4c52e543-1863-4751-8c8f-e508933745b8-S0
I0217 00:38:26.782425  8876 executor.cpp:176] Received SUBSCRIBED event
I0217 00:38:26.787452  8876 executor.cpp:180] Subscribed executor on 
build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0217 00:38:26.788452  8876 executor.cpp:176] Received LAUNCH event
I0217 00:38:26.792425  8876 executor.cpp:648] Starting task 
9fde43fa-d011-4dd0-9181-cd2b25c21ce8
I0217 00:38:26.868449  8876 executor.cpp:483] Running 
'D:\DCOS\mesos\src\mesos-containerizer.exe launch '
I0217 00:38:27.398429  8876 executor.cpp:661] Forked command at 4040
I0217 00:38:27.424430  9484 exec.cpp:445] Executor asked to shutdown
I0217 00:38:27.425429  3876 executor.cpp:176] Received SHUTDOWN event
I0217 00:38:27.425429  3876 executor.cpp:758] Shutting down
I0217 00:38:27.425429  3876 executor.cpp:868] Sending SIGTERM to process tree 
at pid 48566
I0217 00:38:27.424430  5408 slave.cpp:922] Agent terminating
W0217 00:38:27.424430  5408 slave.cpp:3875] Ignoring shutdown framework 
4c52e543-1863-4751-8c8f-e508933745b8- because it is terminating
I0217 00:38:27.424430  1200 master.cpp:10348] Removing task 
9fde43fa-d011-4dd0-9181-cd2b25c21ce8 with resources cpus(allocated: *):4; 
mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: 
*):[31000-32000] of framework 4c52e543-1863-4751-8c8f-e508933745b8- on 
agent 4c52e543-1863-4751-8c8f-e508933745b8-S0 at slave(392)@10.3.1.11:58544 
(build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0217 00:38:27.427428  4948 containerizer.cpp:2338] Destroying container 
324331bc-7901-49ca-901a-2aac1b974cab in RUNNING state
I0217 00:38:27.427428  1200 master.cpp:1307] Agent 
4c52e543-1863-4751-8c8f-e508933745b8-S0 at slave(392)@10.3.1.11:58544 
(build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0217 00:38:27.427428  4948 containerizer.cpp:2952] Transitioning the state of 
container 324331bc-7901-49ca-901a-2aac1b974cab from RUNNING to DESTROYING
I0217 00:38:27.427428  1200 master.cpp:3277] Disconnecting agent 
4c52e543-1863-4751-8c8f-e508933745b8-S0 at slave(392)@10.3.1.11:58544

Review Request 65694: Made the default executor's handling of kill escalations more robust.

2018-02-16 Thread Gaston Kleiman


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65694/
---

Review request for mesos, Joseph Wu, Qian Zhang, and Vinod Kone.


Bugs: MESOS-8530
https://issues.apache.org/jira/browse/MESOS-8530


Repository: mesos


Description
---

This patch makes the default executor retry SIGKILL escalations if the
it is disconnected from the agent or the kill call fails.


Diffs
-

  src/launcher/default_executor.cpp 8720dada8bc6ca66f9e0fec6dc265eda3dcc7407 


Diff: https://reviews.apache.org/r/65694/diff/1/


Testing
---

`sudo bin/mesos-tests.sh` on GNU/Linux


Thanks,

Gaston Kleiman

Review Request 65695: Made the default executor allow schedulers to retry task kills.

2018-02-16 Thread Gaston Kleiman


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65695/
---

Review request for mesos, Joseph Wu, Qian Zhang, and Vinod Kone.


Bugs: MESOS-8530
https://issues.apache.org/jira/browse/MESOS-8530


Repository: mesos


Description
---

The default executor transitions a task to `TASK_KILLING` and marks its
child container as being killed before posting a `KILL` call to the
agent.

The executor ignores kill requests for containers that are marked as
being killed, and it doesn't remove this mark if the `KILL` call fails.
This means that it's possible for tasks to get stuck in a `TASK_KILLING`
state.

This patch makes the default executor remove the killing mark if a
`KILL` call fails. That way a scheduler can retry a kill.


Diffs
-

  src/launcher/default_executor.cpp 8720dada8bc6ca66f9e0fec6dc265eda3dcc7407 


Diff: https://reviews.apache.org/r/65695/diff/1/


Testing
---

`sudo bin/mesos-tests.sh` on GNU/Linux


Thanks,

Gaston Kleiman

Review Request 65696: Allowed base64-decoding with whitespaces.

2018-02-16 Thread Kapil Arya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65696/
---

Review request for mesos, Michael Park and Till Toenshoff.


Bugs: MESOS-8569
https://issues.apache.org/jira/browse/MESOS-8569


Repository: mesos


Description
---

Most base64 decoders do not fail on encountering whitespace characters
as several encoders embed newlines to enforce line-width in encoded
data.


Diffs
-

  3rdparty/stout/include/stout/base64.hpp 
eabc9b0f0ad794ffccda44e338ea855b8c4a796f 
  3rdparty/stout/tests/base64_tests.cpp 
a6837c820384e3311d2c030885039a7dd7f01a66 


Diff: https://reviews.apache.org/r/65696/diff/1/


Testing
---

Updated base64 tests and ran make check


Thanks,

Kapil Arya

Review Request 65693: Made the default executor fail kills if the response isn't "200 OK".

2018-02-16 Thread Gaston Kleiman


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65693/
---

Review request for mesos, Joseph Wu, Qian Zhang, and Vinod Kone.


Bugs: MESOS-8530
https://issues.apache.org/jira/browse/MESOS-8530


Repository: mesos


Description
---

The default executor's `Future kill(const ContainerID&, int)`
method returns `Nothing()` if the agent responded to the
`KILL_NESTED_CONTAINER` call, regardless of the response.

This patch updates the method, so that it returns a failure if the
response is not "200 OK".


Diffs
-

  src/launcher/default_executor.cpp 8720dada8bc6ca66f9e0fec6dc265eda3dcc7407 


Diff: https://reviews.apache.org/r/65693/diff/1/


Testing
---

`sudo bin/mesos-tests.sh` on GNU/Linux


Thanks,

Gaston Kleiman

Review Request 65692: Changed the signature of a DefaultExecutor kill method.

2018-02-16 Thread Gaston Kleiman


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65692/
---

Review request for mesos, Joseph Wu, Qian Zhang, and Vinod Kone.


Bugs: MESOS-8530
https://issues.apache.org/jira/browse/MESOS-8530


Repository: mesos


Description
---

This method is being passed the container to be killed as
`Owned`.

The container object is owned by the executor and stored in
`LinkedHashMap containers`.

We should pass around raw pointers and not make copies of the stored
`Owned` object, so this patch changes the signature of the `kill`
method.


Diffs
-

  src/launcher/default_executor.cpp 8720dada8bc6ca66f9e0fec6dc265eda3dcc7407 


Diff: https://reviews.apache.org/r/65692/diff/1/


Testing
---

`sudo bin/mesos-tests.sh` on GNU/Linux


Thanks,

Gaston Kleiman

Re: Review Request 64387: Windows: Ported docker health check tests.

2018-02-16 Thread Akash Gupta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64387/
---

(Updated Feb. 16, 2018, 11:49 p.m.)


Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston 
Kleiman, Jie Yu, Joseph Wu, and Michael Park.


Changes
---

Rebased and feedback.


Bugs: MESOS-8498
https://issues.apache.org/jira/browse/MESOS-8498


Repository: mesos


Description
---

The `HealthCheckTest.ROOT_DOCKER_*` and
`DockerContainerizerHealthCheckTest.*` tests now work on Windows.


Diffs (updated)
-

  src/tests/containerizer/docker_common.hpp PRE-CREATION 
  src/tests/environment.cpp 931e647c9531dc27c31a02b9e8aca15ef441a5b6 
  src/tests/health_check_tests.cpp 1893c85169f5e94e164434b93e6a24268224225d 


Diff: https://reviews.apache.org/r/64387/diff/12/

Changes: https://reviews.apache.org/r/64387/diff/11-12/


Testing
---

Windows Server:
[==] Running 5 tests from 2 test cases.
[--] Global test environment set-up.
[--] 2 tests from HealthCheckTest
[ RUN  ] HealthCheckTest.ROOT_DOCKER_DockerHealthyTask
[   OK ] HealthCheckTest.ROOT_DOCKER_DockerHealthyTask (21263 ms)
[ RUN  ] HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange
[   OK ] HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange (23512 ms)
[--] 2 tests from HealthCheckTest (44835 ms total)

[--] 3 tests from NetworkProtocol/DockerContainerizerHealthCheckTest
[ RUN  ] 
NetworkProtocol/DockerContainerizerHealthCheckTest.ROOT_DOCKER_USERNETWORK_NETNAMESPACE_HealthyTaskViaHTTP/0
[   OK ] 
NetworkProtocol/DockerContainerizerHealthCheckTest.ROOT_DOCKER_USERNETWORK_NETNAMESPACE_HealthyTaskViaHTTP/0
 (28487 ms)
[ RUN  ] 
NetworkProtocol/DockerContainerizerHealthCheckTest.ROOT_DOCKER_USERNETWORK_NETNAMESPACE_HealthyTaskViaHTTPS/0
[   OK ] 
NetworkProtocol/DockerContainerizerHealthCheckTest.ROOT_DOCKER_USERNETWORK_NETNAMESPACE_HealthyTaskViaHTTPS/0
 (26447 ms)
[ RUN  ] 
NetworkProtocol/DockerContainerizerHealthCheckTest.ROOT_DOCKER_USERNETWORK_NETNAMESPACE_HealthyTaskViaTCP/0
[   OK ] 
NetworkProtocol/DockerContainerizerHealthCheckTest.ROOT_DOCKER_USERNETWORK_NETNAMESPACE_HealthyTaskViaTCP/0
 (26264 ms)
[--] 3 tests from NetworkProtocol/DockerContainerizerHealthCheckTest 
(81268 ms total)

[--] Global test environment tear-down
[==] 5 tests from 2 test cases ran. (126559 ms total)
[  PASSED  ] 5 tests

Rest of tests pass.

Windows Client (Disabled network health checks):
Proof that network health checks are skipped on Windows Client.
C:\Program Files\Docker\Docker\Resources\bin\docker.exe: Error response from 
daemon: sharing of hyperv containers network is not supported.
356b087e7fa640f83fe27ebeb3396bfc7b2bbebd917aeaec0508b887b41d31f4
-
We cannot run any Docker health checks tests because:
Running in another container's namespace is not supported on this version of 
Windows.

Rest rests pass.

Linux:
make check passes


Thanks,

Akash Gupta

Re: Review Request 64604: Windows: Updated heath-checks.md with Windows implementation.

2018-02-16 Thread Akash Gupta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64604/
---

(Updated Feb. 16, 2018, 11:47 p.m.)


Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston 
Kleiman, Jie Yu, and Michael Park.


Changes
---

Rebased


Bugs: MESOS-8498
https://issues.apache.org/jira/browse/MESOS-8498


Repository: mesos


Description
---

Updated health-checks.md with details of the Windows health check
implementations for the mesos and docker executors.


Diffs (updated)
-

  docs/health-checks.md 119d149f29f2f2d3178da6ef63a7ce97a4dbc952 


Diff: https://reviews.apache.org/r/64604/diff/6/

Changes: https://reviews.apache.org/r/64604/diff/5-6/


Testing
---


Thanks,

Akash Gupta

Re: Review Request 65615: Added docker constants and common functions file.

2018-02-16 Thread Akash Gupta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65615/
---

(Updated Feb. 16, 2018, 11:30 p.m.)


Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, and Gaston 
Kleiman.


Changes
---

Address feedback


Bugs: MESOS-8498
https://issues.apache.org/jira/browse/MESOS-8498


Repository: mesos


Description
---

This patch is in preparation of porting docker tests to Windows. There
were a few hardcoded values that were used throughout the codebase,
such as the `alpine` image, that are defined as a constant in a single
file.


Diffs (updated)
-

  src/Makefile.am a2ba1e6de0868c7a4fe58304ec479dce039bc288 
  src/tests/containerizer/docker_common.hpp PRE-CREATION 
  src/tests/containerizer/docker_containerizer_tests.cpp 
d1e657050d623ad0412208b3aa3e3101e3654e99 
  src/tests/health_check_tests.cpp 1893c85169f5e94e164434b93e6a24268224225d 
  src/tests/mesos.hpp f088cfdd490054ec605e33bd8c361a9d0939e22d 


Diff: https://reviews.apache.org/r/65615/diff/2/

Changes: https://reviews.apache.org/r/65615/diff/1-2/


Testing
---


Thanks,

Akash Gupta

Re: Review Request 65419: Fixed quoting issues in docker executor command checks.

2018-02-16 Thread Akash Gupta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65419/
---

(Updated Feb. 16, 2018, 11:29 p.m.)


Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston 
Kleiman, and Joseph Wu.


Changes
---

Rebased.


Bugs: MESOS-4812 and MESOS-8498
https://issues.apache.org/jira/browse/MESOS-4812
https://issues.apache.org/jira/browse/MESOS-8498


Repository: mesos


Description
---

The docker executor was wrapping the docker exec command around with
`sh -c ""`, which was causing quoting issues, especially on Windows.
Now, the comamnd health check simply runs `docker exec` without any
wrapping.


Diffs (updated)
-

  src/checks/checker_process.cpp ddb197b8cc2c503fef5ae20af32f5881fff9833f 


Diff: https://reviews.apache.org/r/65419/diff/4/

Changes: https://reviews.apache.org/r/65419/diff/3-4/


Testing
---

make check


Thanks,

Akash Gupta

Re: Review Request 65394: Added separate structs for health check runtime and check types.

2018-02-16 Thread Akash Gupta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65394/
---

(Updated Feb. 16, 2018, 11:25 p.m.)


Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, and Gaston 
Kleiman.


Changes
---

Added files to Makefile


Bugs: MESOS-8498
https://issues.apache.org/jira/browse/MESOS-8498


Repository: mesos


Description
---

This patch is in preparation of another patch that will refactor the
health check code using these types.


Diffs (updated)
-

  src/Makefile.am a2ba1e6de0868c7a4fe58304ec479dce039bc288 
  src/checks/checks_runtime.hpp PRE-CREATION 
  src/checks/checks_types.hpp PRE-CREATION 


Diff: https://reviews.apache.org/r/65394/diff/5/

Changes: https://reviews.apache.org/r/65394/diff/4-5/


Testing
---

make check


Thanks,

Akash Gupta

Re: Review Request 65393: Fixed docker command health check to use the right docker socket.

2018-02-16 Thread Akash Gupta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65393/
---

(Updated Feb. 16, 2018, 11:25 p.m.)


Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, and Gaston 
Kleiman.


Changes
---

rebased


Bugs: MESOS-8498
https://issues.apache.org/jira/browse/MESOS-8498


Repository: mesos


Description
---

The original command health check was calling `docker exec` instead
of `docker -H  exec`, so it was ignoring the socket
value passed to the docker executor.


Diffs (updated)
-

  src/docker/docker.hpp d9e71f8841a868082170d28fc4f3d495e2eb1e61 
  src/docker/executor.cpp 80e2d81169f0d4303ca1ddbcef9fa87fe52601fc 


Diff: https://reviews.apache.org/r/65393/diff/3/

Changes: https://reviews.apache.org/r/65393/diff/2-3/


Testing
---

ran mesos-tests --docker flag.


Thanks,

Akash Gupta

Re: Review Request 64211: Added options to build the Python CLI and run unit tests.

2018-02-16 Thread Armand Grillet


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64211/
---

(Updated Feb. 16, 2018, 10:54 p.m.)


Review request for mesos, Benjamin Bannier and Kevin Klues.


Changes
---

Rebased patch and improved `Testing Done`.


Bugs: MESOS-8240
https://issues.apache.org/jira/browse/MESOS-8240


Repository: mesos


Description
---

An update of the discarded review /r/52543.

Works with Autotools and CMake.


Diffs (updated)
-

  CMakeLists.txt 6702f02245e3867c06bbd9efbbf4e3b961a7d9aa 
  cmake/CompilationConfigure.cmake 50cddf9476c8c5196c4824a7b060c2680a96b277 
  cmake/MesosConfigure.cmake 0954a9cd31fa290ff9099be4b06d69d96b701f1e 
  configure.ac 30fbadc32d1d96f719d45fa8067f975283c25507 
  docs/configuration/cmake.md 1e34657ea55fa324f65f865f7d0a67084c6719d9 
  src/CMakeLists.txt 0c135034982a6a4844509cd0e9b2cc41804333ef 
  src/Makefile.am a2ba1e6de0868c7a4fe58304ec479dce039bc288 
  src/python/cli_new/CMakeLists.txt PRE-CREATION 
  src/python/cli_new/tests/CMakeLists.txt PRE-CREATION 


Diff: https://reviews.apache.org/r/64211/diff/10/

Changes: https://reviews.apache.org/r/64211/diff/9-10/


Testing (updated)
---

Testing done on Fedora 25.

For Autotools:
```
$ ./bootstrap
$ mkdir build
$ cd build
$ ../configure --enable-new-cli --disable-java --disable-python
$ make check
```

For CMake:
```
$ ./bootstrap
$ mkdir build
$ cd build
$ cmake .. -DENABLE_NEW_CLI=1
$ cmake --build . -- -j16
$ ./src/mesos
Mesos CLI

Usage:
  mesos (-h | --help)
  mesos --version
  mesos  [...]

Options:
  -h --help  Show this screen.
  --version  Show version info.

Commands:
  agent   Interacts with the Mesos agents
  config  Interacts with the Mesos CLI configuration file
  taskInteracts with the tasks running in a Mesos cluster

See 'mesos help ' for more information on a specific command.
$ cmake --build . --target tests -- -j16
$ ctest -R CLI
Test project /home/agrillet/apache-mesos/build
Start 4: CLITests
1/1 Test #4: CLITests .   Passed3.63 sec

100% tests passed, 0 tests failed out of 1
```

Checked that the the CLI tests were run, that the content of the directory 
`build/src/cli` was as expected, and that `build/src/mesos` was correctly 
running.


Thanks,

Armand Grillet

Re: Review Request 65585: Improved documentation regarding the new CLI setup.

2018-02-16 Thread Armand Grillet


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65585/
---

(Updated Feb. 16, 2018, 10:45 p.m.)


Review request for mesos, Benjamin Bannier and Kevin Klues.


Changes
---

Decreased scope of this patch. Mainly a documentation change now with a few 
improvements.


Summary (updated)
-

Improved documentation regarding the new CLI setup.


Bugs: MESOS-8240
https://issues.apache.org/jira/browse/MESOS-8240


Repository: mesos


Description (updated)
---

Explains how to create the necessary virtual environment from
anywhere and how to set up autocompletion in such case.


Diffs (updated)
-

  src/python/cli_new/README.md 847141db9a1f9eb5c78b2d50367b599a5c72ce61 
  src/python/cli_new/bin/mesos c5152a2ebf8704c804bb4f39e46580a512aecdea 
  src/python/cli_new/bin/mesos-cli-tests 
07659e0b4551c2381828b256608d2c6ced3ae745 
  src/python/cli_new/bootstrap 9329a61a2a1f05286b4ff6e5fe68cd86ed48859a 


Diff: https://reviews.apache.org/r/65585/diff/2/

Changes: https://reviews.apache.org/r/65585/diff/1-2/


Testing (updated)
---

On Fedora 25:
```
apache-mesos (MESOS-8240)$ cd src/python/cli_new/
cli_new (MESOS-8240)$ ./bootstrap
cli_new (MESOS-8240)$ source .virtualenv/activate
(mesos-cli) cli_new (MESOS-8240)$ mesos
Mesos CLI

Usage:
  mesos (-h | --help)
  mesos --version
  mesos  [...]

Options:
  -h --help  Show this screen.
  --version  Show version info.

Commands:
  agent   Interacts with the Mesos agents
  config  Interacts with the Mesos CLI configuration file
  taskInteracts with the tasks running in a Mesos cluster

See 'mesos help ' for more information on a specific command.
(mesos-cli) cli_new (MESOS-8240)$ source deactivate
cli_new (MESOS-8240)$ rm -rf .virtualenv/
cli_new (MESOS-8240)$ cd ..
python (MESOS-8240)$ VIRTUALENV_DIRECTORY=$(pwd)/.venv ./cli_new/bootstrap
python (MESOS-8240)$ source 
/home/agrillet/apache-mesos/src/python/.venv/bin/activate
python (MESOS-8240)$ source 
/home/agrillet/apache-mesos/src/python/.venv/bin/postactivate
(mesos-cli) python (MESOS-8240)$ mesos
Mesos CLI

Usage:
  mesos (-h | --help)
  mesos --version
  mesos  [...]

Options:
  -h --help  Show this screen.
  --version  Show version info.

Commands:
  agent   Interacts with the Mesos agents
  config  Interacts with the Mesos CLI configuration file
  taskInteracts with the tasks running in a Mesos cluster

See 'mesos help ' for more information on a specific command.
```


Thanks,

Armand Grillet

Re: Review Request 65689: Fixed the task update issue on framework due to docker daemon hangs.

2018-02-16 Thread Mesos Reviewbot Windows


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65689/#review197686
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['65689']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65689

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65689/logs/mesos-tests-stdout.log):

```
[ RUN  ] ExecutorAuthorizationTest.RunTaskGroup
[   OK ] ExecutorAuthorizationTest.RunTaskGroup (2679 ms)
[ RUN  ] ExecutorAuthorizationTest.FailedSubscribe
[   OK ] ExecutorAuthorizationTest.FailedSubscribe (265 ms)
[ RUN  ] ExecutorAuthorizationTest.FailedApiCalls
[   OK ] ExecutorAuthorizationTest.FailedApiCalls (387 ms)
[--] 3 tests from ExecutorAuthorizationTest (3391 ms total)

[--] 4 tests from SlaveCompatibilityTest
[ RUN  ] SlaveCompatibilityTest.Equal
[   OK ] SlaveCompatibilityTest.Equal (4 ms)
[ RUN  ] SlaveCompatibilityTest.Additive
[   OK ] SlaveCompatibilityTest.Additive (8 ms)
[ RUN  ] SlaveCompatibilityTest.AdditiveWithReservations
[   OK ] SlaveCompatibilityTest.AdditiveWithReservations (4 ms)
[ RUN  ] SlaveCompatibilityTest.Disks
[   OK ] SlaveCompatibilityTest.Disks (3 ms)
[--] 4 tests from SlaveCompatibilityTest (23 ms total)

[--] 75 tests from SlaveTest
[ RUN  ] SlaveTest.Shutdown
[   OK ] SlaveTest.Shutdown (232 ms)
[ RUN  ] SlaveTest.DuplicateTerminalUpdateBeforeAck
[   OK ] SlaveTest.DuplicateTerminalUpdateBeforeAck (294 ms)
[ RUN  ] SlaveTest.ShutdownUnregisteredExecutor
D:\DCOS\mesos\mesos\src\tests\slave_tests.cpp(439): error: Failed to wait 
15secs for status
D:\DCOS\mesos\mesos\src\tests\slave_tests.cpp(425): error: Actual function call 
count doesn't match EXPECT_CALL(sched, statusUpdate(, _))...
 Expected: to be called once
   Actual: never called - unsatisfied and active
```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65689/logs/mesos-tests-stderr.log):

```
I0216 19:43:08.213665  1888 master.cpp:1422] Framework 
9873f6a9-5313-41bc-b7b2-de0c1edf3cc8- (default) at 
scheduler-771381fe-fbcc-4813-af31-cd90fe7af742@10.3.1.5:61339 disconnected
I0216 19:43:08.214664  1888 master.cpp:3240] Deactivating framework 
9873f6a9-5313-41bc-b7b2-de0c1edf3cc8- (default) at 
scheduler-771381fe-fbcc-4813-af31-cd90fe7af742@10.3.1.5:61339
I0216 19:43:08.214664  1888 master.cpp:3217] Disconnecting framework 
9873f6a9-5313-41bc-b7b2-de0c1edf3cc8- (default) at 
scheduler-771381fe-fbcc-4813-af31-cd90fe7af742@10.3.1.5:61339
I0216 19:43:08.214664 10268 hierarchical.cpp:405] Deactivated framework 
9873f6a9-5313-41bc-b7b2-de0c1edf3cc8-
I0216 19:43:08.214664  1888 master.cpp:1437] Giving framework 
9873f6a9-5313-41bc-b7b2-de0c1edf3cc8- (default) at 
scheduler-771381fe-fbcc-4813-af31-cd90fe7af742@10.3.1.5:61339 0ns to failover
I0216 19:43:08.216671  4916 master.cpp:8668] Framework failover timeout, 
removing framework 9873f6a9-5313-41bc-b7b2-de0c1edf3cc8- (default) at 
scheduler-771381fe-fbcc-4813-af31-cd90fe7af742@10.3.1.5:61339
I0216 19:43:08.216671  4916 master.cpp:9545] Removing framework 
9873f6a9-5313-41bc-b7b2-de0c1edf3cc8- (default) at 
scheduler-771381fe-fbcc-4813-af31-cd90fe7af742@10.3.1.5:61339
I0216 19:43:08.216671  4916 master.cpp:10249] Updating the state of task 1 of 
framework 9873f6a9-5313-41bc-b7b2-de0c1edf3cc8- (latest state: TASK_KILLED, 
status update state: TASK_KILLED)
I0216 19:43:08.218672  4916 master.cpp:10348] Removing task 1 with resources 
cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; 
ports(allocated: *):[31000-32000] of framework 
9873f6a9-5313-41bc-b7b2-de0c1edf3cc8- on agent @   7FF64DAE0B1A  
),mesos::FrameworkID,mesos::ExecutorID,process::Future

Re: Review Request 65202: Adopted `TEST_AWAIT_TIMEOUT` in Mesos tests.

2018-02-16 Thread Mesos Reviewbot Windows


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65202/#review197683
---



PASS: Mesos patch 65202 was successfully built and tested.

Reviews applied: `['65201', '65343', '65298', '65202']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65202

- Mesos Reviewbot Windows


On Feb. 16, 2018, 6:07 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65202/
> ---
> 
> (Updated Feb. 16, 2018, 6:07 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Gaston Kleiman.
> 
> 
> Bugs: MESOS-7016
> https://issues.apache.org/jira/browse/MESOS-7016
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Rather than hard-coding a 15sec test timeout, use the libprocess
> `TEST_AWAIT_TIMEOUT` variable so that this can be globally tuned.
> Added a test flag `--test_await_timeout` that can be used to set
> the `TEST_AWAIT_TIMEOUT` on a test run.
> 
> 
> Diffs
> -
> 
>   src/tests/agent_container_api_tests.cpp 
> 618569277545205017320aaf1f3a70e540d35e30 
>   src/tests/containerizer/cgroups_isolator_tests.cpp 
> 5412a7eccaa836a7f182772f1eb33b10298c96a1 
>   src/tests/containerizer/xfs_quota_tests.cpp 
> d761ea46fd4f12c6bed74090bf5ead7587f16811 
>   src/tests/disk_quota_tests.cpp 31cf4c44b1494afd3501046abffd303c7a1307f8 
>   src/tests/fetcher_cache_tests.cpp 7db7b7dcef27b1686ccae5a7408ff2811a3b9255 
>   src/tests/flags.hpp df4d4588f405ea884bb89021264e70218e054fae 
>   src/tests/flags.cpp 4542f3443830474edd97e8b695af0c61685e947c 
>   src/tests/gc_tests.cpp 947399e9e082070282a48d8aa8f745ba37a64c07 
>   src/tests/main.cpp f945ac9e8858998174b4c2785f6a5612bae66a41 
>   src/tests/master_contender_detector_tests.cpp 
> 015d310b72a152829641d436f7cb558f72dfd77c 
>   src/tests/registrar_tests.cpp cbb58c1cd72dc13ed16b5465452d17526255c763 
>   src/tests/slave_recovery_tests.cpp 898270db9c524fd09599155db4990ae0fa9d2c2f 
>   src/tests/slave_tests.cpp d2c242eae3169bff3b0197a36f171cd668ba 
> 
> 
> Diff: https://reviews.apache.org/r/65202/diff/9/
> 
> 
> Testing
> ---
> 
> make check (Fedora 27).
> 
> 
> Thanks,
> 
> James Peach
> 
>

Review Request 65689: Fixed the task update issue on framework due to docker daemon hangs.

2018-02-16 Thread Gilbert Song


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65689/
---

Review request for mesos, Andrei Budnik and Greg Mann.


Bugs: MESOS-8573
https://issues.apache.org/jira/browse/MESOS-8573


Repository: mesos


Description
---

Fixed the task update issue on framework due to docker daemon hangs.


Diffs
-

  src/slave/slave.cpp df8b33d717d30f550ad90e12c1a6db11fb25b753 


Diff: https://reviews.apache.org/r/65689/diff/1/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 65298: Split test flags into header and source files.

2018-02-16 Thread James Peach


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65298/
---

(Updated Feb. 16, 2018, 6:07 p.m.)


Review request for mesos, Benjamin Bannier and Gaston Kleiman.


Bugs: MESOS-7016
https://issues.apache.org/jira/browse/MESOS-7016


Repository: mesos


Description
---

Split the test flags into header and source files to reduce the amount
of recompilation necessary when the implementation changes.


Diffs (updated)
-

  src/tests/flags.hpp df4d4588f405ea884bb89021264e70218e054fae 
  src/tests/flags.cpp 4542f3443830474edd97e8b695af0c61685e947c 


Diff: https://reviews.apache.org/r/65298/diff/7/

Changes: https://reviews.apache.org/r/65298/diff/6-7/


Testing
---

make check (Fedora 27)


Thanks,

James Peach

Re: Review Request 65202: Adopted `TEST_AWAIT_TIMEOUT` in Mesos tests.

2018-02-16 Thread James Peach


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65202/
---

(Updated Feb. 16, 2018, 6:07 p.m.)


Review request for mesos, Benjamin Bannier and Gaston Kleiman.


Summary (updated)
-

Adopted `TEST_AWAIT_TIMEOUT` in Mesos tests.


Bugs: MESOS-7016
https://issues.apache.org/jira/browse/MESOS-7016


Repository: mesos


Description (updated)
---

Rather than hard-coding a 15sec test timeout, use the libprocess
`TEST_AWAIT_TIMEOUT` variable so that this can be globally tuned.
Added a test flag `--test_await_timeout` that can be used to set
the `TEST_AWAIT_TIMEOUT` on a test run.


Diffs (updated)
-

  src/tests/agent_container_api_tests.cpp 
618569277545205017320aaf1f3a70e540d35e30 
  src/tests/containerizer/cgroups_isolator_tests.cpp 
5412a7eccaa836a7f182772f1eb33b10298c96a1 
  src/tests/containerizer/xfs_quota_tests.cpp 
d761ea46fd4f12c6bed74090bf5ead7587f16811 
  src/tests/disk_quota_tests.cpp 31cf4c44b1494afd3501046abffd303c7a1307f8 
  src/tests/fetcher_cache_tests.cpp 7db7b7dcef27b1686ccae5a7408ff2811a3b9255 
  src/tests/flags.hpp df4d4588f405ea884bb89021264e70218e054fae 
  src/tests/flags.cpp 4542f3443830474edd97e8b695af0c61685e947c 
  src/tests/gc_tests.cpp 947399e9e082070282a48d8aa8f745ba37a64c07 
  src/tests/main.cpp f945ac9e8858998174b4c2785f6a5612bae66a41 
  src/tests/master_contender_detector_tests.cpp 
015d310b72a152829641d436f7cb558f72dfd77c 
  src/tests/registrar_tests.cpp cbb58c1cd72dc13ed16b5465452d17526255c763 
  src/tests/slave_recovery_tests.cpp 898270db9c524fd09599155db4990ae0fa9d2c2f 
  src/tests/slave_tests.cpp d2c242eae3169bff3b0197a36f171cd668ba 


Diff: https://reviews.apache.org/r/65202/diff/9/

Changes: https://reviews.apache.org/r/65202/diff/8-9/


Testing
---

make check (Fedora 27).


Thanks,

James Peach

Re: Review Request 65201: Added a global `TEST_AWAIT_TIMEOUT` variable.

2018-02-16 Thread James Peach


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65201/
---

(Updated Feb. 16, 2018, 6:05 p.m.)


Review request for mesos, Benjamin Bannier and Gaston Kleiman.


Summary (updated)
-

Added a global `TEST_AWAIT_TIMEOUT` variable.


Bugs: MESOS-7016
https://issues.apache.org/jira/browse/MESOS-7016


Repository: mesos


Description (updated)
---

Added a global `TEST_AWAIT_TIMEOUT` variable that applications
can use to globally tune the default timeout in the `AWAIT_READY`
family of test macros. The default remains 15sec.


Diffs (updated)
-

  3rdparty/libprocess/Makefile.am 3071b7ce2b82a4ce0ea62e4d2b3518a6f5114803 
  3rdparty/libprocess/include/Makefile.am 
84877a23399d238874f7b090c2c4564d9d00eb6b 
  3rdparty/libprocess/include/process/gtest.hpp 
eee726653d52af2e4a148819e420ebd22e5123a9 
  3rdparty/libprocess/include/process/gtest_constants.hpp PRE-CREATION 
  3rdparty/libprocess/src/CMakeLists.txt 
f002c157dc2ca64da66bc4e61f5095f2b533ae1f 
  3rdparty/libprocess/src/gtest_constants.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/65201/diff/8/

Changes: https://reviews.apache.org/r/65201/diff/7-8/


Testing
---

make check (Fedora 27).


Thanks,

James Peach

Re: Review Request 65343: Adopted `TEST_AWAIT_TIMEOUT` in libprocess tests.

2018-02-16 Thread James Peach


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65343/
---

(Updated Feb. 16, 2018, 6:06 p.m.)


Review request for mesos, Benjamin Bannier and Gaston Kleiman.


Summary (updated)
-

Adopted `TEST_AWAIT_TIMEOUT` in libprocess tests.


Bugs: MESOS-7016
https://issues.apache.org/jira/browse/MESOS-7016


Repository: mesos


Description (updated)
---

Rather than hard-coding a 15sec test timeout, use the libprocess
`TEST_AWAIT_TIMEOUT` variable so that this can be globally tuned.
Added a test flag `--test_await_timeout` that can be used to set
the `TEST_AWAIT_TIMEOUT` on a test run.


Diffs (updated)
-

  3rdparty/libprocess/src/tests/main.cpp 
4633bea4caad3ddda809b7b5aa0c5220f8ad82c2 
  3rdparty/libprocess/src/tests/subprocess_tests.cpp 
8211ae63e75359705af2bb9ac02a7cbdb28e3252 


Diff: https://reviews.apache.org/r/65343/diff/5/

Changes: https://reviews.apache.org/r/65343/diff/4-5/


Testing
---

make check (Fedora 27)


Thanks,

James Peach

Re: Review Request 65045: Tested correct operation handling during master failover.

2018-02-16 Thread Mesos Reviewbot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65045/#review197680
---



Patch looks great!

Reviews applied: [65671, 65672, 65044, 65045]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Feb. 7, 2018, 10:57 a.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65045/
> ---
> 
> (Updated Feb. 7, 2018, 10:57 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8424
> https://issues.apache.org/jira/browse/MESOS-8424
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Tested correct operation handling during master failover.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 7112bb4efcc312dc4f68bdc44fb685c7624002b1 
> 
> 
> Diff: https://reviews.apache.org/r/65045/diff/8/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 65671: Added comparison operators for operations.

2018-02-16 Thread Jan Schlicht


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65671/
---

(Updated Feb. 16, 2018, 4:35 p.m.)


Review request for mesos and Benjamin Bannier.


Changes
---

Addressed issues.


Bugs: MESOS-8424
https://issues.apache.org/jira/browse/MESOS-8424


Repository: mesos


Description
---

Added comparison operators for operations.


Diffs (updated)
-

  include/mesos/type_utils.hpp af2b187b9b59552e4ba515ad640fd4419eaf5075 
  include/mesos/v1/mesos.hpp f16568ef37ff954f1d28f13f062be9c9f078d2a4 
  src/common/type_utils.cpp a4d5dcb4e4445e307356d9b0c16dd39f00f6a8e2 
  src/v1/mesos.cpp 576f367f1974111be5eee3f3c4cc7cc9a8bbc154 


Diff: https://reviews.apache.org/r/65671/diff/2/

Changes: https://reviews.apache.org/r/65671/diff/1-2/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 65045: Tested correct operation handling during master failover.

2018-02-16 Thread Benjamin Bannier


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65045/#review197674
---


Fix it, then Ship it!





src/tests/master_tests.cpp
Lines 8803 (patched)


nit: Let's wrap this like other multi-line function calls you added above.



src/tests/master_tests.cpp
Lines 8812 (patched)


Let's add a comment here why we expect to registrations; readers don't have 
that context, yet.



src/tests/master_tests.cpp
Lines 8823 (patched)


Make this a `const` ref.



src/tests/master_tests.cpp
Lines 8869 (patched)


`const` ref.



src/tests/master_tests.cpp
Lines 8930 (patched)


`const` ref



src/tests/master_tests.cpp
Lines 8934-8936 (patched)


We could also check here that this is the same operation (identical ID) 
which was pending above.


- Benjamin Bannier


On Feb. 7, 2018, 11:57 a.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65045/
> ---
> 
> (Updated Feb. 7, 2018, 11:57 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8424
> https://issues.apache.org/jira/browse/MESOS-8424
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Tested correct operation handling during master failover.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 7112bb4efcc312dc4f68bdc44fb685c7624002b1 
> 
> 
> Diff: https://reviews.apache.org/r/65045/diff/8/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

2018-02-16 Thread Benjamin Bannier


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65044/#review197672
---


Fix it, then Ship it!





src/slave/http.cpp
Lines 1695 (patched)


We could make this `const`.



src/tests/api_tests.cpp
Lines 1061 (patched)


We don't necessarily need to use the same content type for the RP as we do 
for the request (we more care about the latter). Still seems like a good 
approach to me to increase coverage.



src/tests/api_tests.cpp
Lines 1135-1142 (patched)


Let's also check here that `agent_id` matches what we expect. We should 
already have it from e.g., `updateSlaveMessage` above.



src/tests/api_tests.cpp
Lines 6643-6651 (patched)


Ditto.


- Benjamin Bannier


On Feb. 15, 2018, 11:19 a.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65044/
> ---
> 
> (Updated Feb. 15, 2018, 11:19 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Gaston Kleiman, Greg Mann, Jie 
> Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-8424
> https://issues.apache.org/jira/browse/MESOS-8424
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The 'GET_OPERATIONS' call lists all operations known to master or agent.
> 
> 
> Diffs
> -
> 
>   include/mesos/agent/agent.proto 315820041990d28e5cdae71c8385d4551d56558c 
>   include/mesos/master/master.proto 3e34634f3b864222d07374936c0d9a18269c2fbd 
>   include/mesos/v1/agent/agent.proto 9e8b49defb83ffd4dd240ebb3a09b2dd3610ab2a 
>   include/mesos/v1/master/master.proto 
> 6759c3004e7e04c0044360b0c54f4438c2f6ec8a 
>   src/master/http.cpp 46f2872a17215464de2e4990e9cfcb3bff46812a 
>   src/master/master.hpp c4d3c8080dc7899968b1030696172ed73d473bc1 
>   src/master/validation.cpp 42f767e4269abe3f160fc7d97eb4522d1bee8e95 
>   src/slave/http.hpp 1619bb77e3e7d5a6d387e4d4bb071d83ce914967 
>   src/slave/http.cpp 59eef7a4c90490a6dbcc09153494c200ed1d1b53 
>   src/slave/validation.cpp 0c2ccda177734cf3c47c0346ed34d20d58e7d932 
>   src/tests/api_tests.cpp b042201bf07428bfc0007a713b98bf15d15470e1 
> 
> 
> Diff: https://reviews.apache.org/r/65044/diff/11/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 65655: Updated Mesos CLI test base to use shell to start masters and agents.

2018-02-16 Thread Kevin Klues


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65655/#review197671
---


Ship it!




Ship It!

- Kevin Klues


On Feb. 14, 2018, 4:17 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65655/
> ---
> 
> (Updated Feb. 14, 2018, 4:17 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Kevin Klues.
> 
> 
> Bugs: MESOS-8240
> https://issues.apache.org/jira/browse/MESOS-8240
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We use the shell scripts in `build/src` to start masters and agents
> for the CLI tests. Instead of running them as executable, we now use
> shell to interprete them using the new Executable attribute 'shell'.
> 
> 
> Diffs
> -
> 
>   src/python/cli_new/lib/cli/tests/base.py 
> 33c67c1161d9c9fd57aa5f44b04746e3740e1dd9 
> 
> 
> Diff: https://reviews.apache.org/r/65655/diff/2/
> 
> 
> Testing
> ---
> 
> Checked that `mesos-cli-tests` was working as before.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 65672: Added comparison operators for 'v1::UUID'.

2018-02-16 Thread Benjamin Bannier


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65672/#review197670
---


Ship it!




Ship It!

- Benjamin Bannier


On Feb. 15, 2018, 11:18 a.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65672/
> ---
> 
> (Updated Feb. 15, 2018, 11:18 a.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-8424
> https://issues.apache.org/jira/browse/MESOS-8424
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added comparison operators for 'v1::UUID'.
> 
> 
> Diffs
> -
> 
>   include/mesos/v1/mesos.hpp f16568ef37ff954f1d28f13f062be9c9f078d2a4 
> 
> 
> Diff: https://reviews.apache.org/r/65672/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 65671: Added comparison operators for operations.

2018-02-16 Thread Benjamin Bannier


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65671/#review197669
---


Fix it, then Ship it!





include/mesos/type_utils.hpp
Lines 65 (patched)


Let's use the nested type `Offer::Operation` when referring to this type.



include/mesos/type_utils.hpp
Lines 88 (patched)


Ditto.



include/mesos/v1/mesos.hpp
Lines 63 (patched)


Ditto.



include/mesos/v1/mesos.hpp
Lines 79 (patched)


Ditto.


- Benjamin Bannier


On Feb. 15, 2018, 11:17 a.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65671/
> ---
> 
> (Updated Feb. 15, 2018, 11:17 a.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-8424
> https://issues.apache.org/jira/browse/MESOS-8424
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added comparison operators for operations.
> 
> 
> Diffs
> -
> 
>   include/mesos/type_utils.hpp af2b187b9b59552e4ba515ad640fd4419eaf5075 
>   include/mesos/v1/mesos.hpp f16568ef37ff954f1d28f13f062be9c9f078d2a4 
>   src/common/type_utils.cpp a4d5dcb4e4445e307356d9b0c16dd39f00f6a8e2 
>   src/v1/mesos.cpp 576f367f1974111be5eee3f3c4cc7cc9a8bbc154 
> 
> 
> Diff: https://reviews.apache.org/r/65671/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 65482: Improved handling of non-terminal operations after master failover.

2018-02-16 Thread Benjamin Bannier



> On Feb. 3, 2018, 12:06 a.m., Greg Mann wrote:
> > src/master/master.cpp
> > Lines 7594-7597 (original), 7609-7612 (patched)
> > 
> >
> > Is this function now only called with resources from already-existing 
> > frameworks? Does that mean that we can update the code here? 
> > https://github.com/apache/mesos/blob/5a1433576eca20f15f1ea309fc202f4bbaf3b6c7/src/master/allocator/mesos/hierarchical.cpp#L690-L703
> 
> Benjamin Bannier wrote:
> I am not sure we can make sure this will always happen in general. As a 
> precaution I think it is still a good idea to leave this check in the 
> allocator, if only to document allocator-local invariants.

Dropping this.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65482/#review196752
---


On Feb. 16, 2018, 3:12 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65482/
> ---
> 
> (Updated Feb. 16, 2018, 3:12 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Jie Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-8536
> https://issues.apache.org/jira/browse/MESOS-8536
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch fixes the handling of non-terminal operations learned by a
> newly elected master after a master failover, so that only these
> operations are counted as using resources. Previously we did not count
> any operations as using resources which by accident produced expected
> behavior if the operation was already terminal when the master learned
> about them.
> 
> We do not address the issue of being unable to properly account for
> operations triggered by frameworks unknown to the master, see
> MESOS-8582. Instead we emit a warning for now since the master might
> continue to abort due to assertion failures due to incomplete resource
> accounting.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp b06d7a6e2fbbb81b97eaf537d5b6745c73dc867d 
> 
> 
> Diff: https://reviews.apache.org/r/65482/diff/4/
> 
> 
> Testing
> ---
> 
> `make check`, also tested with a version of the test added in r/65045 which 
> triggered this issue.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 65591: Explicitly tracked resource providers in master.

2018-02-16 Thread Benjamin Bannier



> On Feb. 16, 2018, 2:13 a.m., Gaston Kleiman wrote:
> > src/master/master.cpp
> > Line 7307 (original), 7351 (patched)
> > 
> >
> > Do we plan to support resource providers with info (so not the 
> > agent-default resources), but without an ID?
> > 
> > Line 7470 indicates that we don't.

Added `CHECK`s here as well.


> On Feb. 16, 2018, 2:13 a.m., Gaston Kleiman wrote:
> > src/master/master.cpp
> > Lines 7516 (patched)
> > 
> >
> > It doesnt look like `operation_` is used after this line. Can we revert 
> > to inlining the creation of the operation?

Like the comment above indicated this should have updated `operations`, fixed 
the code.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65591/#review197652
---


On Feb. 16, 2018, 3:12 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65591/
> ---
> 
> (Updated Feb. 16, 2018, 3:12 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jan Schlicht.
> 
> 
> Bugs: MESOS-8382
> https://issues.apache.org/jira/browse/MESOS-8382
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds explicit tracking of resource providers to the master
> process. While we already had explicitly send resource provider
> information in e.g., `UpdateSlaveMessage`, we only stored that
> information aggregated over the full agent in the master up to now.
> 
> 
> Diffs
> -
> 
>   src/common/protobuf_utils.cpp b5c2997ada8362e42150fa3cfd762120e5ea715f 
>   src/master/master.hpp c4d3c8080dc7899968b1030696172ed73d473bc1 
>   src/master/master.cpp b06d7a6e2fbbb81b97eaf537d5b6745c73dc867d 
> 
> 
> Diff: https://reviews.apache.org/r/65591/diff/3/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 65482: Improved handling of non-terminal operations after master failover.

2018-02-16 Thread Benjamin Bannier



> On Feb. 16, 2018, 1:13 a.m., Gaston Kleiman wrote:
> > src/master/master.cpp
> > Lines 7652 (patched)
> > 
> >
> > s/   "operation/<< "operation/

I don't think we need or want an extra function call here. I ended up moving 
the space from the previous line to this one though.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65482/#review197651
---


On Feb. 16, 2018, 3:12 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65482/
> ---
> 
> (Updated Feb. 16, 2018, 3:12 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Jie Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-8536
> https://issues.apache.org/jira/browse/MESOS-8536
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch fixes the handling of non-terminal operations learned by a
> newly elected master after a master failover, so that only these
> operations are counted as using resources. Previously we did not count
> any operations as using resources which by accident produced expected
> behavior if the operation was already terminal when the master learned
> about them.
> 
> We do not address the issue of being unable to properly account for
> operations triggered by frameworks unknown to the master, see
> MESOS-8582. Instead we emit a warning for now since the master might
> continue to abort due to assertion failures due to incomplete resource
> accounting.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp b06d7a6e2fbbb81b97eaf537d5b6745c73dc867d 
> 
> 
> Diff: https://reviews.apache.org/r/65482/diff/4/
> 
> 
> Testing
> ---
> 
> `make check`, also tested with a version of the test added in r/65045 which 
> triggered this issue.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 65482: Improved handling of non-terminal operations after master failover.

2018-02-16 Thread Benjamin Bannier



> On Feb. 16, 2018, 12:55 a.m., Greg Mann wrote:
> > src/master/master.cpp
> > Lines 7645 (patched)
> > 
> >
> > s/`RunTaskMessage`, see/`RunTaskMessage`. See/

Hmm ... I am not a native speaker, but wouldn't starting an extra sentence here 
needlessly inflate this comment (e.g., we would likely want some verb as well 
then)? We seem to use this pattern elsewhere already,

% git grep ', see' src | wc -l
77


> On Feb. 16, 2018, 12:55 a.m., Greg Mann wrote:
> > src/master/master.cpp
> > Lines 7647-7654 (patched)
> > 
> >
> > I'm sitting here trying to think of ways we might avoid crashing if the 
> > framework subscribes before the operation becomes terminal...
> > 
> > Would it be reasonable to add an `if (framework == nullptr)` check to 
> > `updateOperation()` so that we only recover resources if the framework is 
> > known to the master?
> 
> Greg Mann wrote:
> Er... wait that doesn't make sense :) I guess when we receive the 
> operation update, we have no way of knowing whether or not the framework had 
> subscribed when the master learned about the pending operation. As a 
> workaround for now, we could store in a set the operation UUIDs of operations 
> for which we do not track allocated resources (i.e., operations which hit 
> this block of code). Then, in `updateOperation` we could avoid recovering 
> resources if the operation's UUID is in the set?

No matter what we do here, we will already have entered dangerous territory 
with `CHECK` failures looming as soon as we added such an operation to master 
state, since we cannot update the allocator on these used resources (update the 
allocation to reflect operation results, or recover). We might also end up 
unknowingly oversubscribing the resources used by the operation.

I am unsure whether working around this by e.g., no updating the allocator when 
the operation becomes terminal is a good way forward since it seems to delay 
the needed master failover for even longer. With the approach I proposed we 
would failover when this operation gets terminal (i.e., when we can safely 
reconcile this particular operation).

I added the framework ID to the log output since it might be useful for 
operators debugging such scenarios.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65482/#review197641
---


On Feb. 16, 2018, 3:12 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65482/
> ---
> 
> (Updated Feb. 16, 2018, 3:12 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Jie Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-8536
> https://issues.apache.org/jira/browse/MESOS-8536
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch fixes the handling of non-terminal operations learned by a
> newly elected master after a master failover, so that only these
> operations are counted as using resources. Previously we did not count
> any operations as using resources which by accident produced expected
> behavior if the operation was already terminal when the master learned
> about them.
> 
> We do not address the issue of being unable to properly account for
> operations triggered by frameworks unknown to the master, see
> MESOS-8582. Instead we emit a warning for now since the master might
> continue to abort due to assertion failures due to incomplete resource
> accounting.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp b06d7a6e2fbbb81b97eaf537d5b6745c73dc867d 
> 
> 
> Diff: https://reviews.apache.org/r/65482/diff/4/
> 
> 
> Testing
> ---
> 
> `make check`, also tested with a version of the test added in r/65045 which 
> triggered this issue.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 65482: Improved handling of non-terminal operations after master failover.

2018-02-16 Thread Benjamin Bannier


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65482/
---

(Updated Feb. 16, 2018, 3:12 p.m.)


Review request for mesos, Greg Mann, Jie Yu, and Jan Schlicht.


Changes
---

Fixed comment issues pointed out by Greg; improved logging.


Bugs: MESOS-8536
https://issues.apache.org/jira/browse/MESOS-8536


Repository: mesos


Description
---

This patch fixes the handling of non-terminal operations learned by a
newly elected master after a master failover, so that only these
operations are counted as using resources. Previously we did not count
any operations as using resources which by accident produced expected
behavior if the operation was already terminal when the master learned
about them.

We do not address the issue of being unable to properly account for
operations triggered by frameworks unknown to the master, see
MESOS-8582. Instead we emit a warning for now since the master might
continue to abort due to assertion failures due to incomplete resource
accounting.


Diffs (updated)
-

  src/master/master.cpp b06d7a6e2fbbb81b97eaf537d5b6745c73dc867d 


Diff: https://reviews.apache.org/r/65482/diff/4/

Changes: https://reviews.apache.org/r/65482/diff/3-4/


Testing
---

`make check`, also tested with a version of the test added in r/65045 which 
triggered this issue.


Thanks,

Benjamin Bannier

Re: Review Request 65591: Explicitly tracked resource providers in master.

2018-02-16 Thread Benjamin Bannier


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65591/
---

(Updated Feb. 16, 2018, 3:12 p.m.)


Review request for mesos, Jie Yu and Jan Schlicht.


Changes
---

Fixed member documentation.


Bugs: MESOS-8382
https://issues.apache.org/jira/browse/MESOS-8382


Repository: mesos


Description
---

This patch adds explicit tracking of resource providers to the master
process. While we already had explicitly send resource provider
information in e.g., `UpdateSlaveMessage`, we only stored that
information aggregated over the full agent in the master up to now.


Diffs (updated)
-

  src/common/protobuf_utils.cpp b5c2997ada8362e42150fa3cfd762120e5ea715f 
  src/master/master.hpp c4d3c8080dc7899968b1030696172ed73d473bc1 
  src/master/master.cpp b06d7a6e2fbbb81b97eaf537d5b6745c73dc867d 


Diff: https://reviews.apache.org/r/65591/diff/3/

Changes: https://reviews.apache.org/r/65591/diff/2-3/


Testing
---

`make check`


Thanks,

Benjamin Bannier

Re: Review Request 65683: Added discard handling to Docker library functions.

2018-02-16 Thread Mesos Reviewbot Windows


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65683/#review197667
---



PASS: Mesos patch 65683 was successfully built and tested.

Reviews applied: `['65683']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65683

- Mesos Reviewbot Windows


On Feb. 16, 2018, 6:34 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65683/
> ---
> 
> (Updated Feb. 16, 2018, 6:34 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Gilbert Song.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added discard handling to Docker library functions.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.cpp 3df370e988fce12d323ff6b441da15dab27bdd28 
> 
> 
> Diff: https://reviews.apache.org/r/65683/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 65683: Added discard handling to Docker library functions.

2018-02-16 Thread Mesos Reviewbot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65683/#review197662
---



Patch looks great!

Reviews applied: [65683]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Feb. 16, 2018, 6:34 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65683/
> ---
> 
> (Updated Feb. 16, 2018, 6:34 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Gilbert Song.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added discard handling to Docker library functions.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.cpp 3df370e988fce12d323ff6b441da15dab27bdd28 
> 
> 
> Diff: https://reviews.apache.org/r/65683/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

44 matches

Mail list logo