Re: Review Request 65728: Add test to check quotes in docker executor health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65728/#review198095 --- Ship it! Ship It! - Andrew Schwartzmeyer On Feb. 21, 2018, 5

Re: Review Request 65728: Add test to check quotes in docker executor health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65728/#review198094 --- Patch looks great! Reviews applied: [65393, 65394, 65395, 65396,

Re: Review Request 65728: Add test to check quotes in docker executor health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65728/#review198093 --- PASS: Mesos patch 65728 was successfully built and tested. Review

Re: Review Request 65728: Add test to check quotes in docker executor health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65728/ --- (Updated Feb. 22, 2018, 1:51 a.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 64604: Windows: Updated heath-checks.md with Windows implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64604/ --- (Updated Feb. 22, 2018, 1:50 a.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 64387: Windows: Ported docker health check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64387/ --- (Updated Feb. 22, 2018, 1:48 a.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 65615: Added docker constants and common functions file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65615/ --- (Updated Feb. 22, 2018, 1:47 a.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 65127: Windows: Enabled docker health checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65127/ --- (Updated Feb. 22, 2018, 1:46 a.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 65419: Fixed quoting issues in docker executor command checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65419/ --- (Updated Feb. 22, 2018, 1:46 a.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 65395: Refactored health checks to cleanly separate each different check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65395/ --- (Updated Feb. 22, 2018, 1:44 a.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 65396: Moved docker command check code inside health check library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65396/ --- (Updated Feb. 22, 2018, 1:45 a.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 65394: Added separate structs for health check runtime and check types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65394/ --- (Updated Feb. 22, 2018, 1:41 a.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 65393: Fixed docker command health check to use the right docker socket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65393/ --- (Updated Feb. 22, 2018, 1:39 a.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 65743: Ensured that Docker containerizer returns a failed Future in one case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65743/#review198085 --- Bad patch! Reviews applied: [65743, 65683] Failed command: pytho

Re: Review Request 65743: Ensured that Docker containerizer returns a failed Future in one case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65743/#review198084 --- FAIL: Failed to apply the dependent review: 65683. Failed command

Review Request 65743: Ensured that Docker containerizer returns a failed Future in one case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65743/ --- Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park. Bugs:

Re: Review Request 65683: Updated discard handling in Docker library functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65683/ --- (Updated Feb. 22, 2018, 12:36 a.m.) Review request for mesos, Andrei Budnik, Gi

Re: Review Request 65683: Updated discard handling in Docker library functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65683/#review198083 --- FAIL: Failed to apply the current review. Failed command: `python

Re: Review Request 65683: Updated discard handling in Docker library functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65683/ --- (Updated Feb. 22, 2018, 12:30 a.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review197990 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63372: Added documentation for memory profiling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63372/#review197983 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 65461: Provide new overload of 'ProcessBase::route()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65461/#review197980 --- Bad review! Error: Circular dependency detected for review 65462.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review198018 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 65461: Provide new overload of 'ProcessBase::route()'.

> On Feb. 21, 2018, 9:31 p.m., Mesos Reviewbot Windows wrote: > > Bad review! > > > > Error: > > Circular dependency detected for review 65462. Please fix the 'depends_on' > > field. There was a glitch in the reviewbot code. This was fixed. Sorry for the spam! - Mesos -

Re: Review Request 63370: Added new --memory_profiling flag to agent and master binaries.

> On Feb. 21, 2018, 9:31 p.m., Mesos Reviewbot Windows wrote: > > Bad review! > > > > Error: > > Circular dependency detected for review 63367. Please fix the 'depends_on' > > field. There was a glitch in the reviewbot code. This was fixed. Sorry for the spam! - Mesos -

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review198065 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63372: Added documentation for memory profiling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63372/#review198066 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63370: Added new --memory_profiling flag to agent and master binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63370/#review198064 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 65461: Provide new overload of 'ProcessBase::route()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65461/#review198063 --- Bad review! Error: Circular dependency detected for review 65462.

Re: Review Request 63372: Added documentation for memory profiling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63372/#review198027 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63370: Added new --memory_profiling flag to agent and master binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63370/#review198060 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 65461: Provide new overload of 'ProcessBase::route()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65461/#review198059 --- Bad review! Error: Circular dependency detected for review 65462.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review198061 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63372: Added documentation for memory profiling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63372/#review198062 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review198030 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63370: Added new --memory_profiling flag to agent and master binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63370/#review198056 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63372: Added documentation for memory profiling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63372/#review198058 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 65461: Provide new overload of 'ProcessBase::route()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65461/#review198055 --- Bad review! Error: Circular dependency detected for review 65462.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review198057 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 65624: Added fetcher tests for `stderr` output.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65624/#review198054 --- Ship it! Ship It! - Akash Gupta On Feb. 20, 2018, 7:40 p.m.,

Re: Review Request 63370: Added new --memory_profiling flag to agent and master binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63370/#review198051 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review198052 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63372: Added documentation for memory profiling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63372/#review198053 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 65461: Provide new overload of 'ProcessBase::route()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65461/#review198050 --- Bad review! Error: Circular dependency detected for review 65462.

Re: Review Request 65624: Added fetcher tests for `stderr` output.

> On Feb. 20, 2018, 11:43 a.m., Jeff Coffler wrote: > > src/tests/fetcher_tests.cpp > > Lines 132 (patched) > > > > > > These tests pretty much check the fetcher in a "stand-alone" > > environment. Could you add som

Re: Review Request 63372: Added documentation for memory profiling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63372/#review198048 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63370: Added new --memory_profiling flag to agent and master binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63370/#review198046 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 65461: Provide new overload of 'ProcessBase::route()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65461/#review198045 --- Bad review! Error: Circular dependency detected for review 65462.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review198047 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63372: Added documentation for memory profiling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63372/#review198023 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 65727: Moved `*DOCKER*` tests to `DockerContainerizerHealthCheckTest`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65727/#review198010 --- Ship it! To expand on why this change was necessary: each `DOCK

Re: Review Request 65461: Provide new overload of 'ProcessBase::route()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65461/#review198028 --- Bad review! Error: Circular dependency detected for review 65462.

Re: Review Request 65461: Provide new overload of 'ProcessBase::route()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65461/#review197984 --- Bad review! Error: Circular dependency detected for review 65462.

Re: Review Request 63372: Added documentation for memory profiling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63372/#review197987 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 65728: Add test to check quotes in docker executor health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65728/#review198011 --- src/tests/health_check_tests.cpp Lines 2716 (patched)

Re: Review Request 63370: Added new --memory_profiling flag to agent and master binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63370/#review198025 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63372: Added documentation for memory profiling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63372/#review198015 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 65461: Provide new overload of 'ProcessBase::route()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65461/#review198041 --- Bad review! Error: Circular dependency detected for review 65462.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review198043 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63372: Added documentation for memory profiling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63372/#review198044 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63370: Added new --memory_profiling flag to agent and master binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63370/#review198042 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63370: Added new --memory_profiling flag to agent and master binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63370/#review198037 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63372: Added documentation for memory profiling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63372/#review198039 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63370: Added new --memory_profiling flag to agent and master binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63370/#review197989 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63370: Added new --memory_profiling flag to agent and master binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63370/#review198017 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review197986 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 65461: Provide new overload of 'ProcessBase::route()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65461/#review197975 --- Bad review! Error: Circular dependency detected for review 65462.

Re: Review Request 63370: Added new --memory_profiling flag to agent and master binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63370/#review197997 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review197982 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 65461: Provide new overload of 'ProcessBase::route()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65461/#review198032 --- Bad review! Error: Circular dependency detected for review 65462.

Re: Review Request 63372: Added documentation for memory profiling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63372/#review197999 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63370: Added new --memory_profiling flag to agent and master binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63370/#review198007 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63372: Added documentation for memory profiling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63372/#review198031 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 65461: Provide new overload of 'ProcessBase::route()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65461/#review198020 --- Bad review! Error: Circular dependency detected for review 65462.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review198004 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 65461: Provide new overload of 'ProcessBase::route()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65461/#review198012 --- Bad review! Error: Circular dependency detected for review 65462.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review198022 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review198014 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 65720: Windows: Fixed location of imported libraries for Ninja.

> On Feb. 21, 2018, 5:18 a.m., Benjamin Bannier wrote: > > 3rdparty/CMakeLists.txt > > Lines 169-182 (patched) > > > > > > Could we generalize this a little bit to whether we are using a multi- > > or single config

Re: Review Request 63372: Added documentation for memory profiling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63372/#review197991 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 65733: Windows: Fixed flaky Docker command health check test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65733/#review198000 --- Ship it! Ship It! - Andrew Schwartzmeyer On Feb. 21, 2018, 6

Re: Review Request 65461: Provide new overload of 'ProcessBase::route()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65461/#review198024 --- Bad review! Error: Circular dependency detected for review 65462.

Re: Review Request 65461: Provide new overload of 'ProcessBase::route()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65461/#review198036 --- Bad review! Error: Circular dependency detected for review 65462.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review198038 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63372: Added documentation for memory profiling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63372/#review198009 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review198034 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63370: Added new --memory_profiling flag to agent and master binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63370/#review198033 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63372: Added documentation for memory profiling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63372/#review198035 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63370: Added new --memory_profiling flag to agent and master binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63370/#review198029 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 65461: Provide new overload of 'ProcessBase::route()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65461/#review198016 --- Bad review! Error: Circular dependency detected for review 65462.

Re: Review Request 63372: Added documentation for memory profiling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63372/#review198005 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review198026 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63370: Added new --memory_profiling flag to agent and master binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63370/#review198021 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63372: Added documentation for memory profiling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63372/#review198019 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63370: Added new --memory_profiling flag to agent and master binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63370/#review198013 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review198008 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 65461: Provide new overload of 'ProcessBase::route()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65461/#review198006 --- Bad review! Error: Circular dependency detected for review 65462.

Re: Review Request 65461: Provide new overload of 'ProcessBase::route()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65461/#review198002 --- Bad review! Error: Circular dependency detected for review 65462.

Re: Review Request 63370: Added new --memory_profiling flag to agent and master binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63370/#review198003 --- Bad review! Error: Circular dependency detected for review 63367.

Re: Review Request 65461: Provide new overload of 'ProcessBase::route()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65461/#review197996 --- Bad review! Error: Circular dependency detected for review 65462.

  1   2   3   >